[jira] [Updated] (LUCENE-8192) Remove offsetsAreCorrect from BaseTokenStreamTestCase

2018-03-04 Thread Robert Muir (JIRA)

 [ 
https://issues.apache.org/jira/browse/LUCENE-8192?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Muir updated LUCENE-8192:

Attachment: LUCENE-8192.patch

> Remove offsetsAreCorrect from BaseTokenStreamTestCase
> -
>
> Key: LUCENE-8192
> URL: https://issues.apache.org/jira/browse/LUCENE-8192
> Project: Lucene - Core
>  Issue Type: Bug
>Reporter: Robert Muir
>Priority: Major
> Attachments: LUCENE-8192.patch, LUCENE-8192_prototype.patch, 
> LUCENE-8192_take_two.patch
>
>
> Similar to LUCENE-8191, now that indexwriter checks the offsets, this boolean 
> is useless: if offsets are broken it will still fail.
> We should just remove the boolean.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org



[jira] [Updated] (LUCENE-8192) Remove offsetsAreCorrect from BaseTokenStreamTestCase

2018-03-04 Thread Robert Muir (JIRA)

 [ 
https://issues.apache.org/jira/browse/LUCENE-8192?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Muir updated LUCENE-8192:

Attachment: LUCENE-8192_take_two.patch

> Remove offsetsAreCorrect from BaseTokenStreamTestCase
> -
>
> Key: LUCENE-8192
> URL: https://issues.apache.org/jira/browse/LUCENE-8192
> Project: Lucene - Core
>  Issue Type: Bug
>Reporter: Robert Muir
>Priority: Major
> Attachments: LUCENE-8192_prototype.patch, LUCENE-8192_take_two.patch
>
>
> Similar to LUCENE-8191, now that indexwriter checks the offsets, this boolean 
> is useless: if offsets are broken it will still fail.
> We should just remove the boolean.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org



[jira] [Updated] (LUCENE-8192) Remove offsetsAreCorrect from BaseTokenStreamTestCase

2018-03-04 Thread Robert Muir (JIRA)

 [ 
https://issues.apache.org/jira/browse/LUCENE-8192?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Muir updated LUCENE-8192:

Attachment: LUCENE-8192_prototype.patch

> Remove offsetsAreCorrect from BaseTokenStreamTestCase
> -
>
> Key: LUCENE-8192
> URL: https://issues.apache.org/jira/browse/LUCENE-8192
> Project: Lucene - Core
>  Issue Type: Bug
>Reporter: Robert Muir
>Priority: Major
> Attachments: LUCENE-8192_prototype.patch
>
>
> Similar to LUCENE-8191, now that indexwriter checks the offsets, this boolean 
> is useless: if offsets are broken it will still fail.
> We should just remove the boolean.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org