[jira] [Updated] (SOLR-11140) (private) SolrMetricManager.prepareCloudPlugins has unused parameter

2017-07-28 Thread Omar Abdelnabi (JIRA) 

 [ 
https://issues.apache.org/jira/browse/SOLR-11140?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Omar Abdelnabi updated SOLR-11140:
--
Attachment: SOLR-11140.patch

Attaching a patch

> (private) SolrMetricManager.prepareCloudPlugins has unused parameter
> 
>
> Key: SOLR-11140
> URL: https://issues.apache.org/jira/browse/SOLR-11140
> Project: Solr
>  Issue Type: Task
>  Components: metrics
>Reporter: Christine Poerschke
>Priority: Minor
> Attachments: SOLR-11140.patch
>
>
> {{SolrMetricManager.prepareCloudPlugins}} is a private method and its last 
> parameter ({{defaultPlugin}}) is always passed in as {{null}} leading to an 
> effectively dead/unreachable block of code in the method implementation.
> This ticket proposes to remove the unused parameter and associated 
> unreachable block of code.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

[jira] [Updated] (SOLR-11140) (private) SolrMetricManager.prepareCloudPlugins has unused parameter

2017-07-26 Thread Cassandra Targett (JIRA) 

 [ 
https://issues.apache.org/jira/browse/SOLR-11140?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Cassandra Targett updated SOLR-11140:
-
Component/s: metrics

> (private) SolrMetricManager.prepareCloudPlugins has unused parameter
> 
>
> Key: SOLR-11140
> URL: https://issues.apache.org/jira/browse/SOLR-11140
> Project: Solr
>  Issue Type: Task
>  Components: metrics
>Reporter: Christine Poerschke
>Priority: Minor
>
> {{SolrMetricManager.prepareCloudPlugins}} is a private method and its last 
> parameter ({{defaultPlugin}}) is always passed in as {{null}} leading to an 
> effectively dead/unreachable block of code in the method implementation.
> This ticket proposes to remove the unused parameter and associated 
> unreachable block of code.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org