[jira] [Updated] (SOLR-11198) downconfig downloads empty file as folder

2017-08-06 Thread Erick Erickson (JIRA)

 [ 
https://issues.apache.org/jira/browse/SOLR-11198?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Erick Erickson updated SOLR-11198:
--
Attachment: SOLR-11198.patch

Final patch with CHANGES.txt

> downconfig downloads empty file as folder
> -
>
> Key: SOLR-11198
> URL: https://issues.apache.org/jira/browse/SOLR-11198
> Project: Solr
>  Issue Type: Bug
>  Security Level: Public(Default Security Level. Issues are Public) 
>Affects Versions: 6.6
> Environment: Windows 7
>Reporter: Isabelle Giguere
>Assignee: Erick Erickson
>Priority: Minor
> Attachments: SOLR-11198.patch, SOLR-11198.patch
>
>
> With Solr 6.6.0, when downloading a config from Zookeeper (3.4.10), if a file 
> is empty, it is downloaded as a folder (on Windows, at least).
> A Zookeeper browser (Eclipse: Zookeeper Explorer) shows the file as a file, 
> however, in ZK.
> Noticed because we keep an empty synonyms.txt file in the Solr config 
> provided with our product, in case a client would want to use it.
> The workaround is simple, since the file allows comments: just add a comment, 
> so it is not empty.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org



[jira] [Updated] (SOLR-11198) downconfig downloads empty file as folder

2017-08-05 Thread Erick Erickson (JIRA)

 [ 
https://issues.apache.org/jira/browse/SOLR-11198?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Erick Erickson updated SOLR-11198:
--
Attachment: SOLR-11198.patch

OK, false alarm. bin/solr, zkcli and ZkCLI all look like they go through 
ZkMaintenanceUtils so the same fix should work for them all.

The fix isn't even a one-liner in ZkMaintnanceUtils, there was a lot more work 
in the tests. Not unusual.

Anyway, I tested with bin/solr, zkcli.sh and ZkCLI (mac) but I can't test it on 
Windows. Isabelle, if you're feeling brave could you download the patch, 
compile and give it a whirl and let me know?

BTW, the start scripts may be easier to use, try "bin/solr.cmd zk -help". The 
upconfig/downconfig are modeled closely on the ZkCLI, but don't require all the 
classpath etc. 

I have yet to precommit and run all the tests, but certainly all the tests in 
SolrCLIZkUtilsTest run successfully.

> downconfig downloads empty file as folder
> -
>
> Key: SOLR-11198
> URL: https://issues.apache.org/jira/browse/SOLR-11198
> Project: Solr
>  Issue Type: Bug
>  Security Level: Public(Default Security Level. Issues are Public) 
>Affects Versions: 6.6
> Environment: Windows 7
>Reporter: Isabelle Giguere
>Assignee: Erick Erickson
>Priority: Minor
> Attachments: SOLR-11198.patch
>
>
> With Solr 6.6.0, when downloading a config from Zookeeper (3.4.10), if a file 
> is empty, it is downloaded as a folder (on Windows, at least).
> A Zookeeper browser (Eclipse: Zookeeper Explorer) shows the file as a file, 
> however, in ZK.
> Noticed because we keep an empty synonyms.txt file in the Solr config 
> provided with our product, in case a client would want to use it.
> The workaround is simple, since the file allows comments: just add a comment, 
> so it is not empty.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org