[jira] [Updated] (SOLR-1942) Ability to select codec per field
[ https://issues.apache.org/jira/browse/SOLR-1942?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Muir updated SOLR-1942: -- Attachment: SOLR-1942.patch Updated patch with Simon's suggestions Ability to select codec per field - Key: SOLR-1942 URL: https://issues.apache.org/jira/browse/SOLR-1942 Project: Solr Issue Type: New Feature Affects Versions: 4.0 Reporter: Yonik Seeley Assignee: Robert Muir Fix For: 4.0 Attachments: SOLR-1942.patch, SOLR-1942.patch, SOLR-1942.patch, SOLR-1942.patch, SOLR-1942.patch, SOLR-1942.patch, SOLR-1942.patch, SOLR-1942.patch, SOLR-1942.patch, SOLR-1942.patch, SOLR-1942.patch, SOLR-1942.patch We should use PerFieldCodecWrapper to allow users to select the codec per-field. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-1942) Ability to select codec per field
[ https://issues.apache.org/jira/browse/SOLR-1942?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Muir updated SOLR-1942: -- Attachment: SOLR-1942.patch Updated patch with Simon's previous suggestions. A few more things I saw that I'm not sure I like: * the CodecProvider syntax in the test config is cool, but i'm not sure this should be done in SolrCore? I think if you want to have a CP that loads up codecs by classname like this, it should be done in a CodecProviderFactory (you know parsing arguments however it wants). * I think its confusing how the SchemaCodecProvider answers to codec requests in 3 ways, 1. from the 'delegate' in SolrConfig, 2. from the schema, and 3. from the default codecProvider. I think if you try to use this, its easy to get yourself in a situation where solrconfig conflicts with the schema. I also don't think we need to bother with the 'defaultCP', in other words if you specify a custom codec provider, this is the only one that is used. Ability to select codec per field - Key: SOLR-1942 URL: https://issues.apache.org/jira/browse/SOLR-1942 Project: Solr Issue Type: New Feature Affects Versions: 4.0 Reporter: Yonik Seeley Assignee: Grant Ingersoll Fix For: 4.0 Attachments: SOLR-1942.patch, SOLR-1942.patch, SOLR-1942.patch, SOLR-1942.patch, SOLR-1942.patch, SOLR-1942.patch, SOLR-1942.patch, SOLR-1942.patch, SOLR-1942.patch, SOLR-1942.patch We should use PerFieldCodecWrapper to allow users to select the codec per-field. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-1942) Ability to select codec per field
[ https://issues.apache.org/jira/browse/SOLR-1942?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Muir updated SOLR-1942: -- Attachment: SOLR-1942.patch patch synced up to trunk Ability to select codec per field - Key: SOLR-1942 URL: https://issues.apache.org/jira/browse/SOLR-1942 Project: Solr Issue Type: New Feature Affects Versions: 4.0 Reporter: Yonik Seeley Assignee: Grant Ingersoll Fix For: 4.0 Attachments: SOLR-1942.patch, SOLR-1942.patch, SOLR-1942.patch, SOLR-1942.patch, SOLR-1942.patch, SOLR-1942.patch, SOLR-1942.patch, SOLR-1942.patch We should use PerFieldCodecWrapper to allow users to select the codec per-field. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-1942) Ability to select codec per field
[ https://issues.apache.org/jira/browse/SOLR-1942?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Muir updated SOLR-1942: -- Attachment: SOLR-1942.patch some minor tweaks: delegate the listAll() in the schemacodecprovider, and minimize the test config Ability to select codec per field - Key: SOLR-1942 URL: https://issues.apache.org/jira/browse/SOLR-1942 Project: Solr Issue Type: New Feature Affects Versions: 4.0 Reporter: Yonik Seeley Assignee: Grant Ingersoll Fix For: 4.0 Attachments: SOLR-1942.patch, SOLR-1942.patch, SOLR-1942.patch, SOLR-1942.patch, SOLR-1942.patch, SOLR-1942.patch, SOLR-1942.patch, SOLR-1942.patch, SOLR-1942.patch We should use PerFieldCodecWrapper to allow users to select the codec per-field. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] Updated: (SOLR-1942) Ability to select codec per field
[ https://issues.apache.org/jira/browse/SOLR-1942?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Simon Willnauer updated SOLR-1942: -- Attachment: SOLR-1942.patch updated to trunk - if somebody has time a review would be appreciated. Ability to select codec per field - Key: SOLR-1942 URL: https://issues.apache.org/jira/browse/SOLR-1942 Project: Solr Issue Type: New Feature Affects Versions: 4.0 Reporter: Yonik Seeley Assignee: Simon Willnauer Fix For: 4.0 Attachments: SOLR-1942.patch, SOLR-1942.patch, SOLR-1942.patch, SOLR-1942.patch, SOLR-1942.patch, SOLR-1942.patch, SOLR-1942.patch We should use PerFieldCodecWrapper to allow users to select the codec per-field. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] Updated: (SOLR-1942) Ability to select codec per field
[ https://issues.apache.org/jira/browse/SOLR-1942?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Simon Willnauer updated SOLR-1942: -- Attachment: SOLR-1942.patch updated patch to trunk Ability to select codec per field - Key: SOLR-1942 URL: https://issues.apache.org/jira/browse/SOLR-1942 Project: Solr Issue Type: New Feature Affects Versions: 4.0 Reporter: Yonik Seeley Assignee: Simon Willnauer Fix For: 4.0 Attachments: SOLR-1942.patch, SOLR-1942.patch, SOLR-1942.patch, SOLR-1942.patch, SOLR-1942.patch, SOLR-1942.patch We should use PerFieldCodecWrapper to allow users to select the codec per-field. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] Updated: (SOLR-1942) Ability to select codec per field
[ https://issues.apache.org/jira/browse/SOLR-1942?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Simon Willnauer updated SOLR-1942: -- Attachment: SOLR-1942.patch here is an updated patch - I think we are close here so a review would be helpful! Anyone, Yonik / Hoss? Ability to select codec per field - Key: SOLR-1942 URL: https://issues.apache.org/jira/browse/SOLR-1942 Project: Solr Issue Type: New Feature Affects Versions: 4.0 Reporter: Yonik Seeley Assignee: Simon Willnauer Fix For: 4.0 Attachments: SOLR-1942.patch, SOLR-1942.patch, SOLR-1942.patch, SOLR-1942.patch We should use PerFieldCodecWrapper to allow users to select the codec per-field. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] Updated: (SOLR-1942) Ability to select codec per field
[ https://issues.apache.org/jira/browse/SOLR-1942?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Simon Willnauer updated SOLR-1942: -- Attachment: SOLR-1942.patch here is a new patch that adds dynamic field support and removes the static setDefaultCodec() method completely. This method is obsolete since we have setDefaultFieldCodec now on each provider. simon Ability to select codec per field - Key: SOLR-1942 URL: https://issues.apache.org/jira/browse/SOLR-1942 Project: Solr Issue Type: New Feature Affects Versions: 4.0 Reporter: Yonik Seeley Assignee: Simon Willnauer Fix For: 4.0 Attachments: SOLR-1942.patch, SOLR-1942.patch, SOLR-1942.patch, SOLR-1942.patch, SOLR-1942.patch We should use PerFieldCodecWrapper to allow users to select the codec per-field. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] Updated: (SOLR-1942) Ability to select codec per field
[ https://issues.apache.org/jira/browse/SOLR-1942?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Simon Willnauer updated SOLR-1942: -- Attachment: SOLR-1942.patch the previous patch got somehow corrupted Ability to select codec per field - Key: SOLR-1942 URL: https://issues.apache.org/jira/browse/SOLR-1942 Project: Solr Issue Type: New Feature Affects Versions: 4.0 Reporter: Yonik Seeley Assignee: Simon Willnauer Fix For: 4.0 Attachments: SOLR-1942.patch, SOLR-1942.patch We should use PerFieldCodecWrapper to allow users to select the codec per-field. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] Updated: (SOLR-1942) Ability to select codec per field
[ https://issues.apache.org/jira/browse/SOLR-1942?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Simon Willnauer updated SOLR-1942: -- Attachment: SOLR-1942.patch Updated the last version to support custom CodecProvider as well as custom Codecs via plugin. Currently this patch only supports specifying codecs for FieldTypes like this: {code} fieldType name=string_pulsing class=solr.StrField codec=Pulsing/ fieldType name=string_simpletext class=solr.StrField codec=SimpleText/ fieldType name=string_standard class=solr.StrField codec=Standard/ {code} and in solrconfig.xml the provider and its codecs can be configured like this: (while the class argument on codecProvider is optional) {code} /deletionPolicy codecProvider class=org.apache.solr.core.MockCodecProvider defaultCodec=Pulsing codec class=org.apache.lucene.index.codecs.simpletext.SimpleTextCodec/ codec class=org.apache.lucene.index.codecs.preflex.PreFlexCodec/ /codecProvider /mainIndex {code} Ability to select codec per field - Key: SOLR-1942 URL: https://issues.apache.org/jira/browse/SOLR-1942 Project: Solr Issue Type: New Feature Affects Versions: 4.0 Reporter: Yonik Seeley Assignee: Simon Willnauer Fix For: 4.0 Attachments: SOLR-1942.patch, SOLR-1942.patch, SOLR-1942.patch We should use PerFieldCodecWrapper to allow users to select the codec per-field. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] Updated: (SOLR-1942) Ability to select codec per field
[ https://issues.apache.org/jira/browse/SOLR-1942?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Simon Willnauer updated SOLR-1942: -- Attachment: SOLR-1942.patch I started working on this today and attach my current state. There are still some edges and there is a testcase (SpellCheckComponent) that is still failing though. Anyway its good enough for the first round of feedback which would be great since I am not a solr expert :) thanks Ability to select codec per field - Key: SOLR-1942 URL: https://issues.apache.org/jira/browse/SOLR-1942 Project: Solr Issue Type: New Feature Affects Versions: 4.0 Reporter: Yonik Seeley Fix For: 4.0 Attachments: SOLR-1942.patch We should use PerFieldCodecWrapper to allow users to select the codec per-field. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org