[jira] [Updated] (SOLR-2633) Make SolrDispatchFilter testable and add tests
[ https://issues.apache.org/jira/browse/SOLR-2633?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hoss Man updated SOLR-2633: --- Fix Version/s: (was: 4.0) There is no indication that anyone is actively working on this issue, so removing 4.0 from the fixVersion. > Make SolrDispatchFilter testable and add tests > -- > > Key: SOLR-2633 > URL: https://issues.apache.org/jira/browse/SOLR-2633 > Project: Solr > Issue Type: Improvement > Components: search >Affects Versions: 3.1, 3.2, 3.3 >Reporter: Edoardo Tosca >Assignee: Mark Miller >Priority: Minor > Attachments: SOLR-2633-tests-only.patch, SOLR-2633-tests-only.patch > > > I have ideas for possible extensions/enhancements to the SolrDispatchFilter. > However, as it doesn't have any tests, making safe enhancements is difficult. > Given its monolithic nature, it is hard to test. Therefore, I am proposing to > refactor it to make it testable, and to provide tests for it. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-2633) Make SolrDispatchFilter testable and add tests
[ https://issues.apache.org/jira/browse/SOLR-2633?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Edoardo Tosca updated SOLR-2633: Affects Version/s: (was: 4.0) 3.3 > Make SolrDispatchFilter testable and add tests > -- > > Key: SOLR-2633 > URL: https://issues.apache.org/jira/browse/SOLR-2633 > Project: Solr > Issue Type: Improvement > Components: search >Affects Versions: 3.1, 3.2, 3.3 >Reporter: Edoardo Tosca >Priority: Minor > > I have ideas for possible extensions/enhancements to the SolrDispatchFilter. > However, as it doesn't have any tests, making safe enhancements is difficult. > Given its monolithic nature, it is hard to test. Therefore, I am proposing to > refactor it to make it testable, and to provide tests for it. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-2633) Make SolrDispatchFilter testable and add tests
[ https://issues.apache.org/jira/browse/SOLR-2633?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Edoardo Tosca updated SOLR-2633: Attachment: SOLR-2633-tests-only.patch This is a first cut. The patch contains a new test class: SolrDispatchFilterTest. At the moment there are 4 tests which covers some behaviour of the public method doFilter > Make SolrDispatchFilter testable and add tests > -- > > Key: SOLR-2633 > URL: https://issues.apache.org/jira/browse/SOLR-2633 > Project: Solr > Issue Type: Improvement > Components: search >Affects Versions: 3.1, 3.2, 3.3 >Reporter: Edoardo Tosca >Priority: Minor > Attachments: SOLR-2633-tests-only.patch > > > I have ideas for possible extensions/enhancements to the SolrDispatchFilter. > However, as it doesn't have any tests, making safe enhancements is difficult. > Given its monolithic nature, it is hard to test. Therefore, I am proposing to > refactor it to make it testable, and to provide tests for it. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-2633) Make SolrDispatchFilter testable and add tests
[ https://issues.apache.org/jira/browse/SOLR-2633?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Miller updated SOLR-2633: -- Fix Version/s: 4.0 3.4 > Make SolrDispatchFilter testable and add tests > -- > > Key: SOLR-2633 > URL: https://issues.apache.org/jira/browse/SOLR-2633 > Project: Solr > Issue Type: Improvement > Components: search >Affects Versions: 3.1, 3.2, 3.3 >Reporter: Edoardo Tosca >Assignee: Mark Miller >Priority: Minor > Fix For: 3.4, 4.0 > > Attachments: SOLR-2633-tests-only.patch > > > I have ideas for possible extensions/enhancements to the SolrDispatchFilter. > However, as it doesn't have any tests, making safe enhancements is difficult. > Given its monolithic nature, it is hard to test. Therefore, I am proposing to > refactor it to make it testable, and to provide tests for it. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-2633) Make SolrDispatchFilter testable and add tests
[ https://issues.apache.org/jira/browse/SOLR-2633?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Edoardo Tosca updated SOLR-2633: Attachment: SOLR-2633-only-tests.patch This second cut contains more tests which are convering about 80% of the code of the class under test. > Make SolrDispatchFilter testable and add tests > -- > > Key: SOLR-2633 > URL: https://issues.apache.org/jira/browse/SOLR-2633 > Project: Solr > Issue Type: Improvement > Components: search >Affects Versions: 3.1, 3.2, 3.3 >Reporter: Edoardo Tosca >Assignee: Mark Miller >Priority: Minor > Fix For: 3.4, 4.0 > > Attachments: SOLR-2633-tests-only.patch > > > I have ideas for possible extensions/enhancements to the SolrDispatchFilter. > However, as it doesn't have any tests, making safe enhancements is difficult. > Given its monolithic nature, it is hard to test. Therefore, I am proposing to > refactor it to make it testable, and to provide tests for it. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-2633) Make SolrDispatchFilter testable and add tests
[ https://issues.apache.org/jira/browse/SOLR-2633?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Edoardo Tosca updated SOLR-2633: Attachment: (was: SOLR-2633-only-tests.patch) > Make SolrDispatchFilter testable and add tests > -- > > Key: SOLR-2633 > URL: https://issues.apache.org/jira/browse/SOLR-2633 > Project: Solr > Issue Type: Improvement > Components: search >Affects Versions: 3.1, 3.2, 3.3 >Reporter: Edoardo Tosca >Assignee: Mark Miller >Priority: Minor > Fix For: 3.4, 4.0 > > Attachments: SOLR-2633-tests-only.patch > > > I have ideas for possible extensions/enhancements to the SolrDispatchFilter. > However, as it doesn't have any tests, making safe enhancements is difficult. > Given its monolithic nature, it is hard to test. Therefore, I am proposing to > refactor it to make it testable, and to provide tests for it. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-2633) Make SolrDispatchFilter testable and add tests
[ https://issues.apache.org/jira/browse/SOLR-2633?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Edoardo Tosca updated SOLR-2633: Attachment: SOLR-2633-tests-only.patch > Make SolrDispatchFilter testable and add tests > -- > > Key: SOLR-2633 > URL: https://issues.apache.org/jira/browse/SOLR-2633 > Project: Solr > Issue Type: Improvement > Components: search >Affects Versions: 3.1, 3.2, 3.3 >Reporter: Edoardo Tosca >Assignee: Mark Miller >Priority: Minor > Fix For: 3.4, 4.0 > > Attachments: SOLR-2633-tests-only.patch, SOLR-2633-tests-only.patch > > > I have ideas for possible extensions/enhancements to the SolrDispatchFilter. > However, as it doesn't have any tests, making safe enhancements is difficult. > Given its monolithic nature, it is hard to test. Therefore, I am proposing to > refactor it to make it testable, and to provide tests for it. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-2633) Make SolrDispatchFilter testable and add tests
[ https://issues.apache.org/jira/browse/SOLR-2633?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Miller updated SOLR-2633: -- Assignee: (was: Mark Miller) > Make SolrDispatchFilter testable and add tests > -- > > Key: SOLR-2633 > URL: https://issues.apache.org/jira/browse/SOLR-2633 > Project: Solr > Issue Type: Improvement > Components: search >Affects Versions: 3.1, 3.2, 3.3 >Reporter: Edoardo Tosca >Priority: Minor > Attachments: SOLR-2633-tests-only.patch, SOLR-2633-tests-only.patch > > > I have ideas for possible extensions/enhancements to the SolrDispatchFilter. > However, as it doesn't have any tests, making safe enhancements is difficult. > Given its monolithic nature, it is hard to test. Therefore, I am proposing to > refactor it to make it testable, and to provide tests for it. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
