[jira] [Updated] (SOLR-3699) SolrIndexWriter constructor leaks Directory if Exception creating IndexWriterConfig
[ https://issues.apache.org/jira/browse/SOLR-3699?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hoss Man updated SOLR-3699: --- Attachment: SOLR-3699.patch updated patch to trunk (incorporates the new IndexSplitter class yonik recently added) all tests pass, i'm going to press forward with committing so this can get more testing. SolrIndexWriter constructor leaks Directory if Exception creating IndexWriterConfig --- Key: SOLR-3699 URL: https://issues.apache.org/jira/browse/SOLR-3699 Project: Solr Issue Type: Bug Reporter: Robert Muir Assignee: Mark Miller Fix For: 4.0 Attachments: SOLR-3699.patch, SOLR-3699.patch, SOLR-3699.patch, SOLR-3699.patch, SOLR-3699.patch in LUCENE-4278 i had to add a hack to force SimpleFSDir for CoreContainerCoreInitFailuresTest, because it doesnt close its Directory on certain errors. This might indicate a problem that leaks happen if certain errors happen (e.g. not handled in finally) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-3699) SolrIndexWriter constructor leaks Directory if Exception creating IndexWriterConfig
[ https://issues.apache.org/jira/browse/SOLR-3699?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hoss Man updated SOLR-3699: --- Attachment: SOLR-3699.patch updated patch to trunk. Doing this helped uncover another (distinct) case where directories were not being closed that was exposed by the test SOLR-3746 added: if the updateHandler fails to init, then nothing in SolrCore was closing the directoryfactory. I'd asked miller to review this earlier, but i'm going to assume CTR soon unless i hear objections. SolrIndexWriter constructor leaks Directory if Exception creating IndexWriterConfig --- Key: SOLR-3699 URL: https://issues.apache.org/jira/browse/SOLR-3699 Project: Solr Issue Type: Bug Reporter: Robert Muir Assignee: Mark Miller Fix For: 4.0 Attachments: SOLR-3699.patch, SOLR-3699.patch, SOLR-3699.patch, SOLR-3699.patch in LUCENE-4278 i had to add a hack to force SimpleFSDir for CoreContainerCoreInitFailuresTest, because it doesnt close its Directory on certain errors. This might indicate a problem that leaks happen if certain errors happen (e.g. not handled in finally) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-3699) SolrIndexWriter constructor leaks Directory if Exception creating IndexWriterConfig
[ https://issues.apache.org/jira/browse/SOLR-3699?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hoss Man updated SOLR-3699: --- Attachment: SOLR-3699.patch Figured out the problem in my last patch: i was ignorant of the full DirectoryFactory API and didn't realize i should be calling doneWithDirectory(). I think this new patch is good to go, but i don't want to commit w/o review from someone who understands the DirectoryFactory semantics better (already opened SOLR-3717 because something looks wonky about the API, don't want to mess up and just fix a symptom here instead of the real problem SolrIndexWriter constructor leaks Directory if Exception creating IndexWriterConfig --- Key: SOLR-3699 URL: https://issues.apache.org/jira/browse/SOLR-3699 Project: Solr Issue Type: Bug Reporter: Robert Muir Fix For: 4.0 Attachments: SOLR-3699.patch, SOLR-3699.patch, SOLR-3699.patch in LUCENE-4278 i had to add a hack to force SimpleFSDir for CoreContainerCoreInitFailuresTest, because it doesnt close its Directory on certain errors. This might indicate a problem that leaks happen if certain errors happen (e.g. not handled in finally) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-3699) SolrIndexWriter constructor leaks Directory if Exception creating IndexWriterConfig
[ https://issues.apache.org/jira/browse/SOLR-3699?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hoss Man updated SOLR-3699: --- Fix Version/s: 5.0 4.0 Summary: SolrIndexWriter constructor leaks Directory if Exception creating IndexWriterConfig (was: fix CoreContainerCoreInitFailuresTest directory leak) SolrIndexWriter constructor leaks Directory if Exception creating IndexWriterConfig --- Key: SOLR-3699 URL: https://issues.apache.org/jira/browse/SOLR-3699 Project: Solr Issue Type: Bug Reporter: Robert Muir Fix For: 4.0, 5.0 Attachments: SOLR-3699.patch in LUCENE-4278 i had to add a hack to force SimpleFSDir for CoreContainerCoreInitFailuresTest, because it doesnt close its Directory on certain errors. This might indicate a problem that leaks happen if certain errors happen (e.g. not handled in finally) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-3699) SolrIndexWriter constructor leaks Directory if Exception creating IndexWriterConfig
[ https://issues.apache.org/jira/browse/SOLR-3699?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hoss Man updated SOLR-3699: --- Attachment: SOLR-3699.patch My quick and dirty attempt to fix this by making SolrIndexWriter's constructor private and adding a static create method that deals with calling directoryFactory.release() if the private constructor fails. Unfortunately it's still not working ... not clear to me why, but i'm about to get on a plain and won't have a chance to dig into it anymore for another 3-4 days, so i wanted to get what i have into Jira in case anyone else wants to take a stab at it. SolrIndexWriter constructor leaks Directory if Exception creating IndexWriterConfig --- Key: SOLR-3699 URL: https://issues.apache.org/jira/browse/SOLR-3699 Project: Solr Issue Type: Bug Reporter: Robert Muir Fix For: 4.0, 5.0 Attachments: SOLR-3699.patch, SOLR-3699.patch in LUCENE-4278 i had to add a hack to force SimpleFSDir for CoreContainerCoreInitFailuresTest, because it doesnt close its Directory on certain errors. This might indicate a problem that leaks happen if certain errors happen (e.g. not handled in finally) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
