[jira] [Updated] (SOLR-3861) regresion of SOLR-2008 - updateHandler should be closed before searcherExecutor
[ https://issues.apache.org/jira/browse/SOLR-3861?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Miller updated SOLR-3861: -- Fix Version/s: 5.0 > regresion of SOLR-2008 - updateHandler should be closed before > searcherExecutor > --- > > Key: SOLR-3861 > URL: https://issues.apache.org/jira/browse/SOLR-3861 > Project: Solr > Issue Type: Bug >Affects Versions: 4.0-ALPHA, 4.0-BETA >Reporter: Hoss Man >Assignee: Mark Miller >Priority: Blocker > Fix For: 4.0, 5.0 > > > SOLR-2008 fixed a possible RejectedExecutionException by ensuring that > SolrCore closed the updateHandler before the searcherExecutor. > [~markrmil...@gmail.com] re-flipped this logic in r1159378, which is > annotated as fixing both SOLR-2654 and SOLR-2654 (dup typo i guess) but it's > not clear why - pretty sure this means that the risk of a Rejected exception > is back in 4.0-BETA... > https://svn.apache.org/viewvc/lucene/dev/trunk/solr/core/src/java/org/apache/solr/core/SolrCore.java?r1=1146905&r2=1159378 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-3861) regresion of SOLR-2008 - updateHandler should be closed before searcherExecutor
[ https://issues.apache.org/jira/browse/SOLR-3861?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Miller updated SOLR-3861: -- Fix Version/s: (was: 4.0) 4.1 > regresion of SOLR-2008 - updateHandler should be closed before > searcherExecutor > --- > > Key: SOLR-3861 > URL: https://issues.apache.org/jira/browse/SOLR-3861 > Project: Solr > Issue Type: Bug >Affects Versions: 4.0-ALPHA, 4.0-BETA >Reporter: Hoss Man >Assignee: Mark Miller >Priority: Blocker > Fix For: 4.1, 5.0 > > > SOLR-2008 fixed a possible RejectedExecutionException by ensuring that > SolrCore closed the updateHandler before the searcherExecutor. > [~markrmil...@gmail.com] re-flipped this logic in r1159378, which is > annotated as fixing both SOLR-2654 and SOLR-2654 (dup typo i guess) but it's > not clear why - pretty sure this means that the risk of a Rejected exception > is back in 4.0-BETA... > https://svn.apache.org/viewvc/lucene/dev/trunk/solr/core/src/java/org/apache/solr/core/SolrCore.java?r1=1146905&r2=1159378 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-3861) regresion of SOLR-2008 - updateHandler should be closed before searcherExecutor
[ https://issues.apache.org/jira/browse/SOLR-3861?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Miller updated SOLR-3861: -- Attachment: SOLR-3861.patch I think something like this would work - a little hokey on the API side though. > regresion of SOLR-2008 - updateHandler should be closed before > searcherExecutor > --- > > Key: SOLR-3861 > URL: https://issues.apache.org/jira/browse/SOLR-3861 > Project: Solr > Issue Type: Bug >Affects Versions: 4.0-ALPHA, 4.0-BETA >Reporter: Hoss Man >Assignee: Mark Miller >Priority: Blocker > Fix For: 4.1, 5.0 > > Attachments: SOLR-3861.patch > > > SOLR-2008 fixed a possible RejectedExecutionException by ensuring that > SolrCore closed the updateHandler before the searcherExecutor. > [~markrmil...@gmail.com] re-flipped this logic in r1159378, which is > annotated as fixing both SOLR-2654 and SOLR-2654 (dup typo i guess) but it's > not clear why - pretty sure this means that the risk of a Rejected exception > is back in 4.0-BETA... > https://svn.apache.org/viewvc/lucene/dev/trunk/solr/core/src/java/org/apache/solr/core/SolrCore.java?r1=1146905&r2=1159378 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-3861) regresion of SOLR-2008 - updateHandler should be closed before searcherExecutor
[ https://issues.apache.org/jira/browse/SOLR-3861?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Miller updated SOLR-3861: -- Attachment: SOLR-3861.patch Here is a rough patch managing the SolrCore state more in SolrCore. Something is off still - TestIndexingPerformance fails - the final rollback it does causes a write.lock to be left behind when we try and close a directory. > regresion of SOLR-2008 - updateHandler should be closed before > searcherExecutor > --- > > Key: SOLR-3861 > URL: https://issues.apache.org/jira/browse/SOLR-3861 > Project: Solr > Issue Type: Bug >Affects Versions: 4.0-ALPHA, 4.0-BETA >Reporter: Hoss Man >Assignee: Mark Miller >Priority: Blocker > Fix For: 4.1, 5.0 > > Attachments: SOLR-3861.patch, SOLR-3861.patch > > > SOLR-2008 fixed a possible RejectedExecutionException by ensuring that > SolrCore closed the updateHandler before the searcherExecutor. > [~markrmil...@gmail.com] re-flipped this logic in r1159378, which is > annotated as fixing both SOLR-2654 and SOLR-2654 (dup typo i guess) but it's > not clear why - pretty sure this means that the risk of a Rejected exception > is back in 4.0-BETA... > https://svn.apache.org/viewvc/lucene/dev/trunk/solr/core/src/java/org/apache/solr/core/SolrCore.java?r1=1146905&r2=1159378 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-3861) regresion of SOLR-2008 - updateHandler should be closed before searcherExecutor
[ https://issues.apache.org/jira/browse/SOLR-3861?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Miller updated SOLR-3861: -- Attachment: SOLR-3861.patch Here is a completed test. > regresion of SOLR-2008 - updateHandler should be closed before > searcherExecutor > --- > > Key: SOLR-3861 > URL: https://issues.apache.org/jira/browse/SOLR-3861 > Project: Solr > Issue Type: Bug >Affects Versions: 4.0-ALPHA, 4.0-BETA >Reporter: Hoss Man >Assignee: Mark Miller >Priority: Blocker > Fix For: 4.1, 5.0 > > Attachments: SOLR-3861.patch, SOLR-3861.patch, SOLR-3861.patch > > > SOLR-2008 fixed a possible RejectedExecutionException by ensuring that > SolrCore closed the updateHandler before the searcherExecutor. > [~markrmil...@gmail.com] re-flipped this logic in r1159378, which is > annotated as fixing both SOLR-2654 and SOLR-2654 (dup typo i guess) but it's > not clear why - pretty sure this means that the risk of a Rejected exception > is back in 4.0-BETA... > https://svn.apache.org/viewvc/lucene/dev/trunk/solr/core/src/java/org/apache/solr/core/SolrCore.java?r1=1146905&r2=1159378 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
