[jira] [Updated] (SOLR-3984) Unload the core, don't remove the core data from disk for parameter deleteInstanceDir=true

2012-10-24 Thread Erick Erickson (JIRA)

 [ 
https://issues.apache.org/jira/browse/SOLR-3984?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Erick Erickson updated SOLR-3984:
-

Attachment: SOLR-3984.patch

Raintung is correct. In fact, deleteInstanceDir seems to be completely broken 
unless you specify an absolute dir.

Here's a reworked patch because it seems like the trap here 
(CoreContainer.getInstanceDir()) is just laying in wait for the unwary. I've 
added a new method getRawInstanceDir and refactored the uses of getInstanceDir 
to use the right one. I wouldn't dare return the new getInstanceDir to, say, 
the snapshooter code, and the code that writes solr.xml back out would also be 
broken if it used the (new) getInstanceDir().

If there are no objections, I'll commit this tomorrow.

Thanks  Raintung! Your patch provided me a _much_ easier time tackling this!

> Unload the core, don't remove the core data from disk for parameter 
> deleteInstanceDir=true
> --
>
> Key: SOLR-3984
> URL: https://issues.apache.org/jira/browse/SOLR-3984
> Project: Solr
>  Issue Type: Bug
>  Components: SolrCloud
>Affects Versions: 4.0-ALPHA, 4.0-BETA, 4.0
>Reporter: Raintung Li
>Assignee: Erick Erickson
> Attachments: patch.txt, SOLR-3984.patch
>
>   Original Estimate: 168h
>  Remaining Estimate: 168h
>
> Call URL :
> http://localhost:8983/solr/admin/cores?action=UNLOAD&deleteInstanceDir=true&core=mycollection1&qt=/admin/cores
> Check the disk path:
> folder: /apache-solr-4.0.0/example3/solr/mycollection1 still exist, but 
> caller response is success.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org



[jira] [Updated] (SOLR-3984) Unload the core, don't remove the core data from disk for parameter deleteInstanceDir=true

2012-10-24 Thread Raintung Li (JIRA)

 [ 
https://issues.apache.org/jira/browse/SOLR-3984?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Raintung Li updated SOLR-3984:
--

Attachment: patch.txt

Fix the bug patch

> Unload the core, don't remove the core data from disk for parameter 
> deleteInstanceDir=true
> --
>
> Key: SOLR-3984
> URL: https://issues.apache.org/jira/browse/SOLR-3984
> Project: Solr
>  Issue Type: Bug
>  Components: SolrCloud
>Affects Versions: 4.0-ALPHA, 4.0-BETA, 4.0
>Reporter: Raintung Li
> Attachments: patch.txt
>
>   Original Estimate: 168h
>  Remaining Estimate: 168h
>
> Call URL :
> http://localhost:8983/solr/admin/cores?action=UNLOAD&deleteInstanceDir=true&core=mycollection1&qt=/admin/cores
> Check the disk path:
> folder: /apache-solr-4.0.0/example3/solr/mycollection1 still exist, but 
> caller response is success.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org



[jira] [Updated] (SOLR-3984) Unload the core, don't remove the core data from disk for parameter deleteInstanceDir=true

2012-10-24 Thread Raintung Li (JIRA)

 [ 
https://issues.apache.org/jira/browse/SOLR-3984?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Raintung Li updated SOLR-3984:
--

Description: 
Call URL :
http://localhost:8983/solr/admin/cores?action=UNLOAD&deleteInstanceDir=true&core=mycollection1&qt=/admin/cores

Check the disk path:
folder: /apache-solr-4.0.0/example3/solr/mycollection1 still exist, but caller 
response is success.



  was:
Call URL :
http://localhost:8983/solr/admin/cores?action=UNLOAD&deleteInstanceDir=true&core=mycollection1&qt=/admin/cores

Check the disk path:
folder: /apache-solr-4.0.0/example3/solr/mycollection1 still exist, but caller 
response is ok.




> Unload the core, don't remove the core data from disk for parameter 
> deleteInstanceDir=true
> --
>
> Key: SOLR-3984
> URL: https://issues.apache.org/jira/browse/SOLR-3984
> Project: Solr
>  Issue Type: Bug
>  Components: SolrCloud
>Affects Versions: 4.0-ALPHA, 4.0-BETA, 4.0
>Reporter: Raintung Li
>   Original Estimate: 168h
>  Remaining Estimate: 168h
>
> Call URL :
> http://localhost:8983/solr/admin/cores?action=UNLOAD&deleteInstanceDir=true&core=mycollection1&qt=/admin/cores
> Check the disk path:
> folder: /apache-solr-4.0.0/example3/solr/mycollection1 still exist, but 
> caller response is success.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org