[jira] [Updated] (SOLR-4317) SolrTestCaseJ4: Can't avoid "collection1" convention
[ https://issues.apache.org/jira/browse/SOLR-4317?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Erick Erickson updated SOLR-4317: - Attachment: SOLR-4317.patch Added CHANGES.txt entry. > SolrTestCaseJ4: Can't avoid "collection1" convention > > > Key: SOLR-4317 > URL: https://issues.apache.org/jira/browse/SOLR-4317 > Project: Solr > Issue Type: Improvement > Components: Tests >Affects Versions: 4.0 >Reporter: Tricia Jenkins >Priority: Minor > Fix For: 4.2, 5.0 > > Attachments: SOLR-4317.patch, SOLR-4317.patch, SOLR-4317.patch, > SOLR-4317.patch > > > There is still an issue after the SOLR-3826 patch was applied for 4.0 > [https://issues.apache.org/jira/browse/SOLR-3826] in September 2012. When > TestHarness is called from SolrTestCase4J the only available constructors > ignore coreName, set coreName = null, and initialize the default > 'collection1.' -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-4317) SolrTestCaseJ4: Can't avoid "collection1" convention
[ https://issues.apache.org/jira/browse/SOLR-4317?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tricia Jenkins updated SOLR-4317: - Attachment: (was: SOLR-4317.patch) > SolrTestCaseJ4: Can't avoid "collection1" convention > > > Key: SOLR-4317 > URL: https://issues.apache.org/jira/browse/SOLR-4317 > Project: Solr > Issue Type: Improvement > Components: Tests >Affects Versions: 4.0 >Reporter: Tricia Jenkins >Priority: Minor > Fix For: 4.2, 5.0 > > Attachments: SOLR-4317.patch, SOLR-4317.patch, SOLR-4317.patch > > > There is still an issue after the SOLR-3826 patch was applied for 4.0 > [https://issues.apache.org/jira/browse/SOLR-3826] in September 2012. When > TestHarness is called from SolrTestCase4J the only available constructors > ignore coreName, set coreName = null, and initialize the default > 'collection1.' -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-4317) SolrTestCaseJ4: Can't avoid "collection1" convention
[ https://issues.apache.org/jira/browse/SOLR-4317?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tricia Jenkins updated SOLR-4317: - Attachment: SOLR-4317.patch Hi Erik. Your re-organized patch looks great! It applies cleanly for me and all tests pass. The patch I'm attaching has an added test for the sharedLib directory which I had complained about in my last comment. I don't see the 'sharedLib' tested anywhere else but it seems to work outside of the test-framework. The test fails proving my frustration. Should I make this a separate issue in JIRA? > SolrTestCaseJ4: Can't avoid "collection1" convention > > > Key: SOLR-4317 > URL: https://issues.apache.org/jira/browse/SOLR-4317 > Project: Solr > Issue Type: Improvement > Components: Tests >Affects Versions: 4.0 >Reporter: Tricia Jenkins >Priority: Minor > Fix For: 4.2, 5.0 > > Attachments: SOLR-4317.patch, SOLR-4317.patch, SOLR-4317.patch, > SOLR-4317.patch > > > There is still an issue after the SOLR-3826 patch was applied for 4.0 > [https://issues.apache.org/jira/browse/SOLR-3826] in September 2012. When > TestHarness is called from SolrTestCase4J the only available constructors > ignore coreName, set coreName = null, and initialize the default > 'collection1.' -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-4317) SolrTestCaseJ4: Can't avoid "collection1" convention
[ https://issues.apache.org/jira/browse/SOLR-4317?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Erick Erickson updated SOLR-4317: - Attachment: SOLR-4317.patch Tricia: I revised the patch a bit to fit better in the general scheme of things, see below. Does this still do what you intended? I haven't run all tests yet, just this one 1> puts the test case in the "usual" place so it's run with the rest of the unit tests. 2> creates a temporary directory with the relevant files in it for a multicore setup 3> adds a solr-multi.xml file to the test files so we have one available. This now runs either in an IDE or as a stand-alone test. > SolrTestCaseJ4: Can't avoid "collection1" convention > > > Key: SOLR-4317 > URL: https://issues.apache.org/jira/browse/SOLR-4317 > Project: Solr > Issue Type: Improvement > Components: Tests >Affects Versions: 4.0 >Reporter: Tricia Jenkins >Priority: Minor > Fix For: 4.2, 5.0 > > Attachments: SOLR-4317.patch, SOLR-4317.patch, SOLR-4317.patch > > > There is still an issue after the SOLR-3826 patch was applied for 4.0 > [https://issues.apache.org/jira/browse/SOLR-3826] in September 2012. When > TestHarness is called from SolrTestCase4J the only available constructors > ignore coreName, set coreName = null, and initialize the default > 'collection1.' -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-4317) SolrTestCaseJ4: Can't avoid "collection1" convention
[ https://issues.apache.org/jira/browse/SOLR-4317?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tricia Jenkins updated SOLR-4317: - Attachment: (was: SOLR-4317.patch) > SolrTestCaseJ4: Can't avoid "collection1" convention > > > Key: SOLR-4317 > URL: https://issues.apache.org/jira/browse/SOLR-4317 > Project: Solr > Issue Type: Improvement > Components: Tests >Affects Versions: 4.0 >Reporter: Tricia Jenkins >Priority: Minor > Fix For: 4.2, 5.0 > > Attachments: SOLR-4317.patch, SOLR-4317.patch > > > There is still an issue after the SOLR-3826 patch was applied for 4.0 > [https://issues.apache.org/jira/browse/SOLR-3826] in September 2012. When > TestHarness is called from SolrTestCase4J the only available constructors > ignore coreName, set coreName = null, and initialize the default > 'collection1.' -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-4317) SolrTestCaseJ4: Can't avoid "collection1" convention
[ https://issues.apache.org/jira/browse/SOLR-4317?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tricia Jenkins updated SOLR-4317: - Attachment: SOLR-4317.patch Missing a file :( > SolrTestCaseJ4: Can't avoid "collection1" convention > > > Key: SOLR-4317 > URL: https://issues.apache.org/jira/browse/SOLR-4317 > Project: Solr > Issue Type: Improvement > Components: Tests >Affects Versions: 4.0 >Reporter: Tricia Jenkins >Priority: Minor > Fix For: 4.2, 5.0 > > Attachments: SOLR-4317.patch, SOLR-4317.patch, SOLR-4317.patch > > > There is still an issue after the SOLR-3826 patch was applied for 4.0 > [https://issues.apache.org/jira/browse/SOLR-3826] in September 2012. When > TestHarness is called from SolrTestCase4J the only available constructors > ignore coreName, set coreName = null, and initialize the default > 'collection1.' -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-4317) SolrTestCaseJ4: Can't avoid "collection1" convention
[
https://issues.apache.org/jira/browse/SOLR-4317?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tricia Jenkins updated SOLR-4317:
-
Description: There is still an issue after the SOLR-3826 patch was applied
for 4.0 [https://issues.apache.org/jira/browse/SOLR-3826] in September 2012.
When TestHarness is called from SolrTestCase4J the only available constructors
ignore coreName, set coreName = null, and initialize the default 'collection1.'
(was: I think that there is still an issue after the SOLR-3826 patch was
applied for 4.0 [https://issues.apache.org/jira/browse/SOLR-3826] in September
2012. This line is missing:
Index: solr/test-framework/src/java/org/apache/solr/SolrTestCaseJ4.java
===
--- solr/test-framework/src/java/org/apache/solr/SolrTestCaseJ4.java
(revision 1435375)
+++ solr/test-framework/src/java/org/apache/solr/SolrTestCaseJ4.java
(working copy)
@@ -384,9 +384,9 @@
public static void createCore() {
assertNotNull(testSolrHome);
solrConfig = TestHarness.createConfig(testSolrHome, coreName,
getSolrConfigFile());
-h = new TestHarness( dataDir.getAbsolutePath(),
+h = new TestHarness( coreName, new Initializer( coreName,
dataDir.getAbsolutePath(),
solrConfig,
-getSchemaFile());
+getSchemaFile() ) );
lrf = h.getRequestFactory
("standard",0,20,CommonParams.VERSION,"2.2");
}
TestHarness( String dataDirectory,SolrConfig solrConfig, IndexSchema
indexSchema) sets coreName to null and opens the default core: collection1. I
would expect that coreName is carried all the way through the test.)
> SolrTestCaseJ4: Can't avoid "collection1" convention
>
>
> Key: SOLR-4317
> URL: https://issues.apache.org/jira/browse/SOLR-4317
> Project: Solr
> Issue Type: Improvement
> Components: Tests
>Affects Versions: 4.0
>Reporter: Tricia Jenkins
>Priority: Minor
> Fix For: 4.2, 5.0
>
> Attachments: SOLR-4317.patch, SOLR-4317.patch
>
>
> There is still an issue after the SOLR-3826 patch was applied for 4.0
> [https://issues.apache.org/jira/browse/SOLR-3826] in September 2012. When
> TestHarness is called from SolrTestCase4J the only available constructors
> ignore coreName, set coreName = null, and initialize the default
> 'collection1.'
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-4317) SolrTestCaseJ4: Can't avoid "collection1" convention
[
https://issues.apache.org/jira/browse/SOLR-4317?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tricia Jenkins updated SOLR-4317:
-
Attachment: SOLR-4317.patch
Added test which uses multicore example. Also further modified TestHarness and
SolrTestCase4J to use coreName in creating core. Didn't make any changes to
ant scripts so the test isn't called during a normal build.
> SolrTestCaseJ4: Can't avoid "collection1" convention
>
>
> Key: SOLR-4317
> URL: https://issues.apache.org/jira/browse/SOLR-4317
> Project: Solr
> Issue Type: Improvement
> Components: Tests
>Affects Versions: 4.0
>Reporter: Tricia Jenkins
>Priority: Minor
> Fix For: 4.2, 5.0
>
> Attachments: SOLR-4317.patch, SOLR-4317.patch
>
>
> I think that there is still an issue after the SOLR-3826 patch was applied
> for 4.0 [https://issues.apache.org/jira/browse/SOLR-3826] in September 2012.
> This line is missing:
> Index: solr/test-framework/src/java/org/apache/solr/SolrTestCaseJ4.java
> ===
> --- solr/test-framework/src/java/org/apache/solr/SolrTestCaseJ4.java
> (revision 1435375)
> +++ solr/test-framework/src/java/org/apache/solr/SolrTestCaseJ4.java
> (working copy)
> @@ -384,9 +384,9 @@
>public static void createCore() {
> assertNotNull(testSolrHome);
> solrConfig = TestHarness.createConfig(testSolrHome, coreName,
> getSolrConfigFile());
> -h = new TestHarness( dataDir.getAbsolutePath(),
> +h = new TestHarness( coreName, new Initializer( coreName,
> dataDir.getAbsolutePath(),
> solrConfig,
> -getSchemaFile());
> +getSchemaFile() ) );
> lrf = h.getRequestFactory
> ("standard",0,20,CommonParams.VERSION,"2.2");
>}
> TestHarness( String dataDirectory,SolrConfig solrConfig, IndexSchema
> indexSchema) sets coreName to null and opens the default core: collection1.
> I would expect that coreName is carried all the way through the test.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-4317) SolrTestCaseJ4: Can't avoid "collection1" convention
[
https://issues.apache.org/jira/browse/SOLR-4317?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tricia Jenkins updated SOLR-4317:
-
Fix Version/s: 5.0
> SolrTestCaseJ4: Can't avoid "collection1" convention
>
>
> Key: SOLR-4317
> URL: https://issues.apache.org/jira/browse/SOLR-4317
> Project: Solr
> Issue Type: Improvement
> Components: Tests
>Affects Versions: 4.0
>Reporter: Tricia Jenkins
>Priority: Minor
> Fix For: 4.2, 5.0
>
> Attachments: SOLR-4317.patch
>
>
> I think that there is still an issue after the SOLR-3826 patch was applied
> for 4.0 [https://issues.apache.org/jira/browse/SOLR-3826] in September 2012.
> This line is missing:
> Index: solr/test-framework/src/java/org/apache/solr/SolrTestCaseJ4.java
> ===
> --- solr/test-framework/src/java/org/apache/solr/SolrTestCaseJ4.java
> (revision 1435375)
> +++ solr/test-framework/src/java/org/apache/solr/SolrTestCaseJ4.java
> (working copy)
> @@ -384,9 +384,9 @@
>public static void createCore() {
> assertNotNull(testSolrHome);
> solrConfig = TestHarness.createConfig(testSolrHome, coreName,
> getSolrConfigFile());
> -h = new TestHarness( dataDir.getAbsolutePath(),
> +h = new TestHarness( coreName, new Initializer( coreName,
> dataDir.getAbsolutePath(),
> solrConfig,
> -getSchemaFile());
> +getSchemaFile() ) );
> lrf = h.getRequestFactory
> ("standard",0,20,CommonParams.VERSION,"2.2");
>}
> TestHarness( String dataDirectory,SolrConfig solrConfig, IndexSchema
> indexSchema) sets coreName to null and opens the default core: collection1.
> I would expect that coreName is carried all the way through the test.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-4317) SolrTestCaseJ4: Can't avoid "collection1" convention
[
https://issues.apache.org/jira/browse/SOLR-4317?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tricia Jenkins updated SOLR-4317:
-
Fix Version/s: (was: 4.1)
4.2
> SolrTestCaseJ4: Can't avoid "collection1" convention
>
>
> Key: SOLR-4317
> URL: https://issues.apache.org/jira/browse/SOLR-4317
> Project: Solr
> Issue Type: Improvement
> Components: Tests
>Affects Versions: 4.0
>Reporter: Tricia Jenkins
>Priority: Minor
> Fix For: 4.2
>
> Attachments: SOLR-4317.patch
>
>
> I think that there is still an issue after the SOLR-3826 patch was applied
> for 4.0 [https://issues.apache.org/jira/browse/SOLR-3826] in September 2012.
> This line is missing:
> Index: solr/test-framework/src/java/org/apache/solr/SolrTestCaseJ4.java
> ===
> --- solr/test-framework/src/java/org/apache/solr/SolrTestCaseJ4.java
> (revision 1435375)
> +++ solr/test-framework/src/java/org/apache/solr/SolrTestCaseJ4.java
> (working copy)
> @@ -384,9 +384,9 @@
>public static void createCore() {
> assertNotNull(testSolrHome);
> solrConfig = TestHarness.createConfig(testSolrHome, coreName,
> getSolrConfigFile());
> -h = new TestHarness( dataDir.getAbsolutePath(),
> +h = new TestHarness( coreName, new Initializer( coreName,
> dataDir.getAbsolutePath(),
> solrConfig,
> -getSchemaFile());
> +getSchemaFile() ) );
> lrf = h.getRequestFactory
> ("standard",0,20,CommonParams.VERSION,"2.2");
>}
> TestHarness( String dataDirectory,SolrConfig solrConfig, IndexSchema
> indexSchema) sets coreName to null and opens the default core: collection1.
> I would expect that coreName is carried all the way through the test.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-4317) SolrTestCaseJ4: Can't avoid "collection1" convention
[
https://issues.apache.org/jira/browse/SOLR-4317?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tricia Jenkins updated SOLR-4317:
-
Attachment: SOLR-4317.patch
This is the patch from my description.
> SolrTestCaseJ4: Can't avoid "collection1" convention
>
>
> Key: SOLR-4317
> URL: https://issues.apache.org/jira/browse/SOLR-4317
> Project: Solr
> Issue Type: Improvement
> Components: Tests
>Affects Versions: 4.0
>Reporter: Tricia Jenkins
>Priority: Minor
> Fix For: 4.1
>
> Attachments: SOLR-4317.patch
>
>
> I think that there is still an issue after the SOLR-3826 patch was applied
> for 4.0 [https://issues.apache.org/jira/browse/SOLR-3826] in September 2012.
> This line is missing:
> Index: solr/test-framework/src/java/org/apache/solr/SolrTestCaseJ4.java
> ===
> --- solr/test-framework/src/java/org/apache/solr/SolrTestCaseJ4.java
> (revision 1435375)
> +++ solr/test-framework/src/java/org/apache/solr/SolrTestCaseJ4.java
> (working copy)
> @@ -384,9 +384,9 @@
>public static void createCore() {
> assertNotNull(testSolrHome);
> solrConfig = TestHarness.createConfig(testSolrHome, coreName,
> getSolrConfigFile());
> -h = new TestHarness( dataDir.getAbsolutePath(),
> +h = new TestHarness( coreName, new Initializer( coreName,
> dataDir.getAbsolutePath(),
> solrConfig,
> -getSchemaFile());
> +getSchemaFile() ) );
> lrf = h.getRequestFactory
> ("standard",0,20,CommonParams.VERSION,"2.2");
>}
> TestHarness( String dataDirectory,SolrConfig solrConfig, IndexSchema
> indexSchema) sets coreName to null and opens the default core: collection1.
> I would expect that coreName is carried all the way through the test.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
