[jira] [Updated] (SOLR-4842) Field faceting with local params affects successive field faceting parameters
[
https://issues.apache.org/jira/browse/SOLR-4842?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Hoss Man updated SOLR-4842:
---
Attachment: SOLR-4842.patch
Ugh ... i didn't realize how stateful param parsing had gotten i nthe faceting
code.
Erik's last patch had at least one bug remaining that affected range & date
faceting because of the need to reset the "required" params.
attached patch seems to fix that ... i don't see any other obvious bugs.
> Field faceting with local params affects successive field faceting parameters
> -
>
> Key: SOLR-4842
> URL: https://issues.apache.org/jira/browse/SOLR-4842
> Project: Solr
> Issue Type: Bug
> Components: search, SearchComponents - other
>Affects Versions: 4.3
>Reporter: Erik Hatcher
>Assignee: Erik Hatcher
>Priority: Critical
> Fix For: 5.0, 4.3.1
>
> Attachments: SOLR-4842__hoss_tests.patch, SOLR-4842.patch,
> SOLR-4842.patch, SOLR-4842.patch, SOLR-4842.patch
>
>
> SOLR-4717 introduced local param support for per-field faceting, allowing the
> same field to be faceted in various ways. There's a problem such that one
> fields local param setting will override the defaults of the next field. For
> example:
> {code}http://localhost:8983/solr/query?q=*:*&facet=true&rows=0&facet.field={!facet.prefix=a}name&facet.field=features{code}
> where the facet.prefix for name affects the features faceting.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-4842) Field faceting with local params affects successive field faceting parameters
[
https://issues.apache.org/jira/browse/SOLR-4842?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Erik Hatcher updated SOLR-4842:
---
Fix Version/s: 4.3.1
5.0
> Field faceting with local params affects successive field faceting parameters
> -
>
> Key: SOLR-4842
> URL: https://issues.apache.org/jira/browse/SOLR-4842
> Project: Solr
> Issue Type: Bug
> Components: search, SearchComponents - other
>Affects Versions: 4.3
>Reporter: Erik Hatcher
>Assignee: Erik Hatcher
>Priority: Critical
> Fix For: 5.0, 4.3.1
>
> Attachments: SOLR-4842__hoss_tests.patch, SOLR-4842.patch,
> SOLR-4842.patch, SOLR-4842.patch
>
>
> SOLR-4717 introduced local param support for per-field faceting, allowing the
> same field to be faceted in various ways. There's a problem such that one
> fields local param setting will override the defaults of the next field. For
> example:
> {code}http://localhost:8983/solr/query?q=*:*&facet=true&rows=0&facet.field={!facet.prefix=a}name&facet.field=features{code}
> where the facet.prefix for name affects the features faceting.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-4842) Field faceting with local params affects successive field faceting parameters
[
https://issues.apache.org/jira/browse/SOLR-4842?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Erik Hatcher updated SOLR-4842:
---
Description: SOLR-4717 introduced local param support for per-field
faceting, allowing the same field to be faceted in various ways. There's a
problem such that one fields local param setting will override the defaults of
the next field. For example:
{code}http://localhost:8983/solr/query?q=*:*&facet=true&rows=0&facet.field={!facet.prefix=a}name&facet.field=features{code}
where the facet.prefix for name affects the features faceting. (was:
SOLR-4717 introduced local param support for per-field faceting, allowing the
same field to be faceted in various ways. There's a problem such that one
fields local param setting will override the defaults of the next field. For
example: {code}facet.field={!key=foo facet.mincount=1
facet.missing=false}field&facet.field={!key=bar facet.missing=true}field{code}
causes the "bar" faceting to use facet.mincount=1 when it should use the
default of 0.)
adjusted example with Yonik's example since mincount is a red herring here.
> Field faceting with local params affects successive field faceting parameters
> -
>
> Key: SOLR-4842
> URL: https://issues.apache.org/jira/browse/SOLR-4842
> Project: Solr
> Issue Type: Bug
> Components: search, SearchComponents - other
>Affects Versions: 4.3
>Reporter: Erik Hatcher
>Assignee: Erik Hatcher
>Priority: Critical
> Attachments: SOLR-4842__hoss_tests.patch, SOLR-4842.patch,
> SOLR-4842.patch, SOLR-4842.patch
>
>
> SOLR-4717 introduced local param support for per-field faceting, allowing the
> same field to be faceted in various ways. There's a problem such that one
> fields local param setting will override the defaults of the next field. For
> example:
> {code}http://localhost:8983/solr/query?q=*:*&facet=true&rows=0&facet.field={!facet.prefix=a}name&facet.field=features{code}
> where the facet.prefix for name affects the features faceting.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-4842) Field faceting with local params affects successive field faceting parameters
[
https://issues.apache.org/jira/browse/SOLR-4842?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Erik Hatcher updated SOLR-4842:
---
Attachment: SOLR-4842.patch
Here's a patch incorporating Hoss' additional tests as well as my failing test
as well as a fix in SimpleFacets in #parseParams logic when localParams == null
which caused carrying over of previous local params.
I'm running the full test suite now and will await Hoss' review (and maybe
Ryan's eyes too?) before committing.
> Field faceting with local params affects successive field faceting parameters
> -
>
> Key: SOLR-4842
> URL: https://issues.apache.org/jira/browse/SOLR-4842
> Project: Solr
> Issue Type: Bug
> Components: search, SearchComponents - other
>Affects Versions: 4.3
>Reporter: Erik Hatcher
>Assignee: Erik Hatcher
>Priority: Critical
> Attachments: SOLR-4842__hoss_tests.patch, SOLR-4842.patch,
> SOLR-4842.patch, SOLR-4842.patch
>
>
> SOLR-4717 introduced local param support for per-field faceting, allowing the
> same field to be faceted in various ways. There's a problem such that one
> fields local param setting will override the defaults of the next field. For
> example: {code}facet.field={!key=foo facet.mincount=1
> facet.missing=false}field&facet.field={!key=bar
> facet.missing=true}field{code} causes the "bar" faceting to use
> facet.mincount=1 when it should use the default of 0.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-4842) Field faceting with local params affects successive field faceting parameters
[
https://issues.apache.org/jira/browse/SOLR-4842?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Erik Hatcher updated SOLR-4842:
---
Attachment: SOLR-4842.patch
Here's a patch that demonstrates the issue clearly. The actual problem
reported to me (via a customer) was about facet.prefix, but I tried to distill
it to the mincount initially missing the weird mincount/zeros interaction.
I've added two test cases, one that passes as-is, the second fails, and the
only difference is the order of the two facet.field params, one using a
localparam of facet.prefix, the other not.
> Field faceting with local params affects successive field faceting parameters
> -
>
> Key: SOLR-4842
> URL: https://issues.apache.org/jira/browse/SOLR-4842
> Project: Solr
> Issue Type: Bug
> Components: search, SearchComponents - other
>Affects Versions: 4.3
>Reporter: Erik Hatcher
>Assignee: Erik Hatcher
>Priority: Critical
> Attachments: SOLR-4842__hoss_tests.patch, SOLR-4842.patch,
> SOLR-4842.patch
>
>
> SOLR-4717 introduced local param support for per-field faceting, allowing the
> same field to be faceted in various ways. There's a problem such that one
> fields local param setting will override the defaults of the next field. For
> example: {code}facet.field={!key=foo facet.mincount=1
> facet.missing=false}field&facet.field={!key=bar
> facet.missing=true}field{code} causes the "bar" faceting to use
> facet.mincount=1 when it should use the default of 0.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-4842) Field faceting with local params affects successive field faceting parameters
[
https://issues.apache.org/jira/browse/SOLR-4842?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Hoss Man updated SOLR-4842:
---
Attachment: SOLR-4842__hoss_tests.patch
Erik: based on your followup comment, i ignored your patch and attempted to
write a test to reproduce the general problem you described and could not do so
-- see attached SOLR-4842__hoss_tests.patch.
if there is a bug, i suspect it must be something subtle in the way the
defaults of a particular param are defined. if you're having trouble writing a
test aptch to demonstrate the problme you are seeing, can you at least describe
a specific example query where you observe a problem? even if you can't share
the docs needed to seee the problem, knowing exactly what params may help
narrow things down.
> Field faceting with local params affects successive field faceting parameters
> -
>
> Key: SOLR-4842
> URL: https://issues.apache.org/jira/browse/SOLR-4842
> Project: Solr
> Issue Type: Bug
> Components: search, SearchComponents - other
>Affects Versions: 4.3
>Reporter: Erik Hatcher
>Assignee: Erik Hatcher
>Priority: Critical
> Attachments: SOLR-4842__hoss_tests.patch, SOLR-4842.patch
>
>
> SOLR-4717 introduced local param support for per-field faceting, allowing the
> same field to be faceted in various ways. There's a problem such that one
> fields local param setting will override the defaults of the next field. For
> example: {code}facet.field={!key=foo facet.mincount=1
> facet.missing=false}field&facet.field={!key=bar
> facet.missing=true}field{code} causes the "bar" faceting to use
> facet.mincount=1 when it should use the default of 0.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-4842) Field faceting with local params affects successive field faceting parameters
[
https://issues.apache.org/jira/browse/SOLR-4842?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Erik Hatcher updated SOLR-4842:
---
Fix Version/s: (was: 4.3.1)
Description: SOLR-4717 introduced local param support for per-field
faceting, allowing the same field to be faceted in various ways. There's a
problem such that one fields local param setting will override the defaults of
the next field. For example: {code}facet.field={!key=foo facet.mincount=1
facet.missing=false}field&facet.field={!key=bar facet.missing=true}field{code}
causes the "bar" faceting to use facet.mincount=1 when it should use the
default of 0. (was: SOLR-4717 introduced local param support for per-field
faceting, allowing the same field to be faceted in various ways. There's a
problem such that one fields local param setting will override the defaults of
the next field. For example: facet.field={!key=foo facet.mincount=1
facet.missing=false}field&facet.field={!key=bar facet.missing=true}field causes
the "bar" faceting to use facet.mincount=1 when it should use the default of 0.)
> Field faceting with local params affects successive field faceting parameters
> -
>
> Key: SOLR-4842
> URL: https://issues.apache.org/jira/browse/SOLR-4842
> Project: Solr
> Issue Type: Bug
> Components: search, SearchComponents - other
>Affects Versions: 4.3
>Reporter: Erik Hatcher
>Assignee: Erik Hatcher
>Priority: Critical
> Attachments: SOLR-4842.patch
>
>
> SOLR-4717 introduced local param support for per-field faceting, allowing the
> same field to be faceted in various ways. There's a problem such that one
> fields local param setting will override the defaults of the next field. For
> example: {code}facet.field={!key=foo facet.mincount=1
> facet.missing=false}field&facet.field={!key=bar
> facet.missing=true}field{code} causes the "bar" faceting to use
> facet.mincount=1 when it should use the default of 0.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-4842) Field faceting with local params affects successive field faceting parameters
[
https://issues.apache.org/jira/browse/SOLR-4842?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yonik Seeley updated SOLR-4842:
---
Fix Version/s: 4.3.1
> Field faceting with local params affects successive field faceting parameters
> -
>
> Key: SOLR-4842
> URL: https://issues.apache.org/jira/browse/SOLR-4842
> Project: Solr
> Issue Type: Bug
> Components: search, SearchComponents - other
>Affects Versions: 4.3
>Reporter: Erik Hatcher
>Assignee: Erik Hatcher
>Priority: Critical
> Fix For: 4.3.1
>
> Attachments: SOLR-4842.patch
>
>
> SOLR-4717 introduced local param support for per-field faceting, allowing the
> same field to be faceted in various ways. There's a problem such that one
> fields local param setting will override the defaults of the next field. For
> example: facet.field={!key=foo facet.mincount=1
> facet.missing=false}field&facet.field={!key=bar facet.missing=true}field
> causes the "bar" faceting to use facet.mincount=1 when it should use the
> default of 0.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-4842) Field faceting with local params affects successive field faceting parameters
[
https://issues.apache.org/jira/browse/SOLR-4842?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Erik Hatcher updated SOLR-4842:
---
Attachment: SOLR-4842.patch
Here's a patch demonstrating a failing test case that should pass,
demonstrating the corruption of one facet.field's local params into another
facet.field.
> Field faceting with local params affects successive field faceting parameters
> -
>
> Key: SOLR-4842
> URL: https://issues.apache.org/jira/browse/SOLR-4842
> Project: Solr
> Issue Type: Bug
> Components: search, SearchComponents - other
>Affects Versions: 4.3
>Reporter: Erik Hatcher
>Assignee: Erik Hatcher
>Priority: Critical
> Attachments: SOLR-4842.patch
>
>
> SOLR-4717 introduced local param support for per-field faceting, allowing the
> same field to be faceted in various ways. There's a problem such that one
> fields local param setting will override the defaults of the next field. For
> example: facet.field={!key=foo facet.mincount=1
> facet.missing=false}field&facet.field={!key=bar facet.missing=true}field
> causes the "bar" faceting to use facet.mincount=1 when it should use the
> default of 0.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
