[jira] [Updated] (SOLR-5173) Solr-core's Maven configuration includes test-only Hadoop dependencies as indirect compile-time dependencies
[ https://issues.apache.org/jira/browse/SOLR-5173?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Rowe updated SOLR-5173: - Summary: Solr-core's Maven configuration includes test-only Hadoop dependencies as indirect compile-time dependencies (was: Test-only Hadoop dependencies are included in release artifacts) > Solr-core's Maven configuration includes test-only Hadoop dependencies as > indirect compile-time dependencies > > > Key: SOLR-5173 > URL: https://issues.apache.org/jira/browse/SOLR-5173 > Project: Solr > Issue Type: Bug > Components: Build >Affects Versions: 4.4 >Reporter: Steve Rowe >Assignee: Steve Rowe >Priority: Blocker > Fix For: 4.5 > > Attachments: SOLR-5173.patch > > > Chris Collins [reported on > solr-user|http://markmail.org/message/evhpcougs5ppafjk] that solr-core 4.4 > has dependencies on hadoop, and indirectly on jetty 6. > As a workaround for Maven dependencies, the hadoop-hdfs, hadoop-auth, and > hadoop-annotations dependencies can be excluded, which will also exclude the > indirect jetty 6 dependency/ies. hadoop-common is a compile-time dependency, > though, so I'm not sure if it's safe to exclude. > The problems, as far as I can tell, are: > 1) The ivy configuration puts three test-only dependencies (hadoop-hdfs, > hadoo-auth, and hadoop-annotations) in solr/core/lib/, rather than where they > belong, in solr/core/test-lib/. (hadoop-common is required for solr-core > compilation to succeed.) > 2) The Maven configuration makes the equivalent mistake in marking these > test-only hadoop dependencies as compile-scope rather than test-scope > dependencies. > 3) The Solr .war, which packages everything under solr/core/lib/, includes > these three test-only hadoop dependencies (though it does not include any > jetty 6 jars). > 4) The license files for jetty and jetty-util v6.1.26, but not the jar files > corresponding to them, are included in the Solr distribution. > I have working (tests pass) local Ant and Maven configurations that treat the > three hadoop test-only dependencies properly; as result, the .war will no > longer contain them - this will cover problems #1-3 above. > I think we can just remove the jetty and jetty-util 6.1.26 license files from > solr/licenses/, since we don't ship those jars. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-5173) Solr-core's Maven configuration includes test-only Hadoop dependencies as indirect compile-time dependencies
[ https://issues.apache.org/jira/browse/SOLR-5173?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Rowe updated SOLR-5173: - Description: Chris Collins [reported on solr-user|http://markmail.org/message/evhpcougs5ppafjk] that solr-core 4.4 has dependencies on hadoop, and indirectly on jetty 6. As a workaround for Maven dependencies, the indirect jetty 6 dependency/ies can be excluded. The Maven configuration should exclude any compile-time (and also run-time) dependencies that are not Ant/Ivy compile- and run-time dependencies, including jetty 6. was: Chris Collins [reported on solr-user|http://markmail.org/message/evhpcougs5ppafjk] that solr-core 4.4 has dependencies on hadoop, and indirectly on jetty 6. As a workaround for Maven dependencies, the hadoop-hdfs, hadoop-auth, and hadoop-annotations dependencies can be excluded, which will also exclude the indirect jetty 6 dependency/ies. hadoop-common is a compile-time dependency, though, so I'm not sure if it's safe to exclude. The problems, as far as I can tell, are: 1) The ivy configuration puts three test-only dependencies (hadoop-hdfs, hadoo-auth, and hadoop-annotations) in solr/core/lib/, rather than where they belong, in solr/core/test-lib/. (hadoop-common is required for solr-core compilation to succeed.) 2) The Maven configuration makes the equivalent mistake in marking these test-only hadoop dependencies as compile-scope rather than test-scope dependencies. 3) The Solr .war, which packages everything under solr/core/lib/, includes these three test-only hadoop dependencies (though it does not include any jetty 6 jars). 4) The license files for jetty and jetty-util v6.1.26, but not the jar files corresponding to them, are included in the Solr distribution. I have working (tests pass) local Ant and Maven configurations that treat the three hadoop test-only dependencies properly; as result, the .war will no longer contain them - this will cover problems #1-3 above. I think we can just remove the jetty and jetty-util 6.1.26 license files from solr/licenses/, since we don't ship those jars. > Solr-core's Maven configuration includes test-only Hadoop dependencies as > indirect compile-time dependencies > > > Key: SOLR-5173 > URL: https://issues.apache.org/jira/browse/SOLR-5173 > Project: Solr > Issue Type: Bug > Components: Build >Affects Versions: 4.4 >Reporter: Steve Rowe >Assignee: Steve Rowe >Priority: Blocker > Fix For: 4.5 > > Attachments: SOLR-5173.patch > > > Chris Collins [reported on > solr-user|http://markmail.org/message/evhpcougs5ppafjk] that solr-core 4.4 > has dependencies on hadoop, and indirectly on jetty 6. > As a workaround for Maven dependencies, the indirect jetty 6 dependency/ies > can be excluded. > The Maven configuration should exclude any compile-time (and also run-time) > dependencies that are not Ant/Ivy compile- and run-time dependencies, > including jetty 6. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-5173) Solr-core's Maven configuration includes test-only Hadoop dependencies as indirect compile-time dependencies
[ https://issues.apache.org/jira/browse/SOLR-5173?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Rowe updated SOLR-5173: - Attachment: SOLR-5173.patch This patch no longer removes hadoop-auth, hadoop-hdfs, and hdfs-annotations as Ivy and Maven dependencies. Instead, the solr-core Maven dependencies are trimmed down to a minimum, and no longer include indirect jetty 6 dependencies. Committing shortly. > Solr-core's Maven configuration includes test-only Hadoop dependencies as > indirect compile-time dependencies > > > Key: SOLR-5173 > URL: https://issues.apache.org/jira/browse/SOLR-5173 > Project: Solr > Issue Type: Bug > Components: Build >Affects Versions: 4.4 >Reporter: Steve Rowe >Assignee: Steve Rowe >Priority: Blocker > Fix For: 4.5 > > Attachments: SOLR-5173.patch, SOLR-5173.patch > > > Chris Collins [reported on > solr-user|http://markmail.org/message/evhpcougs5ppafjk] that solr-core 4.4 > has dependencies on hadoop, and indirectly on jetty 6. > As a workaround for Maven dependencies, the indirect jetty 6 dependency/ies > can be excluded. > The Maven configuration should exclude any compile-time (and also run-time) > dependencies that are not Ant/Ivy compile- and run-time dependencies, > including jetty 6. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
