[jira] [Updated] (SOLR-5561) DefaultSimilarity 'init' method is not called, if the similarity plugin is not explicitly declared in the schema
[ https://issues.apache.org/jira/browse/SOLR-5561?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hoss Man updated SOLR-5561: --- Attachment: SOLR-5561.patch Ahmet Vitaliy - thanks for your tests improvements! Here's a slightly updated patch... * introduce a String constant for the discountOverlaps param name (since it's now used outside the class in IndexSchema, a constant is appropriate) * consolidated the two tests classes into one to reduce some duplication leverage some existing BaseSimilarityTestCase helper methods * change the tests to leverage the Version enum values instead of just version string constants (this will make it easier to find/remove tests refering to 4.6 and 4.7 once those constants are no longer explicitly supported) * added some javadocs I'll commit soon unless anyone sees any problems? DefaultSimilarity 'init' method is not called, if the similarity plugin is not explicitly declared in the schema Key: SOLR-5561 URL: https://issues.apache.org/jira/browse/SOLR-5561 Project: Solr Issue Type: Bug Components: Schema and Analysis Affects Versions: 4.6 Reporter: Isaac Hebsh Assignee: Hoss Man Labels: similarity Fix For: 5.0, 4.7 Attachments: SOLR-5561.patch, SOLR-5561.patch, SOLR-5561.patch, SOLR-5561.patch As a result, discountOverlap is not initialized to true, and the default behavior is that multiple terms on the same position DO affect the fieldNorm. this is not the intended default. -- This message was sent by Atlassian JIRA (v6.1.5#6160) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-5561) DefaultSimilarity 'init' method is not called, if the similarity plugin is not explicitly declared in the schema
[ https://issues.apache.org/jira/browse/SOLR-5561?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Miller updated SOLR-5561: -- Fix Version/s: 5.0 DefaultSimilarity 'init' method is not called, if the similarity plugin is not explicitly declared in the schema Key: SOLR-5561 URL: https://issues.apache.org/jira/browse/SOLR-5561 Project: Solr Issue Type: Bug Components: Schema and Analysis Affects Versions: 4.6 Reporter: Isaac Hebsh Labels: similarity Fix For: 5.0, 4.7 Attachments: SOLR-5561.patch, SOLR-5561.patch, SOLR-5561.patch As a result, discountOverlap is not initialized to true, and the default behavior is that multiple terms on the same position DO affect the fieldNorm. this is not the intended default. -- This message was sent by Atlassian JIRA (v6.1.5#6160) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-5561) DefaultSimilarity 'init' method is not called, if the similarity plugin is not explicitly declared in the schema
[ https://issues.apache.org/jira/browse/SOLR-5561?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Miller updated SOLR-5561: -- Fix Version/s: (was: 4.6.1) DefaultSimilarity 'init' method is not called, if the similarity plugin is not explicitly declared in the schema Key: SOLR-5561 URL: https://issues.apache.org/jira/browse/SOLR-5561 Project: Solr Issue Type: Bug Components: Schema and Analysis Affects Versions: 4.6 Reporter: Isaac Hebsh Labels: similarity Fix For: 4.7 Attachments: SOLR-5561.patch, SOLR-5561.patch, SOLR-5561.patch As a result, discountOverlap is not initialized to true, and the default behavior is that multiple terms on the same position DO affect the fieldNorm. this is not the intended default. -- This message was sent by Atlassian JIRA (v6.1.5#6160) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-5561) DefaultSimilarity 'init' method is not called, if the similarity plugin is not explicitly declared in the schema
[ https://issues.apache.org/jira/browse/SOLR-5561?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vitaliy Zhovtyuk updated SOLR-5561: --- Attachment: SOLR-5561.patch Added changes to IndexSchema Added IndexSchema tests checking discountOverlaps depending on luceneMatchVersion DefaultSimilarity 'init' method is not called, if the similarity plugin is not explicitly declared in the schema Key: SOLR-5561 URL: https://issues.apache.org/jira/browse/SOLR-5561 Project: Solr Issue Type: Bug Components: Schema and Analysis Affects Versions: 4.6 Reporter: Isaac Hebsh Labels: similarity Fix For: 4.7, 4.6.1 Attachments: SOLR-5561.patch, SOLR-5561.patch, SOLR-5561.patch As a result, discountOverlap is not initialized to true, and the default behavior is that multiple terms on the same position DO affect the fieldNorm. this is not the intended default. -- This message was sent by Atlassian JIRA (v6.1.5#6160) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-5561) DefaultSimilarity 'init' method is not called, if the similarity plugin is not explicitly declared in the schema
[ https://issues.apache.org/jira/browse/SOLR-5561?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ahmet Arslan updated SOLR-5561: --- Attachment: SOLR-5561.patch I had this test case handy. DefaultSimilarity 'init' method is not called, if the similarity plugin is not explicitly declared in the schema Key: SOLR-5561 URL: https://issues.apache.org/jira/browse/SOLR-5561 Project: Solr Issue Type: Bug Components: Schema and Analysis Affects Versions: 4.6 Reporter: Isaac Hebsh Labels: similarity Fix For: 4.7, 4.6.1 Attachments: SOLR-5561.patch, SOLR-5561.patch As a result, discountOverlap is not initialized to true, and the default behavior is that multiple terms on the same position DO affect the fieldNorm. this is not the intended default. -- This message was sent by Atlassian JIRA (v6.1.5#6160) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-5561) DefaultSimilarity 'init' method is not called, if the similarity plugin is not explicitly declared in the schema
[ https://issues.apache.org/jira/browse/SOLR-5561?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Isaac Hebsh updated SOLR-5561: -- Fix Version/s: 4.6.1 DefaultSimilarity 'init' method is not called, if the similarity plugin is not explicitly declared in the schema Key: SOLR-5561 URL: https://issues.apache.org/jira/browse/SOLR-5561 Project: Solr Issue Type: Bug Components: Schema and Analysis Affects Versions: 4.6 Reporter: Isaac Hebsh Labels: similarity Fix For: 4.6.1 As a result, discountOverlap is not initialized to true, and the default behavior is that multiple terms on the same position DO affect the fieldNorm. this is not the intended default. -- This message was sent by Atlassian JIRA (v6.1.5#6160) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-5561) DefaultSimilarity 'init' method is not called, if the similarity plugin is not explicitly declared in the schema
[ https://issues.apache.org/jira/browse/SOLR-5561?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Isaac Hebsh updated SOLR-5561: -- Fix Version/s: 4.7 DefaultSimilarity 'init' method is not called, if the similarity plugin is not explicitly declared in the schema Key: SOLR-5561 URL: https://issues.apache.org/jira/browse/SOLR-5561 Project: Solr Issue Type: Bug Components: Schema and Analysis Affects Versions: 4.6 Reporter: Isaac Hebsh Labels: similarity Fix For: 4.7, 4.6.1 As a result, discountOverlap is not initialized to true, and the default behavior is that multiple terms on the same position DO affect the fieldNorm. this is not the intended default. -- This message was sent by Atlassian JIRA (v6.1.5#6160) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-5561) DefaultSimilarity 'init' method is not called, if the similarity plugin is not explicitly declared in the schema
[ https://issues.apache.org/jira/browse/SOLR-5561?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Isaac Hebsh updated SOLR-5561: -- Attachment: SOLR-5561.patch Patch attached. DefaultSimilarity 'init' method is not called, if the similarity plugin is not explicitly declared in the schema Key: SOLR-5561 URL: https://issues.apache.org/jira/browse/SOLR-5561 Project: Solr Issue Type: Bug Components: Schema and Analysis Affects Versions: 4.6 Reporter: Isaac Hebsh Labels: similarity Fix For: 4.7, 4.6.1 Attachments: SOLR-5561.patch As a result, discountOverlap is not initialized to true, and the default behavior is that multiple terms on the same position DO affect the fieldNorm. this is not the intended default. -- This message was sent by Atlassian JIRA (v6.1.5#6160) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
