[jira] [Updated] (SOLR-5685) Some tests are not really committing when they intend to

2014-01-31 Thread JIRA

 [ 
https://issues.apache.org/jira/browse/SOLR-5685?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tomás Fernández Löbbe updated SOLR-5685:


Attachment: FieldFacetAccumulator.patch

The test passes with this change

 Some tests are not really committing when they intend to
 

 Key: SOLR-5685
 URL: https://issues.apache.org/jira/browse/SOLR-5685
 Project: Solr
  Issue Type: Bug
Affects Versions: 5.0
Reporter: Tomás Fernández Löbbe
Assignee: Yonik Seeley
 Fix For: 5.0, 4.7

 Attachments: FieldFacetAccumulator.patch, SOLR-5685.patch


 There are some tests that call SolrTestCaseJ4.commit() but don't really 
 submit the commit command (using assertU() ). This causes the commit to not 
 really run. 



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org



[jira] [Updated] (SOLR-5685) Some tests are not really committing when they intend to

2014-01-30 Thread JIRA

 [ 
https://issues.apache.org/jira/browse/SOLR-5685?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tomás Fernández Löbbe updated SOLR-5685:


Attachment: SOLR-5685.patch

Adding assertU in the cases that I found. This is causing the test 
org.apache.solr.analytics.facet.FieldFacetTest to fail

 Some tests are not really committing when they intend to
 

 Key: SOLR-5685
 URL: https://issues.apache.org/jira/browse/SOLR-5685
 Project: Solr
  Issue Type: Bug
Affects Versions: 5.0
Reporter: Tomás Fernández Löbbe
 Fix For: 5.0

 Attachments: SOLR-5685.patch


 There are some tests that call SolrTestCaseJ4.commit() but don't really 
 submit the commit command (using assertU() ). This causes the commit to not 
 really run. 



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org