[jira] [Updated] (SOLR-5922) Add Properties and other parameters to SolrJ Collection Admin Request calls
[ https://issues.apache.org/jira/browse/SOLR-5922?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Varun Thacker updated SOLR-5922: Attachment: SOLR-5922.patch Thanks [~anshumg] for the review! Updated patch. - Old patch had getProps and setProps in SplitShard. Renamed it to getProperties and setProperties to make it uniform - We don't have a specific call for MIGRATE and ADDREPLICAPROP in SolrJ so I have skipped those. - Added Properties param to CREATESHARD, ADDREPLICA, > Add Properties and other parameters to SolrJ Collection Admin Request calls > --- > > Key: SOLR-5922 > URL: https://issues.apache.org/jira/browse/SOLR-5922 > Project: Solr > Issue Type: Improvement > Components: SolrJ >Reporter: Varun Thacker >Assignee: Anshum Gupta > Fix For: 5.0, Trunk > > Attachments: SOLR-5922.patch, SOLR-5922.patch, SOLR-5922.patch, > SOLR-5922.patch, SOLR-5922.patch, SOLR-5922.patch, SOLR-5922.patch > > > SOLR-5208 added functionality for the setting of core.properties key/values > at create-time on Collections API. > We should allow the same behaviour for SolrJ API calls as well. > Also I want to add get and set methods to be able to add 'instanceDir', > 'dataDir', 'ulogDir' for a create colleciton call. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-5922) Add Properties and other parameters to SolrJ Collection Admin Request calls
[ https://issues.apache.org/jira/browse/SOLR-5922?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anshum Gupta updated SOLR-5922: --- Fix Version/s: 5.0 > Add Properties and other parameters to SolrJ Collection Admin Request calls > --- > > Key: SOLR-5922 > URL: https://issues.apache.org/jira/browse/SOLR-5922 > Project: Solr > Issue Type: Improvement > Components: SolrJ >Reporter: Varun Thacker >Assignee: Anshum Gupta > Fix For: 5.0, Trunk > > Attachments: SOLR-5922.patch, SOLR-5922.patch, SOLR-5922.patch, > SOLR-5922.patch, SOLR-5922.patch, SOLR-5922.patch > > > SOLR-5208 added functionality for the setting of core.properties key/values > at create-time on Collections API. > We should allow the same behaviour for SolrJ API calls as well. > Also I want to add get and set methods to be able to add 'instanceDir', > 'dataDir', 'ulogDir' for a create colleciton call. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-5922) Add Properties and other parameters to SolrJ Collection Admin Request calls
[ https://issues.apache.org/jira/browse/SOLR-5922?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anshum Gupta updated SOLR-5922: --- Component/s: SolrJ > Add Properties and other parameters to SolrJ Collection Admin Request calls > --- > > Key: SOLR-5922 > URL: https://issues.apache.org/jira/browse/SOLR-5922 > Project: Solr > Issue Type: Improvement > Components: SolrJ >Reporter: Varun Thacker >Assignee: Anshum Gupta > Fix For: 5.0, Trunk > > Attachments: SOLR-5922.patch, SOLR-5922.patch, SOLR-5922.patch, > SOLR-5922.patch, SOLR-5922.patch, SOLR-5922.patch > > > SOLR-5208 added functionality for the setting of core.properties key/values > at create-time on Collections API. > We should allow the same behaviour for SolrJ API calls as well. > Also I want to add get and set methods to be able to add 'instanceDir', > 'dataDir', 'ulogDir' for a create colleciton call. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-5922) Add Properties and other parameters to SolrJ Collection Admin Request calls
[ https://issues.apache.org/jira/browse/SOLR-5922?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Varun Thacker updated SOLR-5922: Attachment: SOLR-5922.patch Patch which improves how the test. > Add Properties and other parameters to SolrJ Collection Admin Request calls > --- > > Key: SOLR-5922 > URL: https://issues.apache.org/jira/browse/SOLR-5922 > Project: Solr > Issue Type: Improvement >Reporter: Varun Thacker >Assignee: Anshum Gupta > Fix For: Trunk > > Attachments: SOLR-5922.patch, SOLR-5922.patch, SOLR-5922.patch, > SOLR-5922.patch, SOLR-5922.patch, SOLR-5922.patch > > > SOLR-5208 added functionality for the setting of core.properties key/values > at create-time on Collections API. > We should allow the same behaviour for SolrJ API calls as well. > Also I want to add get and set methods to be able to add 'instanceDir', > 'dataDir', 'ulogDir' for a create colleciton call. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-5922) Add Properties and other parameters to SolrJ Collection Admin Request calls
[ https://issues.apache.org/jira/browse/SOLR-5922?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Varun Thacker updated SOLR-5922: Attachment: SOLR-5922.patch New patch. Since our motivation here is to make sure that whatever is supported in the Collection API calls should be mirrored for SolrJ I just added the setProperties() option for Create and SplitShard calls. Patch removes the additional convenience methods in previous patches around uLogDir, dataDir and instanceDir as those are not directly exposed through the collections api call but only through property.key=value format. > Add Properties and other parameters to SolrJ Collection Admin Request calls > --- > > Key: SOLR-5922 > URL: https://issues.apache.org/jira/browse/SOLR-5922 > Project: Solr > Issue Type: Improvement >Reporter: Varun Thacker >Assignee: Anshum Gupta > Fix For: 5.0 > > Attachments: SOLR-5922.patch, SOLR-5922.patch, SOLR-5922.patch, > SOLR-5922.patch, SOLR-5922.patch > > > SOLR-5208 added functionality for the setting of core.properties key/values > at create-time on Collections API. > We should allow the same behaviour for SolrJ API calls as well. > Also I want to add get and set methods to be able to add 'instanceDir', > 'dataDir', 'ulogDir' for a create colleciton call. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-5922) Add Properties and other parameters to SolrJ Collection Admin Request calls
[ https://issues.apache.org/jira/browse/SOLR-5922?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Varun Thacker updated SOLR-5922: Attachment: SOLR-5922.patch New patch. The test case gets the base_url and uses that to create a server to call the CoreAdmin STATUS API call. I still don't see the data_dir being created in the filesystem. The STATUS call returns the correct location to the data_dir thought. instance_dir, uLog and core.properties gets created correctly. > Add Properties and other parameters to SolrJ Collection Admin Request calls > --- > > Key: SOLR-5922 > URL: https://issues.apache.org/jira/browse/SOLR-5922 > Project: Solr > Issue Type: Improvement >Reporter: Varun Thacker >Assignee: Shalin Shekhar Mangar > Fix For: 5.0 > > Attachments: SOLR-5922.patch, SOLR-5922.patch, SOLR-5922.patch, > SOLR-5922.patch > > > SOLR-5208 added functionality for the setting of core.properties key/values > at create-time on Collections API. > We should allow the same behaviour for SolrJ API calls as well. > Also I want to add get and set methods to be able to add 'instanceDir', > 'dataDir', 'ulogDir' for a create colleciton call. -- This message was sent by Atlassian JIRA (v6.2#6252) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-5922) Add Properties and other parameters to SolrJ Collection Admin Request calls
[ https://issues.apache.org/jira/browse/SOLR-5922?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Varun Thacker updated SOLR-5922: Attachment: SOLR-5922.patch New patch with 2 test cases. - I only see these 2 directories getting created 1. testInstanceDirAsPropertyParam-XYZ/ 2. testInstanceDirAsPropertyParam-XYZ/testuLogDirAsPropertyParam-XYZ/ Don't see the dataDir getting created > Add Properties and other parameters to SolrJ Collection Admin Request calls > --- > > Key: SOLR-5922 > URL: https://issues.apache.org/jira/browse/SOLR-5922 > Project: Solr > Issue Type: Improvement >Reporter: Varun Thacker >Assignee: Shalin Shekhar Mangar > Fix For: 5.0 > > Attachments: SOLR-5922.patch, SOLR-5922.patch, SOLR-5922.patch > > > SOLR-5208 added functionality for the setting of core.properties key/values > at create-time on Collections API. > We should allow the same behaviour for SolrJ API calls as well. > Also I want to add get and set methods to be able to add 'instanceDir', > 'dataDir', 'ulogDir' for a create colleciton call. -- This message was sent by Atlassian JIRA (v6.2#6252) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-5922) Add Properties and other parameters to SolrJ Collection Admin Request calls
[ https://issues.apache.org/jira/browse/SOLR-5922?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Varun Thacker updated SOLR-5922: Attachment: SOLR-5922.patch - New patch with a test case. Test is broken when it tries to verify if the properties is getting used correctly. Any ideas on what I am doing incorrectly? - Fixed typo in CoreAdminCreateDiscoveryTest > Add Properties and other parameters to SolrJ Collection Admin Request calls > --- > > Key: SOLR-5922 > URL: https://issues.apache.org/jira/browse/SOLR-5922 > Project: Solr > Issue Type: Improvement >Reporter: Varun Thacker >Assignee: Shalin Shekhar Mangar > Fix For: 5.0 > > Attachments: SOLR-5922.patch, SOLR-5922.patch > > > SOLR-5208 added functionality for the setting of core.properties key/values > at create-time on Collections API. > We should allow the same behaviour for SolrJ API calls as well. > Also I want to add get and set methods to be able to add 'instanceDir', > 'dataDir', 'ulogDir' for a create colleciton call. -- This message was sent by Atlassian JIRA (v6.2#6252) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-5922) Add Properties and other parameters to SolrJ Collection Admin Request calls
[ https://issues.apache.org/jira/browse/SOLR-5922?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Varun Thacker updated SOLR-5922: Attachment: SOLR-5922.patch - For createCollection it adds 3 params - ulogDir, instanceDir and dataDir - Adds options to add Properties to both createCollection and splitShard methods - User does not have to prefix "property." when defining properties. It is done internally. > Add Properties and other parameters to SolrJ Collection Admin Request calls > --- > > Key: SOLR-5922 > URL: https://issues.apache.org/jira/browse/SOLR-5922 > Project: Solr > Issue Type: Improvement >Reporter: Varun Thacker > Fix For: 5.0 > > Attachments: SOLR-5922.patch > > > SOLR-5208 added functionality for the setting of core.properties key/values > at create-time on Collections API. > We should allow the same behaviour for SolrJ API calls as well. > Also I want to add get and set methods to be able to add 'instanceDir', > 'dataDir', 'ulogDir' for a create colleciton call. -- This message was sent by Atlassian JIRA (v6.2#6252) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
