[jira] [Updated] (SOLR-8423) DELETESHARD should cleanup the instance and data directory, like DELETEREPLICA
[ https://issues.apache.org/jira/browse/SOLR-8423?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hoss Man updated SOLR-8423: --- Fix Version/s: master (7.0) 6.1 Manually correcting fixVersion per Step #S6 of LUCENE-7271 > DELETESHARD should cleanup the instance and data directory, like DELETEREPLICA > -- > > Key: SOLR-8423 > URL: https://issues.apache.org/jira/browse/SOLR-8423 > Project: Solr > Issue Type: Bug >Reporter: Anshum Gupta >Assignee: Anshum Gupta > Fix For: 6.0, 6.1, master (7.0) > > Attachments: SOLR-8423.patch, SOLR-8423.patch, SOLR-8423.patch > > > DELETESHARD only cleans up the index directory and not the instance/data > directory. DELETEREPLICA on the other hand cleans up the data and instance > directory. > DELETESHARD should clean up the instance and data directory, so that we don't > leak disk space on executing the command. > If we think this would break back-compat, though I don't see why this should > not clean up the instance dir, we should at least provide an option to clean > up everything and make it default in 6.0. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-8423) DELETESHARD should cleanup the instance and data directory, like DELETEREPLICA
[ https://issues.apache.org/jira/browse/SOLR-8423?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anshum Gupta updated SOLR-8423: --- Fix Version/s: 6.0 master > DELETESHARD should cleanup the instance and data directory, like DELETEREPLICA > -- > > Key: SOLR-8423 > URL: https://issues.apache.org/jira/browse/SOLR-8423 > Project: Solr > Issue Type: Bug >Reporter: Anshum Gupta >Assignee: Anshum Gupta > Fix For: master, 6.0 > > Attachments: SOLR-8423.patch, SOLR-8423.patch, SOLR-8423.patch > > > DELETESHARD only cleans up the index directory and not the instance/data > directory. DELETEREPLICA on the other hand cleans up the data and instance > directory. > DELETESHARD should clean up the instance and data directory, so that we don't > leak disk space on executing the command. > If we think this would break back-compat, though I don't see why this should > not clean up the instance dir, we should at least provide an option to clean > up everything and make it default in 6.0. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-8423) DELETESHARD should cleanup the instance and data directory, like DELETEREPLICA
[ https://issues.apache.org/jira/browse/SOLR-8423?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anshum Gupta updated SOLR-8423: --- Attachment: SOLR-8423.patch Patch with tests. I'll commit this once the 6.0 work is in place. > DELETESHARD should cleanup the instance and data directory, like DELETEREPLICA > -- > > Key: SOLR-8423 > URL: https://issues.apache.org/jira/browse/SOLR-8423 > Project: Solr > Issue Type: Bug >Reporter: Anshum Gupta > Attachments: SOLR-8423.patch, SOLR-8423.patch, SOLR-8423.patch > > > DELETESHARD only cleans up the index directory and not the instance/data > directory. DELETEREPLICA on the other hand cleans up the data and instance > directory. > DELETESHARD should clean up the instance and data directory, so that we don't > leak disk space on executing the command. > If we think this would break back-compat, though I don't see why this should > not clean up the instance dir, we should at least provide an option to clean > up everything and make it default in 6.0. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-8423) DELETESHARD should cleanup the instance and data directory, like DELETEREPLICA
[ https://issues.apache.org/jira/browse/SOLR-8423?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anshum Gupta updated SOLR-8423: --- Attachment: SOLR-8423.patch Patch that uses deleteDataDir, deleteInstanceDir and defaults them to true. It now also supports setting those to false for DELETESHARD and DELETEREPLICA. > DELETESHARD should cleanup the instance and data directory, like DELETEREPLICA > -- > > Key: SOLR-8423 > URL: https://issues.apache.org/jira/browse/SOLR-8423 > Project: Solr > Issue Type: Bug >Reporter: Anshum Gupta > Attachments: SOLR-8423.patch, SOLR-8423.patch > > > DELETESHARD only cleans up the index directory and not the instance/data > directory. DELETEREPLICA on the other hand cleans up the data and instance > directory. > DELETESHARD should clean up the instance and data directory, so that we don't > leak disk space on executing the command. > If we think this would break back-compat, though I don't see why this should > not clean up the instance dir, we should at least provide an option to clean > up everything and make it default in 6.0. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-8423) DELETESHARD should cleanup the instance and data directory, like DELETEREPLICA
[ https://issues.apache.org/jira/browse/SOLR-8423?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anshum Gupta updated SOLR-8423: --- Attachment: SOLR-8423.patch Patch without a test. I'll add a test for this and also need to find a better param for supporting deletion without cleaning up of the instance directory (like right now). In this patch, it's called _safedelete_. > DELETESHARD should cleanup the instance and data directory, like DELETEREPLICA > -- > > Key: SOLR-8423 > URL: https://issues.apache.org/jira/browse/SOLR-8423 > Project: Solr > Issue Type: Bug >Reporter: Anshum Gupta > Attachments: SOLR-8423.patch > > > DELETESHARD only cleans up the index directory and not the instance/data > directory. DELETEREPLICA on the other hand cleans up the data and instance > directory. > DELETESHARD should clean up the instance and data directory, so that we don't > leak disk space on executing the command. > If we think this would break back-compat, though I don't see why this should > not clean up the instance dir, we should at least provide an option to clean > up everything and make it default in 6.0. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
