[jira] [Updated] (SOLR-8689) bin/solr.cmd does not start with recent Verona builds of Java 9 because of version parsing issue
[
https://issues.apache.org/jira/browse/SOLR-8689?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Uwe Schindler updated SOLR-8689:
Attachment: SOLR-8689.patch
Patch with [~hossman]'s suggestions. If somebody sets GC_LOG_OPTS on Java 9 it
bails out. I also updated documentation in the solr.in.cmd file.
I tested with:
- Java 8u144: Works as usual, GC_LOG_OPT is respected if explicitely set
- Java 9b182: Works now by default; if you comment out the GC_LOG_OPTS it fails
early. BTW, in the UNIX scripts it would also fail if somebody updates Java 8
to Java 9, becaus ethe logging options are incompatible So we are consistent
for users that have GC_LOG_OPTS configured.
- IBM J9 (Java 8): Works as before
- Java 7u90: Fails early
- Java 6: Fails early
I think we should really commit this and maybe later improve this. It looks
like I am the only person lkeft that knows windows shell scripts a bit. IMHO,
maybe we should switch to PowerShell, really! PowerShell is now installed on
all supported Windows VMs, Windows 7 is out of service.
[~hossman]: Any complaints or do you trust me? The current state is much better
than before and the added code is trivial. IMHO, we should really not release
that without basic Java 9 support and some migration path. Java comes out on
Sept 21 (for sure, I already booked my tickets to the party in Munich).
> bin/solr.cmd does not start with recent Verona builds of Java 9 because of
> version parsing issue
>
>
> Key: SOLR-8689
> URL: https://issues.apache.org/jira/browse/SOLR-8689
> Project: Solr
> Issue Type: Bug
> Components: scripts and tools
>Affects Versions: 5.5, 6.0
> Environment: Windows 7
>Reporter: Uwe Schindler
>Assignee: Uwe Schindler
>Priority: Blocker
> Labels: Java9
> Fix For: 7.0, master (8.0), 7.1
>
> Attachments: SOLR-8689.patch, SOLR-8689.patch, SOLR-8689.patch,
> SOLR-8689.patch, SOLR-8689.patch
>
>
> At least on Windows, Solr 5.5 does not start with the shell script using a
> Verona-Java-9 JDK:
> {noformat}
> *
> JAVA_HOME = C:\Program Files\Java\jdk-9
> java version "9-ea"
> Java(TM) SE Runtime Environment (build
> 9-ea+105-2016-02-11-003336.javare.4433.nc)
> Java HotSpot(TM) 64-Bit Server VM (build
> 9-ea+105-2016-02-11-003336.javare.4433.nc, mixed mode)
> *
> C:\Users\Uwe Schindler\Desktop\solr-5.5.0\bin>solr start
> ERROR: Java 1.7 or later is required to run Solr. Current Java version is:
> 9-ea
> {noformat}
> I don't know if this is better with Linux, but I assume the version parsing
> is broken (e.g., String#startsWith, interpret as floating point number,...)
> We should fix this before Java 9 gets released! The version numbering scheme
> changed completely: http://openjdk.java.net/jeps/223
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-8689) bin/solr.cmd does not start with recent Verona builds of Java 9 because of version parsing issue
[
https://issues.apache.org/jira/browse/SOLR-8689?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Uwe Schindler updated SOLR-8689:
Attachment: SOLR-8689.patch
I reordered the checks. Java 9 is detected before IBM J9. Because IBM J9 for
Java 9 will handle the command line options like Oracle. This goes in-line with
[~hossman]'s UNIX shell script.
I just noticed: JAVA_BUILD is not used anywhere, may I remove it. Because this
wouldn't ever work with Java 9. The UNIX shell script does not have any build
version parsing.
> bin/solr.cmd does not start with recent Verona builds of Java 9 because of
> version parsing issue
>
>
> Key: SOLR-8689
> URL: https://issues.apache.org/jira/browse/SOLR-8689
> Project: Solr
> Issue Type: Bug
> Components: scripts and tools
>Affects Versions: 5.5, 6.0
> Environment: Windows 7
>Reporter: Uwe Schindler
>Assignee: Uwe Schindler
>Priority: Blocker
> Labels: Java9
> Fix For: 7.0, master (8.0), 7.1
>
> Attachments: SOLR-8689.patch, SOLR-8689.patch, SOLR-8689.patch,
> SOLR-8689.patch
>
>
> At least on Windows, Solr 5.5 does not start with the shell script using a
> Verona-Java-9 JDK:
> {noformat}
> *
> JAVA_HOME = C:\Program Files\Java\jdk-9
> java version "9-ea"
> Java(TM) SE Runtime Environment (build
> 9-ea+105-2016-02-11-003336.javare.4433.nc)
> Java HotSpot(TM) 64-Bit Server VM (build
> 9-ea+105-2016-02-11-003336.javare.4433.nc, mixed mode)
> *
> C:\Users\Uwe Schindler\Desktop\solr-5.5.0\bin>solr start
> ERROR: Java 1.7 or later is required to run Solr. Current Java version is:
> 9-ea
> {noformat}
> I don't know if this is better with Linux, but I assume the version parsing
> is broken (e.g., String#startsWith, interpret as floating point number,...)
> We should fix this before Java 9 gets released! The version numbering scheme
> changed completely: http://openjdk.java.net/jeps/223
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-8689) bin/solr.cmd does not start with recent Verona builds of Java 9 because of version parsing issue
[
https://issues.apache.org/jira/browse/SOLR-8689?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Uwe Schindler updated SOLR-8689:
Attachment: SOLR-8689.patch
Hi,
this variant works, although it looks crazy: The {{\"}} escaping is ignored by
the shell of windows, so it is passed as-is to Java (because "\" is not a good
escape char on windows, so this approach won't work on Linux, but there are not
colons in filenames!)
This patch does not do the same stuff like Linux, because we do not have easy
regular expressions available in Windows. The GC_LOG_OPTS used as it was before
the change on Java <= 8, but for Java 9 it is ignored. I have no better idea
how to do this. IMHO, this is better than not working at all! I added
documentation for this.
Does anybody have a better idea or knows how to do the same magic regex
replcaments like in the linux shell script? Is the current approach acceptable,
[~hossman]?
> bin/solr.cmd does not start with recent Verona builds of Java 9 because of
> version parsing issue
>
>
> Key: SOLR-8689
> URL: https://issues.apache.org/jira/browse/SOLR-8689
> Project: Solr
> Issue Type: Bug
> Components: scripts and tools
>Affects Versions: 5.5, 6.0
> Environment: Windows 7
>Reporter: Uwe Schindler
>Priority: Blocker
> Labels: Java9
> Fix For: 7.0, master (8.0), 7.1
>
> Attachments: SOLR-8689.patch, SOLR-8689.patch, SOLR-8689.patch
>
>
> At least on Windows, Solr 5.5 does not start with the shell script using a
> Verona-Java-9 JDK:
> {noformat}
> *
> JAVA_HOME = C:\Program Files\Java\jdk-9
> java version "9-ea"
> Java(TM) SE Runtime Environment (build
> 9-ea+105-2016-02-11-003336.javare.4433.nc)
> Java HotSpot(TM) 64-Bit Server VM (build
> 9-ea+105-2016-02-11-003336.javare.4433.nc, mixed mode)
> *
> C:\Users\Uwe Schindler\Desktop\solr-5.5.0\bin>solr start
> ERROR: Java 1.7 or later is required to run Solr. Current Java version is:
> 9-ea
> {noformat}
> I don't know if this is better with Linux, but I assume the version parsing
> is broken (e.g., String#startsWith, interpret as floating point number,...)
> We should fix this before Java 9 gets released! The version numbering scheme
> changed completely: http://openjdk.java.net/jeps/223
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-8689) bin/solr.cmd does not start with recent Verona builds of Java 9 because of version parsing issue
[
https://issues.apache.org/jira/browse/SOLR-8689?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Uwe Schindler updated SOLR-8689:
Attachment: SOLR-8689.patch
> bin/solr.cmd does not start with recent Verona builds of Java 9 because of
> version parsing issue
>
>
> Key: SOLR-8689
> URL: https://issues.apache.org/jira/browse/SOLR-8689
> Project: Solr
> Issue Type: Bug
> Components: scripts and tools
>Affects Versions: 5.5, 6.0
> Environment: Windows 7
>Reporter: Uwe Schindler
>Priority: Blocker
> Labels: Java9
> Fix For: 7.0, master (8.0), 7.1
>
> Attachments: SOLR-8689.patch, SOLR-8689.patch
>
>
> At least on Windows, Solr 5.5 does not start with the shell script using a
> Verona-Java-9 JDK:
> {noformat}
> *
> JAVA_HOME = C:\Program Files\Java\jdk-9
> java version "9-ea"
> Java(TM) SE Runtime Environment (build
> 9-ea+105-2016-02-11-003336.javare.4433.nc)
> Java HotSpot(TM) 64-Bit Server VM (build
> 9-ea+105-2016-02-11-003336.javare.4433.nc, mixed mode)
> *
> C:\Users\Uwe Schindler\Desktop\solr-5.5.0\bin>solr start
> ERROR: Java 1.7 or later is required to run Solr. Current Java version is:
> 9-ea
> {noformat}
> I don't know if this is better with Linux, but I assume the version parsing
> is broken (e.g., String#startsWith, interpret as floating point number,...)
> We should fix this before Java 9 gets released! The version numbering scheme
> changed completely: http://openjdk.java.net/jeps/223
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-8689) bin/solr.cmd does not start with recent Verona builds of Java 9 because of version parsing issue
[
https://issues.apache.org/jira/browse/SOLR-8689?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Uwe Schindler updated SOLR-8689:
Attachment: SOLR-8689.patch
Here my current patch, which breaks, because of the absolute path issue.
> bin/solr.cmd does not start with recent Verona builds of Java 9 because of
> version parsing issue
>
>
> Key: SOLR-8689
> URL: https://issues.apache.org/jira/browse/SOLR-8689
> Project: Solr
> Issue Type: Bug
> Components: scripts and tools
>Affects Versions: 5.5, 6.0
> Environment: Windows 7
>Reporter: Uwe Schindler
>Priority: Blocker
> Labels: Java9
> Fix For: 7.0, master (8.0), 7.1
>
> Attachments: SOLR-8689.patch
>
>
> At least on Windows, Solr 5.5 does not start with the shell script using a
> Verona-Java-9 JDK:
> {noformat}
> *
> JAVA_HOME = C:\Program Files\Java\jdk-9
> java version "9-ea"
> Java(TM) SE Runtime Environment (build
> 9-ea+105-2016-02-11-003336.javare.4433.nc)
> Java HotSpot(TM) 64-Bit Server VM (build
> 9-ea+105-2016-02-11-003336.javare.4433.nc, mixed mode)
> *
> C:\Users\Uwe Schindler\Desktop\solr-5.5.0\bin>solr start
> ERROR: Java 1.7 or later is required to run Solr. Current Java version is:
> 9-ea
> {noformat}
> I don't know if this is better with Linux, but I assume the version parsing
> is broken (e.g., String#startsWith, interpret as floating point number,...)
> We should fix this before Java 9 gets released! The version numbering scheme
> changed completely: http://openjdk.java.net/jeps/223
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-8689) bin/solr.cmd does not start with recent Verona builds of Java 9 because of version parsing issue
[
https://issues.apache.org/jira/browse/SOLR-8689?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Uwe Schindler updated SOLR-8689:
Priority: Blocker (was: Major)
> bin/solr.cmd does not start with recent Verona builds of Java 9 because of
> version parsing issue
>
>
> Key: SOLR-8689
> URL: https://issues.apache.org/jira/browse/SOLR-8689
> Project: Solr
> Issue Type: Bug
> Components: scripts and tools
>Affects Versions: 5.5, 6.0
> Environment: Windows 7
>Reporter: Uwe Schindler
>Priority: Blocker
> Labels: Java9
> Fix For: 7.0, master (8.0), 7.1
>
>
> At least on Windows, Solr 5.5 does not start with the shell script using a
> Verona-Java-9 JDK:
> {noformat}
> *
> JAVA_HOME = C:\Program Files\Java\jdk-9
> java version "9-ea"
> Java(TM) SE Runtime Environment (build
> 9-ea+105-2016-02-11-003336.javare.4433.nc)
> Java HotSpot(TM) 64-Bit Server VM (build
> 9-ea+105-2016-02-11-003336.javare.4433.nc, mixed mode)
> *
> C:\Users\Uwe Schindler\Desktop\solr-5.5.0\bin>solr start
> ERROR: Java 1.7 or later is required to run Solr. Current Java version is:
> 9-ea
> {noformat}
> I don't know if this is better with Linux, but I assume the version parsing
> is broken (e.g., String#startsWith, interpret as floating point number,...)
> We should fix this before Java 9 gets released! The version numbering scheme
> changed completely: http://openjdk.java.net/jeps/223
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-8689) bin/solr.cmd does not start with recent Verona builds of Java 9 because of version parsing issue
[
https://issues.apache.org/jira/browse/SOLR-8689?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Uwe Schindler updated SOLR-8689:
Fix Version/s: 7.1
master (8.0)
7.0
> bin/solr.cmd does not start with recent Verona builds of Java 9 because of
> version parsing issue
>
>
> Key: SOLR-8689
> URL: https://issues.apache.org/jira/browse/SOLR-8689
> Project: Solr
> Issue Type: Bug
> Components: scripts and tools
>Affects Versions: 5.5, 6.0
> Environment: Windows 7
>Reporter: Uwe Schindler
>Priority: Blocker
> Labels: Java9
> Fix For: 7.0, master (8.0), 7.1
>
>
> At least on Windows, Solr 5.5 does not start with the shell script using a
> Verona-Java-9 JDK:
> {noformat}
> *
> JAVA_HOME = C:\Program Files\Java\jdk-9
> java version "9-ea"
> Java(TM) SE Runtime Environment (build
> 9-ea+105-2016-02-11-003336.javare.4433.nc)
> Java HotSpot(TM) 64-Bit Server VM (build
> 9-ea+105-2016-02-11-003336.javare.4433.nc, mixed mode)
> *
> C:\Users\Uwe Schindler\Desktop\solr-5.5.0\bin>solr start
> ERROR: Java 1.7 or later is required to run Solr. Current Java version is:
> 9-ea
> {noformat}
> I don't know if this is better with Linux, but I assume the version parsing
> is broken (e.g., String#startsWith, interpret as floating point number,...)
> We should fix this before Java 9 gets released! The version numbering scheme
> changed completely: http://openjdk.java.net/jeps/223
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-8689) bin/solr.cmd does not start with recent Verona builds of Java 9 because of version parsing issue
[
https://issues.apache.org/jira/browse/SOLR-8689?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Hoss Man updated SOLR-8689:
---
Summary: bin/solr.cmd does not start with recent Verona builds of Java 9
because of version parsing issue (was: Solr 5/6 does not start with recent
Verona builds of Java 9 because of version parsing issue)
> bin/solr.cmd does not start with recent Verona builds of Java 9 because of
> version parsing issue
>
>
> Key: SOLR-8689
> URL: https://issues.apache.org/jira/browse/SOLR-8689
> Project: Solr
> Issue Type: Bug
> Components: scripts and tools
>Affects Versions: 5.5, 6.0
> Environment: Windows 7
>Reporter: Uwe Schindler
> Labels: Java9
>
> At least on Windows, Solr 5.5 does not start with the shell script using a
> Verona-Java-9 JDK:
> {noformat}
> *
> JAVA_HOME = C:\Program Files\Java\jdk-9
> java version "9-ea"
> Java(TM) SE Runtime Environment (build
> 9-ea+105-2016-02-11-003336.javare.4433.nc)
> Java HotSpot(TM) 64-Bit Server VM (build
> 9-ea+105-2016-02-11-003336.javare.4433.nc, mixed mode)
> *
> C:\Users\Uwe Schindler\Desktop\solr-5.5.0\bin>solr start
> ERROR: Java 1.7 or later is required to run Solr. Current Java version is:
> 9-ea
> {noformat}
> I don't know if this is better with Linux, but I assume the version parsing
> is broken (e.g., String#startsWith, interpret as floating point number,...)
> We should fix this before Java 9 gets released! The version numbering scheme
> changed completely: http://openjdk.java.net/jeps/223
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
