[jira] [Updated] (SOLR-8724) Upgrade Zookeeper to 3.4.8
[ https://issues.apache.org/jira/browse/SOLR-8724?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Rowe updated SOLR-8724: - Fix Version/s: (was: master) > Upgrade Zookeeper to 3.4.8 > -- > > Key: SOLR-8724 > URL: https://issues.apache.org/jira/browse/SOLR-8724 > Project: Solr > Issue Type: Bug >Reporter: Steve Rowe > Attachments: SOLR-8724.patch, SOLR-8724.patch, SOLR-8724.patch, > SOLR-8724.patch > > > Zookeeper 3.4.8 was released a few days ago - we should upgrade. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-8724) Upgrade Zookeeper to 3.4.8
[ https://issues.apache.org/jira/browse/SOLR-8724?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Rowe updated SOLR-8724: - Attachment: SOLR-8724.patch Patch adding a workaround to the Solr's test ZK server that subclasses ZooKeeperServer to order server JMX registration before setting up its request processing pipeline. With this patch I no longer see Solr test failures. However, I think we should wait for the ZooKeeper 3.4.9 release (Flavio Junqueira has made ZOOKEEPER-2383 a 3.4.9 Blocker). So I've removed the CHANGES.txt changes from the attached patch. It should be usable as the basis for upgrading to 3.4.9 when that gets released, though at that point I assume we'll no longer need to subclass ZooKeeperServer to change JMX registration, so the ZkTestServer.java changes in this patch will need to be left out. > Upgrade Zookeeper to 3.4.8 > -- > > Key: SOLR-8724 > URL: https://issues.apache.org/jira/browse/SOLR-8724 > Project: Solr > Issue Type: Bug >Reporter: Steve Rowe > Fix For: master > > Attachments: SOLR-8724.patch, SOLR-8724.patch, SOLR-8724.patch, > SOLR-8724.patch > > > Zookeeper 3.4.8 was released a few days ago - we should upgrade. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-8724) Upgrade Zookeeper to 3.4.8
[
https://issues.apache.org/jira/browse/SOLR-8724?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Steve Rowe updated SOLR-8724:
-
Attachment: SOLR-8724.patch
{quote}
bq. If it weren't for that last item, I'd advocate for getting rid of this
patched parseProperties() and directly calling the superclass version, catching
the ".../myid file is missing" IllegalArgumentException, and handling setting
the server id in the catch block.
Might not be a bad improvement - not ideal to have the MDC call, but also
probably not very problematic.
{quote}
Yeah, the MDC call only happens when there's a myid file present, certainly not
the case for OOTB embedded Solr ZK.
This version of the patch makes the above-described change. Running tests now.
> Upgrade Zookeeper to 3.4.8
> --
>
> Key: SOLR-8724
> URL: https://issues.apache.org/jira/browse/SOLR-8724
> Project: Solr
> Issue Type: Bug
>Reporter: Steve Rowe
> Fix For: master
>
> Attachments: SOLR-8724.patch, SOLR-8724.patch, SOLR-8724.patch
>
>
> Zookeeper 3.4.8 was released a few days ago - we should upgrade.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-8724) Upgrade Zookeeper to 3.4.8
[
https://issues.apache.org/jira/browse/SOLR-8724?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Steve Rowe updated SOLR-8724:
-
Attachment: SOLR-8724.patch
Updated patch:
* Added commented out config options to {{zoo.cfg}}, pulled from ZK 3.4.8's
{{zoo_sample.cfg}}
* Fixed a couple comment alignment issues in the copied method (4 space per
indent level in ZK source vs 2 in Solr)
> Upgrade Zookeeper to 3.4.8
> --
>
> Key: SOLR-8724
> URL: https://issues.apache.org/jira/browse/SOLR-8724
> Project: Solr
> Issue Type: Bug
>Reporter: Steve Rowe
> Fix For: master
>
> Attachments: SOLR-8724.patch, SOLR-8724.patch
>
>
> Zookeeper 3.4.8 was released a few days ago - we should upgrade.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-8724) Upgrade Zookeeper to 3.4.8
[
https://issues.apache.org/jira/browse/SOLR-8724?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Steve Rowe updated SOLR-8724:
-
Attachment: SOLR-8724.patch
Patch, all Solr tests pass for me.
There is only one non-drop-in aspect: ZOOKEEPER-1506 makes private the
previously public {{QuorumPeer.QuorumServer}} constructors used in
{{SolrZkServerProps.parseProperties()}}, which was copied from ZK v3.2's
{{QuorumPeerConfig}} (which {{SolrZkServerProps}} extends) and modified to
"[allow] us to set a default for the data dir before parsing zoo.cfg (which
validates that there is a dataDir)" (<- comment above {{SolrZkServerProps}},
which extends {{QuorumPeerConfig}}).
Rather than try to make more local modifications to this copy to allow it to
compile, I've taken the tack of lifting the 3.4.8 version of
{{QuorumPeerConfig.parseProperties()}} (which has quite a few config changes we
should likely be supporting anyway), and then applying the same mods that had
been made to Solr's version:
# Add {{@Override}} annotation
# Add above-described fallback for when the "myid" file can't be found
# Specify the encoding when opening the "myid" file (LUCENE-5560)
I made two additional changes:
# Added a differently-named copy in {{SolrZkServerProps}} of a private access
data member referred to from the new {{parseProperties()}}:
{{QuorumPeerConfig.MIN_SNAP_RETAIN_COUNT}}
# Commented out a call to set "myid" in MDC
If it weren't for that last item, I'd advocate for getting rid of this patched
{{parseProperties()}} and directly calling the superclass version, catching the
".../myid file is missing" {{IllegalArgumentException}}, and handling setting
the server id in the catch block.
[~markrmil...@gmail.com], I'd appreciate your review.
> Upgrade Zookeeper to 3.4.8
> --
>
> Key: SOLR-8724
> URL: https://issues.apache.org/jira/browse/SOLR-8724
> Project: Solr
> Issue Type: Bug
>Reporter: Steve Rowe
> Fix For: master
>
> Attachments: SOLR-8724.patch
>
>
> Zookeeper 3.4.8 was released a few days ago - we should upgrade.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-8724) Upgrade Zookeeper to 3.4.8
[ https://issues.apache.org/jira/browse/SOLR-8724?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Rowe updated SOLR-8724: - Description: Zookeeper 3.4.8 was released a few days ago - we should upgrade. (was: Zookeeper 3.4.8 was released a few weeks ago - we should upgrade.) > Upgrade Zookeeper to 3.4.8 > -- > > Key: SOLR-8724 > URL: https://issues.apache.org/jira/browse/SOLR-8724 > Project: Solr > Issue Type: Bug >Reporter: Steve Rowe > Fix For: master > > > Zookeeper 3.4.8 was released a few days ago - we should upgrade. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
