[jira] [Updated] (SOLR-9720) Refactor responsewriter to remove dependencies on TupleStream etc
[ https://issues.apache.org/jira/browse/SOLR-9720?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shalin Shekhar Mangar updated SOLR-9720: Attachment: SOLR_9720_fix_JSONWriterTest.patch This change makes the JSONWriterTest.testArrnvpWriterOverridesAllWrites fail because it expects that the ArrayOfNamedValuePairJSONWriter class added in SOLR-9442 overrides all public/protected writeXXX methods from JSONWriter. However, this change introduced two new public/protected methods writeJsonIter(java.util.Iterator) and writeArray(java.lang.String,java.util.List) which aren't overriden by ArrayOfNamedValuePairJSONWriter. This patch fixes it by adding a writeArray(java.lang.String,java.util.List) in ArrayOfNamedValuePairJSONWriter which delegates to writeArray(String name, Iterator val) and making writeJsonIter private (which is used internally by both variants of writeArray in the super class. If we ever have a need for overriding writeJsonIter directly, we can make it protected then. > Refactor responsewriter to remove dependencies on TupleStream etc > - > > Key: SOLR-9720 > URL: https://issues.apache.org/jira/browse/SOLR-9720 > Project: Solr > Issue Type: Sub-task > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Noble Paul >Assignee: Noble Paul > Attachments: SOLR-9720.patch, SOLR-9720.patch, SOLR-9720.patch, > SOLR_9720_fix_JSONWriterTest.patch > > > ResponseWriters are designed to be agnostic of components and they should > work with the well know set of types we already support -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-9720) Refactor responsewriter to remove dependencies on TupleStream etc
[ https://issues.apache.org/jira/browse/SOLR-9720?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Noble Paul updated SOLR-9720: - Attachment: SOLR-9720.patch > Refactor responsewriter to remove dependencies on TupleStream etc > - > > Key: SOLR-9720 > URL: https://issues.apache.org/jira/browse/SOLR-9720 > Project: Solr > Issue Type: Sub-task > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Noble Paul >Assignee: Noble Paul > Attachments: SOLR-9720.patch, SOLR-9720.patch, SOLR-9720.patch > > > ResponseWriters are designed to be agnostic of components and they should > work with the well know set of types we already support -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-9720) Refactor responsewriter to remove dependencies on TupleStream etc
[
https://issues.apache.org/jira/browse/SOLR-9720?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Noble Paul updated SOLR-9720:
-
Attachment: SOLR-9720.patch
remove special handling for {{Explanation}} as well
> Refactor responsewriter to remove dependencies on TupleStream etc
> -
>
> Key: SOLR-9720
> URL: https://issues.apache.org/jira/browse/SOLR-9720
> Project: Solr
> Issue Type: Sub-task
> Security Level: Public(Default Security Level. Issues are Public)
>Reporter: Noble Paul
>Assignee: Noble Paul
> Attachments: SOLR-9720.patch, SOLR-9720.patch
>
>
> ResponseWriters are designed to be agnostic of components and they should
> work with the well know set of types we already support
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-9720) Refactor responsewriter to remove dependencies on TupleStream etc
[ https://issues.apache.org/jira/browse/SOLR-9720?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Noble Paul updated SOLR-9720: - Attachment: (was: SOLR-9720.patch) > Refactor responsewriter to remove dependencies on TupleStream etc > - > > Key: SOLR-9720 > URL: https://issues.apache.org/jira/browse/SOLR-9720 > Project: Solr > Issue Type: Sub-task > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Noble Paul >Assignee: Noble Paul > Attachments: SOLR-9720.patch > > > ResponseWriters are designed to be agnostic of components and they should > work with the well know set of types we already support -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-9720) Refactor responsewriter to remove dependencies on TupleStream etc
[ https://issues.apache.org/jira/browse/SOLR-9720?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Noble Paul updated SOLR-9720: - Attachment: SOLR-9720.patch > Refactor responsewriter to remove dependencies on TupleStream etc > - > > Key: SOLR-9720 > URL: https://issues.apache.org/jira/browse/SOLR-9720 > Project: Solr > Issue Type: Sub-task > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Noble Paul >Assignee: Noble Paul > Attachments: SOLR-9720.patch, SOLR-9720.patch > > > ResponseWriters are designed to be agnostic of components and they should > work with the well know set of types we already support -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-9720) Refactor responsewriter to remove dependencies on TupleStream etc
[ https://issues.apache.org/jira/browse/SOLR-9720?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Noble Paul updated SOLR-9720: - Attachment: SOLR-9720.patch not final but gives an idea > Refactor responsewriter to remove dependencies on TupleStream etc > - > > Key: SOLR-9720 > URL: https://issues.apache.org/jira/browse/SOLR-9720 > Project: Solr > Issue Type: Sub-task > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Noble Paul >Assignee: Noble Paul > Attachments: SOLR-9720.patch > > > ResponseWriters are designed to be agnostic of components and they should > work with the well know set of types we already support -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
