[jira] [Updated] (SOLR-9947) Miscellaneous metrics cleanup

2017-01-11 Thread Andrzej Bialecki (JIRA)

 [ 
https://issues.apache.org/jira/browse/SOLR-9947?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrzej Bialecki  updated SOLR-9947:

Attachment: SOLR-9947.patch

Current patch. Includes the alternative view for SolrInfoMBeans.

> Miscellaneous metrics cleanup
> -
>
> Key: SOLR-9947
> URL: https://issues.apache.org/jira/browse/SOLR-9947
> Project: Solr
>  Issue Type: Improvement
>  Security Level: Public(Default Security Level. Issues are Public) 
>  Components: metrics
>Reporter: Shalin Shekhar Mangar
>Assignee: Andrzej Bialecki 
>Priority: Minor
> Fix For: master (7.0), 6.4
>
> Attachments: SOLR-9947-with-mbeans.patch, SOLR-9947.patch, 
> SOLR-9947.patch, SOLR-9947.patch, screenshot-1.png
>
>
> Misc cleanup in metrics API to fix:
> # metrics reporting themselves under the wrong category
> # core container metrics are without a category



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org



[jira] [Updated] (SOLR-9947) Miscellaneous metrics cleanup

2017-01-11 Thread Andrzej Bialecki (JIRA)

 [ 
https://issues.apache.org/jira/browse/SOLR-9947?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrzej Bialecki  updated SOLR-9947:

Attachment: SOLR-9947-with-mbeans.patch

I attached a patch with this modification.

> Miscellaneous metrics cleanup
> -
>
> Key: SOLR-9947
> URL: https://issues.apache.org/jira/browse/SOLR-9947
> Project: Solr
>  Issue Type: Improvement
>  Security Level: Public(Default Security Level. Issues are Public) 
>  Components: metrics
>Reporter: Shalin Shekhar Mangar
>Assignee: Andrzej Bialecki 
>Priority: Minor
> Fix For: master (7.0), 6.4
>
> Attachments: SOLR-9947-with-mbeans.patch, SOLR-9947.patch, 
> SOLR-9947.patch, screenshot-1.png
>
>
> Misc cleanup in metrics API to fix:
> # metrics reporting themselves under the wrong category
> # core container metrics are without a category



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org



[jira] [Updated] (SOLR-9947) Miscellaneous metrics cleanup

2017-01-11 Thread Andrzej Bialecki (JIRA)

 [ 
https://issues.apache.org/jira/browse/SOLR-9947?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrzej Bialecki  updated SOLR-9947:

Attachment: screenshot-1.png

> Miscellaneous metrics cleanup
> -
>
> Key: SOLR-9947
> URL: https://issues.apache.org/jira/browse/SOLR-9947
> Project: Solr
>  Issue Type: Improvement
>  Security Level: Public(Default Security Level. Issues are Public) 
>  Components: metrics
>Reporter: Shalin Shekhar Mangar
>Assignee: Andrzej Bialecki 
>Priority: Minor
> Fix For: master (7.0), 6.4
>
> Attachments: SOLR-9947.patch, SOLR-9947.patch, screenshot-1.png
>
>
> Misc cleanup in metrics API to fix:
> # metrics reporting themselves under the wrong category
> # core container metrics are without a category



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org



[jira] [Updated] (SOLR-9947) Miscellaneous metrics cleanup

2017-01-11 Thread Andrzej Bialecki (JIRA)

 [ 
https://issues.apache.org/jira/browse/SOLR-9947?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrzej Bialecki  updated SOLR-9947:

Attachment: SOLR-9947.patch

More cleanups:
* fix broken tests
* always report total size of tlogs, not just during recovery
* add a note about UpdateLog.State enum being reported, to take care when 
adding or modifying this enum, and use explicit values for this enum.
* HIGHTLIGHTING -> HIGHLIGHTER for consistency
* TLOG.applying_buffered.ops -> TLOG.applyingBuffered.ops for consistency.

> Miscellaneous metrics cleanup
> -
>
> Key: SOLR-9947
> URL: https://issues.apache.org/jira/browse/SOLR-9947
> Project: Solr
>  Issue Type: Improvement
>  Security Level: Public(Default Security Level. Issues are Public) 
>  Components: metrics
>Reporter: Shalin Shekhar Mangar
>Assignee: Andrzej Bialecki 
>Priority: Minor
> Fix For: master (7.0), 6.4
>
> Attachments: SOLR-9947.patch, SOLR-9947.patch
>
>
> Misc cleanup in metrics API to fix:
> # metrics reporting themselves under the wrong category
> # core container metrics are without a category



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org



[jira] [Updated] (SOLR-9947) Miscellaneous metrics cleanup

2017-01-10 Thread Andrzej Bialecki (JIRA)

 [ 
https://issues.apache.org/jira/browse/SOLR-9947?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrzej Bialecki  updated SOLR-9947:

Attachment: SOLR-9947.patch

Current patch with the following changes:
* simplified UPDATEHANDLER and QUERYHANDLER to UPDATE and QUERY respectively. 
This also allows us to put into this category those plugins that are not 
handlers.
* added ADMIN and CONTAINER. The first category covers all admin handlers, the 
other covers CoreContainer-specific handlers.
* moved some handlers to UPDATE and REPLICATION

This seems to bring much more consistency and transparency into where plugins 
logically belong to, as oppose to them being {{RequestHandlerBase}} subclasses, 
which is an implementation detail. If there are no objections I'd like to 
commit it soon, so that it makes it into 6.4.

> Miscellaneous metrics cleanup
> -
>
> Key: SOLR-9947
> URL: https://issues.apache.org/jira/browse/SOLR-9947
> Project: Solr
>  Issue Type: Improvement
>  Security Level: Public(Default Security Level. Issues are Public) 
>  Components: metrics
>Reporter: Shalin Shekhar Mangar
>Assignee: Andrzej Bialecki 
>Priority: Minor
> Fix For: master (7.0), 6.4
>
> Attachments: SOLR-9947.patch
>
>
> Misc cleanup in metrics API to fix:
> # metrics reporting themselves under the wrong category
> # core container metrics are without a category



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org