[jira] Commented: (LUCENE-2436) FilterIndexReader doesn't delegate everything necessary
[ https://issues.apache.org/jira/browse/LUCENE-2436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12863242#action_12863242 ] Uwe Schindler commented on LUCENE-2436: --- Reflection police says: +1 Good idea, its something like our final assertments for TokenStreams and Analyzers in tests. I think about it. FilterIndexReader doesn't delegate everything necessary --- Key: LUCENE-2436 URL: https://issues.apache.org/jira/browse/LUCENE-2436 Project: Lucene - Java Issue Type: Bug Reporter: Yonik Seeley Fix For: 4.0.0 Some new methods like fields() aren't delegated by FilterIndexReader, incorrectly resulting in the IndexReader base class method being used. We should audit all current IndexReader methods to determine which should be overridden and delegated. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] Commented: (LUCENE-2436) FilterIndexReader doesn't delegate everything necessary
[ https://issues.apache.org/jira/browse/LUCENE-2436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12863248#action_12863248 ] Uwe Schindler commented on LUCENE-2436: --- VirtualMethod is the sophisticated™ tool we use for delegating to overriden deprecated methods. It has all the checks you do inside, only the enumerations are missing. The code for the checks is almost finished... :-) The rest is just the getDeclaredMethods() iteration. FilterIndexReader doesn't delegate everything necessary --- Key: LUCENE-2436 URL: https://issues.apache.org/jira/browse/LUCENE-2436 Project: Lucene - Java Issue Type: Bug Reporter: Yonik Seeley Fix For: 4.0.0 Some new methods like fields() aren't delegated by FilterIndexReader, incorrectly resulting in the IndexReader base class method being used. We should audit all current IndexReader methods to determine which should be overridden and delegated. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] Commented: (LUCENE-2436) FilterIndexReader doesn't delegate everything necessary
[ https://issues.apache.org/jira/browse/LUCENE-2436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12863285#action_12863285 ] Michael McCandless commented on LUCENE-2436: +1 for a test to catch this :) FilterIndexReader doesn't delegate everything necessary --- Key: LUCENE-2436 URL: https://issues.apache.org/jira/browse/LUCENE-2436 Project: Lucene - Java Issue Type: Bug Reporter: Yonik Seeley Fix For: 4.0.0 Some new methods like fields() aren't delegated by FilterIndexReader, incorrectly resulting in the IndexReader base class method being used. We should audit all current IndexReader methods to determine which should be overridden and delegated. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] Commented: (LUCENE-2436) FilterIndexReader doesn't delegate everything necessary
[ https://issues.apache.org/jira/browse/LUCENE-2436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12863207#action_12863207 ] Yonik Seeley commented on LUCENE-2436: -- We could perhaps use some fancy reflection in a test to determine if FilterIndexReader overrides everything it needs to? FilterIndexReader doesn't delegate everything necessary --- Key: LUCENE-2436 URL: https://issues.apache.org/jira/browse/LUCENE-2436 Project: Lucene - Java Issue Type: Bug Reporter: Yonik Seeley Fix For: 4.0.0 Some new methods like fields() aren't delegated by FilterIndexReader, incorrectly resulting in the IndexReader base class method being used. We should audit all current IndexReader methods to determine which should be overridden and delegated. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
