[jira] Commented: (LUCENE-2855) Contrib queryparser should not use CharSequence as Map key
[ https://issues.apache.org/jira/browse/LUCENE-2855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12979274#action_12979274 ] Simon Willnauer commented on LUCENE-2855: - +1 - just put your name after the description in the changes.txt Contrib queryparser should not use CharSequence as Map key -- Key: LUCENE-2855 URL: https://issues.apache.org/jira/browse/LUCENE-2855 Project: Lucene - Java Issue Type: Bug Components: contrib/* Affects Versions: 3.0.3 Reporter: Adriano Crestani Assignee: Adriano Crestani Fix For: 3.0.4 Attachments: lucene_2855_adriano_crestani_2011_01_08.patch Today, contrib query parser uses MapCharSequence,... in many different places, which may lead to problems, since CharSequence interface does not enforce the implementation of hashcode and equals methods. Today, it's causing a problem with QueryTreeBuilder.setBuilder(CharSequence,QueryBuilder) method, that does not works as expected. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] Commented: (LUCENE-2855) Contrib queryparser should not use CharSequence as Map key
[ https://issues.apache.org/jira/browse/LUCENE-2855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12979253#action_12979253 ] Uwe Schindler commented on LUCENE-2855: --- +1 to commit. In general, one should never use interfaces as keys in maps (as long as they don't declare the equals and hashcode methods inside the interface). Contrib queryparser should not use CharSequence as Map key -- Key: LUCENE-2855 URL: https://issues.apache.org/jira/browse/LUCENE-2855 Project: Lucene - Java Issue Type: Bug Components: contrib/* Affects Versions: 3.0.3 Reporter: Adriano Crestani Assignee: Adriano Crestani Fix For: 3.0.4 Attachments: lucene_2855_adriano_crestani_2011_01_08.patch Today, contrib query parser uses MapCharSequence,... in many different places, which may lead to problems, since CharSequence interface does not enforce the implementation of hashcode and equals methods. Today, it's causing a problem with QueryTreeBuilder.setBuilder(CharSequence,QueryBuilder) method, that does not works as expected. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] Commented: (LUCENE-2855) Contrib queryparser should not use CharSequence as Map key
[ https://issues.apache.org/jira/browse/LUCENE-2855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12979255#action_12979255 ] Uwe Schindler commented on LUCENE-2855: --- One thing in your patch: Lucene tests should always extend LuceneTestCase (which is Junit4) Contrib queryparser should not use CharSequence as Map key -- Key: LUCENE-2855 URL: https://issues.apache.org/jira/browse/LUCENE-2855 Project: Lucene - Java Issue Type: Bug Components: contrib/* Affects Versions: 3.0.3 Reporter: Adriano Crestani Assignee: Adriano Crestani Fix For: 3.0.4 Attachments: lucene_2855_adriano_crestani_2011_01_08.patch Today, contrib query parser uses MapCharSequence,... in many different places, which may lead to problems, since CharSequence interface does not enforce the implementation of hashcode and equals methods. Today, it's causing a problem with QueryTreeBuilder.setBuilder(CharSequence,QueryBuilder) method, that does not works as expected. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
