[Lucene.Net] [jira] [Commented] (LUCENENET-380) Evaluate Sharpen as a port tool
[ https://issues.apache.org/jira/browse/LUCENENET-380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13010777#comment-13010777 ] Prescott Nasser commented on LUCENENET-380: --- Keeping it all in the same place has some real positives to me. It makes it all easily 'seeable' to everyone, no going to another project. What if we keep it in our repo and at the appropriate time spin it off into a sub project, or another incubator project? I just think for getting started and building momentum it would pay to keep it close. Evaluate Sharpen as a port tool --- Key: LUCENENET-380 URL: https://issues.apache.org/jira/browse/LUCENENET-380 Project: Lucene.Net Issue Type: Task Components: Build Automation, Lucene.Net Contrib, Lucene.Net Core, Lucene.Net Demo, Lucene.Net Test Reporter: George Aroush Assignee: Alex Thompson Attachments: 3.0.2_JavaToCSharpConverter_AfterPostProcessing.zip, 3.0.2_JavaToCSharpConverter_NoPostProcessing.zip, IndexWriter.java, Lucene.Net.3_0_3_Sharpen20110106.zip, Lucene.Net.Sharpen20101104.zip, Lucene.Net.Sharpen20101114.zip, NIOFSDirectory.java, QueryParser.java, TestBufferedIndexInput.java, TestDateFilter.java This task is to evaluate Sharpen as a port tool for Lucene.Net. The files to be evaluated are attached. We need to run those files (which are off Java Lucene 2.9.2) against Sharpen and compare the result against JLCA result. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[Lucene.Net] [jira] [Commented] (LUCENENET-380) Evaluate Sharpen as a port tool
[ https://issues.apache.org/jira/browse/LUCENENET-380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13010779#comment-13010779 ] Prescott Nasser commented on LUCENENET-380: --- I'm assuming we can give it the ASF license? If there are licensing issues, then I think this conversation is moot. Evaluate Sharpen as a port tool --- Key: LUCENENET-380 URL: https://issues.apache.org/jira/browse/LUCENENET-380 Project: Lucene.Net Issue Type: Task Components: Build Automation, Lucene.Net Contrib, Lucene.Net Core, Lucene.Net Demo, Lucene.Net Test Reporter: George Aroush Assignee: Alex Thompson Attachments: 3.0.2_JavaToCSharpConverter_AfterPostProcessing.zip, 3.0.2_JavaToCSharpConverter_NoPostProcessing.zip, IndexWriter.java, Lucene.Net.3_0_3_Sharpen20110106.zip, Lucene.Net.Sharpen20101104.zip, Lucene.Net.Sharpen20101114.zip, NIOFSDirectory.java, QueryParser.java, TestBufferedIndexInput.java, TestDateFilter.java This task is to evaluate Sharpen as a port tool for Lucene.Net. The files to be evaluated are attached. We need to run those files (which are off Java Lucene 2.9.2) against Sharpen and compare the result against JLCA result. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[Lucene.Net] [jira] [Commented] (LUCENENET-380) Evaluate Sharpen as a port tool
[
https://issues.apache.org/jira/browse/LUCENENET-380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13010841#comment-13010841
]
Alex Thompson commented on LUCENENET-380:
-
Another question from the dOCL:
{quote}
1. Subject
Software means the current version of the db4o database engine software and
all patches, bug fixes, error corrections and future versions. Software does
not mean add-on packages which are not part of the db4o database engine such as
Hibernate or Bloat, which you would license directly from their respective
vendors. {quote}
I don't know if sharpen can be considered part of the database engine so can
the dOCL even apply?
Also to put it in our repo wouldn't there need to be a software grant agreement
from db4o and any other contributors?
I don't know if it would be any easier to get started.
Evaluate Sharpen as a port tool
---
Key: LUCENENET-380
URL: https://issues.apache.org/jira/browse/LUCENENET-380
Project: Lucene.Net
Issue Type: Task
Components: Build Automation, Lucene.Net Contrib, Lucene.Net Core,
Lucene.Net Demo, Lucene.Net Test
Reporter: George Aroush
Assignee: Alex Thompson
Attachments: 3.0.2_JavaToCSharpConverter_AfterPostProcessing.zip,
3.0.2_JavaToCSharpConverter_NoPostProcessing.zip, IndexWriter.java,
Lucene.Net.3_0_3_Sharpen20110106.zip, Lucene.Net.Sharpen20101104.zip,
Lucene.Net.Sharpen20101114.zip, NIOFSDirectory.java, QueryParser.java,
TestBufferedIndexInput.java, TestDateFilter.java
This task is to evaluate Sharpen as a port tool for Lucene.Net.
The files to be evaluated are attached. We need to run those files (which
are off Java Lucene 2.9.2) against Sharpen and compare the result against
JLCA result.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[Lucene.Net] [jira] [Commented] (LUCENENET-380) Evaluate Sharpen as a port tool
[ https://issues.apache.org/jira/browse/LUCENENET-380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13010857#comment-13010857 ] Scott Lombard commented on LUCENENET-380: - My point when starting this is it worth asking the questions to bring the source into our repo. I agree with Prescott that it will be easier to manage as part of the project, atleast to start. I will send a new email out to the dev list and see what people have to say. I feel it is worth investigating and getting all the answers to the unknowns. Evaluate Sharpen as a port tool --- Key: LUCENENET-380 URL: https://issues.apache.org/jira/browse/LUCENENET-380 Project: Lucene.Net Issue Type: Task Components: Build Automation, Lucene.Net Contrib, Lucene.Net Core, Lucene.Net Demo, Lucene.Net Test Reporter: George Aroush Assignee: Alex Thompson Attachments: 3.0.2_JavaToCSharpConverter_AfterPostProcessing.zip, 3.0.2_JavaToCSharpConverter_NoPostProcessing.zip, IndexWriter.java, Lucene.Net.3_0_3_Sharpen20110106.zip, Lucene.Net.Sharpen20101104.zip, Lucene.Net.Sharpen20101114.zip, NIOFSDirectory.java, QueryParser.java, TestBufferedIndexInput.java, TestDateFilter.java This task is to evaluate Sharpen as a port tool for Lucene.Net. The files to be evaluated are attached. We need to run those files (which are off Java Lucene 2.9.2) against Sharpen and compare the result against JLCA result. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[Lucene.Net] [jira] [Commented] (LUCENENET-380) Evaluate Sharpen as a port tool
[ https://issues.apache.org/jira/browse/LUCENENET-380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13010051#comment-13010051 ] Scott Lombard commented on LUCENENET-380: - Why fork outside of ASF if we can keep it inside? Is a independent project justified? It seems to me there is a lot of infrastructure that needs to be duplicated and maintained. I agreed to starting a fork outside of ASF because I didn't think there was any possibility to bring code into lucene.net. Now, I just don't understand licensing well enough to rule out a dOCL license from db4o. Evaluate Sharpen as a port tool --- Key: LUCENENET-380 URL: https://issues.apache.org/jira/browse/LUCENENET-380 Project: Lucene.Net Issue Type: Task Components: Build Automation, Lucene.Net Contrib, Lucene.Net Core, Lucene.Net Demo, Lucene.Net Test Reporter: George Aroush Assignee: Alex Thompson Attachments: 3.0.2_JavaToCSharpConverter_AfterPostProcessing.zip, 3.0.2_JavaToCSharpConverter_NoPostProcessing.zip, IndexWriter.java, Lucene.Net.3_0_3_Sharpen20110106.zip, Lucene.Net.Sharpen20101104.zip, Lucene.Net.Sharpen20101114.zip, NIOFSDirectory.java, QueryParser.java, TestBufferedIndexInput.java, TestDateFilter.java This task is to evaluate Sharpen as a port tool for Lucene.Net. The files to be evaluated are attached. We need to run those files (which are off Java Lucene 2.9.2) against Sharpen and compare the result against JLCA result. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[Lucene.Net] [jira] [Commented] (LUCENENET-380) Evaluate Sharpen as a port tool
[ https://issues.apache.org/jira/browse/LUCENENET-380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13010206#comment-13010206 ] Alex Thompson commented on LUCENENET-380: - My thoughts on the fork have been to make something that would be useful beyond Lucene, and the scope of the problems seem to be beyond the scope of Lucene.Net, so I do think an independent project would be a more natural fit. And if we used say BitBucket, would the infrastructure really be that much of a barrier? Evaluate Sharpen as a port tool --- Key: LUCENENET-380 URL: https://issues.apache.org/jira/browse/LUCENENET-380 Project: Lucene.Net Issue Type: Task Components: Build Automation, Lucene.Net Contrib, Lucene.Net Core, Lucene.Net Demo, Lucene.Net Test Reporter: George Aroush Assignee: Alex Thompson Attachments: 3.0.2_JavaToCSharpConverter_AfterPostProcessing.zip, 3.0.2_JavaToCSharpConverter_NoPostProcessing.zip, IndexWriter.java, Lucene.Net.3_0_3_Sharpen20110106.zip, Lucene.Net.Sharpen20101104.zip, Lucene.Net.Sharpen20101114.zip, NIOFSDirectory.java, QueryParser.java, TestBufferedIndexInput.java, TestDateFilter.java This task is to evaluate Sharpen as a port tool for Lucene.Net. The files to be evaluated are attached. We need to run those files (which are off Java Lucene 2.9.2) against Sharpen and compare the result against JLCA result. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[Lucene.Net] [jira] [Commented] (LUCENENET-380) Evaluate Sharpen as a port tool
[ https://issues.apache.org/jira/browse/LUCENENET-380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13009726#comment-13009726 ] Scott Lombard commented on LUCENENET-380: - I was investigating what license sharpen uses and found they offer what is called db4o Opensource Compatibility License (dOCL) instead of the GPL (refer to http://www.db4o.com/about/company/legalpolicies/docl.aspx). I read this a possiblity, but I have to admit I don't fully understand all the legal language. Evaluate Sharpen as a port tool --- Key: LUCENENET-380 URL: https://issues.apache.org/jira/browse/LUCENENET-380 Project: Lucene.Net Issue Type: Task Components: Build Automation, Lucene.Net Contrib, Lucene.Net Core, Lucene.Net Demo, Lucene.Net Test Reporter: George Aroush Assignee: Alex Thompson Attachments: 3.0.2_JavaToCSharpConverter_AfterPostProcessing.zip, 3.0.2_JavaToCSharpConverter_NoPostProcessing.zip, IndexWriter.java, Lucene.Net.3_0_3_Sharpen20110106.zip, Lucene.Net.Sharpen20101104.zip, Lucene.Net.Sharpen20101114.zip, NIOFSDirectory.java, QueryParser.java, TestBufferedIndexInput.java, TestDateFilter.java This task is to evaluate Sharpen as a port tool for Lucene.Net. The files to be evaluated are attached. We need to run those files (which are off Java Lucene 2.9.2) against Sharpen and compare the result against JLCA result. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[Lucene.Net] [jira] [Commented] (LUCENENET-380) Evaluate Sharpen as a port tool
[ https://issues.apache.org/jira/browse/LUCENENET-380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13009741#comment-13009741 ] Alex Thompson commented on LUCENENET-380: - The dOCL is just an option in addition to (not instead of) the GPL. From the dOCL page: Versant licenses the Software (as defined in Section 1) pursuant to (1) this Agreement, (2) a commercial, royalty-based license agreement, and (3) the GNU General Public License v2.0 (GPL). You may choose to license the Software pursuant to any of the three agreements. I think the purpose of the dOCL is to cover the scenario where you are mixing code that is already under another open source license. For our sharpen fork I think we would just keep the whole thing GPL. Evaluate Sharpen as a port tool --- Key: LUCENENET-380 URL: https://issues.apache.org/jira/browse/LUCENENET-380 Project: Lucene.Net Issue Type: Task Components: Build Automation, Lucene.Net Contrib, Lucene.Net Core, Lucene.Net Demo, Lucene.Net Test Reporter: George Aroush Assignee: Alex Thompson Attachments: 3.0.2_JavaToCSharpConverter_AfterPostProcessing.zip, 3.0.2_JavaToCSharpConverter_NoPostProcessing.zip, IndexWriter.java, Lucene.Net.3_0_3_Sharpen20110106.zip, Lucene.Net.Sharpen20101104.zip, Lucene.Net.Sharpen20101114.zip, NIOFSDirectory.java, QueryParser.java, TestBufferedIndexInput.java, TestDateFilter.java This task is to evaluate Sharpen as a port tool for Lucene.Net. The files to be evaluated are attached. We need to run those files (which are off Java Lucene 2.9.2) against Sharpen and compare the result against JLCA result. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[Lucene.Net] [jira] Commented: (LUCENENET-380) Evaluate Sharpen as a port tool
[ https://issues.apache.org/jira/browse/LUCENENET-380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13001475#comment-13001475 ] Alex Thompson commented on LUCENENET-380: - So db4o did get back to me. They would need typical things like contribution agreements and full review control. You can see the response here: http://developer.db4o.com/Forums/tabid/98/aft/10503/Default.aspx I'm kinda leaning towards a fork but what does everyone think about their constraints? Evaluate Sharpen as a port tool --- Key: LUCENENET-380 URL: https://issues.apache.org/jira/browse/LUCENENET-380 Project: Lucene.Net Issue Type: Task Components: Build Automation, Lucene.Net Contrib, Lucene.Net Core, Lucene.Net Demo, Lucene.Net Test Reporter: George Aroush Assignee: Alex Thompson Attachments: 3.0.2_JavaToCSharpConverter_AfterPostProcessing.zip, 3.0.2_JavaToCSharpConverter_NoPostProcessing.zip, IndexWriter.java, Lucene.Net.3_0_3_Sharpen20110106.zip, Lucene.Net.Sharpen20101104.zip, Lucene.Net.Sharpen20101114.zip, NIOFSDirectory.java, QueryParser.java, TestBufferedIndexInput.java, TestDateFilter.java This task is to evaluate Sharpen as a port tool for Lucene.Net. The files to be evaluated are attached. We need to run those files (which are off Java Lucene 2.9.2) against Sharpen and compare the result against JLCA result. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira
[Lucene.Net] [jira] Commented: (LUCENENET-380) Evaluate Sharpen as a port tool
[ https://issues.apache.org/jira/browse/LUCENENET-380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12998626#comment-12998626 ] Alex Thompson commented on LUCENENET-380: - That's worth a shot I guess. Forum thread I started: http://developer.db4o.com/Forums/tabid/98/aft/10503/Default.aspx Evaluate Sharpen as a port tool --- Key: LUCENENET-380 URL: https://issues.apache.org/jira/browse/LUCENENET-380 Project: Lucene.Net Issue Type: Task Components: Build Automation, Lucene.Net Contrib, Lucene.Net Core, Lucene.Net Demo, Lucene.Net Test Reporter: George Aroush Assignee: Alex Thompson Attachments: 3.0.2_JavaToCSharpConverter_AfterPostProcessing.zip, 3.0.2_JavaToCSharpConverter_NoPostProcessing.zip, IndexWriter.java, Lucene.Net.3_0_3_Sharpen20110106.zip, Lucene.Net.Sharpen20101104.zip, Lucene.Net.Sharpen20101114.zip, NIOFSDirectory.java, QueryParser.java, TestBufferedIndexInput.java, TestDateFilter.java This task is to evaluate Sharpen as a port tool for Lucene.Net. The files to be evaluated are attached. We need to run those files (which are off Java Lucene 2.9.2) against Sharpen and compare the result against JLCA result. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira
[Lucene.Net] [jira] Commented: (LUCENENET-380) Evaluate Sharpen as a port tool
[ https://issues.apache.org/jira/browse/LUCENENET-380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12998150#comment-12998150 ] Prescott Nasser commented on LUCENENET-380: --- I see this is assigned to me - but I'm hoping some other folks have been playing with sharpen? Also, at this point what are our other options? We could do something like tangible softwares java to C# - but that costs money and is likely not as extensible Evaluate Sharpen as a port tool --- Key: LUCENENET-380 URL: https://issues.apache.org/jira/browse/LUCENENET-380 Project: Lucene.Net Issue Type: Task Components: Build Automation, Lucene.Net Contrib, Lucene.Net Core, Lucene.Net Demo, Lucene.Net Test Reporter: George Aroush Assignee: Prescott Nasser Attachments: 3.0.2_JavaToCSharpConverter_AfterPostProcessing.zip, 3.0.2_JavaToCSharpConverter_NoPostProcessing.zip, IndexWriter.java, Lucene.Net.3_0_3_Sharpen20110106.zip, Lucene.Net.Sharpen20101104.zip, Lucene.Net.Sharpen20101114.zip, NIOFSDirectory.java, QueryParser.java, TestBufferedIndexInput.java, TestDateFilter.java This task is to evaluate Sharpen as a port tool for Lucene.Net. The files to be evaluated are attached. We need to run those files (which are off Java Lucene 2.9.2) against Sharpen and compare the result against JLCA result. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira
[Lucene.Net] [jira] Commented: (LUCENENET-380) Evaluate Sharpen as a port tool
[ https://issues.apache.org/jira/browse/LUCENENET-380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12998156#comment-12998156 ] Troy Howard commented on LUCENENET-380: --- So far Sharpen seems to be the most viable option. Worth noting: NGit (a .NET port of JGit) is also using Sharpen to do their code generation. They have pretty good documentation about the process. They have developed a bunch of support classes to enable the Sharpen conversion. I was thinking of contacting Lluis (developer of NGit), and seeing if he would be able to help us get our Sharpen setup rolling, or at least help evaluate our use case. Anyhow, check out the project at: https://github.com/slluis/ngit Evaluate Sharpen as a port tool --- Key: LUCENENET-380 URL: https://issues.apache.org/jira/browse/LUCENENET-380 Project: Lucene.Net Issue Type: Task Components: Build Automation, Lucene.Net Contrib, Lucene.Net Core, Lucene.Net Demo, Lucene.Net Test Reporter: George Aroush Assignee: Prescott Nasser Attachments: 3.0.2_JavaToCSharpConverter_AfterPostProcessing.zip, 3.0.2_JavaToCSharpConverter_NoPostProcessing.zip, IndexWriter.java, Lucene.Net.3_0_3_Sharpen20110106.zip, Lucene.Net.Sharpen20101104.zip, Lucene.Net.Sharpen20101114.zip, NIOFSDirectory.java, QueryParser.java, TestBufferedIndexInput.java, TestDateFilter.java This task is to evaluate Sharpen as a port tool for Lucene.Net. The files to be evaluated are attached. We need to run those files (which are off Java Lucene 2.9.2) against Sharpen and compare the result against JLCA result. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira
[Lucene.Net] [jira] Commented: (LUCENENET-380) Evaluate Sharpen as a port tool
[ https://issues.apache.org/jira/browse/LUCENENET-380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12998172#comment-12998172 ] Alex Thompson commented on LUCENENET-380: - Looks like NGit does the pre/post as patches. I think we can make the pre/post more integrated and generalized by extending sharpen. Their support classes do look useful. Evaluate Sharpen as a port tool --- Key: LUCENENET-380 URL: https://issues.apache.org/jira/browse/LUCENENET-380 Project: Lucene.Net Issue Type: Task Components: Build Automation, Lucene.Net Contrib, Lucene.Net Core, Lucene.Net Demo, Lucene.Net Test Reporter: George Aroush Assignee: Prescott Nasser Attachments: 3.0.2_JavaToCSharpConverter_AfterPostProcessing.zip, 3.0.2_JavaToCSharpConverter_NoPostProcessing.zip, IndexWriter.java, Lucene.Net.3_0_3_Sharpen20110106.zip, Lucene.Net.Sharpen20101104.zip, Lucene.Net.Sharpen20101114.zip, NIOFSDirectory.java, QueryParser.java, TestBufferedIndexInput.java, TestDateFilter.java This task is to evaluate Sharpen as a port tool for Lucene.Net. The files to be evaluated are attached. We need to run those files (which are off Java Lucene 2.9.2) against Sharpen and compare the result against JLCA result. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira
[Lucene.Net] [jira] Commented: (LUCENENET-380) Evaluate Sharpen as a port tool
[ https://issues.apache.org/jira/browse/LUCENENET-380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12998175#comment-12998175 ] Troy Howard commented on LUCENENET-380: --- Alex - I was thinking we could fork Sharpen along those lines. AFAIK, Sharpen doesn't accept contributions, and including the source code in our repo would require them to donate to us... So we'd have to do that outside of the ASF. We could bring together both changes to Sharpen to reduce pre/post patches and also create a reusable set of Support classes starting with the ones at NGit. Perhaps over time we could convince db4o to merge our fork back in, or donate Sharpen to ASF. Evaluate Sharpen as a port tool --- Key: LUCENENET-380 URL: https://issues.apache.org/jira/browse/LUCENENET-380 Project: Lucene.Net Issue Type: Task Components: Build Automation, Lucene.Net Contrib, Lucene.Net Core, Lucene.Net Demo, Lucene.Net Test Reporter: George Aroush Assignee: Prescott Nasser Attachments: 3.0.2_JavaToCSharpConverter_AfterPostProcessing.zip, 3.0.2_JavaToCSharpConverter_NoPostProcessing.zip, IndexWriter.java, Lucene.Net.3_0_3_Sharpen20110106.zip, Lucene.Net.Sharpen20101104.zip, Lucene.Net.Sharpen20101114.zip, NIOFSDirectory.java, QueryParser.java, TestBufferedIndexInput.java, TestDateFilter.java This task is to evaluate Sharpen as a port tool for Lucene.Net. The files to be evaluated are attached. We need to run those files (which are off Java Lucene 2.9.2) against Sharpen and compare the result against JLCA result. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira
[Lucene.Net] [jira] Commented: (LUCENENET-380) Evaluate Sharpen as a port tool
[ https://issues.apache.org/jira/browse/LUCENENET-380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12998181#comment-12998181 ] Alex Thompson commented on LUCENENET-380: - I saw db40 did accept a patch from an outside user, but it was a pretty small fix. For our more significant changes a fork is probably better so our progress is not dictated by db4o. Evaluate Sharpen as a port tool --- Key: LUCENENET-380 URL: https://issues.apache.org/jira/browse/LUCENENET-380 Project: Lucene.Net Issue Type: Task Components: Build Automation, Lucene.Net Contrib, Lucene.Net Core, Lucene.Net Demo, Lucene.Net Test Reporter: George Aroush Assignee: Prescott Nasser Attachments: 3.0.2_JavaToCSharpConverter_AfterPostProcessing.zip, 3.0.2_JavaToCSharpConverter_NoPostProcessing.zip, IndexWriter.java, Lucene.Net.3_0_3_Sharpen20110106.zip, Lucene.Net.Sharpen20101104.zip, Lucene.Net.Sharpen20101114.zip, NIOFSDirectory.java, QueryParser.java, TestBufferedIndexInput.java, TestDateFilter.java This task is to evaluate Sharpen as a port tool for Lucene.Net. The files to be evaluated are attached. We need to run those files (which are off Java Lucene 2.9.2) against Sharpen and compare the result against JLCA result. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira
[Lucene.Net] [jira] Commented: (LUCENENET-380) Evaluate Sharpen as a port tool
[ https://issues.apache.org/jira/browse/LUCENENET-380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12998185#comment-12998185 ] Troy Howard commented on LUCENENET-380: --- I guess the best thing to do is to put it to a 72 hour vote on the list. It would cover, generally, using Sharpen for conversion, and by proxy creating and maintaining a non-ASF fork of Sharpen that our process depends on. The ultimate question, of course, is what should we call the fork? ;) Evaluate Sharpen as a port tool --- Key: LUCENENET-380 URL: https://issues.apache.org/jira/browse/LUCENENET-380 Project: Lucene.Net Issue Type: Task Components: Build Automation, Lucene.Net Contrib, Lucene.Net Core, Lucene.Net Demo, Lucene.Net Test Reporter: George Aroush Assignee: Prescott Nasser Attachments: 3.0.2_JavaToCSharpConverter_AfterPostProcessing.zip, 3.0.2_JavaToCSharpConverter_NoPostProcessing.zip, IndexWriter.java, Lucene.Net.3_0_3_Sharpen20110106.zip, Lucene.Net.Sharpen20101104.zip, Lucene.Net.Sharpen20101114.zip, NIOFSDirectory.java, QueryParser.java, TestBufferedIndexInput.java, TestDateFilter.java This task is to evaluate Sharpen as a port tool for Lucene.Net. The files to be evaluated are attached. We need to run those files (which are off Java Lucene 2.9.2) against Sharpen and compare the result against JLCA result. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira
[Lucene.Net] [jira] Commented: (LUCENENET-380) Evaluate Sharpen as a port tool
[ https://issues.apache.org/jira/browse/LUCENENET-380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12998186#comment-12998186 ] Prescott Nasser commented on LUCENENET-380: --- Sharcene, Larpen, LarceneLupen! Evaluate Sharpen as a port tool --- Key: LUCENENET-380 URL: https://issues.apache.org/jira/browse/LUCENENET-380 Project: Lucene.Net Issue Type: Task Components: Build Automation, Lucene.Net Contrib, Lucene.Net Core, Lucene.Net Demo, Lucene.Net Test Reporter: George Aroush Assignee: Prescott Nasser Attachments: 3.0.2_JavaToCSharpConverter_AfterPostProcessing.zip, 3.0.2_JavaToCSharpConverter_NoPostProcessing.zip, IndexWriter.java, Lucene.Net.3_0_3_Sharpen20110106.zip, Lucene.Net.Sharpen20101104.zip, Lucene.Net.Sharpen20101114.zip, NIOFSDirectory.java, QueryParser.java, TestBufferedIndexInput.java, TestDateFilter.java This task is to evaluate Sharpen as a port tool for Lucene.Net. The files to be evaluated are attached. We need to run those files (which are off Java Lucene 2.9.2) against Sharpen and compare the result against JLCA result. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira
Re: [jira] Commented: (LUCENENET-380) Evaluate Sharpen as a port tool
on Mono)
* Iteration problems. if (i.MoveNext()){...} can not be used (in a while
loop) to detect the end of the list.
* Port of TreeSet. TreeSet in Java sorts its contents based on the default
Comparator of the items, but the ArrayList does not.
* Unexpected results when writing custom analyzers. Override
Read,ReadBlock,ReadLine,Peek,ReadToEnd in ReusableStringReader.
* Multi-dimensional arrays: length in java returns the number of
dimensions. In c# Length returns the total number of elements in all
dimensions.
* Copy private fields in the class' Clone method.
* Don't forget: base-36-encoding is used in filenames.
* Use if (dataLen =0 ) instead of if (dataLen == -1) to detect end of
stream.
* Case insensivity. Don't use public names such as text and Text in a
single class (problem for VB users).
* Use ThreadClass in SupportClass.cs instead of System.Threading.Thread
* Use System.Text.Encoding.UTF8 instead of System.Text.Encoding.ASCII
* is already implemented in SupportClass.
* Threshold differences between .NET Java while comparing floats/doubles.
Use also these classes:
* There is a good implementation of WeakHashTable in SupportClass. (needs
Generics)
* There is a very fast LRU cache impl. (SimpleLRUCache). (needs Generics)
PS: This not a complete list and there may be many others from other
contributers of Lucene.Net
DIGY
-Original Message-
From: Peter Mateja [mailto:peter.mat...@gmail.com]
Sent: Friday, January 07, 2011 7:53 PM
To: lucene-net-...@lucene.apache.org
Subject: Re: [jira] Commented: (LUCENENET-380) Evaluate Sharpen as a port
tool
Nice work Alex!
Not that this represents a solution, but I did load up the core source from
your conversion into a VS2010 project, then ran Resharper's code cleanup on
it.
This process took care of all the unused 'using Java.*' references, cleanup
up formatting, etc. However, I'm still seeing a good many things that need
work:
1) ICloseable - IDisposable, including refactoring of the implementation
from Close() to Dispose() (and also considering any additional refactoring
of the Disposable pattern.)
2) IFieldCache is marked as an interface, but has tons of static fields,
subclasses and interfaces. This may be ok in Java, but not in C#. Not
sure
what the best course of action here might be... perhaps create an abstract
base class called FieldCache or FieldCacheBase to house this stuff, and
pull
out the nested classes / interfaces into their own files.
3) Use of a generic WeakReference, which doesn't exist in generic form in
the .Net Framework. This is something which could either be refactored or
implemented as generic.
4) ICloneable interface not implemented (see IndexInput.cs)
5) Unsigned bitwise shift assignment operator doesn't exist in C#. See
IndexOutput.cs, WriteVInt() method. The line i = 7; in java flags an
error in C#. I'm not entirely sure in this case, but I believe this can
safely be converted to: i = 7; in this case, especially given the comment
that negative numbers are not supported.
6) Use of Java DecimalFormat class. An appropriate .Net replacement should
be easily substituted with some refactoring of the code.
7) Use of Runtime.IdentityHashCode(). Not sure how necessary this is.
8) Java specific value type parsing calls should be refactored to .Net
(e.g.
double.ParseDouble() = double.Parse())
9) Use of the java ReadResolve() object serialization pattern needs to be
analyzed / refactored (see FieldCache.DefaultByteParser (or in the
translated version, IFieldCache._IByteParser)).
10) Use of Sharpen references.
11) Use of Java's NumberFormatException... should be refactored to use an
appropriate standard exception type (perhaps FormatException, though I'm
not
sure this is appropriate) or create an internal Exception class for this
case.
There's plenty more build issues... I need to put this down for the rest of
the day, so I thought I'd at least get this out to the list.
Peter Mateja
peter.mat...@gmail.com
On Fri, Jan 7, 2011 at 9:34 AM, Neal Granroth (JIRA) j...@apache.org
wrote:
[
https://issues.apache.org/jira/browse/LUCENENET-380?page=com.atlassian.jira
.
plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12978816#acti
on_12978816]
Neal Granroth commented on LUCENENET-380:
-
Thanks Alex,
What would be the plan for handling the Sharpen artifacts that prevent
the
converted code from being built by the .NET SDK compiler?
Do you envision a post-conversion script to strip out statements like:
using Java.Lang
using Java.IO
and replace Sharpen-specific classes with standard .NET classes:
Sharpen.Collections.*
Sharpen.Runtime.*
Evaluate Sharpen as a port tool
---
Key: LUCENENET-380
URL:
https://issues.apache.org/jira/browse/LUCENENET-380
Project
[jira] Commented: (LUCENENET-380) Evaluate Sharpen as a port tool
[ https://issues.apache.org/jira/browse/LUCENENET-380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12978816#action_12978816 ] Neal Granroth commented on LUCENENET-380: - Thanks Alex, What would be the plan for handling the Sharpen artifacts that prevent the converted code from being built by the .NET SDK compiler? Do you envision a post-conversion script to strip out statements like: using Java.Lang using Java.IO and replace Sharpen-specific classes with standard .NET classes: Sharpen.Collections.* Sharpen.Runtime.* Evaluate Sharpen as a port tool --- Key: LUCENENET-380 URL: https://issues.apache.org/jira/browse/LUCENENET-380 Project: Lucene.Net Issue Type: Task Reporter: George Aroush Attachments: 3.0.2_JavaToCSharpConverter_AfterPostProcessing.zip, 3.0.2_JavaToCSharpConverter_NoPostProcessing.zip, IndexWriter.java, Lucene.Net.3_0_3_Sharpen20110106.zip, Lucene.Net.Sharpen20101104.zip, Lucene.Net.Sharpen20101114.zip, NIOFSDirectory.java, QueryParser.java, TestBufferedIndexInput.java, TestDateFilter.java This task is to evaluate Sharpen as a port tool for Lucene.Net. The files to be evaluated are attached. We need to run those files (which are off Java Lucene 2.9.2) against Sharpen and compare the result against JLCA result. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (LUCENENET-380) Evaluate Sharpen as a port tool
[ https://issues.apache.org/jira/browse/LUCENENET-380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12978878#action_12978878 ] Alex Thompson commented on LUCENENET-380: - Ideally I think the goal would be to modify sharpen till it outputs buildable C# with no pre/post. Sharpen is build on the abstract syntax tree components of Eclipse so it seems pretty workable. Evaluate Sharpen as a port tool --- Key: LUCENENET-380 URL: https://issues.apache.org/jira/browse/LUCENENET-380 Project: Lucene.Net Issue Type: Task Reporter: George Aroush Attachments: 3.0.2_JavaToCSharpConverter_AfterPostProcessing.zip, 3.0.2_JavaToCSharpConverter_NoPostProcessing.zip, IndexWriter.java, Lucene.Net.3_0_3_Sharpen20110106.zip, Lucene.Net.Sharpen20101104.zip, Lucene.Net.Sharpen20101114.zip, NIOFSDirectory.java, QueryParser.java, TestBufferedIndexInput.java, TestDateFilter.java This task is to evaluate Sharpen as a port tool for Lucene.Net. The files to be evaluated are attached. We need to run those files (which are off Java Lucene 2.9.2) against Sharpen and compare the result against JLCA result. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
Re: [jira] Commented: (LUCENENET-380) Evaluate Sharpen as a port tool
Nice work Alex! Not that this represents a solution, but I did load up the core source from your conversion into a VS2010 project, then ran Resharper's code cleanup on it. This process took care of all the unused 'using Java.*' references, cleanup up formatting, etc. However, I'm still seeing a good many things that need work: 1) ICloseable - IDisposable, including refactoring of the implementation from Close() to Dispose() (and also considering any additional refactoring of the Disposable pattern.) 2) IFieldCache is marked as an interface, but has tons of static fields, subclasses and interfaces. This may be ok in Java, but not in C#. Not sure what the best course of action here might be... perhaps create an abstract base class called FieldCache or FieldCacheBase to house this stuff, and pull out the nested classes / interfaces into their own files. 3) Use of a generic WeakReference, which doesn't exist in generic form in the .Net Framework. This is something which could either be refactored or implemented as generic. 4) ICloneable interface not implemented (see IndexInput.cs) 5) Unsigned bitwise shift assignment operator doesn't exist in C#. See IndexOutput.cs, WriteVInt() method. The line i = 7; in java flags an error in C#. I'm not entirely sure in this case, but I believe this can safely be converted to: i = 7; in this case, especially given the comment that negative numbers are not supported. 6) Use of Java DecimalFormat class. An appropriate .Net replacement should be easily substituted with some refactoring of the code. 7) Use of Runtime.IdentityHashCode(). Not sure how necessary this is. 8) Java specific value type parsing calls should be refactored to .Net (e.g. double.ParseDouble() = double.Parse()) 9) Use of the java ReadResolve() object serialization pattern needs to be analyzed / refactored (see FieldCache.DefaultByteParser (or in the translated version, IFieldCache._IByteParser)). 10) Use of Sharpen references. 11) Use of Java's NumberFormatException... should be refactored to use an appropriate standard exception type (perhaps FormatException, though I'm not sure this is appropriate) or create an internal Exception class for this case. There's plenty more build issues... I need to put this down for the rest of the day, so I thought I'd at least get this out to the list. Peter Mateja peter.mat...@gmail.com On Fri, Jan 7, 2011 at 9:34 AM, Neal Granroth (JIRA) j...@apache.orgwrote: [ https://issues.apache.org/jira/browse/LUCENENET-380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12978816#action_12978816] Neal Granroth commented on LUCENENET-380: - Thanks Alex, What would be the plan for handling the Sharpen artifacts that prevent the converted code from being built by the .NET SDK compiler? Do you envision a post-conversion script to strip out statements like: using Java.Lang using Java.IO and replace Sharpen-specific classes with standard .NET classes: Sharpen.Collections.* Sharpen.Runtime.* Evaluate Sharpen as a port tool --- Key: LUCENENET-380 URL: https://issues.apache.org/jira/browse/LUCENENET-380 Project: Lucene.Net Issue Type: Task Reporter: George Aroush Attachments: 3.0.2_JavaToCSharpConverter_AfterPostProcessing.zip, 3.0.2_JavaToCSharpConverter_NoPostProcessing.zip, IndexWriter.java, Lucene.Net.3_0_3_Sharpen20110106.zip, Lucene.Net.Sharpen20101104.zip, Lucene.Net.Sharpen20101114.zip, NIOFSDirectory.java, QueryParser.java, TestBufferedIndexInput.java, TestDateFilter.java This task is to evaluate Sharpen as a port tool for Lucene.Net. The files to be evaluated are attached. We need to run those files (which are off Java Lucene 2.9.2) against Sharpen and compare the result against JLCA result. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
Re: [jira] Commented: (LUCENENET-380) Evaluate Sharpen as a port tool
Ideally I think the goal would be to modify sharpen till it outputs buildable C# with no pre/post. so basically a fork of the sharpen code base? On Fri, Jan 7, 2011 at 12:37 PM, Alex Thompson (JIRA) j...@apache.orgwrote: [ https://issues.apache.org/jira/browse/LUCENENET-380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12978878#action_12978878] Alex Thompson commented on LUCENENET-380: - Ideally I think the goal would be to modify sharpen till it outputs buildable C# with no pre/post. Sharpen is build on the abstract syntax tree components of Eclipse so it seems pretty workable. Evaluate Sharpen as a port tool --- Key: LUCENENET-380 URL: https://issues.apache.org/jira/browse/LUCENENET-380 Project: Lucene.Net Issue Type: Task Reporter: George Aroush Attachments: 3.0.2_JavaToCSharpConverter_AfterPostProcessing.zip, 3.0.2_JavaToCSharpConverter_NoPostProcessing.zip, IndexWriter.java, Lucene.Net.3_0_3_Sharpen20110106.zip, Lucene.Net.Sharpen20101104.zip, Lucene.Net.Sharpen20101114.zip, NIOFSDirectory.java, QueryParser.java, TestBufferedIndexInput.java, TestDateFilter.java This task is to evaluate Sharpen as a port tool for Lucene.Net. The files to be evaluated are attached. We need to run those files (which are off Java Lucene 2.9.2) against Sharpen and compare the result against JLCA result. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. -- Michael Herndon Senior Developer (mhern...@o19s.com) 804.767.0083 [connect online] http://www.opensourceconnections.com http://www.amptools.net http://www.linkedin.com/pub/michael-herndon/4/893/23 http://www.facebook.com/amptools.net http://www.twitter.com/amptools-net
RE: [jira] Commented: (LUCENENET-380) Evaluate Sharpen as a port tool
We could contribute back to db4o's sharpen trunk. It appears they do patch it periodically. Or depending on the changes a fork might be more appropriate. Date: Fri, 7 Jan 2011 13:07:29 -0500 Subject: Re: [jira] Commented: (LUCENENET-380) Evaluate Sharpen as a port tool From: mhern...@o19s.com To: lucene-net-...@lucene.apache.org Ideally I think the goal would be to modify sharpen till it outputs buildable C# with no pre/post. so basically a fork of the sharpen code base? On Fri, Jan 7, 2011 at 12:37 PM, Alex Thompson (JIRA) j...@apache.orgwrote: [ https://issues.apache.org/jira/browse/LUCENENET-380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12978878#action_12978878] Alex Thompson commented on LUCENENET-380: - Ideally I think the goal would be to modify sharpen till it outputs buildable C# with no pre/post. Sharpen is build on the abstract syntax tree components of Eclipse so it seems pretty workable. Evaluate Sharpen as a port tool --- Key: LUCENENET-380 URL: https://issues.apache.org/jira/browse/LUCENENET-380 Project: Lucene.Net Issue Type: Task Reporter: George Aroush Attachments: 3.0.2_JavaToCSharpConverter_AfterPostProcessing.zip, 3.0.2_JavaToCSharpConverter_NoPostProcessing.zip, IndexWriter.java, Lucene.Net.3_0_3_Sharpen20110106.zip, Lucene.Net.Sharpen20101104.zip, Lucene.Net.Sharpen20101114.zip, NIOFSDirectory.java, QueryParser.java, TestBufferedIndexInput.java, TestDateFilter.java This task is to evaluate Sharpen as a port tool for Lucene.Net. The files to be evaluated are attached. We need to run those files (which are off Java Lucene 2.9.2) against Sharpen and compare the result against JLCA result. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. -- Michael Herndon Senior Developer (mhern...@o19s.com) 804.767.0083 [connect online] http://www.opensourceconnections.com http://www.amptools.net http://www.linkedin.com/pub/michael-herndon/4/893/23 http://www.facebook.com/amptools.net http://www.twitter.com/amptools-net
[jira] Commented: (LUCENENET-380) Evaluate Sharpen as a port tool
[ https://issues.apache.org/jira/browse/LUCENENET-380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12969427#action_12969427 ] Neal Granroth commented on LUCENENET-380: - I had looked them over several weeks ago, but had no additional comment than the one you'd made about needing to find a way to eliminate conversions which make use of Sharpen-specific classes. Hopefully others with a larger stake than I in keeping the project alive will chime in. Evaluate Sharpen as a port tool --- Key: LUCENENET-380 URL: https://issues.apache.org/jira/browse/LUCENENET-380 Project: Lucene.Net Issue Type: Task Reporter: George Aroush Attachments: 3.0.2_JavaToCSharpConverter_AfterPostProcessing.zip, 3.0.2_JavaToCSharpConverter_NoPostProcessing.zip, IndexWriter.java, Lucene.Net.Sharpen20101104.zip, Lucene.Net.Sharpen20101114.zip, NIOFSDirectory.java, QueryParser.java, TestBufferedIndexInput.java, TestDateFilter.java This task is to evaluate Sharpen as a port tool for Lucene.Net. The files to be evaluated are attached. We need to run those files (which are off Java Lucene 2.9.2) against Sharpen and compare the result against JLCA result. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (LUCENENET-380) Evaluate Sharpen as a port tool
[ https://issues.apache.org/jira/browse/LUCENENET-380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12935831#action_12935831 ] Prescott Nasser commented on LUCENENET-380: --- Alex, did you do any post processing to clean up the files? or just the pre processing? Evaluate Sharpen as a port tool --- Key: LUCENENET-380 URL: https://issues.apache.org/jira/browse/LUCENENET-380 Project: Lucene.Net Issue Type: Task Reporter: George Aroush Attachments: 3.0.2_JavaToCSharpConverter_AfterPostProcessing.zip, 3.0.2_JavaToCSharpConverter_NoPostProcessing.zip, IndexWriter.java, Lucene.Net.Sharpen20101104.zip, Lucene.Net.Sharpen20101114.zip, NIOFSDirectory.java, QueryParser.java, TestBufferedIndexInput.java, TestDateFilter.java This task is to evaluate Sharpen as a port tool for Lucene.Net. The files to be evaluated are attached. We need to run those files (which are off Java Lucene 2.9.2) against Sharpen and compare the result against JLCA result. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (LUCENENET-380) Evaluate Sharpen as a port tool
[ https://issues.apache.org/jira/browse/LUCENENET-380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12935845#action_12935845 ] Prescott Nasser commented on LUCENENET-380: --- Aaron any chance you can run 2.9.2 through JavaToCSharp converter? so we have those files to compare, rather than the 3.0.2 ones? Evaluate Sharpen as a port tool --- Key: LUCENENET-380 URL: https://issues.apache.org/jira/browse/LUCENENET-380 Project: Lucene.Net Issue Type: Task Reporter: George Aroush Attachments: 3.0.2_JavaToCSharpConverter_AfterPostProcessing.zip, 3.0.2_JavaToCSharpConverter_NoPostProcessing.zip, IndexWriter.java, Lucene.Net.Sharpen20101104.zip, Lucene.Net.Sharpen20101114.zip, NIOFSDirectory.java, QueryParser.java, TestBufferedIndexInput.java, TestDateFilter.java This task is to evaluate Sharpen as a port tool for Lucene.Net. The files to be evaluated are attached. We need to run those files (which are off Java Lucene 2.9.2) against Sharpen and compare the result against JLCA result. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (LUCENENET-380) Evaluate Sharpen as a port tool
[ https://issues.apache.org/jira/browse/LUCENENET-380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12935851#action_12935851 ] Alex Thompson commented on LUCENENET-380: - its the raw output, no post processing. Evaluate Sharpen as a port tool --- Key: LUCENENET-380 URL: https://issues.apache.org/jira/browse/LUCENENET-380 Project: Lucene.Net Issue Type: Task Reporter: George Aroush Attachments: 3.0.2_JavaToCSharpConverter_AfterPostProcessing.zip, 3.0.2_JavaToCSharpConverter_NoPostProcessing.zip, IndexWriter.java, Lucene.Net.Sharpen20101104.zip, Lucene.Net.Sharpen20101114.zip, NIOFSDirectory.java, QueryParser.java, TestBufferedIndexInput.java, TestDateFilter.java This task is to evaluate Sharpen as a port tool for Lucene.Net. The files to be evaluated are attached. We need to run those files (which are off Java Lucene 2.9.2) against Sharpen and compare the result against JLCA result. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (LUCENENET-380) Evaluate Sharpen as a port tool
[
https://issues.apache.org/jira/browse/LUCENENET-380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12935856#action_12935856
]
Prescott Nasser commented on LUCENENET-380:
---
IndexWriter.java to IndexWriter.cs (Sharpen) - thoughts and observations
Some generic comments:
1. Some comments that are nexted withint methods and functions get moved
around. Some are merged with the summaries of the next function, not a big deal
2. With asserts commented out BEFORE the conversion, sometimes they get moved
to incorrect places (part of 1).
Check out lines 3224(java) and 4242(.cs). This shoudln't be to hard to
diagnose, once we determine how we are going to
convert assert to .net, we can do a quick search for assert to find these
kinds of things
3. Sharpen libraries show up a few places - my intuition says that we need to
get rid of those? Am I correct on that?
3. formatting needs some work imo
4. The CS - SetDiagnostics(...) just feels wrong :) -
diagnostics[java.vendor] = ..
I think the biggest question in my head is how do we deal with the asserts -
the rest seems ok to me.
Specifics:
IndexWriter.java
line 506: final int numSegments = infos.size();
IndexWriter.cs
line 622: int numSegments = infos.Count;
Is this missing a final? (does it matter?) This happens in a number of places.
IndexWriter.java
line 786: notifyAll();
IndexWriter.cs
line 1018: Sharpen.Runtime.NotifyAll(this);
Why is Sharpen referenced here? Is this just part of the assertion stuff? I
don't think
we want to have this line in the final build.
IndexWriter.java
line 789: synchronized final boolean isOpen(boolean includePendingClose) {
IndexWriter.cs
line 1022: internal bool IsOpen(bool includePendingClose)
The method declaration is fine - the question I have is in the implimentation,
for c# it
uses the lock (this) to replace the synchronized java keyword - but then it's
statment is:
return !(closed || (includePendingClose closing));
In other cases, it would be this.closed, and this.closing (or
this._enclosing.closed)..
this shows up a number of other places. It's likely my misunderstanding of how
locking works
in c#, but wouldn't we want the this. infront of those?
This happens in a few places
IndexWriter.java
line 1575: synced.addAll(segmentInfos.files(directory, true));
IndexWriter.cs
line 2102: Sharpen.Collections.AddAll(synced,
segmentInfos.Files(directory, true));
Again we reference Sharpen here - I'm not sure why, but my intuition says this
is not what we want.
(search on Sharpen. turns this up a number of places)
Evaluate Sharpen as a port tool
---
Key: LUCENENET-380
URL: https://issues.apache.org/jira/browse/LUCENENET-380
Project: Lucene.Net
Issue Type: Task
Reporter: George Aroush
Attachments: 3.0.2_JavaToCSharpConverter_AfterPostProcessing.zip,
3.0.2_JavaToCSharpConverter_NoPostProcessing.zip, IndexWriter.java,
Lucene.Net.Sharpen20101104.zip, Lucene.Net.Sharpen20101114.zip,
NIOFSDirectory.java, QueryParser.java, TestBufferedIndexInput.java,
TestDateFilter.java
This task is to evaluate Sharpen as a port tool for Lucene.Net.
The files to be evaluated are attached. We need to run those files (which
are off Java Lucene 2.9.2) against Sharpen and compare the result against
JLCA result.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (LUCENENET-380) Evaluate Sharpen as a port tool
[ https://issues.apache.org/jira/browse/LUCENENET-380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12930554#action_12930554 ] Alex Thompson commented on LUCENENET-380: - The sharpen files I put up are not a full port. Sharpen stops when it finds something you didn't give it a mapping for. What's there is an initial config that converts a few files and needs to be extended. Evaluate Sharpen as a port tool --- Key: LUCENENET-380 URL: https://issues.apache.org/jira/browse/LUCENENET-380 Project: Lucene.Net Issue Type: Task Reporter: George Aroush Attachments: 3.0.2_JavaToCSharpConverter_AfterPostProcessing.zip, 3.0.2_JavaToCSharpConverter_NoPostProcessing.zip, IndexWriter.java, Lucene.Net.Sharpen20101104.zip, NIOFSDirectory.java, QueryParser.java, TestBufferedIndexInput.java, TestDateFilter.java This task is to evaluate Sharpen as a port tool for Lucene.Net. The files to be evaluated are attached. We need to run those files (which are off Java Lucene 2.9.2) against Sharpen and compare the result against JLCA result. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (LUCENENET-380) Evaluate Sharpen as a port tool
[ https://issues.apache.org/jira/browse/LUCENENET-380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12929525#action_12929525 ] Aaron Powell commented on LUCENENET-380: I've started off the wiki over at bitbucket - http://hg.slace.biz/lucene-porting/wiki/Home It's also just a mercurial repo so anyone can update it and send back pull requests: http://hg.slace.biz/lucene-porting/wiki Evaluate Sharpen as a port tool --- Key: LUCENENET-380 URL: https://issues.apache.org/jira/browse/LUCENENET-380 Project: Lucene.Net Issue Type: Task Reporter: George Aroush Attachments: IndexWriter.java, NIOFSDirectory.java, QueryParser.java, TestBufferedIndexInput.java, TestDateFilter.java This task is to evaluate Sharpen as a port tool for Lucene.Net. The files to be evaluated are attached. We need to run those files (which are off Java Lucene 2.9.2) against Sharpen and compare the result against JLCA result. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (LUCENENET-380) Evaluate Sharpen as a port tool
[ https://issues.apache.org/jira/browse/LUCENENET-380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12929567#action_12929567 ] George Aroush commented on LUCENENET-380: - Few points: 1) Work on ASF projects need to be done at ASF. Please use this JIRA issue and the mailing list to communicate questions, report progress and results. 2) The converted files need to be attached to this JIRA issue, so we have a record of it and able to evaluate by all. 3) Prescott point of highlighting pre / post processing work is a good one and important. Please write this up as you work on this task. 4) More than one person can work on this JIRA issue, just keep everyone posted. My expected outcome of this JIRA issue is: 1) What pre / post processing did you use if any? It would also help to show the raw output with and without the pre processing. 2) How close is the result of those 5 attached files to the existing converted C# files? This includes the layout of the code (was anything lost or considerably change?) but most importantly, are the public APIs consistent? The reason why I picked those 5 files is because those are the ones JLCA has some of the most issues with, so it should be a good barometer seeing how Sharpen does. Evaluate Sharpen as a port tool --- Key: LUCENENET-380 URL: https://issues.apache.org/jira/browse/LUCENENET-380 Project: Lucene.Net Issue Type: Task Reporter: George Aroush Attachments: IndexWriter.java, NIOFSDirectory.java, QueryParser.java, TestBufferedIndexInput.java, TestDateFilter.java This task is to evaluate Sharpen as a port tool for Lucene.Net. The files to be evaluated are attached. We need to run those files (which are off Java Lucene 2.9.2) against Sharpen and compare the result against JLCA result. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (LUCENENET-380) Evaluate Sharpen as a port tool
[ https://issues.apache.org/jira/browse/LUCENENET-380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12929725#action_12929725 ] Aaron Powell commented on LUCENENET-380: George, The reason I spun up the external repo is so that it's easy to track changes and have a collaborative effort trying to find the right tool for the job. Can we spin up a repo under the ASF so we can collaboratively work on a solution? Evaluate Sharpen as a port tool --- Key: LUCENENET-380 URL: https://issues.apache.org/jira/browse/LUCENENET-380 Project: Lucene.Net Issue Type: Task Reporter: George Aroush Attachments: IndexWriter.java, Lucene.Net.Sharpen20101104.zip, NIOFSDirectory.java, QueryParser.java, TestBufferedIndexInput.java, TestDateFilter.java This task is to evaluate Sharpen as a port tool for Lucene.Net. The files to be evaluated are attached. We need to run those files (which are off Java Lucene 2.9.2) against Sharpen and compare the result against JLCA result. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (LUCENENET-380) Evaluate Sharpen as a port tool
[ https://issues.apache.org/jira/browse/LUCENENET-380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12929768#action_12929768 ] Mauricio Scheffer commented on LUCENENET-380: - @Aaron Powell: the ASF has official Git mirrors at github, see https://github.com/apache/lucene.net It's outdated so there seems to be a problem with the ASF sync, I'd notify the ASF infrastructure team about it. See also http://www.apache.org/dev/git.html Evaluate Sharpen as a port tool --- Key: LUCENENET-380 URL: https://issues.apache.org/jira/browse/LUCENENET-380 Project: Lucene.Net Issue Type: Task Reporter: George Aroush Attachments: IndexWriter.java, Lucene.Net.Sharpen20101104.zip, NIOFSDirectory.java, QueryParser.java, TestBufferedIndexInput.java, TestDateFilter.java This task is to evaluate Sharpen as a port tool for Lucene.Net. The files to be evaluated are attached. We need to run those files (which are off Java Lucene 2.9.2) against Sharpen and compare the result against JLCA result. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
