[
https://issues.apache.org/jira/browse/LUCENE-2790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12966108#action_12966108
]
Earwin Burrfoot edited comment on LUCENE-2790 at 12/2/10 8:12 AM:
--
Check this patch out.
It changes useCompoundFile(SIS, SI) to respect noCFSRatio and drops
useCompoundFile from OneMerge, so all decisions about using compound files now
happen in a single place.
It also highlights the problem with your patch - when calling useCompoundFile
from addIndexes, you should hold a lock, so segmentInfos won't be modified
while mergePolicy inspects them.
was (Author: earwin):
Check this patch out.
It moves noCFS ratio to useCompoundFile(SIS, SI) and drops useCompoundFile from
OneMerge, so all decisions about using compound files now happen in a single
place.
It also highlights the problem with your patch - when calling useCompoundFile
from addIndexes, you should hold a lock, so segmentInfos won't be modified
while mergePolicy inspects them.
IndexWriter should call MP.useCompoundFile and not LogMP.getUseCompoundFile
---
Key: LUCENE-2790
URL: https://issues.apache.org/jira/browse/LUCENE-2790
Project: Lucene - Java
Issue Type: Improvement
Components: Index
Reporter: Shai Erera
Assignee: Shai Erera
Priority: Minor
Fix For: 3.1, 4.0
Attachments: LUCENE-2790.patch, LUCENE-2790.patch
Spin off from here:
http://www.gossamer-threads.com/lists/lucene/java-dev/112311.
I will attach a patch shortly that addresses the issue on trunk.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
