[ https://issues.apache.org/jira/browse/LUCENE-2830?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Shai Erera resolved LUCENE-2830. -------------------------------- Resolution: Fixed Committed revision 1052180 (3x). Committed revision 1052182 (trunk). > Use StringBuilder instead of StringBuffer in benchmark > ------------------------------------------------------ > > Key: LUCENE-2830 > URL: https://issues.apache.org/jira/browse/LUCENE-2830 > Project: Lucene - Java > Issue Type: Improvement > Components: contrib/benchmark > Reporter: Shai Erera > Assignee: Shai Erera > Priority: Minor > Fix For: 3.1, 4.0 > > Attachments: LUCENE-2830.patch, LUCENE-2830.patch > > > Minor change - use StringBuilder instead of StringBuffer in benchmark's code. > We don't need the synchronization of StringBuffer in all the places that I've > checked. > The only place where it _could_ be a problem is in HtmlParser's API - one > method accepts a StringBuffer and it's an interface. But I think it's ok to > change benchmark's API, back-compat wise and so I'd like to either change it > to accept a String, or remove the method altogether -- no code in benchmark > uses it, and if anyone needs it, he can pass StringReader to the other method. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org