[jira] Updated: (LUCENE-2815) MultiFields not thread safe

2010-12-16 Thread Michael McCandless (JIRA)

 [ 
https://issues.apache.org/jira/browse/LUCENE-2815?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael McCandless updated LUCENE-2815:
---

Fix Version/s: 4.0

> MultiFields not thread safe
> ---
>
> Key: LUCENE-2815
> URL: https://issues.apache.org/jira/browse/LUCENE-2815
> Project: Lucene - Java
>  Issue Type: Bug
>Affects Versions: 4.0
>Reporter: Yonik Seeley
> Fix For: 4.0
>
>
> MultiFields looks like it has thread safety issues

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org



[jira] Updated: (LUCENE-2815) MultiFields not thread safe

2010-12-16 Thread Yonik Seeley (JIRA)

 [ 
https://issues.apache.org/jira/browse/LUCENE-2815?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Yonik Seeley updated LUCENE-2815:
-

Attachment: LUCENE-2815.patch

Here's a patch that uses a ConcurrentHashMap for the Terms cache, and makes 
IndexReader.fields volatile.

That IndexReader.fields variable is just the type of stuff that could just be 
stored in a generic cache on the IndexReader, if/when we get something like 
that.

> MultiFields not thread safe
> ---
>
> Key: LUCENE-2815
> URL: https://issues.apache.org/jira/browse/LUCENE-2815
> Project: Lucene - Java
>  Issue Type: Bug
>Affects Versions: 4.0
>Reporter: Yonik Seeley
> Fix For: 4.0
>
> Attachments: LUCENE-2815.patch
>
>
> MultiFields looks like it has thread safety issues

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org



[jira] Updated: (LUCENE-2815) MultiFields not thread safe

2010-12-17 Thread Yonik Seeley (JIRA)

 [ 
https://issues.apache.org/jira/browse/LUCENE-2815?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Yonik Seeley updated LUCENE-2815:
-

Attachment: LUCENE-2815.patch

Here's an updated patch that avoids containsKey() followed by get() (just an 
optimization)
and avoids caching null Terms instances.  This is the right thing to do anyway, 
since one could easily blow up the cache with fields that don't exist.

> MultiFields not thread safe
> ---
>
> Key: LUCENE-2815
> URL: https://issues.apache.org/jira/browse/LUCENE-2815
> Project: Lucene - Java
>  Issue Type: Bug
>Affects Versions: 4.0
>Reporter: Yonik Seeley
> Fix For: 4.0
>
> Attachments: LUCENE-2815.patch, LUCENE-2815.patch
>
>
> MultiFields looks like it has thread safety issues

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org