[jira] [Updated] (SOLR-2331) Refactor CoreContainer's SolrXML serialization code and improve testing
[
https://issues.apache.org/jira/browse/SOLR-2331?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Steven Rowe updated SOLR-2331:
--
Attachment: SOLR-2331-fix-windows-file-deletion-failure.patch
I reopened SOLR-2500 because TestSolrProperties is failing consistently on
Windows 7/Oracle JDK 1.6.0_21 for me, but it appears that this is the issue
that introduced the problem.
I've tracked the issue down to the anonymous {{FileInputStream}} created in
order to print out the contents of the persisted core configuration to STDOUT
-- the following line was uncommented when Mark committed the patch on this
issue:
{code:java}
206: System.out.println(IOUtils.toString(new FileInputStream(new
File(solrXml.getParent(), solr-persist.xml;
{code}
This patch de-anonymizes the {{FileInputStream}} and closes it after the file
contents are printed out.
I plan to commit this later tonight.
Refactor CoreContainer's SolrXML serialization code and improve testing
---
Key: SOLR-2331
URL: https://issues.apache.org/jira/browse/SOLR-2331
Project: Solr
Issue Type: Improvement
Components: multicore
Reporter: Mark Miller
Assignee: Mark Miller
Priority: Minor
Fix For: 4.0
Attachments: SOLR-2331-fix-windows-file-deletion-failure.patch,
SOLR-2331.patch
CoreContainer has enough code in it - I'd like to factor out the solr.xml
serialization code into SolrXMLSerializer or something - which should make
testing it much easier and lightweight.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-2331) Refactor CoreContainer's SolrXML serialization code and improve testing
[
https://issues.apache.org/jira/browse/SOLR-2331?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Steven Rowe updated SOLR-2331:
--
Attachment: SOLR-2331-fix-windows-file-deletion-failure.patch
This version of the patch wraps the persisted core config printing to STDOUT in
an {{if (VERBOSE)}} block.
Committing shortly.
Refactor CoreContainer's SolrXML serialization code and improve testing
---
Key: SOLR-2331
URL: https://issues.apache.org/jira/browse/SOLR-2331
Project: Solr
Issue Type: Improvement
Components: multicore
Reporter: Mark Miller
Assignee: Mark Miller
Priority: Minor
Fix For: 4.0
Attachments: SOLR-2331-fix-windows-file-deletion-failure.patch,
SOLR-2331-fix-windows-file-deletion-failure.patch, SOLR-2331.patch
CoreContainer has enough code in it - I'd like to factor out the solr.xml
serialization code into SolrXMLSerializer or something - which should make
testing it much easier and lightweight.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] Updated: (SOLR-2331) Refactor CoreContainer's SolrXML serialization code and improve testing
[ https://issues.apache.org/jira/browse/SOLR-2331?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Miller updated SOLR-2331: -- Attachment: SOLR-2331.patch Here is a first pass - more to come. Refactor CoreContainer's SolrXML serialization code and improve testing --- Key: SOLR-2331 URL: https://issues.apache.org/jira/browse/SOLR-2331 Project: Solr Issue Type: Improvement Components: multicore Reporter: Mark Miller Assignee: Mark Miller Priority: Minor Fix For: 4.0 Attachments: SOLR-2331.patch CoreContainer has enough code in it - I'd like to factor out the solr.xml serialization code into SolrXMLSerializer or something - which should make testing it much easier and lightweight. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
