Re: [lucene-solr] branch branch_8x updated: SOLR-14066: Deprecate DIH

2020-07-02 Thread Ishan Chattopadhyaya
Fixed, apologies. Didn't want enough and compile with JDK8 to test before
push. Lesson for next time.

On Thu, 2 Jul, 2020, 10:42 pm Andrzej Białecki,  wrote:

> This breaks branch_8x for me - Java 8 doesn’t recognise the “since”
> attribute in @Deprecated.
>
> > On 2 Jul 2020, at 13:10, is...@apache.org wrote:
> >
> > This is an automated email from the ASF dual-hosted git repository.
> >
> > ishan pushed a commit to branch branch_8x
> > in repository https://gitbox.apache.org/repos/asf/lucene-solr.git
> >
> >
> > The following commit(s) were added to refs/heads/branch_8x by this push:
> > new 755d31c  SOLR-14066: Deprecate DIH
> > 755d31c is described below
> >
> > commit 755d31c4933a5b9bb8e39e5e9fb50b17934ff336
> > Author: Ishan Chattopadhyaya 
> > AuthorDate: Thu Jul 2 16:38:31 2020 +0530
> >
> >SOLR-14066: Deprecate DIH
> > ---
> > solr/CHANGES.txt | 7
> +--
> > solr/contrib/dataimporthandler-extras/src/java/overview.html | 2 +-
> > solr/contrib/dataimporthandler/README.txt| 9
> +
> > .../org/apache/solr/handler/dataimport/DataImportHandler.java| 3 +++
> > solr/contrib/dataimporthandler/src/java/overview.html| 2 +-
> > solr/example/example-DIH/README.txt  | 2 ++
> > solr/solr-ref-guide/src/dataimport-screen.adoc   | 2 ++
> > solr/solr-ref-guide/src/solr-upgrade-notes.adoc  | 3 +++
> > ...-structured-data-store-data-with-the-data-import-handler.adoc | 2 ++
> > solr/webapp/web/css/angular/dataimport.css   | 3 ++-
> > solr/webapp/web/partials/dataimport.html | 1 +
> > 11 files changed, 31 insertions(+), 5 deletions(-)
> >
> > diff --git a/solr/CHANGES.txt b/solr/CHANGES.txt
> > index 59d1972..a0bdcd4 100644
> > --- a/solr/CHANGES.txt
> > +++ b/solr/CHANGES.txt
> > @@ -351,6 +351,9 @@ Other Changes
> >
> > * SOLR-14022: Deprecate CDCR (Joel Bernstein, Ishan Chattopadhyaya)
> >
> > +* SOLR-14066: Data Import Handler is deprecated. It is scheduled to be
> removed as of 9.0 and a community supported
> > +  package for the same may now be used instead. (Ishan Chattopadhyaya,
> janhoy)
> > +
> > ==  8.5.2 ==
> >
> > Consult the LUCENE_CHANGES.txt file for additional, low level, changes
> in this release.
> > @@ -6941,8 +6944,8 @@ Other Changes
> >   (David Smiley)
> >
> > * SOLR-8842: security rules made more foolproof by asking the
> requesthandler  about the well known
> > -  permission name.
> >  The APIs are also modified to ue 'index' as the unique identifier
> instead of name.
> > -  Name is an optional attribute
> >  now and only to be used when specifying well-known permissions (noble)
> > +  permission name.  The APIs are also modified to ue 'index' as the
> unique identifier instead of name.
> > +  Name is an optional attribute  now and only to be used when
> specifying well-known permissions (noble)
> >
> > * SOLR-5616: Simplifies grouping code to use
> ResponseBuilder.needDocList() to determine if it needs to
> >   generate a doc list for grouped results. (Steven Bower, Keith Laban,
> Dennis Gove)
> > diff --git
> a/solr/contrib/dataimporthandler-extras/src/java/overview.html
> b/solr/contrib/dataimporthandler-extras/src/java/overview.html
> > index a60a25e..5a55432 100644
> > --- a/solr/contrib/dataimporthandler-extras/src/java/overview.html
> > +++ b/solr/contrib/dataimporthandler-extras/src/java/overview.html
> > @@ -16,6 +16,6 @@
> > -->
> > 
> > 
> > -Apache Solr Search Server: DataImportHandler Extras contrib
> > +Apache Solr Search Server: DataImportHandler Extras contrib. This
> contrib module is deprecated as of 8.6
> > 
> > 
> > diff --git a/solr/contrib/dataimporthandler/README.txt
> b/solr/contrib/dataimporthandler/README.txt
> > index c969872..1d78b93 100644
> > --- a/solr/contrib/dataimporthandler/README.txt
> > +++ b/solr/contrib/dataimporthandler/README.txt
> > @@ -14,3 +14,12 @@ running Solr you set the following system properties:
> >   -Duser.language=xx -Duser.country=YY -Duser.timezone=ZZZ
> >
> > where xx, YY, and ZZZ are consistent with any database server's
> configuration.
> > +
> > +Deprecation notice
> > +--
> > +This contrib module is deprecated as of v8.6, scheduled for removal in
> Solr 9.0.
> > +The reason is that DIH is no longer being maintained in a manner we
> feel is necessary in order to keep it
> > +healthy and secure. Also it was not designed to work with SolrCloud and
> does not meet current performance requirements.
> > +
> > +The project hopes that the community will take over maintenance of DIH
> as a 3rd party package (See SOLR-14066 for more details). Please reach out
> to us at the dev@ mailing list if you want to help.
> > +
> > diff --git
> a/solr/contrib/dataimporthandler/src/java/org/apache/solr/handler/dataimport/DataImportHandler.java
> b/solr/contrib/dataimporthandler/src/java/org/apache

Re: [lucene-solr] branch branch_8x updated: SOLR-14066: Deprecate DIH

2020-07-02 Thread Andrzej Białecki
This breaks branch_8x for me - Java 8 doesn’t recognise the “since” attribute 
in @Deprecated.

> On 2 Jul 2020, at 13:10, is...@apache.org wrote:
> 
> This is an automated email from the ASF dual-hosted git repository.
> 
> ishan pushed a commit to branch branch_8x
> in repository https://gitbox.apache.org/repos/asf/lucene-solr.git
> 
> 
> The following commit(s) were added to refs/heads/branch_8x by this push:
> new 755d31c  SOLR-14066: Deprecate DIH
> 755d31c is described below
> 
> commit 755d31c4933a5b9bb8e39e5e9fb50b17934ff336
> Author: Ishan Chattopadhyaya 
> AuthorDate: Thu Jul 2 16:38:31 2020 +0530
> 
>SOLR-14066: Deprecate DIH
> ---
> solr/CHANGES.txt | 7 +--
> solr/contrib/dataimporthandler-extras/src/java/overview.html | 2 +-
> solr/contrib/dataimporthandler/README.txt| 9 +
> .../org/apache/solr/handler/dataimport/DataImportHandler.java| 3 +++
> solr/contrib/dataimporthandler/src/java/overview.html| 2 +-
> solr/example/example-DIH/README.txt  | 2 ++
> solr/solr-ref-guide/src/dataimport-screen.adoc   | 2 ++
> solr/solr-ref-guide/src/solr-upgrade-notes.adoc  | 3 +++
> ...-structured-data-store-data-with-the-data-import-handler.adoc | 2 ++
> solr/webapp/web/css/angular/dataimport.css   | 3 ++-
> solr/webapp/web/partials/dataimport.html | 1 +
> 11 files changed, 31 insertions(+), 5 deletions(-)
> 
> diff --git a/solr/CHANGES.txt b/solr/CHANGES.txt
> index 59d1972..a0bdcd4 100644
> --- a/solr/CHANGES.txt
> +++ b/solr/CHANGES.txt
> @@ -351,6 +351,9 @@ Other Changes
> 
> * SOLR-14022: Deprecate CDCR (Joel Bernstein, Ishan Chattopadhyaya)
> 
> +* SOLR-14066: Data Import Handler is deprecated. It is scheduled to be 
> removed as of 9.0 and a community supported
> +  package for the same may now be used instead. (Ishan Chattopadhyaya, 
> janhoy)
> +
> ==  8.5.2 ==
> 
> Consult the LUCENE_CHANGES.txt file for additional, low level, changes in 
> this release.
> @@ -6941,8 +6944,8 @@ Other Changes
>   (David Smiley)
> 
> * SOLR-8842: security rules made more foolproof by asking the requesthandler  
> about the well known
> -  permission name.
>  The APIs are also modified to ue 'index' as the unique identifier instead of 
> name.
> -  Name is an optional attribute
>  now and only to be used when specifying well-known permissions (noble)
> +  permission name.  The APIs are also modified to ue 'index' as the unique 
> identifier instead of name.
> +  Name is an optional attribute  now and only to be used when specifying 
> well-known permissions (noble)
> 
> * SOLR-5616: Simplifies grouping code to use ResponseBuilder.needDocList() to 
> determine if it needs to
>   generate a doc list for grouped results. (Steven Bower, Keith Laban, Dennis 
> Gove)
> diff --git a/solr/contrib/dataimporthandler-extras/src/java/overview.html 
> b/solr/contrib/dataimporthandler-extras/src/java/overview.html
> index a60a25e..5a55432 100644
> --- a/solr/contrib/dataimporthandler-extras/src/java/overview.html
> +++ b/solr/contrib/dataimporthandler-extras/src/java/overview.html
> @@ -16,6 +16,6 @@
> -->
> 
> 
> -Apache Solr Search Server: DataImportHandler Extras contrib
> +Apache Solr Search Server: DataImportHandler Extras contrib. This contrib 
> module is deprecated as of 8.6
> 
> 
> diff --git a/solr/contrib/dataimporthandler/README.txt 
> b/solr/contrib/dataimporthandler/README.txt
> index c969872..1d78b93 100644
> --- a/solr/contrib/dataimporthandler/README.txt
> +++ b/solr/contrib/dataimporthandler/README.txt
> @@ -14,3 +14,12 @@ running Solr you set the following system properties:
>   -Duser.language=xx -Duser.country=YY -Duser.timezone=ZZZ
> 
> where xx, YY, and ZZZ are consistent with any database server's configuration.
> +
> +Deprecation notice
> +--
> +This contrib module is deprecated as of v8.6, scheduled for removal in Solr 
> 9.0.
> +The reason is that DIH is no longer being maintained in a manner we feel is 
> necessary in order to keep it
> +healthy and secure. Also it was not designed to work with SolrCloud and does 
> not meet current performance requirements.
> +
> +The project hopes that the community will take over maintenance of DIH as a 
> 3rd party package (See SOLR-14066 for more details). Please reach out to us 
> at the dev@ mailing list if you want to help.
> +
> diff --git 
> a/solr/contrib/dataimporthandler/src/java/org/apache/solr/handler/dataimport/DataImportHandler.java
>  
> b/solr/contrib/dataimporthandler/src/java/org/apache/solr/handler/dataimport/DataImportHandler.java
> index 9fb8b04..a1fbcc2 100644
> --- 
> a/solr/contrib/dataimporthandler/src/java/org/apache/solr/handler/dataimport/DataImportHandler.java
> +++ 
> b/solr/contrib/dataimporthandler/src/java/org/apache/solr/handler/dataimport/DataImportHandler.java
> @@ -63,8 +63,