Re: Badapple report, rehabilitating annotated tests. Please read the intro and comment.

2018-06-05 Thread Erick Erickson
Got it, thanks Adrien.

Anyone else: If you have tests you don't want enabled, let me know.
I'll add to a permanent list and add to the report.



On Tue, Jun 5, 2018 at 10:06 AM, Adrien Grand  wrote:
> Hi Erick,
>
> Le mar. 5 juin 2018 à 18:19, Erick Erickson  a
> écrit :
>>
>>  TestControlledRealTimeReopenThread.testCRTReopen
>
>
> This test relies on wall clock time, it needs to be refactored before being
> enabled again.
>
>> TestICUNormalizer2CharFilter.testRandomStrings
>
>
> We did several ICU4J upgrades since we disabled that one, so it's not
> impossible that the issue got fixed. I just ran 1000 beasting iterations
> without a failure. I'm good with re-enabling it.
>
>>
>>  TestICUTokenizerCJK
>
>
> This one is due to a bug in ICU4J which still affects the latest release,
> let's keep it disabled.
>

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org



Re: Badapple report, rehabilitating annotated tests. Please read the intro and comment.

2018-06-05 Thread Adrien Grand
Hi Erick,

Le mar. 5 juin 2018 à 18:19, Erick Erickson  a
écrit :

>  TestControlledRealTimeReopenThread.testCRTReopen


This test relies on wall clock time, it needs to be refactored before being
enabled again.

TestICUNormalizer2CharFilter.testRandomStrings
>

We did several ICU4J upgrades since we disabled that one, so it's not
impossible that the issue got fixed. I just ran 1000 beasting iterations
without a failure. I'm good with re-enabling it.


>  TestICUTokenizerCJK
>

This one is due to a bug in ICU4J which still affects the latest release,
let's keep it disabled.