[jira] [Commented] (SOLR-4317) SolrTestCaseJ4: Can't avoid collection1 convention
[ https://issues.apache.org/jira/browse/SOLR-4317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13601110#comment-13601110 ] Commit Tag Bot commented on SOLR-4317: -- [branch_4x commit] Erick Erickson http://svn.apache.org/viewvc?view=revisionrevision=1455395 Fix for SOLR-4317, including fixup for test harness SolrTestCaseJ4: Can't avoid collection1 convention Key: SOLR-4317 URL: https://issues.apache.org/jira/browse/SOLR-4317 Project: Solr Issue Type: Improvement Components: Tests Affects Versions: 4.0 Reporter: Tricia Jenkins Assignee: Erick Erickson Priority: Minor Fix For: 4.3, 5.0 Attachments: SOLR-4317.patch, SOLR-4317.patch, SOLR-4317.patch, SOLR-4317.patch There is still an issue after the SOLR-3826 patch was applied for 4.0 [https://issues.apache.org/jira/browse/SOLR-3826] in September 2012. When TestHarness is called from SolrTestCase4J the only available constructors ignore coreName, set coreName = null, and initialize the default 'collection1.' -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-4317) SolrTestCaseJ4: Can't avoid collection1 convention
[ https://issues.apache.org/jira/browse/SOLR-4317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13601121#comment-13601121 ] Commit Tag Bot commented on SOLR-4317: -- [trunk commit] Erick Erickson http://svn.apache.org/viewvc?view=revisionrevision=1455368 Fix for assumption in the test harness uncovered by SOLR-4317 SolrTestCaseJ4: Can't avoid collection1 convention Key: SOLR-4317 URL: https://issues.apache.org/jira/browse/SOLR-4317 Project: Solr Issue Type: Improvement Components: Tests Affects Versions: 4.0 Reporter: Tricia Jenkins Assignee: Erick Erickson Priority: Minor Fix For: 4.3, 5.0 Attachments: SOLR-4317.patch, SOLR-4317.patch, SOLR-4317.patch, SOLR-4317.patch There is still an issue after the SOLR-3826 patch was applied for 4.0 [https://issues.apache.org/jira/browse/SOLR-3826] in September 2012. When TestHarness is called from SolrTestCase4J the only available constructors ignore coreName, set coreName = null, and initialize the default 'collection1.' -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-4317) SolrTestCaseJ4: Can't avoid collection1 convention
[ https://issues.apache.org/jira/browse/SOLR-4317?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Erick Erickson updated SOLR-4317: - Attachment: SOLR-4317.patch Added CHANGES.txt entry. SolrTestCaseJ4: Can't avoid collection1 convention Key: SOLR-4317 URL: https://issues.apache.org/jira/browse/SOLR-4317 Project: Solr Issue Type: Improvement Components: Tests Affects Versions: 4.0 Reporter: Tricia Jenkins Priority: Minor Fix For: 4.2, 5.0 Attachments: SOLR-4317.patch, SOLR-4317.patch, SOLR-4317.patch, SOLR-4317.patch There is still an issue after the SOLR-3826 patch was applied for 4.0 [https://issues.apache.org/jira/browse/SOLR-3826] in September 2012. When TestHarness is called from SolrTestCase4J the only available constructors ignore coreName, set coreName = null, and initialize the default 'collection1.' -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-4317) SolrTestCaseJ4: Can't avoid collection1 convention
[ https://issues.apache.org/jira/browse/SOLR-4317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13598914#comment-13598914 ] Commit Tag Bot commented on SOLR-4317: -- [trunk commit] Erick Erickson http://svn.apache.org/viewvc?view=revisionrevision=1455196 fix for SOLR-4317, don't requre 'collection1' in test harness. Thanks Tricia. SolrTestCaseJ4: Can't avoid collection1 convention Key: SOLR-4317 URL: https://issues.apache.org/jira/browse/SOLR-4317 Project: Solr Issue Type: Improvement Components: Tests Affects Versions: 4.0 Reporter: Tricia Jenkins Priority: Minor Fix For: 4.2, 5.0 Attachments: SOLR-4317.patch, SOLR-4317.patch, SOLR-4317.patch, SOLR-4317.patch There is still an issue after the SOLR-3826 patch was applied for 4.0 [https://issues.apache.org/jira/browse/SOLR-3826] in September 2012. When TestHarness is called from SolrTestCase4J the only available constructors ignore coreName, set coreName = null, and initialize the default 'collection1.' -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Assigned] (SOLR-4317) SolrTestCaseJ4: Can't avoid collection1 convention
[ https://issues.apache.org/jira/browse/SOLR-4317?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Erick Erickson reassigned SOLR-4317: Assignee: Erick Erickson SolrTestCaseJ4: Can't avoid collection1 convention Key: SOLR-4317 URL: https://issues.apache.org/jira/browse/SOLR-4317 Project: Solr Issue Type: Improvement Components: Tests Affects Versions: 4.0 Reporter: Tricia Jenkins Assignee: Erick Erickson Priority: Minor Fix For: 4.2, 5.0 Attachments: SOLR-4317.patch, SOLR-4317.patch, SOLR-4317.patch, SOLR-4317.patch There is still an issue after the SOLR-3826 patch was applied for 4.0 [https://issues.apache.org/jira/browse/SOLR-3826] in September 2012. When TestHarness is called from SolrTestCase4J the only available constructors ignore coreName, set coreName = null, and initialize the default 'collection1.' -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-4317) SolrTestCaseJ4: Can't avoid collection1 convention
[ https://issues.apache.org/jira/browse/SOLR-4317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13599519#comment-13599519 ] Erick Erickson commented on SOLR-4317: -- Additional fix for problem with test harness this uncovered. I'll fold it in the 4x checkin trunk: r - 1455368 SolrTestCaseJ4: Can't avoid collection1 convention Key: SOLR-4317 URL: https://issues.apache.org/jira/browse/SOLR-4317 Project: Solr Issue Type: Improvement Components: Tests Affects Versions: 4.0 Reporter: Tricia Jenkins Assignee: Erick Erickson Priority: Minor Fix For: 4.2, 5.0 Attachments: SOLR-4317.patch, SOLR-4317.patch, SOLR-4317.patch, SOLR-4317.patch There is still an issue after the SOLR-3826 patch was applied for 4.0 [https://issues.apache.org/jira/browse/SOLR-3826] in September 2012. When TestHarness is called from SolrTestCase4J the only available constructors ignore coreName, set coreName = null, and initialize the default 'collection1.' -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Resolved] (SOLR-4317) SolrTestCaseJ4: Can't avoid collection1 convention
[ https://issues.apache.org/jira/browse/SOLR-4317?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Erick Erickson resolved SOLR-4317. -- Resolution: Fixed Fix Version/s: 5.0 4x r: 1455395 (includes fix for test harness) SolrTestCaseJ4: Can't avoid collection1 convention Key: SOLR-4317 URL: https://issues.apache.org/jira/browse/SOLR-4317 Project: Solr Issue Type: Improvement Components: Tests Affects Versions: 4.0 Reporter: Tricia Jenkins Assignee: Erick Erickson Priority: Minor Fix For: 4.3, 5.0 Attachments: SOLR-4317.patch, SOLR-4317.patch, SOLR-4317.patch, SOLR-4317.patch There is still an issue after the SOLR-3826 patch was applied for 4.0 [https://issues.apache.org/jira/browse/SOLR-3826] in September 2012. When TestHarness is called from SolrTestCase4J the only available constructors ignore coreName, set coreName = null, and initialize the default 'collection1.' -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-4317) SolrTestCaseJ4: Can't avoid collection1 convention
[ https://issues.apache.org/jira/browse/SOLR-4317?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tricia Jenkins updated SOLR-4317: - Attachment: SOLR-4317.patch Hi Erik. Your re-organized patch looks great! It applies cleanly for me and all tests pass. The patch I'm attaching has an added test for the sharedLib directory which I had complained about in my last comment. I don't see the 'sharedLib' tested anywhere else but it seems to work outside of the test-framework. The test fails proving my frustration. Should I make this a separate issue in JIRA? SolrTestCaseJ4: Can't avoid collection1 convention Key: SOLR-4317 URL: https://issues.apache.org/jira/browse/SOLR-4317 Project: Solr Issue Type: Improvement Components: Tests Affects Versions: 4.0 Reporter: Tricia Jenkins Priority: Minor Fix For: 4.2, 5.0 Attachments: SOLR-4317.patch, SOLR-4317.patch, SOLR-4317.patch, SOLR-4317.patch There is still an issue after the SOLR-3826 patch was applied for 4.0 [https://issues.apache.org/jira/browse/SOLR-3826] in September 2012. When TestHarness is called from SolrTestCase4J the only available constructors ignore coreName, set coreName = null, and initialize the default 'collection1.' -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-4317) SolrTestCaseJ4: Can't avoid collection1 convention
[ https://issues.apache.org/jira/browse/SOLR-4317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13596109#comment-13596109 ] Mark Miller commented on SOLR-4317: --- bq. Should I make this a separate issue in JIRA? +1 SolrTestCaseJ4: Can't avoid collection1 convention Key: SOLR-4317 URL: https://issues.apache.org/jira/browse/SOLR-4317 Project: Solr Issue Type: Improvement Components: Tests Affects Versions: 4.0 Reporter: Tricia Jenkins Priority: Minor Fix For: 4.2, 5.0 Attachments: SOLR-4317.patch, SOLR-4317.patch, SOLR-4317.patch, SOLR-4317.patch There is still an issue after the SOLR-3826 patch was applied for 4.0 [https://issues.apache.org/jira/browse/SOLR-3826] in September 2012. When TestHarness is called from SolrTestCase4J the only available constructors ignore coreName, set coreName = null, and initialize the default 'collection1.' -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-4317) SolrTestCaseJ4: Can't avoid collection1 convention
[ https://issues.apache.org/jira/browse/SOLR-4317?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tricia Jenkins updated SOLR-4317: - Attachment: (was: SOLR-4317.patch) SolrTestCaseJ4: Can't avoid collection1 convention Key: SOLR-4317 URL: https://issues.apache.org/jira/browse/SOLR-4317 Project: Solr Issue Type: Improvement Components: Tests Affects Versions: 4.0 Reporter: Tricia Jenkins Priority: Minor Fix For: 4.2, 5.0 Attachments: SOLR-4317.patch, SOLR-4317.patch, SOLR-4317.patch There is still an issue after the SOLR-3826 patch was applied for 4.0 [https://issues.apache.org/jira/browse/SOLR-3826] in September 2012. When TestHarness is called from SolrTestCase4J the only available constructors ignore coreName, set coreName = null, and initialize the default 'collection1.' -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-4317) SolrTestCaseJ4: Can't avoid collection1 convention
[ https://issues.apache.org/jira/browse/SOLR-4317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13596127#comment-13596127 ] Tricia Jenkins commented on SOLR-4317: -- Removed my failing test patch from SOLR-4317 and created new issue SOLR-4536. SolrTestCaseJ4: Can't avoid collection1 convention Key: SOLR-4317 URL: https://issues.apache.org/jira/browse/SOLR-4317 Project: Solr Issue Type: Improvement Components: Tests Affects Versions: 4.0 Reporter: Tricia Jenkins Priority: Minor Fix For: 4.2, 5.0 Attachments: SOLR-4317.patch, SOLR-4317.patch, SOLR-4317.patch There is still an issue after the SOLR-3826 patch was applied for 4.0 [https://issues.apache.org/jira/browse/SOLR-3826] in September 2012. When TestHarness is called from SolrTestCase4J the only available constructors ignore coreName, set coreName = null, and initialize the default 'collection1.' -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-4317) SolrTestCaseJ4: Can't avoid collection1 convention
[ https://issues.apache.org/jira/browse/SOLR-4317?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Erick Erickson updated SOLR-4317: - Attachment: SOLR-4317.patch Tricia: I revised the patch a bit to fit better in the general scheme of things, see below. Does this still do what you intended? I haven't run all tests yet, just this one 1 puts the test case in the usual place so it's run with the rest of the unit tests. 2 creates a temporary directory with the relevant files in it for a multicore setup 3 adds a solr-multi.xml file to the test files so we have one available. This now runs either in an IDE or as a stand-alone test. SolrTestCaseJ4: Can't avoid collection1 convention Key: SOLR-4317 URL: https://issues.apache.org/jira/browse/SOLR-4317 Project: Solr Issue Type: Improvement Components: Tests Affects Versions: 4.0 Reporter: Tricia Jenkins Priority: Minor Fix For: 4.2, 5.0 Attachments: SOLR-4317.patch, SOLR-4317.patch, SOLR-4317.patch There is still an issue after the SOLR-3826 patch was applied for 4.0 [https://issues.apache.org/jira/browse/SOLR-3826] in September 2012. When TestHarness is called from SolrTestCase4J the only available constructors ignore coreName, set coreName = null, and initialize the default 'collection1.' -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Comment Edited] (SOLR-4317) SolrTestCaseJ4: Can't avoid collection1 convention
[ https://issues.apache.org/jira/browse/SOLR-4317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13560050#comment-13560050 ] Tricia Jenkins edited comment on SOLR-4317 at 1/23/13 5:43 PM: --- There is still a problem with jars from a sharedLib directory defined in solr.xml outside of the coreName's dataDir not being available to coreName's TestHarness despite it being logged as added to classpath: 1200 T11 oasc.SolrResourceLoader.replaceClassLoader Adding 'file:/C:/Development/workspace/peel-solr/src/solr.home/lib/my-solrplugins.jar' to classloader I'm getting: SEVERE Full Import failed:java.lang.RuntimeException: org.apache.solr.handler.dataimport.DataImportHandlerException: Unable to load EntityProcessor implementation for entity:properties Processing Document # 1 Caused by: java.lang.ClassNotFoundException: Unable to load PropertiesEntityProcessor or org.apache.solr.handler.dataimport.PropertiesEntityProcessor Workaround is to not use sharedLib. was (Author: pgwillia): There is still a problem with jars from a sharedLib directory defined in solr.xml outside of the coreName's dataDir not being available to coreName's TestHarness despite it being logged as added to classpath: 1200 T11 oasc.SolrResourceLoader.replaceClassLoader Adding 'file:/C:/Development/workspace/peel-solr/src/solr.home/lib/my-solrplugins.jar' to classloader I'm getting: SEVERE Full Import failed:java.lang.RuntimeException: org.apache.solr.handler.dataimport.DataImportHandlerException: Unable to load EntityProcessor implementation for entity:properties Processing Document # 1 Caused by: java.lang.ClassNotFoundException: Unable to load MyEntityProcessor or org.apache.solr.handler.dataimport.PropertiesEntityProcessor Workaround is to not use sharedLib. SolrTestCaseJ4: Can't avoid collection1 convention Key: SOLR-4317 URL: https://issues.apache.org/jira/browse/SOLR-4317 Project: Solr Issue Type: Improvement Components: Tests Affects Versions: 4.0 Reporter: Tricia Jenkins Priority: Minor Fix For: 4.2, 5.0 Attachments: SOLR-4317.patch, SOLR-4317.patch There is still an issue after the SOLR-3826 patch was applied for 4.0 [https://issues.apache.org/jira/browse/SOLR-3826] in September 2012. When TestHarness is called from SolrTestCase4J the only available constructors ignore coreName, set coreName = null, and initialize the default 'collection1.' -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-4317) SolrTestCaseJ4: Can't avoid collection1 convention
[
https://issues.apache.org/jira/browse/SOLR-4317?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tricia Jenkins updated SOLR-4317:
-
Attachment: SOLR-4317.patch
Added test which uses multicore example. Also further modified TestHarness and
SolrTestCase4J to use coreName in creating core. Didn't make any changes to
ant scripts so the test isn't called during a normal build.
SolrTestCaseJ4: Can't avoid collection1 convention
Key: SOLR-4317
URL: https://issues.apache.org/jira/browse/SOLR-4317
Project: Solr
Issue Type: Improvement
Components: Tests
Affects Versions: 4.0
Reporter: Tricia Jenkins
Priority: Minor
Fix For: 4.2, 5.0
Attachments: SOLR-4317.patch, SOLR-4317.patch
I think that there is still an issue after the SOLR-3826 patch was applied
for 4.0 [https://issues.apache.org/jira/browse/SOLR-3826] in September 2012.
This line is missing:
Index: solr/test-framework/src/java/org/apache/solr/SolrTestCaseJ4.java
===
--- solr/test-framework/src/java/org/apache/solr/SolrTestCaseJ4.java
(revision 1435375)
+++ solr/test-framework/src/java/org/apache/solr/SolrTestCaseJ4.java
(working copy)
@@ -384,9 +384,9 @@
public static void createCore() {
assertNotNull(testSolrHome);
solrConfig = TestHarness.createConfig(testSolrHome, coreName,
getSolrConfigFile());
-h = new TestHarness( dataDir.getAbsolutePath(),
+h = new TestHarness( coreName, new Initializer( coreName,
dataDir.getAbsolutePath(),
solrConfig,
-getSchemaFile());
+getSchemaFile() ) );
lrf = h.getRequestFactory
(standard,0,20,CommonParams.VERSION,2.2);
}
TestHarness( String dataDirectory,SolrConfig solrConfig, IndexSchema
indexSchema) sets coreName to null and opens the default core: collection1.
I would expect that coreName is carried all the way through the test.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-4317) SolrTestCaseJ4: Can't avoid collection1 convention
[
https://issues.apache.org/jira/browse/SOLR-4317?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tricia Jenkins updated SOLR-4317:
-
Description: There is still an issue after the SOLR-3826 patch was applied
for 4.0 [https://issues.apache.org/jira/browse/SOLR-3826] in September 2012.
When TestHarness is called from SolrTestCase4J the only available constructors
ignore coreName, set coreName = null, and initialize the default 'collection1.'
(was: I think that there is still an issue after the SOLR-3826 patch was
applied for 4.0 [https://issues.apache.org/jira/browse/SOLR-3826] in September
2012. This line is missing:
Index: solr/test-framework/src/java/org/apache/solr/SolrTestCaseJ4.java
===
--- solr/test-framework/src/java/org/apache/solr/SolrTestCaseJ4.java
(revision 1435375)
+++ solr/test-framework/src/java/org/apache/solr/SolrTestCaseJ4.java
(working copy)
@@ -384,9 +384,9 @@
public static void createCore() {
assertNotNull(testSolrHome);
solrConfig = TestHarness.createConfig(testSolrHome, coreName,
getSolrConfigFile());
-h = new TestHarness( dataDir.getAbsolutePath(),
+h = new TestHarness( coreName, new Initializer( coreName,
dataDir.getAbsolutePath(),
solrConfig,
-getSchemaFile());
+getSchemaFile() ) );
lrf = h.getRequestFactory
(standard,0,20,CommonParams.VERSION,2.2);
}
TestHarness( String dataDirectory,SolrConfig solrConfig, IndexSchema
indexSchema) sets coreName to null and opens the default core: collection1. I
would expect that coreName is carried all the way through the test.)
SolrTestCaseJ4: Can't avoid collection1 convention
Key: SOLR-4317
URL: https://issues.apache.org/jira/browse/SOLR-4317
Project: Solr
Issue Type: Improvement
Components: Tests
Affects Versions: 4.0
Reporter: Tricia Jenkins
Priority: Minor
Fix For: 4.2, 5.0
Attachments: SOLR-4317.patch, SOLR-4317.patch
There is still an issue after the SOLR-3826 patch was applied for 4.0
[https://issues.apache.org/jira/browse/SOLR-3826] in September 2012. When
TestHarness is called from SolrTestCase4J the only available constructors
ignore coreName, set coreName = null, and initialize the default
'collection1.'
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-4317) SolrTestCaseJ4: Can't avoid collection1 convention
[ https://issues.apache.org/jira/browse/SOLR-4317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13560050#comment-13560050 ] Tricia Jenkins commented on SOLR-4317: -- There is still a problem with jars from a sharedLib directory defined in solr.xml outside of the coreName's dataDir not being available to coreName's TestHarness despite it being logged as added to classpath: 1200 T11 oasc.SolrResourceLoader.replaceClassLoader Adding 'file:/C:/Development/workspace/peel-solr/src/solr.home/lib/my-solrplugins.jar' to classloader I'm getting: SEVERE Full Import failed:java.lang.RuntimeException: org.apache.solr.handler.dataimport.DataImportHandlerException: Unable to load EntityProcessor implementation for entity:properties Processing Document # 1 Caused by: java.lang.ClassNotFoundException: Unable to load MyEntityProcessor or org.apache.solr.handler.dataimport.PropertiesEntityProcessor Workaround is to not use sharedLib. SolrTestCaseJ4: Can't avoid collection1 convention Key: SOLR-4317 URL: https://issues.apache.org/jira/browse/SOLR-4317 Project: Solr Issue Type: Improvement Components: Tests Affects Versions: 4.0 Reporter: Tricia Jenkins Priority: Minor Fix For: 4.2, 5.0 Attachments: SOLR-4317.patch, SOLR-4317.patch There is still an issue after the SOLR-3826 patch was applied for 4.0 [https://issues.apache.org/jira/browse/SOLR-3826] in September 2012. When TestHarness is called from SolrTestCase4J the only available constructors ignore coreName, set coreName = null, and initialize the default 'collection1.' -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-4317) SolrTestCaseJ4: Can't avoid collection1 convention
[ https://issues.apache.org/jira/browse/SOLR-4317?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tricia Jenkins updated SOLR-4317: - Attachment: SOLR-4317.patch Missing a file :( SolrTestCaseJ4: Can't avoid collection1 convention Key: SOLR-4317 URL: https://issues.apache.org/jira/browse/SOLR-4317 Project: Solr Issue Type: Improvement Components: Tests Affects Versions: 4.0 Reporter: Tricia Jenkins Priority: Minor Fix For: 4.2, 5.0 Attachments: SOLR-4317.patch, SOLR-4317.patch, SOLR-4317.patch There is still an issue after the SOLR-3826 patch was applied for 4.0 [https://issues.apache.org/jira/browse/SOLR-3826] in September 2012. When TestHarness is called from SolrTestCase4J the only available constructors ignore coreName, set coreName = null, and initialize the default 'collection1.' -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Issue Comment Deleted] (SOLR-4317) SolrTestCaseJ4: Can't avoid collection1 convention
[ https://issues.apache.org/jira/browse/SOLR-4317?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tricia Jenkins updated SOLR-4317: - Comment: was deleted (was: Missing a file :() SolrTestCaseJ4: Can't avoid collection1 convention Key: SOLR-4317 URL: https://issues.apache.org/jira/browse/SOLR-4317 Project: Solr Issue Type: Improvement Components: Tests Affects Versions: 4.0 Reporter: Tricia Jenkins Priority: Minor Fix For: 4.2, 5.0 Attachments: SOLR-4317.patch, SOLR-4317.patch There is still an issue after the SOLR-3826 patch was applied for 4.0 [https://issues.apache.org/jira/browse/SOLR-3826] in September 2012. When TestHarness is called from SolrTestCase4J the only available constructors ignore coreName, set coreName = null, and initialize the default 'collection1.' -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-4317) SolrTestCaseJ4: Can't avoid collection1 convention
[ https://issues.apache.org/jira/browse/SOLR-4317?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tricia Jenkins updated SOLR-4317: - Attachment: (was: SOLR-4317.patch) SolrTestCaseJ4: Can't avoid collection1 convention Key: SOLR-4317 URL: https://issues.apache.org/jira/browse/SOLR-4317 Project: Solr Issue Type: Improvement Components: Tests Affects Versions: 4.0 Reporter: Tricia Jenkins Priority: Minor Fix For: 4.2, 5.0 Attachments: SOLR-4317.patch, SOLR-4317.patch There is still an issue after the SOLR-3826 patch was applied for 4.0 [https://issues.apache.org/jira/browse/SOLR-3826] in September 2012. When TestHarness is called from SolrTestCase4J the only available constructors ignore coreName, set coreName = null, and initialize the default 'collection1.' -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
Re: SolrTestCaseJ4: Can't avoid collection1 convention
Hi folks,
I think that there is still an issue after the SOLR-3826 patch was applied
for 4.0 [https://issues.apache.org/jira/browse/SOLR-3826] in September
2012. This line is missing:
Index: solr/test-framework/src/java/org/apache/solr/SolrTestCaseJ4.java
===
--- solr/test-framework/src/java/org/apache/solr/SolrTestCaseJ4.java
(revision 1435375)
+++ solr/test-framework/src/java/org/apache/solr/SolrTestCaseJ4.java
(working copy)
@@ -384,9 +384,9 @@
public static void createCore() {
assertNotNull(testSolrHome);
solrConfig = TestHarness.createConfig(testSolrHome, coreName,
getSolrConfigFile());
-h = new TestHarness( dataDir.getAbsolutePath(),
+h = new TestHarness( coreName, new Initializer( coreName,
dataDir.getAbsolutePath(),
solrConfig,
-getSchemaFile());
+getSchemaFile() ) );
lrf = h.getRequestFactory
(standard,0,20,CommonParams.VERSION,2.2);
}
TestHarness( String dataDirectory,SolrConfig solrConfig, IndexSchema
indexSchema) sets coreName to null and opens the default core: collection1.
I would expect that coreName is carried all the way through the test.
What's the best course of action for getting this fixed? Should I re-open
SOLR-3826 or create a new issue?
Thanks,
Tricia
On Tue, Aug 14, 2012 at 12:32 PM, Smiley, David W. dsmi...@mitre.orgwrote:
I've got some code that extends Solr and I use the Solr test framework for
my tests. I upgraded from Solr 4 alpha to Solr 4 beta today, and it
appears I am forced to put my test solr home directory in solr/collection1
rather than just plain solr/ (relative to my test classpath). I looked
through the code and found that SolrTestCaseJ4.initCore() calls
createCore() which calls TestHarness.createConfig(solrHome,confFile) which
adds the collection1 to solr home. This is a minor issue, but it annoys
me and I see it as a needless change. If it isn't fixed, we'll have to at
least put that in the release notes and definitely the javadoc so that it
is clear you *have* to use collection1.
~ David
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
Re: SolrTestCaseJ4: Can't avoid collection1 convention
I'd suggest creating a new issue and referencing the old issue in it.
- Mark
On Jan 18, 2013, at 5:48 PM, P Williams williams.tricia.l...@gmail.com wrote:
Hi folks,
I think that there is still an issue after the SOLR-3826 patch was applied
for 4.0 [https://issues.apache.org/jira/browse/SOLR-3826] in September 2012.
This line is missing:
Index: solr/test-framework/src/java/org/apache/solr/SolrTestCaseJ4.java
===
--- solr/test-framework/src/java/org/apache/solr/SolrTestCaseJ4.java
(revision 1435375)
+++ solr/test-framework/src/java/org/apache/solr/SolrTestCaseJ4.java
(working copy)
@@ -384,9 +384,9 @@
public static void createCore() {
assertNotNull(testSolrHome);
solrConfig = TestHarness.createConfig(testSolrHome, coreName,
getSolrConfigFile());
-h = new TestHarness( dataDir.getAbsolutePath(),
+h = new TestHarness( coreName, new Initializer( coreName,
dataDir.getAbsolutePath(),
solrConfig,
-getSchemaFile());
+getSchemaFile() ) );
lrf = h.getRequestFactory
(standard,0,20,CommonParams.VERSION,2.2);
}
TestHarness( String dataDirectory,SolrConfig solrConfig, IndexSchema
indexSchema) sets coreName to null and opens the default core: collection1.
I would expect that coreName is carried all the way through the test.
What's the best course of action for getting this fixed? Should I re-open
SOLR-3826 or create a new issue?
Thanks,
Tricia
On Tue, Aug 14, 2012 at 12:32 PM, Smiley, David W. dsmi...@mitre.org wrote:
I've got some code that extends Solr and I use the Solr test framework for my
tests. I upgraded from Solr 4 alpha to Solr 4 beta today, and it appears I
am forced to put my test solr home directory in solr/collection1 rather than
just plain solr/ (relative to my test classpath). I looked through the code
and found that SolrTestCaseJ4.initCore() calls createCore() which calls
TestHarness.createConfig(solrHome,confFile) which adds the collection1 to
solr home. This is a minor issue, but it annoys me and I see it as a
needless change. If it isn't fixed, we'll have to at least put that in the
release notes and definitely the javadoc so that it is clear you *have* to
use collection1.
~ David
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Created] (SOLR-4317) SolrTestCaseJ4: Can't avoid collection1 convention
Tricia Jenkins created SOLR-4317:
Summary: SolrTestCaseJ4: Can't avoid collection1 convention
Key: SOLR-4317
URL: https://issues.apache.org/jira/browse/SOLR-4317
Project: Solr
Issue Type: Improvement
Components: Tests
Affects Versions: 4.0
Reporter: Tricia Jenkins
Priority: Minor
Fix For: 4.1
I think that there is still an issue after the SOLR-3826 patch was applied for
4.0 [https://issues.apache.org/jira/browse/SOLR-3826] in September 2012. This
line is missing:
Index: solr/test-framework/src/java/org/apache/solr/SolrTestCaseJ4.java
===
--- solr/test-framework/src/java/org/apache/solr/SolrTestCaseJ4.java
(revision 1435375)
+++ solr/test-framework/src/java/org/apache/solr/SolrTestCaseJ4.java
(working copy)
@@ -384,9 +384,9 @@
public static void createCore() {
assertNotNull(testSolrHome);
solrConfig = TestHarness.createConfig(testSolrHome, coreName,
getSolrConfigFile());
-h = new TestHarness( dataDir.getAbsolutePath(),
+h = new TestHarness( coreName, new Initializer( coreName,
dataDir.getAbsolutePath(),
solrConfig,
-getSchemaFile());
+getSchemaFile() ) );
lrf = h.getRequestFactory
(standard,0,20,CommonParams.VERSION,2.2);
}
TestHarness( String dataDirectory,SolrConfig solrConfig, IndexSchema
indexSchema) sets coreName to null and opens the default core: collection1. I
would expect that coreName is carried all the way through the test.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-4317) SolrTestCaseJ4: Can't avoid collection1 convention
[
https://issues.apache.org/jira/browse/SOLR-4317?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tricia Jenkins updated SOLR-4317:
-
Attachment: SOLR-4317.patch
This is the patch from my description.
SolrTestCaseJ4: Can't avoid collection1 convention
Key: SOLR-4317
URL: https://issues.apache.org/jira/browse/SOLR-4317
Project: Solr
Issue Type: Improvement
Components: Tests
Affects Versions: 4.0
Reporter: Tricia Jenkins
Priority: Minor
Fix For: 4.1
Attachments: SOLR-4317.patch
I think that there is still an issue after the SOLR-3826 patch was applied
for 4.0 [https://issues.apache.org/jira/browse/SOLR-3826] in September 2012.
This line is missing:
Index: solr/test-framework/src/java/org/apache/solr/SolrTestCaseJ4.java
===
--- solr/test-framework/src/java/org/apache/solr/SolrTestCaseJ4.java
(revision 1435375)
+++ solr/test-framework/src/java/org/apache/solr/SolrTestCaseJ4.java
(working copy)
@@ -384,9 +384,9 @@
public static void createCore() {
assertNotNull(testSolrHome);
solrConfig = TestHarness.createConfig(testSolrHome, coreName,
getSolrConfigFile());
-h = new TestHarness( dataDir.getAbsolutePath(),
+h = new TestHarness( coreName, new Initializer( coreName,
dataDir.getAbsolutePath(),
solrConfig,
-getSchemaFile());
+getSchemaFile() ) );
lrf = h.getRequestFactory
(standard,0,20,CommonParams.VERSION,2.2);
}
TestHarness( String dataDirectory,SolrConfig solrConfig, IndexSchema
indexSchema) sets coreName to null and opens the default core: collection1.
I would expect that coreName is carried all the way through the test.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
Re: SolrTestCaseJ4: Can't avoid collection1 convention
Done. You can find it here: https://issues.apache.org/jira/browse/SOLR-4317
On Fri, Jan 18, 2013 at 4:01 PM, Mark Miller markrmil...@gmail.com wrote:
I'd suggest creating a new issue and referencing the old issue in it.
- Mark
On Jan 18, 2013, at 5:48 PM, P Williams williams.tricia.l...@gmail.com
wrote:
Hi folks,
I think that there is still an issue after the SOLR-3826 patch was
applied for 4.0 [https://issues.apache.org/jira/browse/SOLR-3826] in
September 2012. This line is missing:
Index: solr/test-framework/src/java/org/apache/solr/SolrTestCaseJ4.java
===
--- solr/test-framework/src/java/org/apache/solr/SolrTestCaseJ4.java
(revision 1435375)
+++ solr/test-framework/src/java/org/apache/solr/SolrTestCaseJ4.java
(working copy)
@@ -384,9 +384,9 @@
public static void createCore() {
assertNotNull(testSolrHome);
solrConfig = TestHarness.createConfig(testSolrHome, coreName,
getSolrConfigFile());
-h = new TestHarness( dataDir.getAbsolutePath(),
+h = new TestHarness( coreName, new Initializer( coreName,
dataDir.getAbsolutePath(),
solrConfig,
-getSchemaFile());
+getSchemaFile() ) );
lrf = h.getRequestFactory
(standard,0,20,CommonParams.VERSION,2.2);
}
TestHarness( String dataDirectory,SolrConfig solrConfig, IndexSchema
indexSchema) sets coreName to null and opens the default core: collection1.
I would expect that coreName is carried all the way through the test.
What's the best course of action for getting this fixed? Should I
re-open SOLR-3826 or create a new issue?
Thanks,
Tricia
On Tue, Aug 14, 2012 at 12:32 PM, Smiley, David W. dsmi...@mitre.org
wrote:
I've got some code that extends Solr and I use the Solr test framework
for my tests. I upgraded from Solr 4 alpha to Solr 4 beta today, and it
appears I am forced to put my test solr home directory in solr/collection1
rather than just plain solr/ (relative to my test classpath). I looked
through the code and found that SolrTestCaseJ4.initCore() calls
createCore() which calls TestHarness.createConfig(solrHome,confFile) which
adds the collection1 to solr home. This is a minor issue, but it annoys
me and I see it as a needless change. If it isn't fixed, we'll have to at
least put that in the release notes and definitely the javadoc so that it
is clear you *have* to use collection1.
~ David
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-4317) SolrTestCaseJ4: Can't avoid collection1 convention
[
https://issues.apache.org/jira/browse/SOLR-4317?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tricia Jenkins updated SOLR-4317:
-
Fix Version/s: (was: 4.1)
4.2
SolrTestCaseJ4: Can't avoid collection1 convention
Key: SOLR-4317
URL: https://issues.apache.org/jira/browse/SOLR-4317
Project: Solr
Issue Type: Improvement
Components: Tests
Affects Versions: 4.0
Reporter: Tricia Jenkins
Priority: Minor
Fix For: 4.2
Attachments: SOLR-4317.patch
I think that there is still an issue after the SOLR-3826 patch was applied
for 4.0 [https://issues.apache.org/jira/browse/SOLR-3826] in September 2012.
This line is missing:
Index: solr/test-framework/src/java/org/apache/solr/SolrTestCaseJ4.java
===
--- solr/test-framework/src/java/org/apache/solr/SolrTestCaseJ4.java
(revision 1435375)
+++ solr/test-framework/src/java/org/apache/solr/SolrTestCaseJ4.java
(working copy)
@@ -384,9 +384,9 @@
public static void createCore() {
assertNotNull(testSolrHome);
solrConfig = TestHarness.createConfig(testSolrHome, coreName,
getSolrConfigFile());
-h = new TestHarness( dataDir.getAbsolutePath(),
+h = new TestHarness( coreName, new Initializer( coreName,
dataDir.getAbsolutePath(),
solrConfig,
-getSchemaFile());
+getSchemaFile() ) );
lrf = h.getRequestFactory
(standard,0,20,CommonParams.VERSION,2.2);
}
TestHarness( String dataDirectory,SolrConfig solrConfig, IndexSchema
indexSchema) sets coreName to null and opens the default core: collection1.
I would expect that coreName is carried all the way through the test.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-4317) SolrTestCaseJ4: Can't avoid collection1 convention
[
https://issues.apache.org/jira/browse/SOLR-4317?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tricia Jenkins updated SOLR-4317:
-
Fix Version/s: 5.0
SolrTestCaseJ4: Can't avoid collection1 convention
Key: SOLR-4317
URL: https://issues.apache.org/jira/browse/SOLR-4317
Project: Solr
Issue Type: Improvement
Components: Tests
Affects Versions: 4.0
Reporter: Tricia Jenkins
Priority: Minor
Fix For: 4.2, 5.0
Attachments: SOLR-4317.patch
I think that there is still an issue after the SOLR-3826 patch was applied
for 4.0 [https://issues.apache.org/jira/browse/SOLR-3826] in September 2012.
This line is missing:
Index: solr/test-framework/src/java/org/apache/solr/SolrTestCaseJ4.java
===
--- solr/test-framework/src/java/org/apache/solr/SolrTestCaseJ4.java
(revision 1435375)
+++ solr/test-framework/src/java/org/apache/solr/SolrTestCaseJ4.java
(working copy)
@@ -384,9 +384,9 @@
public static void createCore() {
assertNotNull(testSolrHome);
solrConfig = TestHarness.createConfig(testSolrHome, coreName,
getSolrConfigFile());
-h = new TestHarness( dataDir.getAbsolutePath(),
+h = new TestHarness( coreName, new Initializer( coreName,
dataDir.getAbsolutePath(),
solrConfig,
-getSchemaFile());
+getSchemaFile() ) );
lrf = h.getRequestFactory
(standard,0,20,CommonParams.VERSION,2.2);
}
TestHarness( String dataDirectory,SolrConfig solrConfig, IndexSchema
indexSchema) sets coreName to null and opens the default core: collection1.
I would expect that coreName is carried all the way through the test.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
SolrTestCaseJ4: Can't avoid collection1 convention
I've got some code that extends Solr and I use the Solr test framework for my tests. I upgraded from Solr 4 alpha to Solr 4 beta today, and it appears I am forced to put my test solr home directory in solr/collection1 rather than just plain solr/ (relative to my test classpath). I looked through the code and found that SolrTestCaseJ4.initCore() calls createCore() which calls TestHarness.createConfig(solrHome,confFile) which adds the collection1 to solr home. This is a minor issue, but it annoys me and I see it as a needless change. If it isn't fixed, we'll have to at least put that in the release notes and definitely the javadoc so that it is clear you *have* to use collection1. ~ David - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
