Re: ant test results in versioned files being modified?
On Sat, Feb 11, 2012 at 5:02 AM, Dawid Weiss dawid.we...@cs.put.poznan.pl wrote: See also the phantastic comment/TODO when you run ant clean in Solr... Yeah... I looked at that briefly yesterday. Seems like there should be no harm if tests.userdir is copied (or even better - synced? http://ant.apache.org/manual/Tasks/sync.html) to some temporary scratch area instead of using the source location. Then temporary files wouldn't be a problem anymore? I disagree: there are reasons why each jvm gets its own temporary directory. when tests are creating files in the source tree, its only a matter of time before two tests try to access the same file and then interfere with each other... thats why this is important to fix and not to bury under the rug. -- lucidimagination.com - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
Re: ant test results in versioned files being modified?
I disagree: there are reasons why each jvm gets its own temporary directory. I don't know enough of Solr to tell if this can cause conflicts and if this should be somehow copied to scratch area by the test itself (perhaps). with each other... thats why this is important to fix and not to bury under the rug. I don't know how to fix it, but I know how to bury under the rug ;) Dawid - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
Re: ant test results in versioned files being modified?
I don't know enough of Solr to tell if this can cause conflicts and if this should be somehow copied to scratch area by the test itself (perhaps). me neither, but eventually no good will come from different tests reading/writing to the same files simultaneously... probably sporatic, hard to reproduce test failures and the like. I don't know how to fix it, but I know how to bury under the rug ;) Well, i think its fine to svn:ignore/.gitignore as long as we have a jira issue open for these files, so that its not totally buried. -- lucidimagination.com - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
ant test results in versioned files being modified?
I'm running ant test from the top level and these files are always modified: solr/contrib/dataimporthandler-extras/src/test-files/dihextras/solr/conf/dataimport.properties solr/contrib/dataimporthandler/src/test-files/dih/solr/conf/dataimport.properties Shouldn't be the case, right? Dawid - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
