RE: svn commit: r1378140 - /lucene/dev/trunk/lucene/core/src/java/org/apache/lucene/search/DisjunctionMaxQuery.java

2012-08-28 Thread Uwe Schindler 
Hi Mike,

The easier way (and also looks more code-style like):
{@code CollectionQuery} - This escapes automatically and you can read it 
better. It also added code/code around!

See my recent additions to WeakIdentityMap :-)

Uwe

-
Uwe Schindler
H.-H.-Meier-Allee 63, D-28213 Bremen
http://www.thetaphi.de
eMail: u...@thetaphi.de


 -Original Message-
 From: mikemcc...@apache.org [mailto:mikemcc...@apache.org]
 Sent: Tuesday, August 28, 2012 4:02 PM
 To: comm...@lucene.apache.org
 Subject: svn commit: r1378140 -
 /lucene/dev/trunk/lucene/core/src/java/org/apache/lucene/search/Disjunction
 MaxQuery.java
 
 Author: mikemccand
 Date: Tue Aug 28 14:02:19 2012
 New Revision: 1378140
 
 URL: http://svn.apache.org/viewvc?rev=1378140view=rev
 Log:
 escape generics to HTML
 
 Modified:
 
 lucene/dev/trunk/lucene/core/src/java/org/apache/lucene/search/Disjunction
 MaxQuery.java
 
 Modified:
 lucene/dev/trunk/lucene/core/src/java/org/apache/lucene/search/Disjunction
 MaxQuery.java
 URL:
 http://svn.apache.org/viewvc/lucene/dev/trunk/lucene/core/src/java/org/apac
 he/lucene/search/DisjunctionMaxQuery.java?rev=1378140r1=1378139r2=1
 378140view=diff
 
 ==
 ---
 lucene/dev/trunk/lucene/core/src/java/org/apache/lucene/search/Disjunction
 MaxQuery.java (original)
 +++ lucene/dev/trunk/lucene/core/src/java/org/apache/lucene/search/Disju
 +++ nctionMaxQuery.java Tue Aug 28 14:02:19 2012
 @@ -61,7 +61,7 @@ public class DisjunctionMaxQuery extends
 
/**
 * Creates a new DisjunctionMaxQuery
 -   * @param disjuncts a CollectionQuery of all the disjuncts to add
 +   * @param disjuncts a Collectionlt;Querygt; of all the disjuncts to
 + add
 * @param tieBreakerMultiplier   the weight to give to each matching non-
 maximum disjunct
 */
public DisjunctionMaxQuery(CollectionQuery disjuncts, float
 tieBreakerMultiplier) { @@ -77,14 +77,14 @@ public class
 DisjunctionMaxQuery extends
}
 
/** Add a collection of disjuncts to this disjunction
 -   * via IterableQuery
 +   * via Iterablelt;Querygt;
 * @param disjuncts a collection of queries to add as disjuncts.
 */
public void add(CollectionQuery disjuncts) {
  this.disjuncts.addAll(disjuncts);
}
 
 -  /** @return An IteratorQuery over the disjuncts */
 +  /** @return An Iteratorlt;Querygt; over the disjuncts */
public IteratorQuery iterator() {
  return disjuncts.iterator();
}



-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Re: svn commit: r1378140 - /lucene/dev/trunk/lucene/core/src/java/org/apache/lucene/search/DisjunctionMaxQuery.java

2012-08-28 Thread Michael McCandless 
Aha!  Most excellent.  I'll switch to {@code ...}.  Thanks for the pointer.

Mike McCandless

http://blog.mikemccandless.com

On Tue, Aug 28, 2012 at 10:35 AM, Uwe Schindler u...@thetaphi.de wrote:
 Hi Mike,

 The easier way (and also looks more code-style like):
 {@code CollectionQuery} - This escapes automatically and you can read it 
 better. It also added code/code around!

 See my recent additions to WeakIdentityMap :-)

 Uwe

 -
 Uwe Schindler
 H.-H.-Meier-Allee 63, D-28213 Bremen
 http://www.thetaphi.de
 eMail: u...@thetaphi.de


 -Original Message-
 From: mikemcc...@apache.org [mailto:mikemcc...@apache.org]
 Sent: Tuesday, August 28, 2012 4:02 PM
 To: comm...@lucene.apache.org
 Subject: svn commit: r1378140 -
 /lucene/dev/trunk/lucene/core/src/java/org/apache/lucene/search/Disjunction
 MaxQuery.java

 Author: mikemccand
 Date: Tue Aug 28 14:02:19 2012
 New Revision: 1378140

 URL: http://svn.apache.org/viewvc?rev=1378140view=rev
 Log:
 escape generics to HTML

 Modified:

 lucene/dev/trunk/lucene/core/src/java/org/apache/lucene/search/Disjunction
 MaxQuery.java

 Modified:
 lucene/dev/trunk/lucene/core/src/java/org/apache/lucene/search/Disjunction
 MaxQuery.java
 URL:
 http://svn.apache.org/viewvc/lucene/dev/trunk/lucene/core/src/java/org/apac
 he/lucene/search/DisjunctionMaxQuery.java?rev=1378140r1=1378139r2=1
 378140view=diff
 
 ==
 ---
 lucene/dev/trunk/lucene/core/src/java/org/apache/lucene/search/Disjunction
 MaxQuery.java (original)
 +++ lucene/dev/trunk/lucene/core/src/java/org/apache/lucene/search/Disju
 +++ nctionMaxQuery.java Tue Aug 28 14:02:19 2012
 @@ -61,7 +61,7 @@ public class DisjunctionMaxQuery extends

/**
 * Creates a new DisjunctionMaxQuery
 -   * @param disjuncts a CollectionQuery of all the disjuncts to add
 +   * @param disjuncts a Collectionlt;Querygt; of all the disjuncts to
 + add
 * @param tieBreakerMultiplier   the weight to give to each matching non-
 maximum disjunct
 */
public DisjunctionMaxQuery(CollectionQuery disjuncts, float
 tieBreakerMultiplier) { @@ -77,14 +77,14 @@ public class
 DisjunctionMaxQuery extends
}

/** Add a collection of disjuncts to this disjunction
 -   * via IterableQuery
 +   * via Iterablelt;Querygt;
 * @param disjuncts a collection of queries to add as disjuncts.
 */
public void add(CollectionQuery disjuncts) {
  this.disjuncts.addAll(disjuncts);
}

 -  /** @return An IteratorQuery over the disjuncts */
 +  /** @return An Iteratorlt;Querygt; over the disjuncts */
public IteratorQuery iterator() {
  return disjuncts.iterator();
}



 -
 To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
 For additional commands, e-mail: dev-h...@lucene.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

RE: svn commit: r1378140 - /lucene/dev/trunk/lucene/core/src/java/org/apache/lucene/search/DisjunctionMaxQuery.java

2012-08-28 Thread Uwe Schindler 
Glad to help you!

- {@code ...} creates a code.../code environment, so ist formatted like 
code.
- there is also {@literal ...} which makes the thing escaped, but plain text 
(so its same font as remaining text)

Uwe

-
Uwe Schindler
H.-H.-Meier-Allee 63, D-28213 Bremen
http://www.thetaphi.de
eMail: u...@thetaphi.de


 -Original Message-
 From: Michael McCandless [mailto:luc...@mikemccandless.com]
 Sent: Tuesday, August 28, 2012 6:16 PM
 To: dev@lucene.apache.org
 Subject: Re: svn commit: r1378140 -
 /lucene/dev/trunk/lucene/core/src/java/org/apache/lucene/search/Disjunction
 MaxQuery.java
 
 Aha!  Most excellent.  I'll switch to {@code ...}.  Thanks for the pointer.
 
 Mike McCandless
 
 http://blog.mikemccandless.com
 
 On Tue, Aug 28, 2012 at 10:35 AM, Uwe Schindler u...@thetaphi.de wrote:
  Hi Mike,
 
  The easier way (and also looks more code-style like):
  {@code CollectionQuery} - This escapes automatically and you can read it
 better. It also added code/code around!
 
  See my recent additions to WeakIdentityMap :-)
 
  Uwe
 
  -
  Uwe Schindler
  H.-H.-Meier-Allee 63, D-28213 Bremen
  http://www.thetaphi.de
  eMail: u...@thetaphi.de
 
 
  -Original Message-
  From: mikemcc...@apache.org [mailto:mikemcc...@apache.org]
  Sent: Tuesday, August 28, 2012 4:02 PM
  To: comm...@lucene.apache.org
  Subject: svn commit: r1378140 -
  /lucene/dev/trunk/lucene/core/src/java/org/apache/lucene/search/Disju
  nction
  MaxQuery.java
 
  Author: mikemccand
  Date: Tue Aug 28 14:02:19 2012
  New Revision: 1378140
 
  URL: http://svn.apache.org/viewvc?rev=1378140view=rev
  Log:
  escape generics to HTML
 
  Modified:
 
  lucene/dev/trunk/lucene/core/src/java/org/apache/lucene/search/Disjun
  ction
  MaxQuery.java
 
  Modified:
  lucene/dev/trunk/lucene/core/src/java/org/apache/lucene/search/Disjun
  ction
  MaxQuery.java
  URL:
  http://svn.apache.org/viewvc/lucene/dev/trunk/lucene/core/src/java/or
  g/apac
 
 he/lucene/search/DisjunctionMaxQuery.java?rev=1378140r1=1378139r2=1
  378140view=diff
 
 
  ==
  ---
  lucene/dev/trunk/lucene/core/src/java/org/apache/lucene/search/Disjun
  ction
  MaxQuery.java (original)
  +++ lucene/dev/trunk/lucene/core/src/java/org/apache/lucene/search/Di
  +++ sju nctionMaxQuery.java Tue Aug 28 14:02:19 2012
  @@ -61,7 +61,7 @@ public class DisjunctionMaxQuery extends
 
 /**
  * Creates a new DisjunctionMaxQuery
  -   * @param disjuncts a CollectionQuery of all the disjuncts to add
  +   * @param disjuncts a Collectionlt;Querygt; of all the disjuncts
  + to add
  * @param tieBreakerMultiplier   the weight to give to each matching
 non-
  maximum disjunct
  */
 public DisjunctionMaxQuery(CollectionQuery disjuncts, float
  tieBreakerMultiplier) { @@ -77,14 +77,14 @@ public class
  DisjunctionMaxQuery extends
 }
 
 /** Add a collection of disjuncts to this disjunction
  -   * via IterableQuery
  +   * via Iterablelt;Querygt;
  * @param disjuncts a collection of queries to add as disjuncts.
  */
 public void add(CollectionQuery disjuncts) {
   this.disjuncts.addAll(disjuncts);
 }
 
  -  /** @return An IteratorQuery over the disjuncts */
  +  /** @return An Iteratorlt;Querygt; over the disjuncts */
 public IteratorQuery iterator() {
   return disjuncts.iterator();
 }
 
 
 
  -
  To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For
  additional commands, e-mail: dev-h...@lucene.apache.org
 
 
 -
 To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional
 commands, e-mail: dev-h...@lucene.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org