[GitHub] madlib issue #191: KNN: Fix optional parameters and ordering

2017-10-26 Thread asfgit 
Github user asfgit commented on the issue:

https://github.com/apache/madlib/pull/191
  

Refer to this link for build results (access rights to CI server needed): 
https://builds.apache.org/job/madlib-pr-build/264/



---

[GitHub] madlib issue #191: KNN: Fix optional parameters and ordering

2017-10-24 Thread asfgit 
Github user asfgit commented on the issue:

https://github.com/apache/madlib/pull/191
  

Refer to this link for build results (access rights to CI server needed): 
https://builds.apache.org/job/madlib-pr-build/263/



---

[GitHub] madlib issue #191: KNN: Fix optional parameters and ordering

2017-10-24 Thread iyerr3 
Github user iyerr3 commented on the issue:

https://github.com/apache/madlib/pull/191
  
jenkins ok to retest


---

[GitHub] madlib issue #191: KNN: Fix optional parameters and ordering

2017-10-24 Thread orhankislal 
Github user orhankislal commented on the issue:

https://github.com/apache/madlib/pull/191
  
jenkins ok to test


---

[GitHub] madlib issue #191: KNN: Fix optional parameters and ordering

2017-10-23 Thread asfgit 
Github user asfgit commented on the issue:

https://github.com/apache/madlib/pull/191
  

Refer to this link for build results (access rights to CI server needed): 
https://builds.apache.org/job/madlib-pr-build/260/



---

[GitHub] madlib issue #191: KNN: Fix optional parameters and ordering

2017-10-23 Thread fmcquillan99 
Github user fmcquillan99 commented on the issue:

https://github.com/apache/madlib/pull/191
  
LGTM based on some testing and docs review.
I would ask other community folks to pls review code in more detail however.


---