[GitHub] incubator-madlib pull request: Prediction Metrics: New module

[iyerr3]

Github user iyerr3 commented on the pull request:

https://github.com/apache/incubator-madlib/pull/42#issuecomment-218301178
  
General comments: 
- The distance functions (mean_*_error) all have the same structure except 
the distance metric. I suggest refactoring the table creation and the grouping 
statements into a single function that takes a parameter for the distance. 
- Avoid using `__` within python. It leads to [name 
mangling](https://docs.python.org/2/tutorial/classes.html#private-variables-and-class-local-references),
 that doesn't really help in this situation. 
- There seems to be considerable overlap between the grouping and 
non-grouping SQL in `r2`, `adjusted_r2` and `auc` functions. Maybe we can 
combine them? 
- I'll bump the 
[suggestion](https://github.com/apache/incubator-madlib/pull/41#issuecomment-216661096)
 by @decibel in the previous PR. It might be helpful to have 2 versions: 1 that 
creates the output table and the other returns the rows directly. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Open office hours for Apache MADlib at Apache:Big Data 5:30 PM PST today

[Gregory Chase]

Dear MADlib community,
We have run into technical difficulties trying to run show floor to virtual
meetings.  So we are going to cancel the virtual office hours meeting this
afternoon.

As always, the community is available to answer your questions via these
newsgroups.  And, we'll continue with our usual monthly meetings in June.

Thanks!

-Greg

On Tue, May 10, 2016 at 9:13 AM, Frank McQuillan 
wrote:

> Thanks for setting this up, Greg.  Happy to attend and speak with the fine
> folks from the Apache community.
>
> Frank
>
> On Tue, May 10, 2016 at 9:11 AM, Gregory Chase  wrote:
>
>> Live from the floor of Apache Con, the Apache MADlib project is holding
>> open office hours.  Bring any question you want, or drop by for a quick
>> introduction.
>>
>> Find us in the ODPi Lounge next to the ODPi booth.
>>
>> You can also join virtually at:
>> pivotalcommunity.adobeconnect.com/hawqnest/ 
>>
>> --
>> Greg Chase
>>
>> Global Head, Big Data Communities
>> http://www.pivotal.io/big-data
>>
>> Pivotal Software
>> http://www.pivotal.io/
>>
>> 650-215-0477
>> @GregChase
>> Blog: http://geekmarketing.biz/
>>
>>
>


-- 
Greg Chase

Global Head, Big Data Communities
http://www.pivotal.io/big-data

Pivotal Software
http://www.pivotal.io/

650-215-0477
@GregChase
Blog: http://geekmarketing.biz/

Re: Open office hours for Apache MADlib at Apache:Big Data 5:30 PM PST today

[Frank McQuillan]

Thanks for setting this up, Greg.  Happy to attend and speak with the fine
folks from the Apache community.

Frank

On Tue, May 10, 2016 at 9:11 AM, Gregory Chase  wrote:

> Live from the floor of Apache Con, the Apache MADlib project is holding
> open office hours.  Bring any question you want, or drop by for a quick
> introduction.
>
> Find us in the ODPi Lounge next to the ODPi booth.
>
> You can also join virtually at:
> pivotalcommunity.adobeconnect.com/hawqnest/ 
>
> --
> Greg Chase
>
> Global Head, Big Data Communities
> http://www.pivotal.io/big-data
>
> Pivotal Software
> http://www.pivotal.io/
>
> 650-215-0477
> @GregChase
> Blog: http://geekmarketing.biz/
>
>