[jira] [Commented] (MAHOUT-1856) Create a framework for new Mahout Clustering, Classification, and Optimization Algorithms
[
https://issues.apache.org/jira/browse/MAHOUT-1856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15840810#comment-15840810
]
ASF GitHub Bot commented on MAHOUT-1856:
Github user dlyubimov commented on a diff in the pull request:
https://github.com/apache/mahout/pull/246#discussion_r98131529
--- Diff:
math-scala/src/main/scala/org/apache/mahout/math/algorithms/regression/Regressor.scala
---
@@ -0,0 +1,49 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.mahout.math.algorithms.regression
+
+import org.apache.mahout.math.algorithms.regression.tests._
+import org.apache.mahout.math.drm._
+import org.apache.mahout.math.{Vector => MahoutVector}
+import org.apache.mahout.math.algorithms.Model
+import org.apache.mahout.math.drm.DrmLike
+
+import scala.reflect.ClassTag
+
+/**
+ * Abstract of Regressors
+ */
+trait Regressor[K] extends Model {
--- End diff --
in most kits i know (including two i am working on right now myself) the
pattern is that fit returns a model object. sckit seems to be on the outlier
end on this.
Also i think the approach "package A does it like this and we do/don't like
it therefore it is good/bad" to be a dogma fallacy. IMO We just need to do what
makes sense.
And it makes sense to me to serialize or persist the model, not the
(fitting algorithm+model). This will cause problems both on user and
implementation ends IMO
> Create a framework for new Mahout Clustering, Classification, and
> Optimization Algorithms
> --
>
> Key: MAHOUT-1856
> URL: https://issues.apache.org/jira/browse/MAHOUT-1856
> Project: Mahout
> Issue Type: New Feature
>Affects Versions: 0.12.1
>Reporter: Andrew Palumbo
>Assignee: Trevor Grant
>Priority: Critical
> Fix For: 0.13.0
>
>
> To ensure that Mahout does not become "A loose bag of algorithms", Create
> basic traits with funtions common to each class of algorithm.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Resolved] (MAHOUT-1916) mahout bug
[ https://issues.apache.org/jira/browse/MAHOUT-1916?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dmitriy Lyubimov resolved MAHOUT-1916. -- Resolution: Invalid > mahout bug > -- > > Key: MAHOUT-1916 > URL: https://issues.apache.org/jira/browse/MAHOUT-1916 > Project: Mahout > Issue Type: Bug >Reporter: sarra sarra > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (MAHOUT-1918) Use traits when probing VCL
[
https://issues.apache.org/jira/browse/MAHOUT-1918?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrew Palumbo updated MAHOUT-1918:
---
Description:
currently we have
eg.
{code}
clazz =
Class.forName("org.apache.mahout.viennacl.opencl.GPUMMul$").getField("MODULE$").get(null).asInstanceOf[MMBinaryFunc]
{code}
To instantiate a Solver.. It is being cast to a {{MMBinaryFunc}}
cast this to at MMulSolver Trait and change the corresponding class GPUMMul to
extend this.
was:
currently we hav
eg.
{code}
clazz =
Class.forName("org.apache.mahout.viennacl.opencl.GPUMMul$").getField("MODULE$").get(null).asInstanceOf[MMBinaryFunc]
{code}
To instantiate a Solver.. It is being cast to a {{MMBinaryFunc}}
cast this to at MMulSolver Trait and change the corresponding class GPUMMul to
extend this.
> Use traits when probing VCL
> ---
>
> Key: MAHOUT-1918
> URL: https://issues.apache.org/jira/browse/MAHOUT-1918
> Project: Mahout
> Issue Type: Test
>Affects Versions: 0.12.2
>Reporter: Andrew Palumbo
>Assignee: Andrew Palumbo
>Priority: Blocker
> Fix For: 0.13.0
>
>
> currently we have
> eg.
> {code}
> clazz =
> Class.forName("org.apache.mahout.viennacl.opencl.GPUMMul$").getField("MODULE$").get(null).asInstanceOf[MMBinaryFunc]
> {code}
> To instantiate a Solver.. It is being cast to a {{MMBinaryFunc}}
> cast this to at MMulSolver Trait and change the corresponding class GPUMMul
> to extend this.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Created] (MAHOUT-1918) Use traits when probing VCL
Andrew Palumbo created MAHOUT-1918:
--
Summary: Use traits when probing VCL
Key: MAHOUT-1918
URL: https://issues.apache.org/jira/browse/MAHOUT-1918
Project: Mahout
Issue Type: Test
Reporter: Andrew Palumbo
Assignee: Andrew Palumbo
Priority: Blocker
currently we hav
eg.
{code}
clazz =
Class.forName("org.apache.mahout.viennacl.opencl.GPUMMul$").getField("MODULE$").get(null).asInstanceOf[MMBinaryFunc]
{code}
To instantiate a Solver.. It is being cast to a {{MMBinaryFunc}}
cast this to at MMulSolver Trait and change the corresponding class GPUMMul to
extend this.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (MAHOUT-1918) Use traits when probing VCL
[
https://issues.apache.org/jira/browse/MAHOUT-1918?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrew Palumbo updated MAHOUT-1918:
---
Fix Version/s: 0.13.0
> Use traits when probing VCL
> ---
>
> Key: MAHOUT-1918
> URL: https://issues.apache.org/jira/browse/MAHOUT-1918
> Project: Mahout
> Issue Type: Test
>Affects Versions: 0.12.2
>Reporter: Andrew Palumbo
>Assignee: Andrew Palumbo
>Priority: Blocker
> Fix For: 0.13.0
>
>
> currently we hav
> eg.
> {code}
> clazz =
> Class.forName("org.apache.mahout.viennacl.opencl.GPUMMul$").getField("MODULE$").get(null).asInstanceOf[MMBinaryFunc]
> {code}
> To instantiate a Solver.. It is being cast to a {{MMBinaryFunc}}
> cast this to at MMulSolver Trait and change the corresponding class GPUMMul
> to extend this.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (MAHOUT-1918) Use traits when probing VCL
[
https://issues.apache.org/jira/browse/MAHOUT-1918?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrew Palumbo updated MAHOUT-1918:
---
Affects Version/s: 0.12.2
> Use traits when probing VCL
> ---
>
> Key: MAHOUT-1918
> URL: https://issues.apache.org/jira/browse/MAHOUT-1918
> Project: Mahout
> Issue Type: Test
>Affects Versions: 0.12.2
>Reporter: Andrew Palumbo
>Assignee: Andrew Palumbo
>Priority: Blocker
> Fix For: 0.13.0
>
>
> currently we hav
> eg.
> {code}
> clazz =
> Class.forName("org.apache.mahout.viennacl.opencl.GPUMMul$").getField("MODULE$").get(null).asInstanceOf[MMBinaryFunc]
> {code}
> To instantiate a Solver.. It is being cast to a {{MMBinaryFunc}}
> cast this to at MMulSolver Trait and change the corresponding class GPUMMul
> to extend this.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Resolved] (MAHOUT-1917) mahout_bug
[ https://issues.apache.org/jira/browse/MAHOUT-1917?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Palumbo resolved MAHOUT-1917. Resolution: Invalid > mahout_bug > -- > > Key: MAHOUT-1917 > URL: https://issues.apache.org/jira/browse/MAHOUT-1917 > Project: Mahout > Issue Type: Bug >Reporter: sarra sarra > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (MAHOUT-1915) mahoot+bug
[ https://issues.apache.org/jira/browse/MAHOUT-1915?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Palumbo resolved MAHOUT-1915. Resolution: Invalid > mahoot+bug > -- > > Key: MAHOUT-1915 > URL: https://issues.apache.org/jira/browse/MAHOUT-1915 > Project: Mahout > Issue Type: Bug >Reporter: lsroudi > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (MAHOUT-1917) mahout_bug
sarra sarra created MAHOUT-1917: --- Summary: mahout_bug Key: MAHOUT-1917 URL: https://issues.apache.org/jira/browse/MAHOUT-1917 Project: Mahout Issue Type: Bug Reporter: sarra sarra -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (MAHOUT-1916) mahout bug
sarra sarra created MAHOUT-1916: --- Summary: mahout bug Key: MAHOUT-1916 URL: https://issues.apache.org/jira/browse/MAHOUT-1916 Project: Mahout Issue Type: Bug Reporter: sarra sarra -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (MAHOUT-1915) mahoot+bug
lsroudi created MAHOUT-1915: --- Summary: mahoot+bug Key: MAHOUT-1915 URL: https://issues.apache.org/jira/browse/MAHOUT-1915 Project: Mahout Issue Type: Bug Reporter: lsroudi -- This message was sent by Atlassian JIRA (v6.3.4#6332)
