[jira] [Commented] (MAHOUT-1263) Serialise/Deserialise Lambda value for OnlineLogisticRegression
[ https://issues.apache.org/jira/browse/MAHOUT-1263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13684209#comment-13684209 ] Hudson commented on MAHOUT-1263: Integrated in Mahout-Quality #2084 (See [https://builds.apache.org/job/Mahout-Quality/2084/]) MAHOUT-1263: Serialize/Deserialize Lambda value for OnlineLogisticRegression - code cleanup (Revision 1493351) Result = SUCCESS smarthi : Files : * /mahout/trunk/core/src/test/java/org/apache/mahout/classifier/sgd/OnlineLogisticRegressionTest.java Serialise/Deserialise Lambda value for OnlineLogisticRegression Key: MAHOUT-1263 URL: https://issues.apache.org/jira/browse/MAHOUT-1263 Project: Mahout Issue Type: Bug Components: Classification Affects Versions: 0.7 Reporter: Mike Davy Assignee: Suneel Marthi Labels: patch Fix For: 0.8 Attachments: MAHOUT-1263.patch Original Estimate: 0.5h Remaining Estimate: 0.5h The value for Lambda in OnlineLogisticRegression seems not the be serialised/deserialised correctly. If I train a model with a specific lambda value, serialise it, then read it back in, the value of Lambda goes back to the default value (1.0e-5). I've created a patch that adds the lambda value into the write/readFields (org.apache.hadoop.io.Writable). Patch includes a unit test that checks the values after serialising/deserialising to/from a ByteArray. I think this is correct, unless I'm missing something obvious? Note: this patch is not backwards compatible - can easily adapt to be more backwards compatible if required. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAHOUT-1263) Serialise/Deserialise Lambda value for OnlineLogisticRegression
[ https://issues.apache.org/jira/browse/MAHOUT-1263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13684085#comment-13684085 ] Hudson commented on MAHOUT-1263: Integrated in Mahout-Quality #2083 (See [https://builds.apache.org/job/Mahout-Quality/2083/]) MAHOUT-1263:Serialise/Deserialise Lambda value for OnlineLogisticRegression (Revision 1493313) Result = SUCCESS smarthi : Files : * /mahout/trunk/CHANGELOG * /mahout/trunk/core/src/main/java/org/apache/mahout/classifier/sgd/OnlineLogisticRegression.java * /mahout/trunk/core/src/test/java/org/apache/mahout/classifier/sgd/OnlineLogisticRegressionTest.java Serialise/Deserialise Lambda value for OnlineLogisticRegression Key: MAHOUT-1263 URL: https://issues.apache.org/jira/browse/MAHOUT-1263 Project: Mahout Issue Type: Bug Components: Classification Affects Versions: 0.7 Reporter: Mike Davy Assignee: Suneel Marthi Labels: patch Fix For: 0.8 Attachments: MAHOUT-1263.patch Original Estimate: 0.5h Remaining Estimate: 0.5h The value for Lambda in OnlineLogisticRegression seems not the be serialised/deserialised correctly. If I train a model with a specific lambda value, serialise it, then read it back in, the value of Lambda goes back to the default value (1.0e-5). I've created a patch that adds the lambda value into the write/readFields (org.apache.hadoop.io.Writable). Patch includes a unit test that checks the values after serialising/deserialising to/from a ByteArray. I think this is correct, unless I'm missing something obvious? Note: this patch is not backwards compatible - can easily adapt to be more backwards compatible if required. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
