RE: Github mirror out of sync
Yes it's done and the problem solved, I closed the JIRA ticket, sorry for the mistake -Message d'origine- De : Karl Wright Envoyé : mercredi 21 septembre 2022 17:27 À : dev Objet : Re: Github mirror out of sync Hi - you created a CONNECTORS ticket. We need an INFRA ticket instead. Karl On Wed, Sep 21, 2022 at 10:53 AM Karl Wright wrote: > It's not been reported before, no. Can you file an INFRA ticket for this? > Karl > > > On Wed, Sep 21, 2022 at 10:48 AM Julien Massiera < > julien.massi...@francelabs.com> wrote: > >> Hi, >> >> >> >> I am not sure it has been reported but the Github mirror seems out of >> sync with the SVN repo since June >> >> >> >> Julien >> >> >> >> >> >> >> >>
Re: Github mirror out of sync
Hi - you created a CONNECTORS ticket. We need an INFRA ticket instead. Karl On Wed, Sep 21, 2022 at 10:53 AM Karl Wright wrote: > It's not been reported before, no. Can you file an INFRA ticket for this? > Karl > > > On Wed, Sep 21, 2022 at 10:48 AM Julien Massiera < > julien.massi...@francelabs.com> wrote: > >> Hi, >> >> >> >> I am not sure it has been reported but the Github mirror seems out of sync >> with the SVN repo since June >> >> >> >> Julien >> >> >> >> >> >> >> >>
[jira] [Resolved] (CONNECTORS-1732) Github mirror out of sync
[ https://issues.apache.org/jira/browse/CONNECTORS-1732?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julien Massiera resolved CONNECTORS-1732. - Resolution: Invalid wrong place for that issue > Github mirror out of sync > - > > Key: CONNECTORS-1732 > URL: https://issues.apache.org/jira/browse/CONNECTORS-1732 > Project: ManifoldCF > Issue Type: Bug > Components: Build >Affects Versions: ManifoldCF 2.22 >Reporter: Julien Massiera >Priority: Major > > The Github mirror seems out of sync with the SVN repo since June 2022 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [manifoldcf] dependabot[bot] commented on pull request #135: Bump jsoup from 1.8.1 to 1.15.3 in /connectors/searchblox
dependabot[bot] commented on PR #135: URL: https://github.com/apache/manifoldcf/pull/135#issuecomment-1253849922 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting `@dependabot ignore this major version` or `@dependabot ignore this minor version`. If you change your mind, just re-open this PR and I'll resolve any conflicts on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@manifoldcf.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [manifoldcf] dependabot[bot] commented on pull request #129: Bump wss4j from 1.5.12 to 1.6.17 in /framework/connector-common
dependabot[bot] commented on PR #129: URL: https://github.com/apache/manifoldcf/pull/129#issuecomment-1253849946 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting `@dependabot ignore this major version` or `@dependabot ignore this minor version`. If you change your mind, just re-open this PR and I'll resolve any conflicts on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@manifoldcf.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [manifoldcf] dependabot[bot] commented on pull request #126: Bump opennlp-tools from 1.6.0 to 1.8.2 in /connectors/opennlp
dependabot[bot] commented on PR #126: URL: https://github.com/apache/manifoldcf/pull/126#issuecomment-1253849898 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting `@dependabot ignore this major version` or `@dependabot ignore this minor version`. If you change your mind, just re-open this PR and I'll resolve any conflicts on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@manifoldcf.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [manifoldcf] dependabot[bot] commented on pull request #124: Bump elasticsearch from 1.0.1 to 6.8.17 in /connectors/elasticsearch
dependabot[bot] commented on PR #124: URL: https://github.com/apache/manifoldcf/pull/124#issuecomment-1253849864 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting `@dependabot ignore this major version` or `@dependabot ignore this minor version`. If you change your mind, just re-open this PR and I'll resolve any conflicts on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@manifoldcf.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [manifoldcf] asfgit closed pull request #135: Bump jsoup from 1.8.1 to 1.15.3 in /connectors/searchblox
asfgit closed pull request #135: Bump jsoup from 1.8.1 to 1.15.3 in /connectors/searchblox URL: https://github.com/apache/manifoldcf/pull/135 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@manifoldcf.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [manifoldcf] asfgit closed pull request #126: Bump opennlp-tools from 1.6.0 to 1.8.2 in /connectors/opennlp
asfgit closed pull request #126: Bump opennlp-tools from 1.6.0 to 1.8.2 in /connectors/opennlp URL: https://github.com/apache/manifoldcf/pull/126 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@manifoldcf.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [manifoldcf] asfgit closed pull request #129: Bump wss4j from 1.5.12 to 1.6.17 in /framework/connector-common
asfgit closed pull request #129: Bump wss4j from 1.5.12 to 1.6.17 in /framework/connector-common URL: https://github.com/apache/manifoldcf/pull/129 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@manifoldcf.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [manifoldcf] dependabot[bot] commented on pull request #133: Bump aws-java-sdk-s3 from 1.9.0 to 1.12.261 in /connectors/amazons3
dependabot[bot] commented on PR #133: URL: https://github.com/apache/manifoldcf/pull/133#issuecomment-1253849840 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting `@dependabot ignore this major version` or `@dependabot ignore this minor version`. If you change your mind, just re-open this PR and I'll resolve any conflicts on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@manifoldcf.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [manifoldcf] dependabot[bot] commented on pull request #130: Bump xalan from 2.7.0 to 2.7.2 in /connectors/alfresco
dependabot[bot] commented on PR #130: URL: https://github.com/apache/manifoldcf/pull/130#issuecomment-1253849792 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting `@dependabot ignore this major version` or `@dependabot ignore this minor version`. If you change your mind, just re-open this PR and I'll resolve any conflicts on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@manifoldcf.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [manifoldcf] asfgit closed pull request #124: Bump elasticsearch from 1.0.1 to 6.8.17 in /connectors/elasticsearch
asfgit closed pull request #124: Bump elasticsearch from 1.0.1 to 6.8.17 in /connectors/elasticsearch URL: https://github.com/apache/manifoldcf/pull/124 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@manifoldcf.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [manifoldcf] asfgit closed pull request #133: Bump aws-java-sdk-s3 from 1.9.0 to 1.12.261 in /connectors/amazons3
asfgit closed pull request #133: Bump aws-java-sdk-s3 from 1.9.0 to 1.12.261 in /connectors/amazons3 URL: https://github.com/apache/manifoldcf/pull/133 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@manifoldcf.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [manifoldcf] dependabot[bot] commented on pull request #125: Bump xercesImpl from 2.8.0 to 2.12.2 in /connectors/alfresco
dependabot[bot] commented on PR #125: URL: https://github.com/apache/manifoldcf/pull/125#issuecomment-1253849816 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting `@dependabot ignore this major version` or `@dependabot ignore this minor version`. If you change your mind, just re-open this PR and I'll resolve any conflicts on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@manifoldcf.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [manifoldcf] dependabot[bot] commented on pull request #131: Bump xmlsec from 1.4.0 to 2.1.7 in /connectors/alfresco
dependabot[bot] commented on PR #131: URL: https://github.com/apache/manifoldcf/pull/131#issuecomment-1253849767 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting `@dependabot ignore this major version` or `@dependabot ignore this minor version`. If you change your mind, just re-open this PR and I'll resolve any conflicts on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@manifoldcf.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [manifoldcf] asfgit closed pull request #130: Bump xalan from 2.7.0 to 2.7.2 in /connectors/alfresco
asfgit closed pull request #130: Bump xalan from 2.7.0 to 2.7.2 in /connectors/alfresco URL: https://github.com/apache/manifoldcf/pull/130 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@manifoldcf.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [manifoldcf] asfgit closed pull request #125: Bump xercesImpl from 2.8.0 to 2.12.2 in /connectors/alfresco
asfgit closed pull request #125: Bump xercesImpl from 2.8.0 to 2.12.2 in /connectors/alfresco URL: https://github.com/apache/manifoldcf/pull/125 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@manifoldcf.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [manifoldcf] dependabot[bot] commented on pull request #127: Bump jsch from 0.1.38 to 0.1.54 in /connectors/alfresco
dependabot[bot] commented on PR #127: URL: https://github.com/apache/manifoldcf/pull/127#issuecomment-1253849735 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting `@dependabot ignore this major version` or `@dependabot ignore this minor version`. If you change your mind, just re-open this PR and I'll resolve any conflicts on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@manifoldcf.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [manifoldcf] asfgit closed pull request #131: Bump xmlsec from 1.4.0 to 2.1.7 in /connectors/alfresco
asfgit closed pull request #131: Bump xmlsec from 1.4.0 to 2.1.7 in /connectors/alfresco URL: https://github.com/apache/manifoldcf/pull/131 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@manifoldcf.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [manifoldcf] asfgit closed pull request #127: Bump jsch from 0.1.38 to 0.1.54 in /connectors/alfresco
asfgit closed pull request #127: Bump jsch from 0.1.38 to 0.1.54 in /connectors/alfresco URL: https://github.com/apache/manifoldcf/pull/127 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@manifoldcf.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (CONNECTORS-1732) Github mirror out of sync
Julien Massiera created CONNECTORS-1732: --- Summary: Github mirror out of sync Key: CONNECTORS-1732 URL: https://issues.apache.org/jira/browse/CONNECTORS-1732 Project: ManifoldCF Issue Type: Bug Components: Build Affects Versions: ManifoldCF 2.22 Reporter: Julien Massiera The Github mirror seems out of sync with the SVN repo since June 2022 -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: Github mirror out of sync
It's not been reported before, no. Can you file an INFRA ticket for this? Karl On Wed, Sep 21, 2022 at 10:48 AM Julien Massiera < julien.massi...@francelabs.com> wrote: > Hi, > > > > I am not sure it has been reported but the Github mirror seems out of sync > with the SVN repo since June > > > > Julien > > > > > > > >
Github mirror out of sync
Hi, I am not sure it has been reported but the Github mirror seems out of sync with the SVN repo since June Julien
[jira] [Resolved] (CONNECTORS-1731) Suggestion for adding handling process for ManifoldCFException in Generic Repository Connector
[
https://issues.apache.org/jira/browse/CONNECTORS-1731?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Karl Wright resolved CONNECTORS-1731.
-
Fix Version/s: ManifoldCF next
Resolution: Fixed
> Suggestion for adding handling process for ManifoldCFException in Generic
> Repository Connector
> --
>
> Key: CONNECTORS-1731
> URL: https://issues.apache.org/jira/browse/CONNECTORS-1731
> Project: ManifoldCF
> Issue Type: Improvement
>Reporter: Nguyen Huu Nhat
>Assignee: Karl Wright
>Priority: Major
> Fix For: ManifoldCF next
>
> Attachments: patch.txt, patch_update.txt
>
>
> Hi there,
> I would like to suggest the following retry-related improvements:
> h3. +*1. Connector name*+
> Generic Repository Connector
> h3. +*2. Reasons for improvement*+
> In the process of ExecuteSeedingThread, DocumentVersionThread and
> ExecuteProcessThread, when HttpClient.execute is executed, there are chances
> that connection gets interrupted and connection error occurs (HTTP status
> code <> 200).
> When HTTP status code <> 200, exception of type ManifoldCFException will be
> thrown. However, there is no process to handle this, which leads to job being
> aborted.
> As errors relating to connection (HTTP status code <> 200) can be resolved
> automatically, retry should be added for cases like this.
> h3. +*3. Improvements*+
> Improvement includes the followings:
> * Adding method to handle retry for exception of type ManifoldCFException
> * Calling method to handle ManifoldCFException exception generated when
> executing in threads: ExecuteSeedingThread, DocumentVersionThread,
> ExecuteProcessThread
> h3. +*4. Suggested source code (based on release 2.22.1)*+
> * Adding method to handle retry for exception of type ManifoldCFException
> [https://github.com/apache/manifoldcf/blob/release-2.22.1/connectors/generic/connector/src/main/java/org/apache/manifoldcf/crawler/connectors/generic/GenericConnector.java#L1026]
> {code:java}
> /**
>* Function for handling ManifoldCFException exception caused by connection
> error.
>* In case of connection error, ServiceInterruption exception is thrown to
> perform retry.
>*
>* @param e ManifoldCFException
>* @throws ServiceInterruption
>*/
> protected static void handleManifoldCFException(ManifoldCFException e)
> throws ServiceInterruption {
> long currentTime = System.currentTimeMillis();
> throw new ServiceInterruption("Connection error: " + e.getMessage(), e,
> currentTime + 30L,
> currentTime + 3 * 60 * 6L, -1, false);
> }
> {code}
> * Calling method to handle ManifoldCFException exception generated when
> executing in threads: ExecuteSeedingThread, DocumentVersionThread,
> ExecuteProcessThread
> ** ExecuteSeedingThread
> [https://github.com/apache/manifoldcf/blob/release-2.22.1/connectors/generic/connector/src/main/java/org/apache/manifoldcf/crawler/connectors/generic/GenericConnector.java#L256]
> {code:java}
> } catch (InterruptedException e) {
> t.interrupt();
> throw new ManifoldCFException("Interrupted: " + e.getMessage(), e,
> ManifoldCFException.INTERRUPTED);
> + } catch (ManifoldCFException e) {
> + handleManifoldCFException(e);
> }
> return new Long(seedTime).toString();
> {code}
> ** DocumentVersionThread
> [https://github.com/apache/manifoldcf/blob/release-2.22.1/connectors/generic/connector/src/main/java/org/apache/manifoldcf/crawler/connectors/generic/GenericConnector.java#L304]
> {code:java}
> try {
> versions = versioningThread.finishUp();
> } catch (IOException ex) {
> handleIOException((IOException)ex);
> + } catch (ManifoldCFException ex) {
> + handleManifoldCFException(ex);
> } catch (InterruptedException ex) {
> throw new ManifoldCFException(ex.getMessage(), ex,
> ManifoldCFException.INTERRUPTED);
> }
> {code}
> ** ExecuteProcessThread
> [https://github.com/apache/manifoldcf/blob/release-2.22.1/connectors/generic/connector/src/main/java/org/apache/manifoldcf/crawler/connectors/generic/GenericConnector.java#L445]
> {code:java}
> } catch (InterruptedIOException e) {
> t.interrupt();
> throw new ManifoldCFException("Interrupted: " + e.getMessage(),
> e, ManifoldCFException.INTERRUPTED);
> } catch (IOException e) {
> handleIOException(e);
> + } catch (ManifoldCFException e) {
> + handleManifoldCFException(e);
> }
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (CONNECTORS-1731) Suggestion for adding handling process for ManifoldCFException in Generic Repository Connector
[
https://issues.apache.org/jira/browse/CONNECTORS-1731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17607635#comment-17607635
]
Karl Wright commented on CONNECTORS-1731:
-
r1904186
> Suggestion for adding handling process for ManifoldCFException in Generic
> Repository Connector
> --
>
> Key: CONNECTORS-1731
> URL: https://issues.apache.org/jira/browse/CONNECTORS-1731
> Project: ManifoldCF
> Issue Type: Improvement
>Reporter: Nguyen Huu Nhat
>Assignee: Karl Wright
>Priority: Major
> Attachments: patch.txt, patch_update.txt
>
>
> Hi there,
> I would like to suggest the following retry-related improvements:
> h3. +*1. Connector name*+
> Generic Repository Connector
> h3. +*2. Reasons for improvement*+
> In the process of ExecuteSeedingThread, DocumentVersionThread and
> ExecuteProcessThread, when HttpClient.execute is executed, there are chances
> that connection gets interrupted and connection error occurs (HTTP status
> code <> 200).
> When HTTP status code <> 200, exception of type ManifoldCFException will be
> thrown. However, there is no process to handle this, which leads to job being
> aborted.
> As errors relating to connection (HTTP status code <> 200) can be resolved
> automatically, retry should be added for cases like this.
> h3. +*3. Improvements*+
> Improvement includes the followings:
> * Adding method to handle retry for exception of type ManifoldCFException
> * Calling method to handle ManifoldCFException exception generated when
> executing in threads: ExecuteSeedingThread, DocumentVersionThread,
> ExecuteProcessThread
> h3. +*4. Suggested source code (based on release 2.22.1)*+
> * Adding method to handle retry for exception of type ManifoldCFException
> [https://github.com/apache/manifoldcf/blob/release-2.22.1/connectors/generic/connector/src/main/java/org/apache/manifoldcf/crawler/connectors/generic/GenericConnector.java#L1026]
> {code:java}
> /**
>* Function for handling ManifoldCFException exception caused by connection
> error.
>* In case of connection error, ServiceInterruption exception is thrown to
> perform retry.
>*
>* @param e ManifoldCFException
>* @throws ServiceInterruption
>*/
> protected static void handleManifoldCFException(ManifoldCFException e)
> throws ServiceInterruption {
> long currentTime = System.currentTimeMillis();
> throw new ServiceInterruption("Connection error: " + e.getMessage(), e,
> currentTime + 30L,
> currentTime + 3 * 60 * 6L, -1, false);
> }
> {code}
> * Calling method to handle ManifoldCFException exception generated when
> executing in threads: ExecuteSeedingThread, DocumentVersionThread,
> ExecuteProcessThread
> ** ExecuteSeedingThread
> [https://github.com/apache/manifoldcf/blob/release-2.22.1/connectors/generic/connector/src/main/java/org/apache/manifoldcf/crawler/connectors/generic/GenericConnector.java#L256]
> {code:java}
> } catch (InterruptedException e) {
> t.interrupt();
> throw new ManifoldCFException("Interrupted: " + e.getMessage(), e,
> ManifoldCFException.INTERRUPTED);
> + } catch (ManifoldCFException e) {
> + handleManifoldCFException(e);
> }
> return new Long(seedTime).toString();
> {code}
> ** DocumentVersionThread
> [https://github.com/apache/manifoldcf/blob/release-2.22.1/connectors/generic/connector/src/main/java/org/apache/manifoldcf/crawler/connectors/generic/GenericConnector.java#L304]
> {code:java}
> try {
> versions = versioningThread.finishUp();
> } catch (IOException ex) {
> handleIOException((IOException)ex);
> + } catch (ManifoldCFException ex) {
> + handleManifoldCFException(ex);
> } catch (InterruptedException ex) {
> throw new ManifoldCFException(ex.getMessage(), ex,
> ManifoldCFException.INTERRUPTED);
> }
> {code}
> ** ExecuteProcessThread
> [https://github.com/apache/manifoldcf/blob/release-2.22.1/connectors/generic/connector/src/main/java/org/apache/manifoldcf/crawler/connectors/generic/GenericConnector.java#L445]
> {code:java}
> } catch (InterruptedIOException e) {
> t.interrupt();
> throw new ManifoldCFException("Interrupted: " + e.getMessage(),
> e, ManifoldCFException.INTERRUPTED);
> } catch (IOException e) {
> handleIOException(e);
> + } catch (ManifoldCFException e) {
> + handleManifoldCFException(e);
> }
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (CONNECTORS-1731) Suggestion for adding handling process for ManifoldCFException in Generic Repository Connector
[
https://issues.apache.org/jira/browse/CONNECTORS-1731?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nguyen Huu Nhat updated CONNECTORS-1731:
Description:
Hi there,
I would like to suggest the following retry-related improvements:
h3. +*1. Connector name*+
Generic Repository Connector
h3. +*2. Reasons for improvement*+
In the process of ExecuteSeedingThread, DocumentVersionThread and
ExecuteProcessThread, when HttpClient.execute is executed, there are chances
that connection gets interrupted and connection error occurs (HTTP status code
<> 200).
When HTTP status code <> 200, exception of type ManifoldCFException will be
thrown. However, there is no process to handle this, which leads to job being
aborted.
As errors relating to connection (HTTP status code <> 200) can be resolved
automatically, retry should be added for cases like this.
h3. +*3. Improvements*+
Improvement includes the followings:
* Adding method to handle retry for exception of type ManifoldCFException
* Calling method to handle ManifoldCFException exception generated when
executing in threads: ExecuteSeedingThread, DocumentVersionThread,
ExecuteProcessThread
h3. +*4. Suggested source code (based on release 2.22.1)*+
* Adding method to handle retry for exception of type ManifoldCFException
[https://github.com/apache/manifoldcf/blob/release-2.22.1/connectors/generic/connector/src/main/java/org/apache/manifoldcf/crawler/connectors/generic/GenericConnector.java#L1026]
{code:java}
/**
* Function for handling ManifoldCFException exception caused by connection
error.
* In case of connection error, ServiceInterruption exception is thrown to
perform retry.
*
* @param e ManifoldCFException
* @throws ServiceInterruption
*/
protected static void handleManifoldCFException(ManifoldCFException e)
throws ServiceInterruption {
long currentTime = System.currentTimeMillis();
throw new ServiceInterruption("Connection error: " + e.getMessage(), e,
currentTime + 30L,
currentTime + 3 * 60 * 6L, -1, false);
}
{code}
* Calling method to handle ManifoldCFException exception generated when
executing in threads: ExecuteSeedingThread, DocumentVersionThread,
ExecuteProcessThread
** ExecuteSeedingThread
[https://github.com/apache/manifoldcf/blob/release-2.22.1/connectors/generic/connector/src/main/java/org/apache/manifoldcf/crawler/connectors/generic/GenericConnector.java#L256]
{code:java}
} catch (InterruptedException e) {
t.interrupt();
throw new ManifoldCFException("Interrupted: " + e.getMessage(), e,
ManifoldCFException.INTERRUPTED);
+ } catch (ManifoldCFException e) {
+ handleManifoldCFException(e);
}
return new Long(seedTime).toString();
{code}
** DocumentVersionThread
[https://github.com/apache/manifoldcf/blob/release-2.22.1/connectors/generic/connector/src/main/java/org/apache/manifoldcf/crawler/connectors/generic/GenericConnector.java#L304]
{code:java}
try {
versions = versioningThread.finishUp();
} catch (IOException ex) {
handleIOException((IOException)ex);
+ } catch (ManifoldCFException ex) {
+ handleManifoldCFException(ex);
} catch (InterruptedException ex) {
throw new ManifoldCFException(ex.getMessage(), ex,
ManifoldCFException.INTERRUPTED);
}
{code}
** ExecuteProcessThread
[https://github.com/apache/manifoldcf/blob/release-2.22.1/connectors/generic/connector/src/main/java/org/apache/manifoldcf/crawler/connectors/generic/GenericConnector.java#L445]
{code:java}
} catch (InterruptedIOException e) {
t.interrupt();
throw new ManifoldCFException("Interrupted: " + e.getMessage(),
e, ManifoldCFException.INTERRUPTED);
} catch (IOException e) {
handleIOException(e);
+ } catch (ManifoldCFException e) {
+ handleManifoldCFException(e);
}
{code}
was:
Hi there,
I would like to suggest the following retry-related improvements:
h3. +*1. Connector name*+
Generic Repository Connector
h3. +*2. Reasons for improvement*+
In the process of ExecuteSeedingThread, DocumentVersionThread and
ExecuteProcessThread, when HttpClient.execute is executed, there are chances
that connection gets interrupted and connection error occurs (HTTP status code
<> 200).
When HTTP status code <> 200, exception of type ManifoldCFException will be
thrown. However, there is no process to handle this, which leads to job being
aborted.
As errors relating to connection (HTTP status code <> 200) can be resolved
automatically, retry should be added for cases like this.
h3. +*3. Improvements*+
Improvement includes the followings:
* Adding method to handle retry for exception of type ManifoldCFException
* Calling method to handle ManifoldCFException exception generated when
executing in threads: ExecuteSeedingThread,
[jira] [Updated] (CONNECTORS-1731) Suggestion for adding handling process for ManifoldCFException in Generic Repository Connector
[
https://issues.apache.org/jira/browse/CONNECTORS-1731?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nguyen Huu Nhat updated CONNECTORS-1731:
Attachment: patch_update.txt
> Suggestion for adding handling process for ManifoldCFException in Generic
> Repository Connector
> --
>
> Key: CONNECTORS-1731
> URL: https://issues.apache.org/jira/browse/CONNECTORS-1731
> Project: ManifoldCF
> Issue Type: Improvement
>Reporter: Nguyen Huu Nhat
>Assignee: Karl Wright
>Priority: Major
> Attachments: patch.txt, patch_update.txt
>
>
> Hi there,
> I would like to suggest the following retry-related improvements:
> h3. +*1. Connector name*+
> Generic Repository Connector
> h3. +*2. Reasons for improvement*+
> In the process of ExecuteSeedingThread, DocumentVersionThread and
> ExecuteProcessThread, when HttpClient.execute is executed, there are chances
> that connection gets interrupted and connection error occurs (HTTP status
> code <> 200).
> When HTTP status code <> 200, exception of type ManifoldCFException will be
> thrown. However, there is no process to handle this, which leads to job being
> aborted.
> As errors relating to connection (HTTP status code <> 200) can be resolved
> automatically, retry should be added for cases like this.
> h3. +*3. Improvements*+
> Improvement includes the followings:
> * Adding method to handle retry for exception of type ManifoldCFException
> * Calling method to handle ManifoldCFException exception generated when
> executing in threads: ExecuteSeedingThread, DocumentVersionThread,
> ExecuteProcessThread
> h3. +*4. Suggested source code (based on release 2.22.1)*+
> * Adding method to handle retry for exception of type ManifoldCFException
> [https://github.com/apache/manifoldcf/blob/release-2.22.1/connectors/generic/connector/src/main/java/org/apache/manifoldcf/crawler/connectors/generic/GenericConnector.java#L1026]
> {code:java}
> /**
>* Function for handling ManifoldCFException exception caused by connection
> error.
>* In case of connection error, ServiceInterruption exception is thrown to
> perform retry.
>*
>* @param e ManifoldCFException
>* @throws ServiceInterruption
>*/
> protected static void handleManifoldCFException(ManifoldCFException e)
> throws ServiceInterruption {
> long currentTime = System.currentTimeMillis();
> throw new ServiceInterruption("Connection error: " + e.getMessage(), e,
> currentTime + 30L,
> currentTime + timeToFail * 3 * 60 * 6L, -1, false);
> }
> {code}
> * Calling method to handle ManifoldCFException exception generated when
> executing in threads: ExecuteSeedingThread, DocumentVersionThread,
> ExecuteProcessThread
> ** ExecuteSeedingThread
> [https://github.com/apache/manifoldcf/blob/release-2.22.1/connectors/generic/connector/src/main/java/org/apache/manifoldcf/crawler/connectors/generic/GenericConnector.java#L256]
> {code:java}
> } catch (InterruptedException e) {
> t.interrupt();
> throw new ManifoldCFException("Interrupted: " + e.getMessage(), e,
> ManifoldCFException.INTERRUPTED);
> + } catch (ManifoldCFException e) {
> + handleManifoldCFException(e);
> }
> return new Long(seedTime).toString();
> {code}
> ** DocumentVersionThread
> [https://github.com/apache/manifoldcf/blob/release-2.22.1/connectors/generic/connector/src/main/java/org/apache/manifoldcf/crawler/connectors/generic/GenericConnector.java#L304]
> {code:java}
> try {
> versions = versioningThread.finishUp();
> } catch (IOException ex) {
> handleIOException((IOException)ex);
> + } catch (ManifoldCFException ex) {
> + handleManifoldCFException(ex);
> } catch (InterruptedException ex) {
> throw new ManifoldCFException(ex.getMessage(), ex,
> ManifoldCFException.INTERRUPTED);
> }
> {code}
> ** ExecuteProcessThread
> [https://github.com/apache/manifoldcf/blob/release-2.22.1/connectors/generic/connector/src/main/java/org/apache/manifoldcf/crawler/connectors/generic/GenericConnector.java#L445]
> {code:java}
> } catch (InterruptedIOException e) {
> t.interrupt();
> throw new ManifoldCFException("Interrupted: " + e.getMessage(),
> e, ManifoldCFException.INTERRUPTED);
> } catch (IOException e) {
> handleIOException(e);
> + } catch (ManifoldCFException e) {
> + handleManifoldCFException(e);
> }
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (CONNECTORS-1731) Suggestion for adding handling process for ManifoldCFException in Generic Repository Connector
[
https://issues.apache.org/jira/browse/CONNECTORS-1731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17607630#comment-17607630
]
Nguyen Huu Nhat commented on CONNECTORS-1731:
-
Sorry. The patch file is currently a bit mistake about the modification source
code. I updated that part in the attached file.
Please check again with the file below:
[^patch_update.txt]
> Suggestion for adding handling process for ManifoldCFException in Generic
> Repository Connector
> --
>
> Key: CONNECTORS-1731
> URL: https://issues.apache.org/jira/browse/CONNECTORS-1731
> Project: ManifoldCF
> Issue Type: Improvement
>Reporter: Nguyen Huu Nhat
>Assignee: Karl Wright
>Priority: Major
> Attachments: patch.txt, patch_update.txt
>
>
> Hi there,
> I would like to suggest the following retry-related improvements:
> h3. +*1. Connector name*+
> Generic Repository Connector
> h3. +*2. Reasons for improvement*+
> In the process of ExecuteSeedingThread, DocumentVersionThread and
> ExecuteProcessThread, when HttpClient.execute is executed, there are chances
> that connection gets interrupted and connection error occurs (HTTP status
> code <> 200).
> When HTTP status code <> 200, exception of type ManifoldCFException will be
> thrown. However, there is no process to handle this, which leads to job being
> aborted.
> As errors relating to connection (HTTP status code <> 200) can be resolved
> automatically, retry should be added for cases like this.
> h3. +*3. Improvements*+
> Improvement includes the followings:
> * Adding method to handle retry for exception of type ManifoldCFException
> * Calling method to handle ManifoldCFException exception generated when
> executing in threads: ExecuteSeedingThread, DocumentVersionThread,
> ExecuteProcessThread
> h3. +*4. Suggested source code (based on release 2.22.1)*+
> * Adding method to handle retry for exception of type ManifoldCFException
> [https://github.com/apache/manifoldcf/blob/release-2.22.1/connectors/generic/connector/src/main/java/org/apache/manifoldcf/crawler/connectors/generic/GenericConnector.java#L1026]
> {code:java}
> /**
>* Function for handling ManifoldCFException exception caused by connection
> error.
>* In case of connection error, ServiceInterruption exception is thrown to
> perform retry.
>*
>* @param e ManifoldCFException
>* @throws ServiceInterruption
>*/
> protected static void handleManifoldCFException(ManifoldCFException e)
> throws ServiceInterruption {
> long currentTime = System.currentTimeMillis();
> throw new ServiceInterruption("Connection error: " + e.getMessage(), e,
> currentTime + 30L,
> currentTime + timeToFail * 3 * 60 * 6L, -1, false);
> }
> {code}
> * Calling method to handle ManifoldCFException exception generated when
> executing in threads: ExecuteSeedingThread, DocumentVersionThread,
> ExecuteProcessThread
> ** ExecuteSeedingThread
> [https://github.com/apache/manifoldcf/blob/release-2.22.1/connectors/generic/connector/src/main/java/org/apache/manifoldcf/crawler/connectors/generic/GenericConnector.java#L256]
> {code:java}
> } catch (InterruptedException e) {
> t.interrupt();
> throw new ManifoldCFException("Interrupted: " + e.getMessage(), e,
> ManifoldCFException.INTERRUPTED);
> + } catch (ManifoldCFException e) {
> + handleManifoldCFException(e);
> }
> return new Long(seedTime).toString();
> {code}
> ** DocumentVersionThread
> [https://github.com/apache/manifoldcf/blob/release-2.22.1/connectors/generic/connector/src/main/java/org/apache/manifoldcf/crawler/connectors/generic/GenericConnector.java#L304]
> {code:java}
> try {
> versions = versioningThread.finishUp();
> } catch (IOException ex) {
> handleIOException((IOException)ex);
> + } catch (ManifoldCFException ex) {
> + handleManifoldCFException(ex);
> } catch (InterruptedException ex) {
> throw new ManifoldCFException(ex.getMessage(), ex,
> ManifoldCFException.INTERRUPTED);
> }
> {code}
> ** ExecuteProcessThread
> [https://github.com/apache/manifoldcf/blob/release-2.22.1/connectors/generic/connector/src/main/java/org/apache/manifoldcf/crawler/connectors/generic/GenericConnector.java#L445]
> {code:java}
> } catch (InterruptedIOException e) {
> t.interrupt();
> throw new ManifoldCFException("Interrupted: " + e.getMessage(),
> e, ManifoldCFException.INTERRUPTED);
> } catch (IOException e) {
> handleIOException(e);
> + } catch (ManifoldCFException e) {
> + handleManifoldCFException(e);
> }
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (CONNECTORS-1731) Suggestion for adding handling process for ManifoldCFException in Generic Repository Connector
[
https://issues.apache.org/jira/browse/CONNECTORS-1731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17607619#comment-17607619
]
Karl Wright commented on CONNECTORS-1731:
-
Patch applies but the code doesn't build. Here is the error:
{code}
[javac]
C:\wip\mcf\trunk\connectors\generic\connector\src\main\java\org\apache\manifoldcf\crawler\connectors\generic\GenericConnector.java:1044:
error: cannot find symbol
[javac] currentTime + timeToFail * 3 * 60 * 6L, -1, false);
[javac] ^
[javac] symbol: variable timeToFail
[javac] location: class GenericConnector
{code}
> Suggestion for adding handling process for ManifoldCFException in Generic
> Repository Connector
> --
>
> Key: CONNECTORS-1731
> URL: https://issues.apache.org/jira/browse/CONNECTORS-1731
> Project: ManifoldCF
> Issue Type: Improvement
>Reporter: Nguyen Huu Nhat
>Assignee: Karl Wright
>Priority: Major
> Attachments: patch.txt
>
>
> Hi there,
> I would like to suggest the following retry-related improvements:
> h3. +*1. Connector name*+
> Generic Repository Connector
> h3. +*2. Reasons for improvement*+
> In the process of ExecuteSeedingThread, DocumentVersionThread and
> ExecuteProcessThread, when HttpClient.execute is executed, there are chances
> that connection gets interrupted and connection error occurs (HTTP status
> code <> 200).
> When HTTP status code <> 200, exception of type ManifoldCFException will be
> thrown. However, there is no process to handle this, which leads to job being
> aborted.
> As errors relating to connection (HTTP status code <> 200) can be resolved
> automatically, retry should be added for cases like this.
> h3. +*3. Improvements*+
> Improvement includes the followings:
> * Adding method to handle retry for exception of type ManifoldCFException
> * Calling method to handle ManifoldCFException exception generated when
> executing in threads: ExecuteSeedingThread, DocumentVersionThread,
> ExecuteProcessThread
> h3. +*4. Suggested source code (based on release 2.22.1)*+
> * Adding method to handle retry for exception of type ManifoldCFException
> [https://github.com/apache/manifoldcf/blob/release-2.22.1/connectors/generic/connector/src/main/java/org/apache/manifoldcf/crawler/connectors/generic/GenericConnector.java#L1026]
> {code:java}
> /**
>* Function for handling ManifoldCFException exception caused by connection
> error.
>* In case of connection error, ServiceInterruption exception is thrown to
> perform retry.
>*
>* @param e ManifoldCFException
>* @throws ServiceInterruption
>*/
> protected static void handleManifoldCFException(ManifoldCFException e)
> throws ServiceInterruption {
> long currentTime = System.currentTimeMillis();
> throw new ServiceInterruption("Connection error: " + e.getMessage(), e,
> currentTime + 30L,
> currentTime + timeToFail * 3 * 60 * 6L, -1, false);
> }
> {code}
> * Calling method to handle ManifoldCFException exception generated when
> executing in threads: ExecuteSeedingThread, DocumentVersionThread,
> ExecuteProcessThread
> ** ExecuteSeedingThread
> [https://github.com/apache/manifoldcf/blob/release-2.22.1/connectors/generic/connector/src/main/java/org/apache/manifoldcf/crawler/connectors/generic/GenericConnector.java#L256]
> {code:java}
> } catch (InterruptedException e) {
> t.interrupt();
> throw new ManifoldCFException("Interrupted: " + e.getMessage(), e,
> ManifoldCFException.INTERRUPTED);
> + } catch (ManifoldCFException e) {
> + handleManifoldCFException(e);
> }
> return new Long(seedTime).toString();
> {code}
> ** DocumentVersionThread
> [https://github.com/apache/manifoldcf/blob/release-2.22.1/connectors/generic/connector/src/main/java/org/apache/manifoldcf/crawler/connectors/generic/GenericConnector.java#L304]
> {code:java}
> try {
> versions = versioningThread.finishUp();
> } catch (IOException ex) {
> handleIOException((IOException)ex);
> + } catch (ManifoldCFException ex) {
> + handleManifoldCFException(ex);
> } catch (InterruptedException ex) {
> throw new ManifoldCFException(ex.getMessage(), ex,
> ManifoldCFException.INTERRUPTED);
> }
> {code}
> ** ExecuteProcessThread
> [https://github.com/apache/manifoldcf/blob/release-2.22.1/connectors/generic/connector/src/main/java/org/apache/manifoldcf/crawler/connectors/generic/GenericConnector.java#L445]
> {code:java}
> } catch (InterruptedIOException e) {
> t.interrupt();
> throw new ManifoldCFException("Interrupted: " + e.getMessage(),
> e, ManifoldCFException.INTERRUPTED);
> } catch
