[jira] [Commented] (CONNECTORS-1545) Parentheses in editConfiguration tab labels not supported

2018-10-12 Thread Julien Massiera (JIRA)


[ 
https://issues.apache.org/jira/browse/CONNECTORS-1545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16647789#comment-16647789
 ] 

Julien Massiera commented on CONNECTORS-1545:
-

Hi [~kishorekumar],

Yes it works !

Thanks

> Parentheses in editConfiguration tab labels not supported
> -
>
> Key: CONNECTORS-1545
> URL: https://issues.apache.org/jira/browse/CONNECTORS-1545
> Project: ManifoldCF
>  Issue Type: Bug
>  Components: Web connector
>Affects Versions: ManifoldCF 2.11
>Reporter: Julien Massiera
>Assignee: Kishore Kumar
>Priority: Minor
>
> In the editConfiguration view of the web connector, the tab 
> 'AccessCredentials' is not "clickable" in the french version of the UI.
> It seems to be due to the presence of parentheses in the string "Informations 
> d'accès (Access Credentials)" as it is used to trigger the javascript 
> function of the tab and so is misinterpreted
> Need to check if similar cases are present for other connectors 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CONNECTORS-1545) Parentheses in editConfiguration tab labels not supported

2018-10-10 Thread Kishore Kumar (JIRA)


[ 
https://issues.apache.org/jira/browse/CONNECTORS-1545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16645562#comment-16645562
 ] 

Kishore Kumar commented on CONNECTORS-1545:
---

Hi [~julienFL] ,

 

I have committed a fix for this issue. The tab names were not escaped. Please 
test now and let me know

r1843509

 

Thanks,

Kishore Kumar

> Parentheses in editConfiguration tab labels not supported
> -
>
> Key: CONNECTORS-1545
> URL: https://issues.apache.org/jira/browse/CONNECTORS-1545
> Project: ManifoldCF
>  Issue Type: Bug
>  Components: Web connector
>Affects Versions: ManifoldCF 2.11
>Reporter: Julien Massiera
>Assignee: Kishore Kumar
>Priority: Minor
>
> In the editConfiguration view of the web connector, the tab 
> 'AccessCredentials' is not "clickable" in the french version of the UI.
> It seems to be due to the presence of parentheses in the string "Informations 
> d'accès (Access Credentials)" as it is used to trigger the javascript 
> function of the tab and so is misinterpreted
> Need to check if similar cases are present for other connectors 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CONNECTORS-1545) Parentheses in editConfiguration tab labels not supported

2018-10-10 Thread Julien Massiera (JIRA)


[ 
https://issues.apache.org/jira/browse/CONNECTORS-1545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16645486#comment-16645486
 ] 

Julien Massiera commented on CONNECTORS-1545:
-

Hi [~kwri...@metacarta.com], my explanations were not so clear so let me expose 
what I noticed so far :

When the UI is in french, the 'AccessCredentials' is not "clickable" in the web 
repository connector configuration. I observed the console log and noticed the 
following error : 
SyntaxError: "" string literal contains an unescaped line break

So I checked the HTML code of the concerned tab and discovered this : 
Informations d'accès (Access 
Credentials)

 

So as you can see, the onclick function of the tab is clearly wrong because of 
the tab label which is re-used somehow here. After reviewing it, I notice that 
the problem is not caused by the parentheses but eventually by the apostrophe.

Also, I noticed the same problem for the JDBC connector 

> Parentheses in editConfiguration tab labels not supported
> -
>
> Key: CONNECTORS-1545
> URL: https://issues.apache.org/jira/browse/CONNECTORS-1545
> Project: ManifoldCF
>  Issue Type: Bug
>  Components: Web connector
>Affects Versions: ManifoldCF 2.11
>Reporter: Julien Massiera
>Assignee: Karl Wright
>Priority: Minor
>
> In the editConfiguration view of the web connector, the tab 
> 'AccessCredentials' is not "clickable" in the french version of the UI.
> It seems to be due to the presence of parentheses in the string "Informations 
> d'accès (Access Credentials)" as it is used to trigger the javascript 
> function of the tab and so is misinterpreted
> Need to check if similar cases are present for other connectors 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CONNECTORS-1545) Parentheses in editConfiguration tab labels not supported

2018-10-09 Thread Karl Wright (JIRA)


[ 
https://issues.apache.org/jira/browse/CONNECTORS-1545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16644282#comment-16644282
 ] 

Karl Wright commented on CONNECTORS-1545:
-

Hi [~julienFL], all strings are escaped, and tabs are accessed by a sequence 
number, and not by the translated string displayed on the tab, so I find your 
explanation for the problem unconvincing.  Usually, problems if this kind are 
due to there being HTML mismatched tags or some such. 

> Parentheses in editConfiguration tab labels not supported
> -
>
> Key: CONNECTORS-1545
> URL: https://issues.apache.org/jira/browse/CONNECTORS-1545
> Project: ManifoldCF
>  Issue Type: Bug
>  Components: Web connector
>Affects Versions: ManifoldCF 2.11
>Reporter: Julien Massiera
>Assignee: Karl Wright
>Priority: Minor
>
> In the editConfiguration view of the web connector, the tab 
> 'AccessCredentials' is not "clickable" in the french version of the UI.
> It seems to be due to the presence of parentheses in the string "Informations 
> d'accès (Access Credentials)" as it is used to trigger the javascript 
> function of the tab and so is misinterpreted
> Need to check if similar cases are present for other connectors 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)