Re: Daemon gRPC

2020-05-07 Thread Wei Chen
One question, should we include authentication information into the proto
spec?

On Fri, May 8, 2020 at 10:35 AM Lucas Cardoso Silva <
cardosolucas61@gmail.com> wrote:

> I did a grpc implementation for the daemon, as discussed earlier. I would
> like to know your opinion about this code. To complete the changes, only a
> user interface module would be missing, which I can do until the beginning
> of next week. All unit tests have also been adapted and the daemon has a
> code coverage of 70%, but I will try to improve this coverage before
> commit. Thanks in advance.
>
> Proto:
> https://gist.github.com/cardosolucas/49b8afa0767dd98b39f25365a0371bb4
> Server:
> https://gist.github.com/cardosolucas/e20855ce82e27526d976781cb46a6d1d
>
> Best regards,
> Lucas Cardoso
>


Daemon gRPC

2020-05-07 Thread Lucas Cardoso Silva
I did a grpc implementation for the daemon, as discussed earlier. I would
like to know your opinion about this code. To complete the changes, only a
user interface module would be missing, which I can do until the beginning
of next week. All unit tests have also been adapted and the daemon has a
code coverage of 70%, but I will try to improve this coverage before
commit. Thanks in advance.

Proto: https://gist.github.com/cardosolucas/49b8afa0767dd98b39f25365a0371bb4
Server:
https://gist.github.com/cardosolucas/e20855ce82e27526d976781cb46a6d1d

Best regards,
Lucas Cardoso