Bug in forked lifecycle?
Hi I think I found a bug in Maven when working in forked lifecycle, like cobertura lifecycle. Look at these two example projects: http://sbt-compiler-maven-plugin.googlecode.com/svn/tmp/bug-in-forked-lifecycle/ There are logs from mvn test -X, mvn cobertura:cobertura -X and mvn site -X executions commited. The problem is the plugin configuration parameter values are initialized to values set for parameters with the same name in previous plugin. In java example maven-surefire-plugin is replaced by scalatest-maven-plugin as testing plugin so there is skipTests=true added to Surefire configuration. When executing test Surefire skips test execution and ScalaTest executes, as expected. When executing cobertura:cobertura or site Surefire skips test execution and ScalaTest skips as well because it's skipTests prameter value is now true. Why? In scala example things are even more weird. There is the same logic as in java example (ScalaTest replaces Surefire) and additionally sbt-compiler-maven-plugin replaces maven-compiler-plugin. In standard compiler plugin skipMain=true to skip source files compilation and skip=true to skip test source files compilation. Situation here is similar to Surefire-ScalaTest conflict, both plugins have the same skipMain option (SBTCompiler has skipTest parameter for skipping test sources compilaiton and Compiler has skip parameter so no conflict here). When executing compile standard Compiler skips compilation and SBTCompiler compiles sources. I was expectiong problems in cobertura lifecycle (when executing site or cobertura:cobertura), but compilation works here! Test execution does not work, like in previous example. Why such difference? I don't know. There is cobertura:instrument execution In cobertura lifecycle in process-classes phase, so after compilation, but before testing. Maybe this execution is the source of the problem. Tested with different versions of Maven, from 2.2.1 to latest 3.2.3. Always the same behaviour. I made one more test, renamed skipTest parameter in SBTCompiler to test (in my local svn copy) to have parameter conflict with standard Compiler in testCompile mojo (executed after cobertura:instrument). Surprisingly, there is no conflict, so maybe this has nothing to do with cobertura:instrument mojo execution. Summary: In forked cobertura lifecycle (in mvn site or mvn cobertura:cobertura executions): - skipTests configuration parameter value of ScalaTest plugin gets overwritten by value of skipTests parameter defined for Surefire plugin, - skipMain and skip configuration parameter values of SBTCompiler don't get overwritten by values of skipMain and skip parameters defined for standard Compiler plugin. Worse, I didn't a workaround. Could someone help me solve this problem? Regards Grzegorz Slowikowski - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: PR 24 for plexus-compiler
Right, well I should have seen that coming...I can't push to the canonical git repo, so I can't tag, and can't run the release:prepare step. Duh! @Olivier, would you mind pushing that release? Thanks! -john On 10/06/2014 01:14 PM, John Casey wrote: Thanks, I'll give it a shot tomorrow most likely, and report back. -john On 10/05/2014 05:56 PM, Olivier Lamy wrote: Perso, I find using github really convenient. Moving somewhere else will take a lot of time.. (Maybe at least an independant github orga) (but ATM I don't have enough bandwith to work on that) @John if you don't have access let me know if you need a release of plexus-compiler? On 5 October 2014 19:55, Hervé BOUTEMY herve.bout...@free.fr wrote: I didn't have time to continue work on http://people.apache.org/~hboutemy/codehaus/summary.html but it's clear it will take time perhaps we should move projects to Apache Extra for transition? Anybody with experience on this? Regards, Hervé Le vendredi 3 octobre 2014 09:21:19 Olivier Lamy a écrit : No idea how to give you access but I will merge that. Maybe Brian? On 3 October 2014 07:38, John Casey jdca...@commonjava.org wrote: It seems that I don't have access to commit directly to plexus-compiler. I've got a fix for the broken IT in the compiler plugin (for MCOMPILER-224, which is currently pegged at JDK 1.7+ since it can't handle output from JDK 1.6). Can someone merge the PR or give me access to do it? https://github.com/sonatype/plexus-compiler/pull/24 Thanks, -john -- John Casey --- GitHub: https://github.com/jdcasey/ Twitter: http://twitter.com/buildchimp - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org -- John Casey --- GitHub: https://github.com/jdcasey/ Twitter: http://twitter.com/buildchimp - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: I'd like to release Maven Compiler Plugin v3.2
https://builds.apache.org/job/maven-plugins-ITs-m3-windows/ws/maven-compiler-plugin/target/it/MCOMPILER-157/build.log Keep in mind that this IT fails on our buildserver. I think it requires a different version of the JDK. [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.2-SNAPSHOT:compile (default-compile) on project annotation-processor: Compilation failure [ERROR] javac: invalid flag: -s Robert Op Fri, 03 Oct 2014 23:13:59 +0200 schreef John Casey jdca...@commonjava.org: I've just fixed MCOMPILER-224, MCOMPILER-157, and (by extension) MCOMPILER-159. Are there any objections to me calling the vote to release 3.2 now? I was hoping to test the waters before it involves backing out a tag to call things back. Thanks, -john - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
maven-war-plugin - Change mavenVersion....
Hi, currently i'm faced with a strange thing which i currently don't understand... I'm trying to upgrade maven-war-plugin to Maven 2.2.1 dependencies... So i have changed mavenVersion property in maven-war-plugin pom to 2.2.1 and compiled but i got a compile error: [ERROR] /Users/kama/apache-maven/maven-plugins/maven-war-plugin/src/test/java/org/apache/maven/plugin/war/stub/AbstractArtifactStub.java:[72,16] name clash: compareTo(java.lang.Object) in org.apache.maven.plugin.war.stub.AbstractArtifactStub and compareTo(T) in java.lang.Comparable have the same erasure, yet neither overrides the other [INFO] 1 error [INFO] - Ok... Changed the implementation of AbstractArtifactStub like this: public int compareTo( Artifact o ) Got the following: [ERROR] /Users/kama/apache-maven/maven-plugins/maven-war-plugin/src/test/java/org/apache/maven/plugin/war/stub/AbstractArtifactStub.java:[72,16] name clash: compareTo(org.apache.maven.artifact.Artifact) in org.apache.maven.plugin.war.stub.AbstractArtifactStub overrides a method whose erasure is the same as another method, yet neither overrides the other first method: compareTo(java.lang.Object) in org.apache.maven.plugin.testing.stubs.ArtifactStub second method: compareTo(T) in java.lang.Comparable [INFO] 1 error After searching a little bit i found out that maven-testing-harness is an old version (1.2) and updated to 2.1 looks better and got a successful compile but all the tests failwith messages similar to this: ests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0 sec FAILURE! - in org.apache.maven.plugin.war.WarMojoTest initializationError(org.apache.maven.plugin.war.WarMojoTest) Time elapsed: 0 sec ERROR! java.lang.NoClassDefFoundError: org/sonatype/aether/RepositorySystemSession at java.lang.Class.getDeclaredMethods0(Native Method) at java.lang.Class.privateGetDeclaredMethods(Class.java:2451) at java.lang.Class.getMethod0(Class.java:2694) at java.lang.Class.getMethod(Class.java:1622) at org.junit.internal.builders.SuiteMethodBuilder.hasSuiteMethod(SuiteMethodBuilder.java:18) at org.junit.internal.builders.SuiteMethodBuilder.runnerForClass(SuiteMethodBuilder.java:10) at org.junit.runners.model.RunnerBuilder.safeRunnerForClass(RunnerBuilder.java:59) at org.junit.internal.builders.AllDefaultPossibilitiesBuilder.runnerForClass(AllDefaultPossibilitiesBuilder.java:26) at org.junit.runners.model.RunnerBuilder.safeRunnerForClass(RunnerBuilder.java:59) at org.junit.internal.requests.ClassRequest.getRunner(ClassRequest.java:26) at org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:262) at org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:153) at org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:124) at org.apache.maven.surefire.booter.ForkedBooter.invokeProviderInSameClassLoader(ForkedBooter.java:200) at org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:153) at org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:103) Caused by: java.lang.ClassNotFoundException: org.sonatype.aether.RepositorySystemSession I have tried to add sonatype.aether dependency but this doesn't help ... I've got the impression that i'm misunderstanding / oversight something or just running into the wrong direction ? Can someone give me a hint how to solve that? Many thanks in advance... Kind regards Karl-Heinz Marbaise - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[VOTE] Release Apache Maven Source Plugin version 2.4
Hi, We solved 4 issues: http://jira.codehaus.org/secure/ReleaseNote.jspa?projectId=11147version=20597 There are still a couple of issues left in JIRA: http://jira.codehaus.org/issues/?jql=project%20%3D%20MSOURCES%20AND%20status%20%3D%20Open%20ORDER%20BY%20key%20DESC%2C%20priority%20DESC Staging repo: https://repository.apache.org/content/repositories/maven-1072/ http://repository.apache.org/content/repositories/maven-1072/org/apache/maven/plugins/maven-source-plugin/2.4/maven-source-plugin-2.4-source-release.zip Source release checksum(s): maven-source-plugin-2.4-source-release.zip sha1: da0d6e369f4841d018ccd29d44f3b70afb42d662 Staging site: http://maven.apache.org/plugins-archives/maven-source-plugin-LATEST/ Guide to testing staged releases: http://maven.apache.org/guides/development/guide-testing-releases.html Vote open for 72 hours. [ ] +1 [ ] +0 [ ] -1 Kind regards Karl-Heinz Marbaise - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: I'd like to release Maven Compiler Plugin v3.2
I think it's fixed now; I added a jdk min version to the failing IT. We'll see what Jenkins thinks of it now. On 10/07/2014 01:56 PM, Robert Scholte wrote: https://builds.apache.org/job/maven-plugins-ITs-m3-windows/ws/maven-compiler-plugin/target/it/MCOMPILER-157/build.log Keep in mind that this IT fails on our buildserver. I think it requires a different version of the JDK. [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.2-SNAPSHOT:compile (default-compile) on project annotation-processor: Compilation failure [ERROR] javac: invalid flag: -s Robert Op Fri, 03 Oct 2014 23:13:59 +0200 schreef John Casey jdca...@commonjava.org: I've just fixed MCOMPILER-224, MCOMPILER-157, and (by extension) MCOMPILER-159. Are there any objections to me calling the vote to release 3.2 now? I was hoping to test the waters before it involves backing out a tag to call things back. Thanks, -john - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org -- John Casey --- GitHub: https://github.com/jdcasey/ Twitter: http://twitter.com/buildchimp - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-surefire pull request: SUREFIRE-1101 Surefire does not shutd...
Github user Tibor17 closed the pull request at: https://github.com/apache/maven-surefire/pull/51 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: PR 24 for plexus-compiler
Sure I will later today. -- Olivier On 8 Oct 2014 03:54, John Casey jdca...@commonjava.org wrote: Right, well I should have seen that coming...I can't push to the canonical git repo, so I can't tag, and can't run the release:prepare step. Duh! @Olivier, would you mind pushing that release? Thanks! -john On 10/06/2014 01:14 PM, John Casey wrote: Thanks, I'll give it a shot tomorrow most likely, and report back. -john On 10/05/2014 05:56 PM, Olivier Lamy wrote: Perso, I find using github really convenient. Moving somewhere else will take a lot of time.. (Maybe at least an independant github orga) (but ATM I don't have enough bandwith to work on that) @John if you don't have access let me know if you need a release of plexus-compiler? On 5 October 2014 19:55, Hervé BOUTEMY herve.bout...@free.fr wrote: I didn't have time to continue work on http://people.apache.org/~hboutemy/codehaus/summary.html but it's clear it will take time perhaps we should move projects to Apache Extra for transition? Anybody with experience on this? Regards, Hervé Le vendredi 3 octobre 2014 09:21:19 Olivier Lamy a écrit : No idea how to give you access but I will merge that. Maybe Brian? On 3 October 2014 07:38, John Casey jdca...@commonjava.org wrote: It seems that I don't have access to commit directly to plexus-compiler. I've got a fix for the broken IT in the compiler plugin (for MCOMPILER-224, which is currently pegged at JDK 1.7+ since it can't handle output from JDK 1.6). Can someone merge the PR or give me access to do it? https://github.com/sonatype/plexus-compiler/pull/24 Thanks, -john -- John Casey --- GitHub: https://github.com/jdcasey/ Twitter: http://twitter.com/buildchimp - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org -- John Casey --- GitHub: https://github.com/jdcasey/ Twitter: http://twitter.com/buildchimp - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: I'd like to release Maven Compiler Plugin v3.2
I'm having some trouble understanding this result: https://builds.apache.org/job/maven-plugins-ITs-m3-windows/751/consoleFull It looks like it's having trouble because it's using snapshots of other plugins that are being built in that job. It doesn't appear to run the compiler plugin integration tests, either. It looks like it's been this way for a couple days, but I'm not sure whether it's related to the compiler plugin itself, or a coincidence. On 10/07/2014 03:01 PM, John Casey wrote: I think it's fixed now; I added a jdk min version to the failing IT. We'll see what Jenkins thinks of it now. On 10/07/2014 01:56 PM, Robert Scholte wrote: https://builds.apache.org/job/maven-plugins-ITs-m3-windows/ws/maven-compiler-plugin/target/it/MCOMPILER-157/build.log Keep in mind that this IT fails on our buildserver. I think it requires a different version of the JDK. [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.2-SNAPSHOT:compile (default-compile) on project annotation-processor: Compilation failure [ERROR] javac: invalid flag: -s Robert Op Fri, 03 Oct 2014 23:13:59 +0200 schreef John Casey jdca...@commonjava.org: I've just fixed MCOMPILER-224, MCOMPILER-157, and (by extension) MCOMPILER-159. Are there any objections to me calling the vote to release 3.2 now? I was hoping to test the waters before it involves backing out a tag to call things back. Thanks, -john - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org -- John Casey --- GitHub: https://github.com/jdcasey/ Twitter: http://twitter.com/buildchimp - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-surefire pull request: [SUREFIRE-1082] Parallelization does ...
GitHub user Tibor17 opened a pull request: https://github.com/apache/maven-surefire/pull/52 [SUREFIRE-1082] Parallelization does not work as expected when using jUn... ...it Parameterized This is not a fix. Commit only IT. The IT proves expected behavior in [SUREFIRE-1082]. The JIRA issue was reported with user error. You can merge this pull request into a Git repository by running: $ git pull https://github.com/Tibor17/maven-surefire s2 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/maven-surefire/pull/52.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #52 commit 1c2698a7527401a4a68a97e905886075fe6c4efa Author: tibordigana tibo...@lycos.com Date: 2014-10-07T22:34:53Z [SUREFIRE-1082] Parallelization does not work as expected when using jUnit Parameterized --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-surefire pull request: [SUREFIRE-1082] Parallelization does ...
Github user asfgit closed the pull request at: https://github.com/apache/maven-surefire/pull/52 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: PR 24 for plexus-compiler
all done. Enjoy!! :-) On 8 October 2014 07:58, Olivier Lamy ol...@apache.org wrote: Sure I will later today. -- Olivier On 8 Oct 2014 03:54, John Casey jdca...@commonjava.org wrote: Right, well I should have seen that coming...I can't push to the canonical git repo, so I can't tag, and can't run the release:prepare step. Duh! @Olivier, would you mind pushing that release? Thanks! -john On 10/06/2014 01:14 PM, John Casey wrote: Thanks, I'll give it a shot tomorrow most likely, and report back. -john On 10/05/2014 05:56 PM, Olivier Lamy wrote: Perso, I find using github really convenient. Moving somewhere else will take a lot of time.. (Maybe at least an independant github orga) (but ATM I don't have enough bandwith to work on that) @John if you don't have access let me know if you need a release of plexus-compiler? On 5 October 2014 19:55, Hervé BOUTEMY herve.bout...@free.fr wrote: I didn't have time to continue work on http://people.apache.org/~hboutemy/codehaus/summary.html but it's clear it will take time perhaps we should move projects to Apache Extra for transition? Anybody with experience on this? Regards, Hervé Le vendredi 3 octobre 2014 09:21:19 Olivier Lamy a écrit : No idea how to give you access but I will merge that. Maybe Brian? On 3 October 2014 07:38, John Casey jdca...@commonjava.org wrote: It seems that I don't have access to commit directly to plexus-compiler. I've got a fix for the broken IT in the compiler plugin (for MCOMPILER-224, which is currently pegged at JDK 1.7+ since it can't handle output from JDK 1.6). Can someone merge the PR or give me access to do it? https://github.com/sonatype/plexus-compiler/pull/24 Thanks, -john -- John Casey --- GitHub: https://github.com/jdcasey/ Twitter: http://twitter.com/buildchimp - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org -- John Casey --- GitHub: https://github.com/jdcasey/ Twitter: http://twitter.com/buildchimp - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org -- Olivier Lamy http://twitter.com/olamy | http://linkedin.com/in/olamy - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
