[GitHub] maven-surefire pull request: [SUREFIRE-1179] integration test

2015-09-26 Thread juherr
Github user juherr commented on the pull request:

https://github.com/apache/maven-surefire/pull/106#issuecomment-143522916
  
Awesome! I should have time this week to close it. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org



Re: Using ${revision} as a version

2015-09-26 Thread Lennart Jörelid
I have painfully noted that the currently only [properly] working way is to
use profiles to
switch between values given on the command line and some type of default
value (given in another profile).

Typically, it takes on the pattern/form as shown below - and it would be
really nice not to have to resort to these kinds of things. Instead, it
would be cleaner if these types of profile workaround patterns would not be
needed, instead simply overriding a property from the CLI.

Question, though: Would overriding properties from the CLI in some way be
contradictory to the requirement of a repeatable build?



tokenization_development


!target_environment




development

${token.dir}/environments/${target_environment}.properties





tokenization_test


target_environment
test




test

${token.dir}/environments/${target_environment}.properties




2015-09-26 22:46 GMT+02:00 Karl Heinz Marbaise :

> Hi,
>
> so after diving into this problem... (
> https://issues.apache.org/jira/browse/MNG-5895)...
>
> I have found the culprit (in my opinion) at Maven-assembly-plugin located
> in this class DefaultDependencyResolver:
>
> at the following method:
>
>
> private Set resolveTransitively(
> final Set dependencyArtifacts,
> final List repos,
> final ResolutionManagementInfo info,
> final AssemblerConfigurationSource configSource )
>  throws DependencyResolutionException
> {
> final MavenProject project = configSource.getProject();
>
> final ArtifactFilter filter = info.getScopeFilter();
>
> ArtifactResolutionRequest req = new ArtifactResolutionRequest();
> req.setLocalRepository( configSource.getLocalRepository() );
> req.setResolveRoot( false );
> req.setRemoteRepositories( repos );
> req.setResolveTransitively( true );
> req.setArtifact( project.getArtifact() );
> req.setArtifactDependencies( dependencyArtifacts );
> req.setManagedVersionMap( project.getManagedVersionMap() );
> req.setCollectionFilter( filter );
> req.setOffline( configSource.getMavenSession().isOffline() );
> req.setForceUpdate(
> configSource.getMavenSession().getRequest().isUpdateSnapshots() );
> req.setServers(
> configSource.getMavenSession().getRequest().getServers() );
> req.setMirrors(
> configSource.getMavenSession().getRequest().getMirrors() );
> req.setProxies(
> configSource.getMavenSession().getRequest().getProxies() );
>
> ArtifactResolutionResult result;
>
> result = resolver.resolve( req );
> if ( result.hasExceptions() )
> {
> throw new DependencyResolutionException( "Failed to resolve
> dependencies for assembly: ",
>
> result.getExceptions().get( 0 ) );
> }
>
> FilterUtils.reportFilteringStatistics( Collections.singleton(
> filter ), getLogger() );
>
> return result.getArtifacts();
> }
>
>
>
> And the identified line is:
>
> result = resolver.resolve( req );
>
> which fails to find the appropriate dependencies...or better the wrong
> version of the dependencies
>
>
> So I'm not sure at the moment if this is based on Maven 2 compatibility of
> maven-assembly-plugin or if there is an other issue in there or I'm just
> simply wrong...
>
> WDYT ?
>
>
> Kind regards
> Karl Heinz Marbaise
>
>
>
> On 8/23/15 5:16 PM, Karl Heinz Marbaise wrote:
>
>> Hi,
>>
>> I have test project where i defined the pom like this:
>>
>> ...
>>4.0.0
>>
>>com.soebes.examples.j2ee
>>parent
>>${revision}
>>pom
>>
>> If i define the revision on command line like this.
>>
>> mvn -Drevision=1.0-SNAPSHOT clean package
>>
>> everything fine...
>>
>> But now i want to make the usage a bit more convenient so i added the
>> following to my pom:
>>
>>
>>
>>  UTF-8
>>  1.0-SNAPSHOT
>>
>>
>> to have a default for revision which works fine now...
>>
>> But if i would like to overwrite the property from command line like this:
>>
>> mvn -Drevision=1.0 clean package
>>
>> the build failes in the following location:
>>
>> [ERROR] Failed to execute goal
>> org.apache.maven.plugins:maven-assembly-plugin:2.5.5:single (assemblies)
>> on project assembly: Failed to create assembly: Unable to resolve
>> dependencies for assembly 'archive': Failed to resolve dependencies for
>> assembly: Unable to get dependency information for
>> com.soebes.examples.j2ee:service-client:jar:1.0-SNAPSHOT: Failed to
>> process POM for
>> com.soebes.examples.j2ee:service-client:jar:1.0-SNAPSHOT: Non-resolvable
>> parent POM for
>> com.soebes.examples.j2ee:service-client:[unknown-version]: Failure to
>> find com.soebes.examples.j2ee:parent:pom:${revision} in
>> http://localhost:8081/nexus/content/groups/public was cached in the
>> local repository, resolution will not be reattempted until the update
>> interval

[GitHub] maven-surefire pull request: [SUREFIRE-1179] integration test

2015-09-26 Thread Tibor17
Github user Tibor17 commented on the pull request:

https://github.com/apache/maven-surefire/pull/106#issuecomment-143505456
  
@juherr 
This is the IT, but the problem is in TestNG because the concurrency 
remains 10 even if dataproviderthreadcount=30.
Meanwhile I reported issue in TestNG I found when I tested the clone of 
TestNG project for the IT and installed as snapshot version in my local repo. 
https://github.com/cbeust/testng/issues/813
Can you make investigation and find out why we still have only 10 
concurrent threads. Feel free to clone my branch and change the value of 
`dataproviderthreadcount` in POM.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org



[GitHub] maven-surefire pull request: [SUREFIRE-1179] integration test

2015-09-26 Thread Tibor17
GitHub user Tibor17 opened a pull request:

https://github.com/apache/maven-surefire/pull/106

[SUREFIRE-1179] integration test

for #105 

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/Tibor17/maven-surefire s4

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/maven-surefire/pull/106.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #106


commit 5ac824733ea4b8201e8acd5c1d6cead0301340ab
Author: Julien Herr 
Date:   2015-09-18T14:19:10Z

Quick fix for SUREFIRE-1177 and SUREFIRE-1179

commit 5105a84099af74d579d5975b25e1bdfe04333643
Author: Tibor17 
Date:   2015-09-26T23:18:12Z

[SUREFIRE-1179] integration test




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org



Re: FOSDEM 2016

2015-09-26 Thread Hervé BOUTEMY
Hi Karl Heinz,

I'm interested: Brussels is near, it's a good opportunity to meet.

Regards,

Hervé

Le samedi 26 septembre 2015 23:06:03 Karl Heinz Marbaise a écrit :
> Hi,
> 
> are there any interest to meetup on FOSDEM 2016 in Brussels...
> 
> I have read the pages where the deadlines for Developer rooms will due
> to 9. October 2015 ...
> 
> 
> Kind regards
> Karl Heinz Marbaise
> 
> 
> 
> -
> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
> For additional commands, e-mail: dev-h...@maven.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org



FOSDEM 2016

2015-09-26 Thread Karl Heinz Marbaise

Hi,

are there any interest to meetup on FOSDEM 2016 in Brussels...

I have read the pages where the deadlines for Developer rooms will due 
to 9. October 2015 ...



Kind regards
Karl Heinz Marbaise



-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org



Re: Using ${revision} as a version

2015-09-26 Thread Karl Heinz Marbaise

Hi,

so after diving into this problem... 
(https://issues.apache.org/jira/browse/MNG-5895)...


I have found the culprit (in my opinion) at Maven-assembly-plugin 
located in this class DefaultDependencyResolver:


at the following method:


private Set resolveTransitively(
final Set dependencyArtifacts,
final List repos,
final ResolutionManagementInfo info,
final AssemblerConfigurationSource configSource )
 throws DependencyResolutionException
{
final MavenProject project = configSource.getProject();

final ArtifactFilter filter = info.getScopeFilter();

ArtifactResolutionRequest req = new ArtifactResolutionRequest();
req.setLocalRepository( configSource.getLocalRepository() );
req.setResolveRoot( false );
req.setRemoteRepositories( repos );
req.setResolveTransitively( true );
req.setArtifact( project.getArtifact() );
req.setArtifactDependencies( dependencyArtifacts );
req.setManagedVersionMap( project.getManagedVersionMap() );
req.setCollectionFilter( filter );
req.setOffline( configSource.getMavenSession().isOffline() );
req.setForceUpdate( 
configSource.getMavenSession().getRequest().isUpdateSnapshots() );
req.setServers( 
configSource.getMavenSession().getRequest().getServers() );
req.setMirrors( 
configSource.getMavenSession().getRequest().getMirrors() );
req.setProxies( 
configSource.getMavenSession().getRequest().getProxies() );


ArtifactResolutionResult result;

result = resolver.resolve( req );
if ( result.hasExceptions() )
{
throw new DependencyResolutionException( "Failed to resolve 
dependencies for assembly: ",


result.getExceptions().get( 0 ) );
}

FilterUtils.reportFilteringStatistics( Collections.singleton( 
filter ), getLogger() );


return result.getArtifacts();
}



And the identified line is:

result = resolver.resolve( req );

which fails to find the appropriate dependencies...or better the wrong 
version of the dependencies



So I'm not sure at the moment if this is based on Maven 2 compatibility 
of maven-assembly-plugin or if there is an other issue in there or I'm 
just simply wrong...


WDYT ?


Kind regards
Karl Heinz Marbaise



On 8/23/15 5:16 PM, Karl Heinz Marbaise wrote:

Hi,

I have test project where i defined the pom like this:

...
   4.0.0

   com.soebes.examples.j2ee
   parent
   ${revision}
   pom

If i define the revision on command line like this.

mvn -Drevision=1.0-SNAPSHOT clean package

everything fine...

But now i want to make the usage a bit more convenient so i added the
following to my pom:


   
 UTF-8
 1.0-SNAPSHOT
   

to have a default for revision which works fine now...

But if i would like to overwrite the property from command line like this:

mvn -Drevision=1.0 clean package

the build failes in the following location:

[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-assembly-plugin:2.5.5:single (assemblies)
on project assembly: Failed to create assembly: Unable to resolve
dependencies for assembly 'archive': Failed to resolve dependencies for
assembly: Unable to get dependency information for
com.soebes.examples.j2ee:service-client:jar:1.0-SNAPSHOT: Failed to
process POM for
com.soebes.examples.j2ee:service-client:jar:1.0-SNAPSHOT: Non-resolvable
parent POM for
com.soebes.examples.j2ee:service-client:[unknown-version]: Failure to
find com.soebes.examples.j2ee:parent:pom:${revision} in
http://localhost:8081/nexus/content/groups/public was cached in the
local repository, resolution will not be reattempted until the update
interval of nexus has elapsed or updates are forced
[ERROR] com.soebes.examples.j2ee:service-client:jar:1.0-SNAPSHOT

The project is available on github
(https://github.com/khmarbaise/javaee/tree/mvn321)

So the question which is coming up...is this based on Maven core or is
this based on maven-assembly-plugin ?

Kind regards
Karl Heinz Marbaise


-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org



Re: How to access $project.build.sourceEncoding?

2015-09-26 Thread Karl Heinz Marbaise

Hi Jochen,

On 9/26/15 10:28 PM, Jochen Wiedmann wrote:

Hi,

I'd like to access $[project.build.sourceEncoding} in a Maven Plugin.
How would I do that? Using what version of maven-model?


Hm...you would like use that for a maven plugin ? Then it's used like this:

@Parameter( property = "encoding", defaultValue = 
"${project.build.sourceEncoding}" )

private String encoding;

That's usually a default value for plugin...

Kind regards
Karl Heinz Marbaise

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org



How to access $project.build.sourceEncoding?

2015-09-26 Thread Jochen Wiedmann
Hi,

I'd like to access $[project.build.sourceEncoding} in a Maven Plugin.
How would I do that? Using what version of maven-model?

Thanks,

Jochen


-- 
The next time you hear: "Don't reinvent the wheel!"

http://www.keystonedevelopment.co.uk/wp-content/uploads/2014/10/evolution-of-the-wheel-300x85.jpg

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org



Re: Maven Plugin ITs with M2 disabled

2015-09-26 Thread Hervé BOUTEMY
+1

with parent upgrade, which should happen shortly, building with Maven 2 will 
simply not work any more: simply disabling these jobs is just because we 
hesitate to throw away anything :)

Regards,

Hervé 

Le samedi 26 septembre 2015 10:53:44 Robert Scholte a écrit :
> Hi,
> 
> FYI, I've disabled these jobs [1][2] on our buildserver. They gave some
> odd M2-specific errors I don't want to spent time on. Time to move forward.
> 
> thanks,
> Robert
> 
> [1] https://builds.apache.org/view/M-R/view/Maven/job/maven-plugins-ITs-m2/
> [2]
> https://builds.apache.org/view/M-R/view/Maven/job/maven-plugins-ITs-m2-with-> 
> maven-plugin/
> 
> -
> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
> For additional commands, e-mail: dev-h...@maven.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org



[GitHub] maven-archetype pull request: ARCHETYPE-487 Add input validation f...

2015-09-26 Thread michael-o
Github user michael-o commented on the pull request:

https://github.com/apache/maven-archetype/pull/7#issuecomment-143424312
  
There hasn't much activity lately. Ping me again next week and I'll review 
and merge your PR.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org



RE: Maven Plugin ITs with M2 disabled

2015-09-26 Thread Martin Gainty



> Date: Sat, 26 Sep 2015 10:53:44 +0200
> To: dev@maven.apache.org
> Subject: Maven Plugin ITs with M2 disabled
> From: rfscho...@apache.org
> 
> Hi,
> 
> FYI, I've disabled these jobs [1][2] on our buildserver. They gave some  
> odd M2-specific errors I don't want to spent time on. Time to move forward.
> 
> thanks,
> Robert
> 
> [1] https://builds.apache.org/view/M-R/view/Maven/job/maven-plugins-ITs-m2/
> [2]  
> https://builds.apache.org/view/M-R/view/Maven/job/maven-plugins-ITs-m2-with-maven-plugin/

MG>verified maven-eclipse-plugin 2.10 trunk is unaffected 
MG>repository location:
MG>https://maven.apache.org/plugins/maven-eclipse-plugin/source-repository.html
MG>clean build
MG>clean package
MG>mvn org.apache.maven.plugins:maven-eclipse-plugin:2.10:eclipse creates 
.project .classpath and .settings 

MG>resolve-workspace-dependencies goal has no output

[DEBUG] Configuring mojo org.apache.maven.plugins:maven-eclipse-plugin:2.10:reso
lve-workspace-dependencies from plugin realm ClassRealm[plugin>org.apache.maven.
plugins:maven-eclipse-plugin:2.10, parent: sun.misc.Launcher$AppClassLoader@4e25
154f]
[DEBUG] Configuring mojo 'org.apache.maven.plugins:maven-eclipse-plugin:2.10:res
olve-workspace-dependencies' with basic configurator -->
[DEBUG]   (f) localRepository =   id: local
  url: file:///C:/Users/mgainty/.m2/repository/
   layout: default
snapshots: [enabled => true, update => always]
 releases: [enabled => true, update => always]
[DEBUG]   (f) remoteArtifactRepositories = [  id: central
  url: https://repo.maven.apache.org/maven2
   layout: default
snapshots: [enabled => false, update => daily]
 releases: [enabled => true, update => daily]
]
[DEBUG] -- end configuration --
[DEBUG] Detected workspace at C:\Maven-plugin\maven-eclipse-plugin\2.10\target\t
mp-workspace0\eclipse\dynamicWorkspace\workspace\.
[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
MG>but no output even when project-A and project-Z live in workspace folder
MG>possible bug here?

MG>would reverting maven-eclipse-plugin pom.xml to 2.10 solve 
cyclic reference: Edge between 
'Vertex{label='org.apache.maven.plugins:maven-invoker-plugin'}' and 
'Vertex{label='org.apache.maven.plugins:maven-site-plugin'}' introduces to 
cycle in the graph org.apache.maven.plugins:maven-site-plugin --> 
org.apache.maven.plugins:maven-invoker-plugin --> 
org.apache.maven.plugins:maven-site-plugin
MG>?

> -
> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
> For additional commands, e-mail: dev-h...@maven.apache.org
> 
  

Maven Plugin ITs with M2 disabled

2015-09-26 Thread Robert Scholte

Hi,

FYI, I've disabled these jobs [1][2] on our buildserver. They gave some  
odd M2-specific errors I don't want to spent time on. Time to move forward.


thanks,
Robert

[1] https://builds.apache.org/view/M-R/view/Maven/job/maven-plugins-ITs-m2/
[2]  
https://builds.apache.org/view/M-R/view/Maven/job/maven-plugins-ITs-m2-with-maven-plugin/


-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org