Re: VOTE] Release Apache Maven Source Plugin version 3.0.1

[Olivier Lamy]

+1

On 19 June 2016 at 00:49, Karl Heinz Marbaise  wrote:

> Hi,
>
> We solved 8 issues:
>
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317924=12335588
>
> There are still one issue left in JIRA:
>
> https://issues.apache.org/jira/issues/?jql=project%20%3D%20MSOURCES%20AND%20status%20%3D%20Open%20ORDER%20BY%20priority%20DESC
>
> Staging repo:
> https://repository.apache.org/content/repositories/maven-1280
>
> https://repository.apache.org/content/repositories/maven-1280/org/apache/maven/plugins/maven-source-plugin/3.0.1/maven-source-plugin-3.0.1-source-release.zip
>
> Source release checksum(s):
> maven-source-plugin-3.0.1-source-release.zip sha1:
> fb9b07870d5a9c8b12622f18c426893a932a3334
>
> Staging site:
> https://maven.apache.org/plugins-archives/maven-source-plugin-LATEST/
>
> Guide to testing staged releases:
> https://maven.apache.org/guides/development/guide-testing-releases.html
>
> Vote open for 72 hours.
>
> [ ] +1
> [ ] +0
> [ ] -1
>
> Kind regards
> Karl Heinz Marbaise
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
> For additional commands, e-mail: dev-h...@maven.apache.org
>
>


-- 
Olivier Lamy
http://twitter.com/olamy | http://linkedin.com/in/olamy

Re: [VOTE] Release Apache Maven JAR Plugin version 3.0.2

[Olivier Lamy]

+1

On 22 June 2016 at 05:54, Karl Heinz Marbaise  wrote:

> Hi,
>
> here is my +1...
>
> one more PMC VOTE needed...
>
> Kind regards
> Karl Heinz
> On 6/18/16 4:24 PM, Karl Heinz Marbaise wrote:
>
>> Hi,
>>
>> We solved 4 issues:
>>
>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317526=12336062=Text
>>
>>
>> There are still a couple of issues left in JIRA:
>>
>> https://issues.apache.org/jira/issues/?jql=project%20%3D%20MJAR%20AND%20status%20%3D%20Open%20ORDER%20BY%20priority%20DESC
>>
>>
>> Staging repo:
>> https://repository.apache.org/content/repositories/maven-1279
>>
>> https://repository.apache.org/content/repositories/maven-1279/org/apache/maven/plugins/maven-jar-plugin/3.0.2/maven-jar-plugin-3.0.2-source-release.zip
>>
>>
>> Source release checksum(s):
>> maven-jar-plugin-3.0.2-source-release.zip sha1:
>> 2aa4c89fc550ff3bd4bcb3ff163644b2e9e7be67
>>
>> Staging site:
>> http://maven.apache.org/plugins-archives/maven-jar-plugin-LATEST/
>>
>> Guide to testing staged releases:
>> http://maven.apache.org/guides/development/guide-testing-releases.html
>>
>> Vote open for 72 hours.
>>
>> [ ] +1
>> [ ] +0
>> [ ] -1
>>
>> Kind regards
>> Karl Heinz Marbaise
>>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
> For additional commands, e-mail: dev-h...@maven.apache.org
>
>


-- 
Olivier Lamy
http://twitter.com/olamy | http://linkedin.com/in/olamy

[GitHub] maven issue #70: MNG-6049: Adds version range result filter behaviour

[barthel]

Github user barthel commented on the issue:

https://github.com/apache/maven/pull/70
  
@talios Not yet public. I'll create a public example extension if the 3.4.0 
release is available.
See integration test: 
https://github.com/apache/maven-integration-testing/pull/14
Not easy to read, but maybe enough for you?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven issue #70: MNG-6049: Adds version range result filter behaviour

[talios]

Github user talios commented on the issue:

https://github.com/apache/maven/pull/70
  
@barthel is there an example anywhere of using this?  I have a project 
(custom lifecycle extension) myself where I think utilizing this will actually 
make what I'm doing much easier, nicer, and probably more "maven safe".  


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven-integration-testing issue #14: MNG-6049: Adds integration tests for ve...

[michael-o]

Github user michael-o commented on the issue:

https://github.com/apache/maven-integration-testing/pull/14
  
@barthel Can you also take care of the file names in the PR? `mng3092` to 
`mng-6049`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven-integration-testing issue #14: MNG-3092: Adds integration tests for ve...

[barthel]

Github user barthel commented on the issue:

https://github.com/apache/maven-integration-testing/pull/14
  
Relabelling commit from MNG-3092 to MNG-6049.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven issue #70: MNG-3092: Adds version range result filter behaviour

[barthel]

Github user barthel commented on the issue:

https://github.com/apache/maven/pull/70
  
Relabelling commit from MNG-3092 to MNG-6049.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven-scm issue #31: SCM-706 finer-grained handling of file rename status fo...

[rfscholte]

Github user rfscholte commented on the issue:

https://github.com/apache/maven-scm/pull/31
  

https://github.com/apache/maven-scm/blob/master/maven-scm-providers/maven-scm-providers-git/maven-scm-provider-gitexe/src/test/java/org/apache/maven/scm/provider/git/gitexe/command/status/GitStatusConsumerTest.java#L191
 confirms this if you see that subDirectory is actually the working directory.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven issue #70: MNG-3092: Adds version range result filter behaviour

[michael-o]

Github user michael-o commented on the issue:

https://github.com/apache/maven/pull/70
  
@barthel Perfect, already assigned. Just waiting for an updated PR and all 
will be merged.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven-integration-testing pull request #14: MNG-3092: Adds integration tests...

[michael-o]

Github user michael-o commented on a diff in the pull request:


https://github.com/apache/maven-integration-testing/pull/14#discussion_r67946906
  
--- Diff: 
core-it-suite/src/test/java/org/apache/maven/it/MavenITmng3092VersionRangeResultFilterExtensionTest.java
 ---
@@ -0,0 +1,132 @@
+package org.apache.maven.it;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import org.apache.maven.it.Verifier;
+import org.apache.maven.it.util.ResourceExtractor;
+
+import java.io.File;
+import java.util.HashMap;
+import java.util.List;
+import java.util.Map;
+
+/**
+ * This is a test set for https://issues.apache.org/jira/browse/MNG-3092;>MNG-3092.
+ *
+ * 
+ *   
+ * 
+ *   org.apache.maven.its.mng3092
+ *   a
+ *   [1.0,2.0)
+ * 
+ *   
+ * 
+ *
+ * @author Benjamin Bentmann
+ */
+public class MavenITmng3092VersionRangeResultFilterExtensionTest
+extends AbstractMavenIntegrationTestCase
+{
+
+public MavenITmng3092VersionRangeResultFilterExtensionTest()
+{
+super( "[3.4.0-SNAPSHOT,)" );
--- End diff --

Am 2016-06-21 um 22:28 schrieb barthel:
>> + *   org.apache.maven.its.mng3092
>> + *   a
>> + *   [1.0,2.0)
>> + * 
>> + *   
>> + * 
>> + *
>> + * @author Benjamin Bentmann
>> + */
>> +public class MavenITmng3092VersionRangeResultFilterExtensionTest
>> +extends AbstractMavenIntegrationTestCase
>> +{
>> +
>> +public MavenITmng3092VersionRangeResultFilterExtensionTest()
>> +{
>> +super( "[3.4.0-SNAPSHOT,)" );
>
> So this test will not execute before 3.4.0 release. I thought I change 
that close after the 3.4.0 release?
> If this is not a problem, I'll change this.

It will, see:
mng3099SettingsProfilesWithNoPom(it).OK (1.2 s)
mng3092VersionRangeResultFilterExtension(Default)OK (1.4 s)

Try it yourself. The -SNAPSHOT is ignored here because we mostly test 
snapshots.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven-integration-testing issue #14: MNG-3092: Adds integration tests for ve...

[barthel]

Github user barthel commented on the issue:

https://github.com/apache/maven-integration-testing/pull/14
  
@michael-o Done.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven-integration-testing pull request #14: MNG-3092: Adds integration tests...

[barthel]

Github user barthel commented on a diff in the pull request:


https://github.com/apache/maven-integration-testing/pull/14#discussion_r67945228
  
--- Diff: 
core-it-suite/src/test/java/org/apache/maven/it/MavenITmng3092VersionRangeResultFilterExtensionTest.java
 ---
@@ -0,0 +1,132 @@
+package org.apache.maven.it;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import org.apache.maven.it.Verifier;
+import org.apache.maven.it.util.ResourceExtractor;
+
+import java.io.File;
+import java.util.HashMap;
+import java.util.List;
+import java.util.Map;
+
+/**
+ * This is a test set for https://issues.apache.org/jira/browse/MNG-3092;>MNG-3092.
+ *
+ * 
+ *   
+ * 
+ *   org.apache.maven.its.mng3092
+ *   a
+ *   [1.0,2.0)
+ * 
+ *   
+ * 
+ *
+ * @author Benjamin Bentmann
+ */
+public class MavenITmng3092VersionRangeResultFilterExtensionTest
+extends AbstractMavenIntegrationTestCase
+{
+
+public MavenITmng3092VersionRangeResultFilterExtensionTest()
+{
+super( "[3.4.0-SNAPSHOT,)" );
--- End diff --

So this test will not execute before 3.4.0 release. I thought I change that 
close after the 3.4.0 release?
If this is not a problem, I'll change this.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven-scm issue #31: SCM-706 finer-grained handling of file rename status fo...

[rfscholte]

Github user rfscholte commented on the issue:

https://github.com/apache/maven-scm/pull/31
  
I think we missed something. `GitStatusConsumer` says

/**
 * Entries are relative to working directory, not to the repositoryroot
 */
private List changedFiles = new ArrayList();

That was probably true before introducing the `--porcelain` argument, 
because the related git-status docs says

Porcelain Format
The porcelain format is similar to the short format, but is guaranteed 
not to change in a backwards-incompatible way between Git versions or based on 
user configuration. This makes it ideal for parsing by scripts. The description 
of the short format above also describes the porcelain format, with a few 
exceptions:
1.The user’s color.status configuration is not respected; color will 
always be off.
2.The user’s status.relativePaths configuration is not respected; 
paths shown will always be relative to the repository root.

So we need to go through the codebase to verify if the proper paths are 
used. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven issue #70: MNG-3092: Adds version range result filter behaviour

[barthel]

Github user barthel commented on the issue:

https://github.com/apache/maven/pull/70
  
@michael-o Please take a look at 
https://issues.apache.org/jira/browse/MNG-6049


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven-integration-testing pull request #14: MNG-3092: Adds integration tests...

[michael-o]

Github user michael-o commented on a diff in the pull request:


https://github.com/apache/maven-integration-testing/pull/14#discussion_r67942011
  
--- Diff: 
core-it-suite/src/test/java/org/apache/maven/it/MavenITmng3092VersionRangeResultFilterExtensionTest.java
 ---
@@ -0,0 +1,132 @@
+package org.apache.maven.it;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import org.apache.maven.it.Verifier;
+import org.apache.maven.it.util.ResourceExtractor;
+
+import java.io.File;
+import java.util.HashMap;
+import java.util.List;
+import java.util.Map;
+
+/**
+ * This is a test set for https://issues.apache.org/jira/browse/MNG-3092;>MNG-3092.
+ *
+ * 
+ *   
+ * 
+ *   org.apache.maven.its.mng3092
+ *   a
+ *   [1.0,2.0)
+ * 
+ *   
+ * 
+ *
+ * @author Benjamin Bentmann
+ */
+public class MavenITmng3092VersionRangeResultFilterExtensionTest
+extends AbstractMavenIntegrationTestCase
+{
+
+public MavenITmng3092VersionRangeResultFilterExtensionTest()
+{
+super( "[3.4.0-SNAPSHOT,)" );
+}
+
+/**
+ * Verify that the Maven default behavior will be used without a 
VersionRangeResultFilter extension.
+ */
+public void testDefault()
+throws Exception
+{
+File testDir = ResourceExtractor.simpleExtractResources( 
getClass(), "/mng-3092" );
+
+Verifier verifier = newVerifier( testDir.getAbsolutePath() );
+verifier.setAutoclean( false );
+verifier.deleteDirectory( "target" );
+verifier.deleteArtifacts( "org.apache.maven.its.mng3092" );
+verifier.filterFile( "settings-template.xml", "settings.xml", 
"UTF-8", verifier.newDefaultFilterProperties() );
+verifier.filterFile( "pom-mng-3092.xml", "pom.xml", "UTF-8", 
verifier.newDefaultFilterProperties() );
+verifier.addCliOption( "--settings" );
+verifier.addCliOption( "settings.xml" );
+verifier.executeGoal( "validate" );
+verifier.verifyErrorFreeLog();
+verifier.resetStreams();
+
+List classpath = verifier.loadLines( 
"target/classpath.txt", "UTF-8" );
+assertTrue( classpath.toString(), classpath.contains( 
"a-2.0-SNAPSHOT.jar" ) );
+}
+
+/**
+ * Verify that the Maven VersionRangeResultFilter extension behavior 
is active and checks that non snapshot
+ * version will be used.
+ */
+public void testVersionRangeResultFilterExtesionSystemProperties()
--- End diff --

`Extesion` => `Extension`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven-integration-testing pull request #14: MNG-3092: Adds integration tests...

[michael-o]

Github user michael-o commented on a diff in the pull request:


https://github.com/apache/maven-integration-testing/pull/14#discussion_r67941526
  
--- Diff: 
core-it-suite/src/test/java/org/apache/maven/it/MavenITmng3092VersionRangeResultFilterExtensionTest.java
 ---
@@ -0,0 +1,132 @@
+package org.apache.maven.it;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import org.apache.maven.it.Verifier;
+import org.apache.maven.it.util.ResourceExtractor;
+
+import java.io.File;
+import java.util.HashMap;
+import java.util.List;
+import java.util.Map;
+
+/**
+ * This is a test set for https://issues.apache.org/jira/browse/MNG-3092;>MNG-3092.
+ *
+ * 
+ *   
+ * 
+ *   org.apache.maven.its.mng3092
+ *   a
+ *   [1.0,2.0)
+ * 
+ *   
+ * 
+ *
+ * @author Benjamin Bentmann
+ */
+public class MavenITmng3092VersionRangeResultFilterExtensionTest
+extends AbstractMavenIntegrationTestCase
+{
+
+public MavenITmng3092VersionRangeResultFilterExtensionTest()
+{
+super( "[3.4.0-SNAPSHOT,)" );
--- End diff --

Again, make it 3.4.0.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

Re: VOTE] Release Apache Maven Source Plugin version 3.0.1

[Michael Osipov]

Am 2016-06-18 um 16:49 schrieb Karl Heinz Marbaise:

Hi,

We solved 8 issues:
https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317924=12335588


There are still one issue left in JIRA:
https://issues.apache.org/jira/issues/?jql=project%20%3D%20MSOURCES%20AND%20status%20%3D%20Open%20ORDER%20BY%20priority%20DESC


Staging repo:
https://repository.apache.org/content/repositories/maven-1280
https://repository.apache.org/content/repositories/maven-1280/org/apache/maven/plugins/maven-source-plugin/3.0.1/maven-source-plugin-3.0.1-source-release.zip


Source release checksum(s):
maven-source-plugin-3.0.1-source-release.zip sha1:
fb9b07870d5a9c8b12622f18c426893a932a3334

Staging site:
https://maven.apache.org/plugins-archives/maven-source-plugin-LATEST/

Guide to testing staged releases:
https://maven.apache.org/guides/development/guide-testing-releases.html

Vote open for 72 hours.


+1


-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven issue #70: MNG-3092: Adds version range result filter behaviour

[michael-o]

Github user michael-o commented on the issue:

https://github.com/apache/maven/pull/70
  
@barthel ITs pass. I am now willing to merge both PRs. Just waiting for 
your comment on the previous message.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

Re: VOTE] Release Apache Maven Source Plugin version 3.0.1

[Karl Heinz Marbaise]

Hi,

here is my +1

two PMC Votes missings...

Kind regards
Karl Heinz
On 6/18/16 4:49 PM, Karl Heinz Marbaise wrote:

Hi,

We solved 8 issues:
https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317924=12335588


There are still one issue left in JIRA:
https://issues.apache.org/jira/issues/?jql=project%20%3D%20MSOURCES%20AND%20status%20%3D%20Open%20ORDER%20BY%20priority%20DESC


Staging repo:
https://repository.apache.org/content/repositories/maven-1280
https://repository.apache.org/content/repositories/maven-1280/org/apache/maven/plugins/maven-source-plugin/3.0.1/maven-source-plugin-3.0.1-source-release.zip


Source release checksum(s):
maven-source-plugin-3.0.1-source-release.zip sha1:
fb9b07870d5a9c8b12622f18c426893a932a3334

Staging site:
https://maven.apache.org/plugins-archives/maven-source-plugin-LATEST/

Guide to testing staged releases:
https://maven.apache.org/guides/development/guide-testing-releases.html

Vote open for 72 hours.

[ ] +1
[ ] +0
[ ] -1

Kind regards
Karl Heinz Marbaise


-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

Re: [VOTE] Release Apache Maven JAR Plugin version 3.0.2

[Karl Heinz Marbaise]

Hi,

here is my +1...

one more PMC VOTE needed...

Kind regards
Karl Heinz
On 6/18/16 4:24 PM, Karl Heinz Marbaise wrote:

Hi,

We solved 4 issues:
https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317526=12336062=Text


There are still a couple of issues left in JIRA:
https://issues.apache.org/jira/issues/?jql=project%20%3D%20MJAR%20AND%20status%20%3D%20Open%20ORDER%20BY%20priority%20DESC


Staging repo:
https://repository.apache.org/content/repositories/maven-1279
https://repository.apache.org/content/repositories/maven-1279/org/apache/maven/plugins/maven-jar-plugin/3.0.2/maven-jar-plugin-3.0.2-source-release.zip


Source release checksum(s):
maven-jar-plugin-3.0.2-source-release.zip sha1:
2aa4c89fc550ff3bd4bcb3ff163644b2e9e7be67

Staging site:
http://maven.apache.org/plugins-archives/maven-jar-plugin-LATEST/

Guide to testing staged releases:
http://maven.apache.org/guides/development/guide-testing-releases.html

Vote open for 72 hours.

[ ] +1
[ ] +0
[ ] -1

Kind regards
Karl Heinz Marbaise


-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven issue #70: MNG-3092: Adds version range result filter behaviour

[michael-o]

Github user michael-o commented on the issue:

https://github.com/apache/maven/pull/70
  
I am already working on your PRs. I think, committing this under MNG-3092 
is wrong and will explain why. I we cannot close the issue, people won't see 
this in the changelog. They won't simply know that a simple extension can solve 
their problem. Can you create a separate issue for your solution and make 
MNG-3092 depend on your issue. People would then know that they can solve it by 
adding an extension. I will change the PR content according to the new issue id.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven-scm issue #31: SCM-706 finer-grained handling of file rename status fo...

[sergei-ivanov]

Github user sergei-ivanov commented on the issue:

https://github.com/apache/maven-scm/pull/31
  
I need help with that from the Apache team.
In the original version of `GitCheckInCommand`, just before committing, the 
list of files to be committed was passed to `git add`. This ensured that all 
the new files were staged into the commit.
Unfortunately, it did not work when there were deleted files in that list. 
So, the patched version attempts to check `git status` on each of the files in 
the list, in order to filter out the deleted files from the list. See the 
changes in `GitCheckInCommand`.
Here is a problem though. Some of the git commands assume file paths 
relative to the working directory, while the other work with paths relative to 
the git repository root. Accordingly, the file paths need to be converted back 
and forth, and it seems that at some point we have a mismatch.
This caused grief previously 
(https://issues.apache.org/jira/browse/SCM-709) and it looks like we are 
observing yet another manifestation of the same problem.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven-scm issue #31: SCM-706 finer-grained handling of file rename status fo...

[YogiKhan]

Github user YogiKhan commented on the issue:

https://github.com/apache/maven-scm/pull/31
  
@sergei-ivanov I followed the steps and i was able to run the plugin 
without any error but couple of things noticed:

- release-pom.xml is also check-in as part of tag along with pom.xml
-if we have multiple modules, it did work only for root but skipped all 
other modules.

Are we planning for any fix for both?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven-scm issue #31: SCM-706 finer-grained handling of file rename status fo...

[sergei-ivanov]

Github user sergei-ivanov commented on the issue:

https://github.com/apache/maven-scm/pull/31
  
@YogiKhan you will need to build this PR branch of `maven-scm`, and then 
build `maven-release` project against it. Then you'll need to update the 
version of `maven-release-plugin` in your own project to the version you've 
just built and test it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven-scm issue #31: SCM-706 finer-grained handling of file rename status fo...

[YogiKhan]

Github user YogiKhan commented on the issue:

https://github.com/apache/maven-scm/pull/31
  
@sergei-ivanov, till it get merge, where i can find the 1.9.5-beta1 
version? So that i can test it ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven-scm issue #31: SCM-706 finer-grained handling of file rename status fo...

[YogiKhan]

Github user YogiKhan commented on the issue:

https://github.com/apache/maven-scm/pull/31
  
Thanks @sergei-ivanov 

@olamy can we merge that and create a release ? is it gonna take time? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven-scm issue #31: SCM-706 finer-grained handling of file rename status fo...

[sergei-ivanov]

Github user sergei-ivanov commented on the issue:

https://github.com/apache/maven-scm/pull/31
  
@olamy I've done a rebase onto the latest master and re-pushed the changes 
to the PR branch.

_However_, there still exists an unresolved regression (as pointed out by 
@indrgun), when the release is being run for a submodule of a bigger project. 
In that case, the working directory is a number of levels down from the git 
repository root, and somewhere in the git scm provider code there's a subtle 
bug related to path relativisation. I spent a few hours trying to track it 
down, and still could not put my finger on it. I would really appreciate it if 
someone like @rfscholte took a look at it, because he had previously invested a 
lot of effort in that area, and may still have a better idea of what is going 
on there.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven-scm issue #31: SCM-706 finer-grained handling of file rename status fo...

[YogiKhan]

Github user YogiKhan commented on the issue:

https://github.com/apache/maven-scm/pull/31
  
@sergei-ivanov  can we resolve that.

This plugin is quite powerful and we are waiting for so long to get that 
bug fix. Can you please resolve and merge.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

Re: [2/5] maven git commit: [MNG-3507] use AnsiUtils API to use colors consistently

[Hervé BOUTEMY]

Le lundi 20 juin 2016 20:33:26 Christian Schulte a écrit :
> Am 06/20/16 um 19:15 schrieb Robert Scholte:
> > Hi Christian,
> > 
> > when I introduced the maven-project-utils I had a library in mind with
> > helpful MavenProject related methods for multiple plugins. For that reason
> > I didn't make it part of the Maven distribution.
> > With this commit the library suddenly is required.
> > Instead I think you should use plain JAnsi or we should extract the
> > logging part from the library.
> 
> Hervé committed this and is currently working on it.
yes, I'm the culprit here :)

> Colours disappeard
> on current 'master' here.
same for me
the code that checks for Maven version before activating colors does not work 
when run in Maven core...
I just activated color explicitely in Maven core, but since this code will 
also be responsible for custom colors injection (later, I still didn't have 
time to implement it), I don't think this will be the right answer

> I am not sure using plain JAnsi is the way to
> go. I would prefer having some kind of facade people can use which
> allows us to replace JAnsi without the need to touch any code.
replacing JAnsi probably won't happen
But this API is responsible for consistent and configable colors

> Currently
> JAnsi still is on the compile classpath. That's like using classes of
> some 'com.sun' package. We have no compiler warning people about direct
> use of JAnsi. So it better disappears from any compile classpath to be
> safe. Allowing direct use of JAnsi we also run into that 'everyone uses
> colours in an inconsistent way' - like someone else already said - we
> will get that rainbow console effect sometime in the future (when people
> start providing colours in theire plugins).
this is where Java 9 modules would help...
For the moment, I don't think hiding JAnsi is a priority: explaining the Maven 
color logging messages API is more important.

> The API Hervé is working on
> looks promising. Maybe we make that a class in 'maven-core' instead of a
> part of some library. Plugins already add 'maven-core' to theire compile
> classpath.
if we do that, doing plugins working on every Maven version will require 
reflection: that's hard

> That could pull in some kind of Ansi Logging helper class as
> well. No need for a separate library, I think.
If using maven-project-utils in core is not ok, yes, we'll need a separate 
library

Regards,

Hervé

> 
> Regards,


-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven-scm issue #31: SCM-706 finer-grained handling of file rename status fo...

[olamy]

Github user olamy commented on the issue:

https://github.com/apache/maven-scm/pull/31
  
@YogiKhan see the message "This branch has conflicts that must be resolved" 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org