[GitHub] maven-shared pull request #21: [MSHARED-632] Expose which dependency classes...
GitHub user jhaber opened a pull request: https://github.com/apache/maven-shared/pull/21 [MSHARED-632] Expose which dependency classes are used and where We use the maven-dependency-plugin to analyze dependencies and fail our build if there are any used undeclared or unused declared dependencies. In the case of used undeclared dependencies, it is often helpful to know which classes are being used and where they are being used. We've found a few workarounds to make this a little easier, but the plugin has access to this information so what we really want is for the plugin to just print this info along with each used undeclared dependency. We've made this change in our fork and our developers are very happy with it, so I'd like to contribute it back ([here](https://gist.github.com/jhaber/d8204829fe61569e0034250df74300fb) is an example of the output before and after the change). If you agree this is a useful feature, this PR implements the first step which is to update the maven-dependency-analyzer to return this information so that the maven-dependency-plugin can use it. I introduced a new interface, `DependencyAnalyzerWithUsages`, to avoid breaking changes to the `DependencyAnalyzer` interface. I confirmed with the japi-compliance-checker that source and binary compatibility has been maintained: ``` â ~ perl japi-compliance-checker.pl -lib maven-dependency-analyzer -jdk-path $JAVA7_HOME -old ~/Downloads/maven-dependency-analyzer-1.6.jar -new ~/src/maven-shared-pr/maven-dependency-analyzer/target/maven-dependency-analyzer-1.7-SNAPSHOT.jar using Java 1.7.0_75 WARNING: set 1st version number to 1.6 (use -v1 option to change it) WARNING: set 2nd version number to 1.7-SNAPSHOT (use -v2 option to change it) reading classes 1.6 ... reading classes 1.7-SNAPSHOT ... comparing classes ... creating compatibility report ... result: COMPATIBLE total "Binary" compatibility problems: 0, warnings: 0 total "Source" compatibility problems: 0, warnings: 0 see detailed report: compat_reports/maven-dependency-analyzer/1.6_to_1.7-SNAPSHOT/compat_report.html ``` I'd love to hear any thoughts or feedback you have, thanks! You can merge this pull request into a Git repository by running: $ git pull https://github.com/jhaber/maven-shared trunk Alternatively you can review and apply these changes as the patch at: https://github.com/apache/maven-shared/pull/21.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #21 commit 578043a6dbf3927491aa01b00497b194ec471ebd Author: Jonathan Haber Date: 2017-04-21T03:41:32Z Expose which dependency classes are used and where --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven issue #114: MNG-6220 add color CLI option
Github user mryan43 commented on the issue: https://github.com/apache/maven/pull/114 I applied solution B. I have added an auto-detection method in MessageUtils in my fork of maven-shared-utils (https://github.com/mryan43/maven-shared) based on the corresponding code in jansi. Unfortunately, upgrading to 3.2.0-SNAPSHOT from maven breaks compilation because of changes done for MSHARED-587 but I'm affraid fixing them would be out of scope of this PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: Please approve branch to support JDK 9 in Surefire
Hi Robert, The IT is in the branch. I am going to push the branch to master if we have no objections. Thx T On Thu, Apr 20, 2017 at 9:57 PM, Robert Scholte wrote: > Hi Tibor, > > I'd suggest to use Jira's attached testcase as part of the commit. > The testcase is very small and reflects to problem very well. > Making it part of the commit ensures you're fixing the right issue. > > Robert > > > On Thu, 20 Apr 2017 21:23:32 +0200, Tibor Digana > wrote: > > Hello, >> >> I committed branch [1] SUREFIRE-1265 with JDK 9 fix. >> The user's test attached in Jira passed. >> Can we proceed pushing it to master? >> >> [1] >> https://git-wip-us.apache.org/repos/asf?p=maven-surefire.git >> ;a=commit;h=c31dc99b78771db0cff085c4567d4a957397f39f >> >> Cheers >> Tibor >> > > - > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > For additional commands, e-mail: dev-h...@maven.apache.org > >
Re: Maven Shell
Thanks Jason. This is great. For those that don't know mvnsh is a shell environment that has a JVM with Maven constantly running so you will get nice performance and usability improvments on the command line. This new version is using Maven 3.5.0. Installation is easy - extract the archive and put the bin folder on your path. More details and filing issues and so on at https://github.com/jdillon/mvnsh And from my testing so far .. it rocks. Try it out! Manfred Jason Dillon wrote on 2017-04-19 23:08: > Folks, just a quick not that I’ve updated Maven Shell for the latest release, > can be found with the latest SNAPSHOT: > > https://oss.sonatype.org/content/repositories/snapshots/com/planet57/maven/shell/dist/mvnsh-assembly/1.2.0-SNAPSHOT/ > > Locally seems to be fully functional. I’ve been updating GShell (which > mvnsh is based on) as well. > > I’m considering augmenting the release versions of mvnsh to match the > upstream versions. > > I’m also eventually gonna update the jline support as I think jline3 is much > much improved, thanks to gnodet, but I haven’t done that yet. > > If there are folks that may still be using older versions of the shell, I’d > like to ask them to test the latest SNAPSHOTS and report back any issues. > > Cheers, > > —jason > > - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: Please approve branch to support JDK 9 in Surefire
Hi Tibor, I'd suggest to use Jira's attached testcase as part of the commit. The testcase is very small and reflects to problem very well. Making it part of the commit ensures you're fixing the right issue. Robert On Thu, 20 Apr 2017 21:23:32 +0200, Tibor Digana wrote: Hello, I committed branch [1] SUREFIRE-1265 with JDK 9 fix. The user's test attached in Jira passed. Can we proceed pushing it to master? [1] https://git-wip-us.apache.org/repos/asf?p=maven-surefire.git;a=commit;h=c31dc99b78771db0cff085c4567d4a957397f39f Cheers Tibor - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Please approve branch to support JDK 9 in Surefire
Hello, I committed branch [1] SUREFIRE-1265 with JDK 9 fix. The user's test attached in Jira passed. Can we proceed pushing it to master? [1] https://git-wip-us.apache.org/repos/asf?p=maven-surefire.git;a=commit;h=c31dc99b78771db0cff085c4567d4a957397f39f Cheers Tibor
[maven-site-plugin] Is there a MavenMultiPage example ?
Hi I am used to produce Maven Site static Html reports. I wish to produce multi pages reports (one report page per source code for example). In version 2.1.1 of org.apache.maven.reporting is defined the MavenMultiPageReport interface. How to use it with the maven-site-plugin ? Thanks for your help. Didier - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-shared pull request #20: Changed the scopeFilter to use a LinkedHashSe...
GitHub user choss opened a pull request: https://github.com/apache/maven-shared/pull/20 Changed the scopeFilter to use a LinkedHashSet I added the ScopeFilter to use a LinkedHashSet, so that the dependency:build-classpath plugin/target can now preserve the order of the classpath entries also when we only want the runtime scope classpath You can merge this pull request into a Git repository by running: $ git pull https://github.com/choss/maven-shared patch-1 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/maven-shared/pull/20.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #20 commit feefd1e18e43b553cc5c38ee5fcc111c6c5932af Author: choss Date: 2017-04-20T10:15:32Z Changed the scopeFilter to use a LinkedHashSet I added the ScopeFilter to use a LinkedHashSet, so that the dependency:build-classpath plugin/target can now preserve the order of the classpath entries also when we only want the runtime scope classpath --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
