[GitHub] maven issue #127: [MNG-6255] Fix concat_lines in mvn to deal with CRLF

2017-07-18 Thread Tunaki 
Github user Tunaki commented on the issue:

https://github.com/apache/maven/pull/127
  
Looks like we have a similar bug in `mvn.cmd`. The added 
`testJvmConfigFileCR` test fails on Windows:

```
testJvmConfigFileCR(org.apache.maven.it.MavenITmng6255FixConcatLines)  Time 
elapsed: 1.983 sec  <<< FAILURE!
junit.framework.ComparisonFailure: null expected: but 
was:
  at junit.framework.Assert.assertEquals(Assert.java:81)
  at junit.framework.Assert.assertEquals(Assert.java:87)
  at 
org.apache.maven.it.MavenITmng6255FixConcatLines.runWithLineEndings(MavenITmng6255FixConcatLines.java:89)
  at 
org.apache.maven.it.MavenITmng6255FixConcatLines.testJvmConfigFileCR(MavenITmng6255FixConcatLines.java:50)
```

Looks like the carriage returns at the end of the line were stripped and 
everything was put on a single line.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

Re: [VOTE] Release Apache Maven Invoker Plugin version 3.0.1 / Apache Maven Script Interpreter 1.2 (take 2)

2017-07-18 Thread Karl Heinz Marbaise 

Hi,

+1 for the maven-script-interpreter
+1 for the maven-invoker-plugin.

Kind regards
Karl Heinz Marbaise

On 17/07/17 13:08, Olivier Lamy wrote:

Hi,
I'd like to release Apache Maven Invoker Plugin version 3.0.1 and Apache
Maven Script Interpreter 1.2.

We fixed 2 issues for Script interpreter:
https://s.apache.org/MSCRIPT-INTERPRETER-JIRA-1.2
We fixed 4 issues for Invoker plugin:
https://s.apache.org/MINVOKER-JIRA-3.0.1

Staging repo: https://repository.apache.org/content/repositories/maven-1346

Source releases:
*
https://repository.apache.org/content/repositories/maven-1346/org/apache/maven/plugins/maven-invoker-plugin/3.0.1/maven-invoker-plugin-3.0.1-source-release.zip
*
https://repository.apache.org/content/repositories/maven-1346/org/apache/maven/shared/maven-script-interpreter/1.2/maven-script-interpreter-1.2-source-release.zip

Staging sites:
http://maven.apache.org/components/plugins-archives/maven-invoker-plugin-LATEST/
http://maven.apache.org/components/shared-archives/maven-script-interpreter-LATEST/

Guide to testing staged releases:
https://maven.apache.org/guides/development/guide-testing-releases.html

Vote open for at least 72 hours.

[ ] +1
[ ] +0
[ ] -1

My +1

Cheers



-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven-integration-testing issue #24: Add test for MNG-6255 jvm.config line e...

2017-07-18 Thread grkvlt 
Github user grkvlt commented on the issue:

https://github.com/apache/maven-integration-testing/pull/24
  
Tested on OSX; passes when change from 
https://github.com/apache/maven/pull/127 are made to the `mvn` script.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven-integration-testing pull request #24: Add test for MNG-6255 jvm.config...

2017-07-18 Thread grkvlt 
GitHub user grkvlt opened a pull request:

https://github.com/apache/maven-integration-testing/pull/24

Add test for MNG-6255 jvm.config line endings

Integration test for fix made in https://github.com/apache/maven/pull/127

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/grkvlt/maven-integration-testing MNG-6255

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/maven-integration-testing/pull/24.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #24


commit 2f60b1e358a477b622a0fb4c8f07a2d2e5ecac8d
Author: Andrew Donald Kennedy 
Date:   2017-07-18T17:21:43Z

Add test for MNG-6255 jvm.config line endings




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven issue #125: [MNG-5965] Parallel build multiplies work if multiple goal...

2017-07-18 Thread ifedorenko 
Github user ifedorenko commented on the issue:

https://github.com/apache/maven/pull/125
  
No, sorry, I can't "assign" this to anyone, you just have to wait for 
somebody to review and merge this pull request.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven issue #125: [MNG-5965] Parallel build multiplies work if multiple goal...

2017-07-18 Thread dbmeneses 
Github user dbmeneses commented on the issue:

https://github.com/apache/maven/pull/125
  
@ifedorenko Ok, thanks for the help preparing the p/r. Is there anyone you 
could assign the review to?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org