Re: main-class + module-version

[Robert Scholte]

Hi all,

I'm having a look at the JarArchiver of the plexus-archiver project as  
used by maven-jar-plugin.
This archiver does some MANIFEST and index stuff already, so it kind of  
makes sense to add the module-descriptor logic here as well.
That will make it reusable as mentioned by Olivier and it'll be easy to  
use by the maven-jar-plugin.


thanks,
Robert

On Tue, 22 Aug 2017 19:17:04 +0200, Robert Scholte   
wrote:



Hi,

The JDK 9 jar packager comes with 2 extra options: main-class and  
module-version.
The first one is used in case of an executable modular jar, the latter  
is just for display/analysis to show which version of a specific module  
is used.
To support these 2 values, the module-info.class must be adjusted (yes,  
the bytecode!).


It is not that hard to support this as well with a little help from ASM,  
but the question is: which plugin should do this: maven-jar-plugin or  
maven-shade-plugin?
If you consider this kind of information to be part of the packaging  
process, maven-jar-plugin seems to be the best fit.
However, if you consider this as a resource transformation, then  
maven-shade-plugin seems better.


Personally I think packaging should be quite a stupid action: making a  
jar  from a set of files. And it should be very reliable, since it is  
part of the lifecycle of the most used packaging type. Of course you can  
control this when exposed as parameters...


Or should these extra (basic?) features require an extra setup of a  
maven-plugin so all transformations are done by one plugin only.


WDYT?
Robert

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

Re: [ANN] Declaration of intent to release 3.5.1

[Arnaud Héritier]

LGTM

Le jeu. 24 août 2017 à 11:17, Stephen Connolly <
stephen.alan.conno...@gmail.com> a écrit :

> On Thu 24 Aug 2017 at 10:16, Robert Scholte  wrote:
>
> > Great news!
> >
> > Unresolved issues for Maven 3.5.x[1]
> > I don't see any critical issues here which are regressions in 3.5.0
> >
> > There's one issue I would like to merge, though needs to be second first.
> > In case of ServiceLoaders it is a Java 8+ issue:
> > MNG-6275: ServiceLoaderFactory can't find implementations via
> ClassRealm[2]
> > Commit[3]
> > Jenkins Happiness[4] (it's red because there is no matching
> > maven-integration branch, new unittest is green)
> >
>
> Seconded
>
>
> > thanks,
> > Robert
> >
> > [1] https://s.apache.org/maven-3.5.1-RC_jira
> > [2] https://issues.apache.org/jira/browse/MNG-6275
> > [3]
> >
> https://git1-us-west.apache.org/repos/asf?p=maven.git;a=commit;h=c829bdcf
> > [4] https://builds.apache.org/job/maven-3.x-jenkinsfile/job/MNG-6275/1/
> >
> >
> > On Wed, 23 Aug 2017 21:09:03 +0200, Stephen Connolly
> >  wrote:
> >
> > > Advance warning, my intent is to start cutting RCs towards the end of
> > > next
> > > week.
> > >
> > > Focus on bugs and Java 9 compatibility would be best at this stage
> > >
> > > (Getting to an actual release will take as long as it takes, but I
> intend
> > > actively triage of the scope and RCs every 1-2 weeks until we get
> there)
> > >
> > > -Stephen
> >
> > -
> > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
> > For additional commands, e-mail: dev-h...@maven.apache.org
> >
> > --
> Sent from my phone
>
-- 
-
Arnaud Héritier
http://aheritier.net
Mail/GTalk: aheritier AT gmail DOT com
Twitter/Skype : aheritier

[GitHub] maven issue #87: [MNG-5457] Added the repository id to show which repository...

[rfscholte]

Github user rfscholte commented on the issue:

https://github.com/apache/maven/pull/87
  
@rajivpjs can you close this pullrequest? This open PR causes warnings for 
https://issues.apache.org/jira/browse/MNG-5457 on the release page.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org