Re: Welcome Christian Stein to the Apache Maven Team

2018-05-07 Thread Christian Stein
On Mon, May 7, 2018 at 11:48 PM Tibor Digana  wrote:

> Welcome!
> I hope Christian is online.
>

No, wasn't online when you wrote the mail.


> We are working on JUnit5 provider in Surefire together and I see we have
> quite a good progress step by step. So I think we will produce a new
> version 2.22.0.


Would be cool if we can have the 2.22 release this month. :)

Cheers,
Christian


Re: Welcome Christian Stein to the Apache Maven Team

2018-05-07 Thread Karl Heinz Marbaise

Hello Christian,

welcome...

Kind regards
Karl Heinz Marbaise

On 07/05/18 22:01, Robert Scholte wrote:

Hi,

On behalf of the Apache Maven PMC I am pleased to announce that 
Christian Stein (sor) has been voted in as a new Apache Maven committer.


Christian, welcome on board and have a lot of fun!

thanks,
Robert


-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org



Re: Welcome Christian Stein to the Apache Maven Team

2018-05-07 Thread Christian Stein
Thank you very much for the warm welcome, everybody.

As Tibor said, my first plan is getting the code donation from JUnit
to Maven Surefire finally finished [1]. Then, there're some open ends
which need some care and improvements [2]. And when the testing
dust settles down, I'd like to get modular white-box [3] test compilation
over the finish line. ;-)

Cheers,
Christian

[1] https://issues.apache.org/jira/browse/SUREFIRE-1330
[2]
https://github.com/junit-team/junit5/issues?q=is%3Aissue+is%3Aopen+label%3A%22component%3A+Surefire%22
[3] https://github.com/apache/maven-compiler-plugin

On Mon, May 7, 2018 at 10:01 PM Robert Scholte  wrote:

> Hi,
>
> On behalf of the Apache Maven PMC I am pleased to announce that Christian
> Stein (sor) has been voted in as a new Apache Maven committer.
>
> Christian, welcome on board and have a lot of fun!
>
> thanks,
> Robert
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
> For additional commands, e-mail: dev-h...@maven.apache.org
>
>


Re: Second MNG-6403

2018-05-07 Thread Michael Osipov

Am 2018-05-07 um 23:35 schrieb Robert Scholte:
On Sun, 06 May 2018 21:32:18 +0200, Karl Heinz Marbaise 
 wrote:



Hi Michael,

two things are coming into my mind:

I stumbled over one thing which is:

Why do we have the tests in maven-compat and not in maven-artifact ? 
Shouldn't they be in maven-artifact instead of maven-compat ?


+1


Done is subsequent commmit: 
https://github.com/apache/maven/commit/9021d66e53f979b0664677b7977c650e71d51d1d


Unit tests pass, as well as ITs.

Are we good to merge to master?




Furthermore if I recap the code and the tests I would think we should 
add a test that proves that the given pattern is NOT a SNAPSHOT 
version...


Something like this:

assertEquals( false, ArtifactUtils.isSnapshot( 
"1.2.3-20090413X094722-2"));


WDYT ?

Kind regards
Karl Heinz Marbaise



On 06/05/18 21:15, Michael Osipov wrote:

Am 2018-05-06 um 21:08 schrieb Karl Heinz Marbaise:

Hi,

I second MNG-6403 for 3.5.4 we should write a test for this to be 
sure this does not happen again...

 Do you have anything specific in mind?
 I have updated the branch and added a test to ArtifactUtilsTest. Is 
that sufficient?

 Michael


-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org






-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org



Re: Welcome Christian Stein to the Apache Maven Team

2018-05-07 Thread Tibor Digana
Welcome!
I hope Christian is online.
We are working on JUnit5 provider in Surefire together and I see we have
quite a good progress step by step. So I think we will produce a new
version 2.22.0.

On Mon, May 7, 2018 at 10:01 PM, Robert Scholte 
wrote:

> Hi,
>
> On behalf of the Apache Maven PMC I am pleased to announce that Christian
> Stein (sor) has been voted in as a new Apache Maven committer.
>
> Christian, welcome on board and have a lot of fun!
>
> thanks,
> Robert
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
> For additional commands, e-mail: dev-h...@maven.apache.org
>
>


Re: Second MNG-5756

2018-05-07 Thread Michael Osipov

Am 2018-05-07 um 23:27 schrieb Robert Scholte:
On Mon, 07 May 2018 23:14:18 +0200, Michael Osipov  
wrote:



Am 2018-05-07 um 22:40 schrieb Robert Scholte:

That's indeed better.
Maybe a comment that when Maven requires Java9 it could be reverted 
to "Java Home"?


Maybe, but still remains not technically Java, but the bundled JRE as 
Oracle documents and can be confused with JAVA_HOME.


What about this one:
Apache Maven 3.5.4-SNAPSHOT 
(0062eba2f82c07d4c13610fb31c8dbbb79b9184c; 2018-05-07T23:08:43+02:00)
Maven home: 
D:\Entwicklung\Projekte\maven\apache-maven\target\apache-maven-3.5.4-SNAPSHOT 

Java version: 1.8.0_162, vendor: Oracle Corporation, location: 
C:\Program Files\Java\jdk1.8.0_162\jre

Default locale: de_DE, platform encoding: Cp1252
OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows"


Seems a bit long, but consistent on one line, just saying "Java 
location".


Interesting, it's complete and all Java info combined: I like it.

Having a look at the docs:
"java.home"    Installation directory for Java Runtime Environment (JRE)

since it is now 1 line, we might simply say JRE, runtime or JRE folder 
now...

location is fine as well, all are acceptable improvements


I really like runtime:

$ apache-maven-3.5.4-SNAPSHOT/bin/mvn -v
Apache Maven 3.5.4-SNAPSHOT (0062eba2f82c07d4c13610fb31c8dbbb79b9184c; 
2018-05-07T23:30:24+02:00)
Maven home: 
D:\Entwicklung\Projekte\maven\apache-maven\target\apache-maven-3.5.4-SNAPSHOT
Java version: 11-ea, vendor: Oracle Corporation, runtime: C:\Program 
Files\Java\jdk-11
Default locale: de_DE, platform encoding: Cp1252
OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows"


Makes sense now. I'll go ahead, amend the commit and merge into master.

Michae



 On Mon, 07 May 2018 22:30:51 +0200, Michael Osipov 
 wrote:



Am 2018-05-07 um 21:46 schrieb Robert Scholte:

I understand the fix, but it'll be no issue anymore with Java 9+
 I have my doubts about "used"? "JRE used" could also refer to a 
version.

This is actually the JRE *location*, but that's quite long
"JRE Home"?
Or just do a Java check and only adjust it for Java 8 and before.
In the end it really is "java.home"...


I brought up the same argument for Java 9+, but people were still 
confused and Java 8 will still be available for many years.


Oracle's docs talk about JRE installation directory, what about "JRE 
installation:"? I know it is long, but unambigious.


It is not really about dropping this information, but merely 
displaying which JVM this Maven instance is running.


Is the proposal acceptable with "installation"?

Michael

On Sun, 06 May 2018 00:11:36 +0200, Michael Osipov 
 wrote:



Hi folks,

who seconds MNG-5756 for 3.5.4? Several folks complain that "mvn 
-v" does not correspond to the reality, therefore two PRs have 
been created.
I have just changed the output to "JRE used:" instead of "Java 
home:".


Michael

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

 -
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org




-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

 -
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org









-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org



Re: Second MNG-6403

2018-05-07 Thread Robert Scholte
On Sun, 06 May 2018 21:32:18 +0200, Karl Heinz Marbaise  
 wrote:



Hi Michael,

two things are coming into my mind:

I stumbled over one thing which is:

Why do we have the tests in maven-compat and not in maven-artifact ?  
Shouldn't they be in maven-artifact instead of maven-compat ?


+1





Furthermore if I recap the code and the tests I would think we should  
add a test that proves that the given pattern is NOT a SNAPSHOT  
version...


Something like this:

assertEquals( false, ArtifactUtils.isSnapshot(  
"1.2.3-20090413X094722-2"));


WDYT ?

Kind regards
Karl Heinz Marbaise



On 06/05/18 21:15, Michael Osipov wrote:

Am 2018-05-06 um 21:08 schrieb Karl Heinz Marbaise:

Hi,

I second MNG-6403 for 3.5.4 we should write a test for this to be sure  
this does not happen again...

 Do you have anything specific in mind?
 I have updated the branch and added a test to ArtifactUtilsTest. Is  
that sufficient?

 Michael


-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org



Re: Second MNG-5756

2018-05-07 Thread Michael Osipov

Am 2018-05-07 um 22:40 schrieb Robert Scholte:

That's indeed better.
Maybe a comment that when Maven requires Java9 it could be reverted to 
"Java Home"?


Maybe, but still remains not technically Java, but the bundled JRE as 
Oracle documents and can be confused with JAVA_HOME.


What about this one:

Apache Maven 3.5.4-SNAPSHOT (0062eba2f82c07d4c13610fb31c8dbbb79b9184c; 
2018-05-07T23:08:43+02:00)
Maven home: 
D:\Entwicklung\Projekte\maven\apache-maven\target\apache-maven-3.5.4-SNAPSHOT
Java version: 1.8.0_162, vendor: Oracle Corporation, location: C:\Program 
Files\Java\jdk1.8.0_162\jre
Default locale: de_DE, platform encoding: Cp1252
OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows"


Seems a bit long, but consistent on one line, just saying "Java location".



On Mon, 07 May 2018 22:30:51 +0200, Michael Osipov  
wrote:



Am 2018-05-07 um 21:46 schrieb Robert Scholte:

I understand the fix, but it'll be no issue anymore with Java 9+
 I have my doubts about "used"? "JRE used" could also refer to a 
version.

This is actually the JRE *location*, but that's quite long
"JRE Home"?
Or just do a Java check and only adjust it for Java 8 and before.
In the end it really is "java.home"...


I brought up the same argument for Java 9+, but people were still 
confused and Java 8 will still be available for many years.


Oracle's docs talk about JRE installation directory, what about "JRE 
installation:"? I know it is long, but unambigious.


It is not really about dropping this information, but merely 
displaying which JVM this Maven instance is running.


Is the proposal acceptable with "installation"?

Michael

On Sun, 06 May 2018 00:11:36 +0200, Michael Osipov 
 wrote:



Hi folks,

who seconds MNG-5756 for 3.5.4? Several folks complain that "mvn -v" 
does not correspond to the reality, therefore two PRs have been 
created.

I have just changed the output to "JRE used:" instead of "Java home:".

Michael

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

 -
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org




-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org






-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org



Re: Welcome Christian Stein to the Apache Maven Team

2018-05-07 Thread Olivier Lamy
Welcome!

On Tue, 8 May 2018 at 08:01, Robert Scholte  wrote:

> Hi,
>
> On behalf of the Apache Maven PMC I am pleased to announce that Christian
> Stein (sor) has been voted in as a new Apache Maven committer.
>
> Christian, welcome on board and have a lot of fun!
>
> thanks,
> Robert
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
> For additional commands, e-mail: dev-h...@maven.apache.org
>
>

-- 
Olivier Lamy
http://twitter.com/olamy | http://linkedin.com/in/olamy


Re: Welcome Christian Stein to the Apache Maven Team

2018-05-07 Thread Martin Gainty
Willkommen Christian!


martin
__



From: Robert Scholte 
Sent: Monday, May 7, 2018 4:01 PM
To: dev@maven.apache.org; Apache Maven Users
Subject: Welcome Christian Stein to the Apache Maven Team

Hi,

On behalf of the Apache Maven PMC I am pleased to announce that Christian
Stein (sor) has been voted in as a new Apache Maven committer.

Christian, welcome on board and have a lot of fun!

thanks,
Robert

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org



Re: Second MNG-5756

2018-05-07 Thread Robert Scholte

That's indeed better.
Maybe a comment that when Maven requires Java9 it could be reverted to  
"Java Home"?


Robert

On Mon, 07 May 2018 22:30:51 +0200, Michael Osipov   
wrote:



Am 2018-05-07 um 21:46 schrieb Robert Scholte:

I understand the fix, but it'll be no issue anymore with Java 9+
 I have my doubts about "used"? "JRE used" could also refer to a  
version.

This is actually the JRE *location*, but that's quite long
"JRE Home"?
Or just do a Java check and only adjust it for Java 8 and before.
In the end it really is "java.home"...


I brought up the same argument for Java 9+, but people were still  
confused and Java 8 will still be available for many years.


Oracle's docs talk about JRE installation directory, what about "JRE  
installation:"? I know it is long, but unambigious.


It is not really about dropping this information, but merely displaying  
which JVM this Maven instance is running.


Is the proposal acceptable with "installation"?

Michael

On Sun, 06 May 2018 00:11:36 +0200, Michael Osipov  
 wrote:



Hi folks,

who seconds MNG-5756 for 3.5.4? Several folks complain that "mvn -v"  
does not correspond to the reality, therefore two PRs have been  
created.

I have just changed the output to "JRE used:" instead of "Java home:".

Michael

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

 -
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org




-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org



Re: Second MNG-5756

2018-05-07 Thread Michael Osipov

Am 2018-05-07 um 21:46 schrieb Robert Scholte:

I understand the fix, but it'll be no issue anymore with Java 9+

I have my doubts about "used"? "JRE used" could also refer to a version.
This is actually the JRE *location*, but that's quite long
"JRE Home"?
Or just do a Java check and only adjust it for Java 8 and before.
In the end it really is "java.home"...


I brought up the same argument for Java 9+, but people were still 
confused and Java 8 will still be available for many years.


Oracle's docs talk about JRE installation directory, what about "JRE 
installation:"? I know it is long, but unambigious.


It is not really about dropping this information, but merely displaying 
which JVM this Maven instance is running.


Is the proposal acceptable with "installation"?

Michael

On Sun, 06 May 2018 00:11:36 +0200, Michael Osipov  
wrote:



Hi folks,

who seconds MNG-5756 for 3.5.4? Several folks complain that "mvn -v" 
does not correspond to the reality, therefore two PRs have been created.

I have just changed the output to "JRE used:" instead of "Java home:".

Michael

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org





-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org



Welcome Christian Stein to the Apache Maven Team

2018-05-07 Thread Robert Scholte

Hi,

On behalf of the Apache Maven PMC I am pleased to announce that Christian  
Stein (sor) has been voted in as a new Apache Maven committer.


Christian, welcome on board and have a lot of fun!

thanks,
Robert

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org



Re: ASM library not compatible with plexus-java:0.9.3 in Maven build

2018-05-07 Thread Robert Scholte

Seems all is fine now (and it actually wasn't a bug :) )

Robert

On Sun, 06 May 2018 13:13:33 +0200, Tibor Digana   
wrote:


We have a problem [1] with old version of plexus-java:0.9.3 and ASM  
library.

We should use plexus-java:0.9.7 which is dependent on ASM 6.1.1.
This would fix our problem with Maven 3.5.3. But is it working solution  
for

older Maven versions too?

What would be a generic solution?
Would be Maven dependent on ASM?
I see currently versions of maven plugins would be related to certain  
maven

version due to ASM.

[1]: https://github.com/junit-team/junit5/issues/1409

Cheers
Tibor


-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org



Re: Second MNG-5756

2018-05-07 Thread Robert Scholte

I understand the fix, but it'll be no issue anymore with Java 9+

I have my doubts about "used"? "JRE used" could also refer to a version.
This is actually the JRE *location*, but that's quite long
"JRE Home"?
Or just do a Java check and only adjust it for Java 8 and before.
In the end it really is "java.home"...

thanks,
Robert

On Sun, 06 May 2018 00:11:36 +0200, Michael Osipov   
wrote:



Hi folks,

who seconds MNG-5756 for 3.5.4? Several folks complain that "mvn -v"  
does not correspond to the reality, therefore two PRs have been created.

I have just changed the output to "JRE used:" instead of "Java home:".

Michael

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org



Re: Second MNG-6386

2018-05-07 Thread Robert Scholte

+1

Robert

On Sat, 05 May 2018 13:46:45 +0200, Michael Osipov   
wrote:



Am 2018-05-05 um 13:23 schrieb Stephen Connolly:

On Sat 5 May 2018 at 09:13, Michael Osipov  wrote:


Am 2018-05-05 um 09:15 schrieb Stephen Connolly:
On Thu 3 May 2018 at 22:10, Michael Osipov   
wrote:



Am 2018-05-02 um 10:41 schrieb Robert Scholte:

I don't see a new test[1][2], only rewrites to confirm there's no
regression.

I understand the issue, but we just need to be sure that nobody in  
the

future thinks that File.toURI() is short for File.toPath().toUri()

Robert

[1]




https://github.com/apache/maven/commit/43b34598629f086523a333dc18665389643832a5


[2]




https://github.com/apache/maven-integration-testing/commit/5e18bb18784585dfc822038f5229785d439c677b


Robert,

done some more digging and added unit and integration tests to it:



https://github.com/apache/maven/commit/9d29bb4d91e9545a9b5bc2957646ad42d5add210




https://github.com/apache/maven-integration-testing/commit/1f4912cda5f49b6ba36a2693bb5c1701ea4d9b86


Though, the IT reasonably runs on Unix if UTF-8 is set as  
file.encoding.

I have also updated the ticket with more description.

I think that this issue should be pushed to 3.6.0.



Unclear why you think it should be dropped from 3.5.4. We’re not  
changing

an API, only fixing a bug...


This fix introduces a change in behavior. It might be unexpected in a
fix release. If we are still OK for 3.5.4 then I am fine too.
  Well if we are worried about any change in behaviour then we  
shouldn’t make

any changes ever.
 The question is whether this is “significant”.
 One of my objections to semver is that it only focuses on APIs... so  
under

semver:
 1. No breaking API method signature changes => no major version bump
2. No new API methods => no minor version bump
3. Must be patch
 Now in the case of Maven, I argue for semver is a poor fit, largely  
because
we have multiple APIs, SPIs and UIs each of which have different  
measures

of breaking changes... but we only have one version number
 We need to get 3.5.4 with the jansi fix out... simple bug fixes are  
fine

for 3.5.4 too.
 then we focus on the next version (3.6.x or 4.0.x) and move on... but  
we
need to move the baseline to Java 8 at this stage and get Java 10  
support
better (both of which i’d like to see in a 4.0.x so if we are missing  
those

then it would be 3.6.x)


Agreed, I'll move it to 3.5.4.

Any other objections from someone else?


-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org



Re: ASM library not compatible with plexus-java:0.9.3 in Maven build

2018-05-07 Thread Christian Stein
Thanks a lot.

Karl Heinz Marbaise  schrieb am Mo., 7. Mai 2018, 17:52:

> Hi,
>
> Release plexus-java 0.9.8...
>
> now available via Maven Central..
>
> Kind regards
> Karl Heinz Marbaise
> On 07/05/18 10:39, Karl Heinz Marbaise wrote:
> > Hi,
> >
> > On 07/05/18 10:23, Christian Stein wrote:
> >> Nit: plexus-java:0.9.7 refers to ASM 6.1 which was superseded by ASM
> >> 6.1.1
> >>
> >> So, an upgrade to ASM 6.1.1 in plexus-java:0.9.8 would be great as that
> >> version [1] fixed two bugs in ClassReader.
> >>
> >> [1] http://asm.ow2.io/versions.html
> >
> >
> > Created issue[1] for this update and upgrade already..
> > I hope I can do a release of this in the evening...
> >
> > Kind regards
> > Karl Heinz Marbaise
> >
> > [1]: https://github.com/codehaus-plexus/plexus-languages/issues/12
>


Re: ASM library not compatible with plexus-java:0.9.3 in Maven build

2018-05-07 Thread Karl Heinz Marbaise

Hi,

Release plexus-java 0.9.8...

now available via Maven Central..

Kind regards
Karl Heinz Marbaise
On 07/05/18 10:39, Karl Heinz Marbaise wrote:

Hi,

On 07/05/18 10:23, Christian Stein wrote:
Nit: plexus-java:0.9.7 refers to ASM 6.1 which was superseded by ASM 
6.1.1


So, an upgrade to ASM 6.1.1 in plexus-java:0.9.8 would be great as that
version [1] fixed two bugs in ClassReader.

[1] http://asm.ow2.io/versions.html



Created issue[1] for this update and upgrade already..
I hope I can do a release of this in the evening...

Kind regards
Karl Heinz Marbaise

[1]: https://github.com/codehaus-plexus/plexus-languages/issues/12


-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org



Re: Second MNG-5756

2018-05-07 Thread Stephen Connolly
+1

On Sat 5 May 2018 at 23:11, Michael Osipov  wrote:

> Hi folks,
>
> who seconds MNG-5756 for 3.5.4? Several folks complain that "mvn -v"
> does not correspond to the reality, therefore two PRs have been created.
> I have just changed the output to "JRE used:" instead of "Java home:".
>
> Michael
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
> For additional commands, e-mail: dev-h...@maven.apache.org
>
> --
Sent from my phone


Re: ASM library not compatible with plexus-java:0.9.3 in Maven build

2018-05-07 Thread Tibor Digana
 @Karl, thx that you will release new plexus-java:0.9.8.
@Christian, yesterday I came late, but I concentrated on permanent issue on
Windows Jenkins nodes. The issues is that java compiles won't compile and I
guess it is again because on windows paths. The problem appears only on
windows-2012-3. I am doing some tricks to short the paths in the workspace.
Let's see if it helps.

Cheers
Tibor

On Mon, May 7, 2018 at 12:50 PM, Tibor Digana 
wrote:

> @Karl, thx that you will release new plexus-java:0.9.8.
> @Christian, yesterday I came late, but I concentrated on permanent issue
> on Windows Jenkins nodes. The issues is that java compiles won't compile
> and I guess it is again because on windows paths. The problem appears only
> on windows-2012-3. I am doing some tricks to short the paths in the
> workspace. Let's see if it helps.
>
> On Mon, May 7, 2018 at 10:39 AM, Karl Heinz Marbaise 
> wrote:
>
>> Hi,
>>
>>
>> On 07/05/18 10:23, Christian Stein wrote:
>>
>>> Nit: plexus-java:0.9.7 refers to ASM 6.1 which was superseded by ASM
>>> 6.1.1
>>>
>>> So, an upgrade to ASM 6.1.1 in plexus-java:0.9.8 would be great as that
>>> version [1] fixed two bugs in ClassReader.
>>>
>>> [1] http://asm.ow2.io/versions.html
>>>
>>
>>
>> Created issue[1] for this update and upgrade already..
>> I hope I can do a release of this in the evening...
>>
>> Kind regards
>> Karl Heinz Marbaise
>>
>> [1]: https://github.com/codehaus-plexus/plexus-languages/issues/12
>>
>> -
>> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
>> For additional commands, e-mail: dev-h...@maven.apache.org
>>
>>
>
>
> --
> Cheers
> Tibor
>


Re: ASM library not compatible with plexus-java:0.9.3 in Maven build

2018-05-07 Thread Tibor Digana
@Karl, thx that you will release new plexus-java:0.9.8.
@Christian, yesterday I came late, but I concentrated on permanent issue on
Windows Jenkins nodes. The issues is that java compiles won't compile and I
guess it is again because on windows paths. The problem appears only on
windows-2012-3. I am doing some tricks to short the paths in the workspace.
Let's see if it helps.

On Mon, May 7, 2018 at 10:39 AM, Karl Heinz Marbaise 
wrote:

> Hi,
>
>
> On 07/05/18 10:23, Christian Stein wrote:
>
>> Nit: plexus-java:0.9.7 refers to ASM 6.1 which was superseded by ASM 6.1.1
>>
>> So, an upgrade to ASM 6.1.1 in plexus-java:0.9.8 would be great as that
>> version [1] fixed two bugs in ClassReader.
>>
>> [1] http://asm.ow2.io/versions.html
>>
>
>
> Created issue[1] for this update and upgrade already..
> I hope I can do a release of this in the evening...
>
> Kind regards
> Karl Heinz Marbaise
>
> [1]: https://github.com/codehaus-plexus/plexus-languages/issues/12
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
> For additional commands, e-mail: dev-h...@maven.apache.org
>
>


-- 
Cheers
Tibor


Re: ASM library not compatible with plexus-java:0.9.3 in Maven build

2018-05-07 Thread Karl Heinz Marbaise

Hi,

On 07/05/18 10:23, Christian Stein wrote:

Nit: plexus-java:0.9.7 refers to ASM 6.1 which was superseded by ASM 6.1.1

So, an upgrade to ASM 6.1.1 in plexus-java:0.9.8 would be great as that
version [1] fixed two bugs in ClassReader.

[1] http://asm.ow2.io/versions.html



Created issue[1] for this update and upgrade already..
I hope I can do a release of this in the evening...

Kind regards
Karl Heinz Marbaise

[1]: https://github.com/codehaus-plexus/plexus-languages/issues/12

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org



Re: ASM library not compatible with plexus-java:0.9.3 in Maven build

2018-05-07 Thread Christian Stein
Nit: plexus-java:0.9.7 refers to ASM 6.1 which was superseded by ASM 6.1.1

So, an upgrade to ASM 6.1.1 in plexus-java:0.9.8 would be great as that
version [1] fixed two bugs in ClassReader.

[1] http://asm.ow2.io/versions.html