Re: Integration Tests of Maven Core

2019-12-17 Thread Mirko Friedenhagen
I would agree with Elliotte here. If someone creates a patch for Maven 2.2.x, 
he or she should just branch from the old tag and have all ITs available at 
that point of time.

Keeping tests and mark them as to be skipped for newer versions is strange.

After reading Tibor’s comment: 
* Tibor just did update the sources to newer Jetty versions but the 
corresponding tests were never run so no one can really say for sure that they 
would run at all, would they?
* Looks to me like a waste of time.

Regards
Mirko


> Am 15.12.2019 um 12:18 schrieb Elliotte Rusty Harold :
> 
> If it's necessary to maintain Maven 2.x or whatever old version,
> that's what version control systems and branches provide. I strongly
> prefer not to have work at head confused by tests that don;t run or
> code that's commented out. In this case, refactorings at head such as
> renaming a method could easily break the ability of an integration
> test to even compile with the version that matters. Project history
> belongs in the source code control system, not the current HEAD
> branch.
> 
> On Sun, Dec 8, 2019 at 2:10 PM Karl Heinz Marbaise  wrote:
>> 
>> Hi,
>> I'm diving a little bit into the integration tests of maven core...
>> 
>> and I realized that at the moment this list of IT's is SKIPPED
>> based on the version of Maven Core:
>> 
>> mng5889FindBasedir(MvnFileLongOptionModule).SKIPPED -
>> Maven version 3.7.0-SNAPSHOT not in range [3.5.0,3.5.1)
>> mng5889FindBasedir(MvnFileShortOptionModule)SKIPPED -
>> Maven version 3.7.0-SNAPSHOT not in range [3.5.0,3.5.1)
>> mng5889FindBasedir(MvnFileShortOption)..SKIPPED -
>> Maven version 3.7.0-SNAPSHOT not in range [3.5.0,3.5.1)
>> mng5889FindBasedir(MvnFileLongOption)...SKIPPED -
>> Maven version 3.7.0-SNAPSHOT not in range [3.5.0,3.5.1)
>> mng5805PkgTypeMojoConfiguration(PkgTypeMojoConfiguration)...SKIPPED -
>> Maven version 3.7.0-SNAPSHOT not in range (3.3.3,3.5.0-alpha)
>> mng4428FollowHttpRedirect(itHttpToHttps)SKIPPED -
>> Maven version 3.7.0-SNAPSHOT not in range [2.2.0,2.2.0]
>> mng4428FollowHttpRedirect(itHttpsToHttp)SKIPPED -
>> Maven version 3.7.0-SNAPSHOT not in range [2.2.0,2.2.0]
>> mng4279WagonProviderFailover(it)SKIPPED -
>> Maven version 3.7.0-SNAPSHOT not in range [2.2.1,3.0-alpha-1)
>> mng4254SelectableWagonProviders(DefaultHttpsWagon)..SKIPPED -
>> Maven version 3.7.0-SNAPSHOT not in range (2.2.0,3.0-alpha-1)
>> mng4254SelectableWagonProviders(DefaultHttpWagon)...SKIPPED -
>> Maven version 3.7.0-SNAPSHOT not in range (2.2.0,3.0-alpha-1)
>> mng4254SelectableWagonProviders(SettingsUsage)..SKIPPED -
>> Maven version 3.7.0-SNAPSHOT not in range (2.2.0,3.0-alpha-1)
>> mng4254SelectableWagonProviders(CliUsage)...SKIPPED -
>> Maven version 3.7.0-SNAPSHOT not in range (2.2.0,3.0-alpha-1)
>> mng4126ParentProfilesXml(itReactorBuild)SKIPPED -
>> Maven version 3.7.0-SNAPSHOT not in range [2.0,2.1.0),(2.1.0,3.0-alpha-1)
>> mng4126ParentProfilesXml(itChildOnlyBuild)..SKIPPED -
>> Maven version 3.7.0-SNAPSHOT not in range [2.0,2.1.0),(2.1.0,3.0-alpha-1)
>> mng4086ExplicitPluginMetaversion(itRelease).SKIPPED -
>> Maven version 3.7.0-SNAPSHOT not in range [2.0.6,3.0-alpha-3)
>> mng4086ExplicitPluginMetaversion(itLatest)..SKIPPED -
>> Maven version 3.7.0-SNAPSHOT not in range [2.0.6,3.0-alpha-3)
>> mng4036ParentResolutionFromSettingsRepo(itLegacyLayout).SKIPPED -
>> Maven version 3.7.0-SNAPSHOT not in range [2.0,3.0-alpha-3)
>> mng3991ValidDependencyScope(it).SKIPPED -
>> Maven version 3.7.0-SNAPSHOT not in range [4.0,)
>> mng3983PluginResolutionFromProfileRepos(itFromProfilesXml)..SKIPPED -
>> Maven version 3.7.0-SNAPSHOT not in range [2.0,3.0-alpha-1)
>> mng3970DepResolutionFromProfileRepos(itFromProfilesXml).SKIPPED -
>> Maven version 3.7.0-SNAPSHOT not in range [2.0,3.0-alpha-1)
>> mng3948ParentResolutionFromProfileRepos(itFromProfilesXml)..SKIPPED -
>> Maven version 3.7.0-SNAPSHOT not in range [2.0,3.0-alpha-1)
>> mng3933ProfilesXmlActivation(itMNG3933).SKIPPED -
>> Maven version 3.7.0-SNAPSHOT not in range [2.0,3.0-alpha-1)
>> mng3885UniqueVersionFromParentProfile(itUniqueVersionReactor)SKIPPED -
>> Maven version 3.7.0-SNAPSHOT not in range (2.0.10,3.0-alpha-1)
>> mng3885UniqueVersionFromParentProfile(itUniqueVersionStandalone)SKIPPED
>> - Maven version 3.7.0-SNAPSHOT not in range (2.0.10,3.0-alpha-1)
>> mng3885UniqueVersionFromParentProfile(itNonUniqueVersionStandalone)SKIPPED
>> - Maven version 3.7.0-SNAPSHOT not in range (2.0.10,3.0-alpha-1)
>> mng3885UniqueVersionFromParentProfile(itNonUniqueVersionReactor)SKIPPED
>> - Maven version 3.7.0-SNAPSHOT not in range (2.0.10,3.0-alpha-1)
>> mng3760BaseUriProperty(itMNG3760)...SKIPPED -
>> Maven version 

Re: releasing maven-javadoc-plugin

2019-12-17 Thread Olivier Lamy
I’m still working on fixing an issue for aggregated javadoc with jmps and
java11
I hope to get this fix for the weekend but if not go ahead and release
I can release again once I get the fix

On Tue, 17 Dec 2019 at 5:18 pm, Hervé BOUTEMY  wrote:

> I would like to release Apache parent POM this WE (then Maven parent
> POMs),
> with plugin versions that support Reproducible Builds
>
> The last plugin to upgrade is maven-javadoc-plugin: Reproducible Builds
> for
> that plugin is ok (MJAVADOC-627), but there are 4 issues open affected to
> the
> future version and assigned:
> https://issues.apache.org/jira/projects/MJAVADOC/versions/12345698
>
> Should I just change the target version?
>
> Regards,
>
> Hervé
>
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
> For additional commands, e-mail: dev-h...@maven.apache.org
>
> --
Olivier Lamy
http://twitter.com/olamy | http://linkedin.com/in/olamy


Re: releasing maven-javadoc-plugin

2019-12-17 Thread Enrico Olivelli
+1 please go  ahead

Enrico

Il giorno mar 17 dic 2019 alle ore 08:18 Hervé BOUTEMY <
herve.bout...@free.fr> ha scritto:

> I would like to release Apache parent POM this WE (then Maven parent
> POMs),
> with plugin versions that support Reproducible Builds
>
> The last plugin to upgrade is maven-javadoc-plugin: Reproducible Builds
> for
> that plugin is ok (MJAVADOC-627), but there are 4 issues open affected to
> the
> future version and assigned:
> https://issues.apache.org/jira/projects/MJAVADOC/versions/12345698
>
> Should I just change the target version?
>
> Regards,
>
> Hervé
>
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
> For additional commands, e-mail: dev-h...@maven.apache.org
>
>


Re: Defining EoL for Older Maven Versions

2019-12-17 Thread Enrico Olivelli
Hi,

Some points:
In my experience upgrading Maven has never been a problem (thanks to the
great attention we pay to backward compatibility)

Maven versioning scheme is very unusual and I suppose that people really
don't care about it or even they can't understand. Maven version is useful
only to plugin developers.
If you really have  problem with Maven usually the fix is about upgrading a
plugin, a dependency of a plugin and rarely to upgrade Maven core.

So my take is that there is no need to have an explicit "support" for older
releases other than the last released.
The case of security vulnerabilities in Maven core, or probably in third
party dependency is important, but we can spin off a branch and create a
release

For old releases the code is available on github and ASF git repository,
anyone can create its own fork and eventually port his fix to the community

just my two cents
Enrico




Il giorno lun 16 dic 2019 alle ore 23:29 Manfred Moser <
manf...@simpligility.com> ha scritto:

> Chiming in late since I remember we discussed this before.
>
> Here is my view.
>
> All releases beyond the most recent one are essentially end of lifed. We
> never backport, we have no explicit support and whenever we fix something
> it goes into the next release.
>
> That is what we concluded last time and that is the reason why the
> download page only offers the latest version.
>
> Anything else is misleading our users with some sort of support or
> guarantee that things continue to work and are tested when really they are
> not.
>
> Of course we make a best effort to keep things smooth ... but thats really
> where it ends.
>
> Manfred
>
> Karl Heinz Marbaise wrote on 2019-12-16 12:57 (GMT -08:00):
>
> > On 15.12.19 12:14, Elliotte Rusty Harold wrote:
> >> Tentative +1.
> >>
> >> Is there any reason we would ever backport a fix to 3.0 or 3.2? E.g.
> >> this was the last release to support Java 1.6.
> >
> > Unfortunately my crystal ball is under repair...I can't see into the
> > future...
> >
> > I would say if we a really bad security issue would could decide to do a
> > backport for older releases...But based on the history I know and can
> > read through the mailing archives it has not happened yet...
> >
> >
> >
> >>
> >> Or would we simply tell users to upgrade to 3.6.3?
> >>
> >>
> >> On Sat, Dec 14, 2019 at 6:31 AM Karl Heinz Marbaise 
> wrote:
> >>>
> >>> Hi,
> >>>
> >>> based on the history we have defined Maven 2.X EoL five years after the
> >>> last release...[1]
> >>>
> >>> Based on that I would suggest to define End Of Life for the following
> >>> Maven versions cause their release date is also five years ago...
> >>>
> >>>
> >>> Maven 3.0.5...3.2.5 included.
> >>>
> >>> We have never backported some things in the last five year...
> >>>
> >>> WDYT?
> >>>
> >>> Kind regards
> >>> Karl Heinz Marbaise
> >>>
> >>>
> >>> [1]: https://maven.apache.org/docs/history.html#Maven_2
> >>>
> >>> -
> >>> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
> >>> For additional commands, e-mail: dev-h...@maven.apache.org
> >
> > -
> > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
> > For additional commands, e-mail: dev-h...@maven.apache.org
> >
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
> For additional commands, e-mail: dev-h...@maven.apache.org
>
>


Re: [VOTE] Release Apache Maven Source Plugin version 3.2.1

2019-12-17 Thread Hervé BOUTEMY
I forgot to mention:
notice that thanks to maven-release-plugin 3.0.0-M1, the 
project.build.outputTimestamp property was automatically updated 2 times during 
the release:
- [1] during the release preparation phase
- [2] when preparing next development iteration

We have now the expected developer experience: everything is automatic (after 
init = manually defining an initial property value) and the timestamp is as 
meaningful as possible

Regards,

Hervé

[1] 
https://github.com/apache/maven-source-plugin/commit/a59a2e481f7d8e46f2abbd339d2d27e9b2964eba

[2] 
https://github.com/apache/maven-source-plugin/commit/e8eaa79e273c5d2b2e02eb1b8a964b2160081e0e

Le lundi 16 décembre 2019, 19:55:47 CET Hervé BOUTEMY a écrit :
> for those interested, I add the "Reproducible Builds (free) Bounty" :)
> 
> instructions:
> - use JDK 8 on an Unix (and please share if you find a trick to build on
> Windows, geting the same result) - please install locally
> maven-buildinfo-plugin
> https://github.com/apache/maven-studies/tree/maven-buildinfo-plugin - build
> with "mvn -Papache-release,run-its -Dgpg.skip verify buildinfo:save" -
> check the content of target/buildinfo against reference in attachment If
> you don't want to install maven-buildinfo-plugin, you can check the output
> checksums by hand, there are only 3 files to check in such a simple
> mono-module project: maven-source-plugin-3.2.1.jar,
> maven-source-plugin-3.2.1-source-release.zip and
> maven-source-plugin-3.2.1-sources.jar
> 
> Regards,
> 
> Hervé
> 
> Le lundi 16 décembre 2019, 19:37:00 CET Hervé BOUTEMY a écrit :
> > Hi,
> > 
> > We solved 2 issues:
> > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317924;
> > ve rsion=12346480=Text
> > 
> > Staging repo:
> > https://repository.apache.org/content/repositories/maven-1545/
> > https://repository.apache.org/content/repositories/maven-1545/org/apache/m
> > av
> > en/plugins/maven-source-plugin/3.2.1/maven-source-plugin-3.2.1-source-rel
> > eas e.zip
> > 
> > Source release checksum(s):
> > maven-source-plugin-3.2.1-source-release.zip sha512:
> > 4d7252839cc74dae8100a47adadbe6fc2c8f4d57e930fa695e4e6c75a8571b1246a63aa25d
> > e
> > 0cf2d73601e599faea2a31be43b1fe442e36d463702d885ccf8b7
> > 
> > Staging site:
> > https://maven.apache.org/plugins-archives/maven-source-plugin-LATEST/
> > 
> > Guide to testing staged releases:
> > https://maven.apache.org/guides/development/guide-testing-releases.html
> > 
> > Vote open for at least 72 hours.
> > 
> > [ ] +1
> > [ ] +0
> > [ ] -1
> > 
> > 
> > 
> > -
> > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
> > For additional commands, e-mail: dev-h...@maven.apache.org





-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org