Re: relativePath for parent poms in our plugins

2019-12-21 Thread Mark Struberg
To be honest, I didn't even know that there is a 'main project' with tons of 
git-submodules to emulate our old maven master build.

I still wonder whether it has any benefit to have the relativePath in our 
plugins.
It is useful if you have a reactor build where maven then knows how to search 
for other dependencies and figures what other parts to build. But I do not 
really see this for multiple reasons:

* We don't have any snapshot but a fixed version of the parent maven-plugins:33 
(and other versions) in every plugin. That means they won't use the 'is-a' in 
aggregator-style anyway
* That means the parent pom is merely a 'build-pom' but not much more. I
* Even if we would upgrade every plugin to use the latest snapshot of our 
maven-plugins parent pom we would not add much. It would still build fine 
without having a relativePath section. And we would not gain much from keeping 
relativePath because we barely have dependencies between our plugins. 

Hervé, others did I overlook something?

And sorry for starting this discussion. It's totally unimportant if we keep it 
or not. I'm fine both ways, it just looked like something we missed to remove 
when we moved from the maven-plugins sparse tree in SVN over to single GIT 
repos for each and every single maven plugin.

LieGrue,
strub


> Am 21.12.2019 um 18:38 schrieb Romain Manni-Bucau :
> 
> Le sam. 21 déc. 2019 à 15:03, Hervé BOUTEMY  a
> écrit :
> 
>> how does the current relativePath work less than without it?
>> Does it really break anything more than just "people don't understand the
>> value" then consider it "wrong"?
>> 
> 
> Well, it is unlikely but it can break the build yes, at least if it exists.
> It is also not friendly for newcomers cause not obvious.
> 
> 
>> in addition, I know that intermittent Maven contributor will clone only
>> one
>> Git repository, but I personally work on every Maven Git repository on
>> many
>> computers: being able to clone and update everything easily is key to me
>> 
> 
> Not sure I see how it changes anything :s. Assume we drop it, then you can
> still do all that (it is top-down and not down-top afaik).
> 
> 
> 
>> Regards,
>> 
>> Hervé
>> 
>> Le samedi 21 décembre 2019, 14:29:17 CET Romain Manni-Bucau a écrit :
>>> Agree with Robert, git clone && mvn install must always work and be
>>> straight forward if we want people to be able to help/work imho.
>>> 
>>> Le sam. 21 déc. 2019 à 13:33, Robert Scholte  a
>>> 
>>> écrit :
 that only works for the very, very few that uses this repository.
 It should work as to how contributors work with it, otherwise you'll
>> see
 other issues compared to them.
 
 Robert
 On 21-12-2019 12:33:53, Hervé BOUTEMY  wrote:
 disagree
 
 We have the repo configuration which brings a location for every Git
 repository:
 https://maven.apache.org/scm.html
 or https://github.com/apache/maven-sources/
 
 The relative paths are calculated against that.
 And I recently even added aggregator poms to build absolutely
>> everything
 in
 one unique build
 
 Regards,
 
 Hervé
 
 Le jeudi 19 décembre 2019, 12:13:56 CET Mark Struberg a écrit :
> Hi folks!
> 
> Looking at massembler right now I stumbled across a parentPom section
> 
> 
> maven-plugins
> org.apache.maven.plugins
> 33
> ../../pom/maven/maven-plugins/pom.xml
> 
> 
> This was perfectly fine when we had all in SVN under one big project.
> But nowadays - having all in GIT - I'd we should remove the
> relativePath,
> isn't?
> 
> LieGrue,
> strub
> 
> 
> -
> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
> For additional commands, e-mail: dev-h...@maven.apache.org
 
 -
 To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
 For additional commands, e-mail: dev-h...@maven.apache.org
>> 
>> 
>> 
>> 
>> 
>> -
>> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
>> For additional commands, e-mail: dev-h...@maven.apache.org
>> 
>> 


-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org



Re: relativePath for parent poms in our plugins

2019-12-21 Thread Romain Manni-Bucau
Le sam. 21 déc. 2019 à 15:03, Hervé BOUTEMY  a
écrit :

> how does the current relativePath work less than without it?
> Does it really break anything more than just "people don't understand the
> value" then consider it "wrong"?
>

Well, it is unlikely but it can break the build yes, at least if it exists.
It is also not friendly for newcomers cause not obvious.


> in addition, I know that intermittent Maven contributor will clone only
> one
> Git repository, but I personally work on every Maven Git repository on
> many
> computers: being able to clone and update everything easily is key to me
>

Not sure I see how it changes anything :s. Assume we drop it, then you can
still do all that (it is top-down and not down-top afaik).



> Regards,
>
> Hervé
>
> Le samedi 21 décembre 2019, 14:29:17 CET Romain Manni-Bucau a écrit :
> > Agree with Robert, git clone && mvn install must always work and be
> > straight forward if we want people to be able to help/work imho.
> >
> > Le sam. 21 déc. 2019 à 13:33, Robert Scholte  a
> >
> > écrit :
> > > that only works for the very, very few that uses this repository.
> > > It should work as to how contributors work with it, otherwise you'll
> see
> > > other issues compared to them.
> > >
> > > Robert
> > > On 21-12-2019 12:33:53, Hervé BOUTEMY  wrote:
> > > disagree
> > >
> > > We have the repo configuration which brings a location for every Git
> > > repository:
> > > https://maven.apache.org/scm.html
> > > or https://github.com/apache/maven-sources/
> > >
> > > The relative paths are calculated against that.
> > > And I recently even added aggregator poms to build absolutely
> everything
> > > in
> > > one unique build
> > >
> > > Regards,
> > >
> > > Hervé
> > >
> > > Le jeudi 19 décembre 2019, 12:13:56 CET Mark Struberg a écrit :
> > > > Hi folks!
> > > >
> > > > Looking at massembler right now I stumbled across a parentPom section
> > > >
> > > >
> > > > maven-plugins
> > > > org.apache.maven.plugins
> > > > 33
> > > > ../../pom/maven/maven-plugins/pom.xml
> > > >
> > > >
> > > > This was perfectly fine when we had all in SVN under one big project.
> > > > But nowadays - having all in GIT - I'd we should remove the
> > > > relativePath,
> > > > isn't?
> > > >
> > > > LieGrue,
> > > > strub
> > > >
> > > >
> > > > -
> > > > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
> > > > For additional commands, e-mail: dev-h...@maven.apache.org
> > >
> > > -
> > > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
> > > For additional commands, e-mail: dev-h...@maven.apache.org
>
>
>
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
> For additional commands, e-mail: dev-h...@maven.apache.org
>
>


Re: [RESULT] [VOTE] Release Apache Maven Source Plugin version 3.2.1

2019-12-21 Thread Stephen Connolly
Nope on PMC quorum, but here’s my +1 to make it legal

On Sat 21 Dec 2019 at 14:19, Hervé BOUTEMY  wrote:

> Hi,
>
> The vote has passed with the following result:
>
> +1 : Karl Heinz Marbaise, Mark Struberg, Hervé Boutemy
>
> PMC quorum reached
>
> I will promote the artifacts to the central repo.
>
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
> For additional commands, e-mail: dev-h...@maven.apache.org
>
> --
Sent from my phone


Re: [VOTE] - Integration Tests of Maven Core

2019-12-21 Thread Karl Heinz Marbaise

Hi,

On 21.12.19 15:23, Enrico Olivelli wrote:

+1

Please also update the release guide

That should be done of course.
thanks for the hint.



Enrico

Il sab 21 dic 2019, 15:18 Karl Heinz Marbaise  ha
scritto:


I suggest to create a tag 3.6.3 in Integration Tests of Maven Core which
preserves the state of the history and furthermore we should create a
tag after each Maven Core release.

Vote open for at least 72 hours.

[ ] +1
[ ] +0
[ ] -1

Kind regards
Karl Heinz Marbaise

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org






-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org



Re: [VOTE] - Integration Tests of Maven Core

2019-12-21 Thread Enrico Olivelli
+1

Please also update the release guide

Enrico

Il sab 21 dic 2019, 15:18 Karl Heinz Marbaise  ha
scritto:

> I suggest to create a tag 3.6.3 in Integration Tests of Maven Core which
> preserves the state of the history and furthermore we should create a
> tag after each Maven Core release.
>
> Vote open for at least 72 hours.
>
> [ ] +1
> [ ] +0
> [ ] -1
>
> Kind regards
> Karl Heinz Marbaise
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
> For additional commands, e-mail: dev-h...@maven.apache.org
>
>


[RESULT] [VOTE] Release Apache Maven Source Plugin version 3.2.1

2019-12-21 Thread Hervé BOUTEMY
Hi,
 
The vote has passed with the following result:
 
+1 : Karl Heinz Marbaise, Mark Struberg, Hervé Boutemy  

PMC quorum reached
 
I will promote the artifacts to the central repo.



-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org



[VOTE] - Integration Tests of Maven Core

2019-12-21 Thread Karl Heinz Marbaise

I suggest to create a tag 3.6.3 in Integration Tests of Maven Core which
preserves the state of the history and furthermore we should create a
tag after each Maven Core release.

Vote open for at least 72 hours.

[ ] +1
[ ] +0
[ ] -1

Kind regards
Karl Heinz Marbaise

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org



Re: [VOTE] Release Apache Maven Source Plugin version 3.2.1

2019-12-21 Thread Hervé BOUTEMY
here is my +1

Regards,

Hervé

Le lundi 16 décembre 2019, 19:37:00 CET Hervé BOUTEMY a écrit :
> Hi,
> 
> We solved 2 issues:
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317924
> rsion=12346480=Text
> 
> Staging repo:
> https://repository.apache.org/content/repositories/maven-1545/
> https://repository.apache.org/content/repositories/maven-1545/org/apache/mav
> en/plugins/maven-source-plugin/3.2.1/maven-source-plugin-3.2.1-source-releas
> e.zip
> 
> Source release checksum(s):
> maven-source-plugin-3.2.1-source-release.zip sha512:
> 4d7252839cc74dae8100a47adadbe6fc2c8f4d57e930fa695e4e6c75a8571b1246a63aa25de
> 0cf2d73601e599faea2a31be43b1fe442e36d463702d885ccf8b7
> 
> Staging site:
> https://maven.apache.org/plugins-archives/maven-source-plugin-LATEST/
> 
> Guide to testing staged releases:
> https://maven.apache.org/guides/development/guide-testing-releases.html
> 
> Vote open for at least 72 hours.
> 
> [ ] +1
> [ ] +0
> [ ] -1
> 
> 
> 
> -
> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
> For additional commands, e-mail: dev-h...@maven.apache.org





-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org



Re: relativePath for parent poms in our plugins

2019-12-21 Thread Hervé BOUTEMY
how does the current relativePath work less than without it?
Does it really break anything more than just "people don't understand the 
value" then consider it "wrong"?

in addition, I know that intermittent Maven contributor will clone only one 
Git repository, but I personally work on every Maven Git repository on many 
computers: being able to clone and update everything easily is key to me

Regards,

Hervé

Le samedi 21 décembre 2019, 14:29:17 CET Romain Manni-Bucau a écrit :
> Agree with Robert, git clone && mvn install must always work and be
> straight forward if we want people to be able to help/work imho.
> 
> Le sam. 21 déc. 2019 à 13:33, Robert Scholte  a
> 
> écrit :
> > that only works for the very, very few that uses this repository.
> > It should work as to how contributors work with it, otherwise you'll see
> > other issues compared to them.
> > 
> > Robert
> > On 21-12-2019 12:33:53, Hervé BOUTEMY  wrote:
> > disagree
> > 
> > We have the repo configuration which brings a location for every Git
> > repository:
> > https://maven.apache.org/scm.html
> > or https://github.com/apache/maven-sources/
> > 
> > The relative paths are calculated against that.
> > And I recently even added aggregator poms to build absolutely everything
> > in
> > one unique build
> > 
> > Regards,
> > 
> > Hervé
> > 
> > Le jeudi 19 décembre 2019, 12:13:56 CET Mark Struberg a écrit :
> > > Hi folks!
> > > 
> > > Looking at massembler right now I stumbled across a parentPom section
> > > 
> > > 
> > > maven-plugins
> > > org.apache.maven.plugins
> > > 33
> > > ../../pom/maven/maven-plugins/pom.xml
> > > 
> > > 
> > > This was perfectly fine when we had all in SVN under one big project.
> > > But nowadays - having all in GIT - I'd we should remove the
> > > relativePath,
> > > isn't?
> > > 
> > > LieGrue,
> > > strub
> > > 
> > > 
> > > -
> > > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
> > > For additional commands, e-mail: dev-h...@maven.apache.org
> > 
> > -
> > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
> > For additional commands, e-mail: dev-h...@maven.apache.org





-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org



Re: relativePath for parent poms in our plugins

2019-12-21 Thread Romain Manni-Bucau
Agree with Robert, git clone && mvn install must always work and be
straight forward if we want people to be able to help/work imho.

Le sam. 21 déc. 2019 à 13:33, Robert Scholte  a
écrit :

> that only works for the very, very few that uses this repository.
> It should work as to how contributors work with it, otherwise you'll see
> other issues compared to them.
>
> Robert
> On 21-12-2019 12:33:53, Hervé BOUTEMY  wrote:
> disagree
>
> We have the repo configuration which brings a location for every Git
> repository:
> https://maven.apache.org/scm.html
> or https://github.com/apache/maven-sources/
>
> The relative paths are calculated against that.
> And I recently even added aggregator poms to build absolutely everything in
> one unique build
>
> Regards,
>
> Hervé
>
> Le jeudi 19 décembre 2019, 12:13:56 CET Mark Struberg a écrit :
> > Hi folks!
> >
> > Looking at massembler right now I stumbled across a parentPom section
> >
> >
> > maven-plugins
> > org.apache.maven.plugins
> > 33
> > ../../pom/maven/maven-plugins/pom.xml
> >
> >
> > This was perfectly fine when we had all in SVN under one big project.
> > But nowadays - having all in GIT - I'd we should remove the relativePath,
> > isn't?
> >
> > LieGrue,
> > strub
> >
> >
> > -
> > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
> > For additional commands, e-mail: dev-h...@maven.apache.org
>
>
>
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
> For additional commands, e-mail: dev-h...@maven.apache.org
>
>


Re: [VOTE] Release Apache Maven Source Plugin version 3.2.1

2019-12-21 Thread Mark Struberg
+1

LieGrue,
strub



> Am 16.12.2019 um 19:37 schrieb Hervé BOUTEMY :
> 
> Hi,
> 
> We solved 2 issues:
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317924=12346480=Text
> 
> Staging repo:
> https://repository.apache.org/content/repositories/maven-1545/
> https://repository.apache.org/content/repositories/maven-1545/org/apache/maven/plugins/maven-source-plugin/3.2.1/maven-source-plugin-3.2.1-source-release.zip
> 
> Source release checksum(s):
> maven-source-plugin-3.2.1-source-release.zip sha512: 
> 4d7252839cc74dae8100a47adadbe6fc2c8f4d57e930fa695e4e6c75a8571b1246a63aa25de0cf2d73601e599faea2a31be43b1fe442e36d463702d885ccf8b7
> 
> Staging site:
> https://maven.apache.org/plugins-archives/maven-source-plugin-LATEST/
> 
> Guide to testing staged releases:
> https://maven.apache.org/guides/development/guide-testing-releases.html
> 
> Vote open for at least 72 hours.
> 
> [ ] +1
> [ ] +0
> [ ] -1
> 
> 
> 
> -
> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
> For additional commands, e-mail: dev-h...@maven.apache.org
> 


-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org



Re: [VOTE] Release Apache Maven Source Plugin version 3.2.1

2019-12-21 Thread Karl Heinz Marbaise

Hi,

tested with several Maven versions, JDK's...

+1 from me.

Kind regards
Karl Heinz Marbaise
On 16.12.19 19:37, Hervé BOUTEMY wrote:

Hi,

We solved 2 issues:
https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317924=12346480=Text

Staging repo:
https://repository.apache.org/content/repositories/maven-1545/
https://repository.apache.org/content/repositories/maven-1545/org/apache/maven/plugins/maven-source-plugin/3.2.1/maven-source-plugin-3.2.1-source-release.zip

Source release checksum(s):
maven-source-plugin-3.2.1-source-release.zip sha512: 
4d7252839cc74dae8100a47adadbe6fc2c8f4d57e930fa695e4e6c75a8571b1246a63aa25de0cf2d73601e599faea2a31be43b1fe442e36d463702d885ccf8b7

Staging site:
https://maven.apache.org/plugins-archives/maven-source-plugin-LATEST/

Guide to testing staged releases:
https://maven.apache.org/guides/development/guide-testing-releases.html

Vote open for at least 72 hours.

[ ] +1
[ ] +0
[ ] -1


-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org



Re: relativePath for parent poms in our plugins

2019-12-21 Thread Robert Scholte
that only works for the very, very few that uses this repository. 
It should work as to how contributors work with it, otherwise you'll see other 
issues compared to them.

Robert
On 21-12-2019 12:33:53, Hervé BOUTEMY  wrote:
disagree

We have the repo configuration which brings a location for every Git
repository:
https://maven.apache.org/scm.html
or https://github.com/apache/maven-sources/

The relative paths are calculated against that.
And I recently even added aggregator poms to build absolutely everything in
one unique build

Regards,

Hervé

Le jeudi 19 décembre 2019, 12:13:56 CET Mark Struberg a écrit :
> Hi folks!
>
> Looking at massembler right now I stumbled across a parentPom section
>
>
> maven-plugins
> org.apache.maven.plugins
> 33
> ../../pom/maven/maven-plugins/pom.xml
>
>
> This was perfectly fine when we had all in SVN under one big project.
> But nowadays - having all in GIT - I'd we should remove the relativePath,
> isn't?
>
> LieGrue,
> strub
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
> For additional commands, e-mail: dev-h...@maven.apache.org





-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org



Re: [VOTE] Release Apache Maven Source Plugin version 3.2.1

2019-12-21 Thread Hervé BOUTEMY
Having a value in master is useful: you get reproducible SNAPSHOTs

Regards,

Hervé

Le samedi 21 décembre 2019, 09:41:34 CET Stephen Connolly a écrit :
> On Tue 17 Dec 2019 at 08:14, Hervé BOUTEMY  wrote:
> > I forgot to mention:
> > notice that thanks to maven-release-plugin 3.0.0-M1, the
> > project.build.outputTimestamp property was automatically updated 2 times
> > during the release:
> > - [1] during the release preparation phase
> > - [2] when preparing next development iteration
> > 
> > We have now the expected developer experience: everything is automatic
> > (after init = manually defining an initial property value) and the
> > timestamp is as meaningful as possible
> 
> Can I -as a developer- have
> https://github.com/apache/maven-source-plugin/blob/e8eaa79e273c5d2b2e02eb1b8
> a964b2160081e0e/pom.xml#L84 as an empty property on `master` and have it
> only populated with a timestamp for the release tag?
> 
> > Regards,
> > 
> > Hervé
> > 
> > [1]
> > https://github.com/apache/maven-source-plugin/commit/a59a2e481f7d8e46f2abb
> > d339d2d27e9b2964eba
> > 
> > [2]
> > https://github.com/apache/maven-source-plugin/commit/e8eaa79e273c5d2b2e02e
> > b1b8a964b2160081e0e> 
> > Le lundi 16 décembre 2019, 19:55:47 CET Hervé BOUTEMY a écrit :
> > > for those interested, I add the "Reproducible Builds (free) Bounty" :)
> > > 
> > > instructions:
> > > - use JDK 8 on an Unix (and please share if you find a trick to build on
> > > Windows, geting the same result) - please install locally
> > > maven-buildinfo-plugin
> > > https://github.com/apache/maven-studies/tree/maven-buildinfo-plugin -
> > 
> > build
> > 
> > > with "mvn -Papache-release,run-its -Dgpg.skip verify buildinfo:save" -
> > > check the content of target/buildinfo against reference in attachment If
> > > you don't want to install maven-buildinfo-plugin, you can check the
> > 
> > output
> > 
> > > checksums by hand, there are only 3 files to check in such a simple
> > > mono-module project: maven-source-plugin-3.2.1.jar,
> > > maven-source-plugin-3.2.1-source-release.zip and
> > > maven-source-plugin-3.2.1-sources.jar
> > > 
> > > Regards,
> > > 
> > > Hervé
> > > 
> > > Le lundi 16 décembre 2019, 19:37:00 CET Hervé BOUTEMY a écrit :
> > > > Hi,
> > 
> > > > We solved 2 issues:
> > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317924;
> > 
> > > > ve rsion=12346480=Text
> > > > 
> > > > Staging repo:
> > > > https://repository.apache.org/content/repositories/maven-1545/
> > 
> > https://repository.apache.org/content/repositories/maven-1545/org/apache/m
> > 
> > > > av
> > 
> > en/plugins/maven-source-plugin/3.2.1/maven-source-plugin-3.2.1-source-rel
> > 
> > > > eas e.zip
> > > > 
> > > > Source release checksum(s):
> > 
> > > > maven-source-plugin-3.2.1-source-release.zip sha512:
> > 4d7252839cc74dae8100a47adadbe6fc2c8f4d57e930fa695e4e6c75a8571b1246a63aa25d
> > 
> > > > e
> > > > 0cf2d73601e599faea2a31be43b1fe442e36d463702d885ccf8b7
> > > > 
> > > > Staging site:
> > > > https://maven.apache.org/plugins-archives/maven-source-plugin-LATEST/
> > 
> > > > Guide to testing staged releases:
> > https://maven.apache.org/guides/development/guide-testing-releases.html
> > 
> > > > Vote open for at least 72 hours.
> > > > 
> > > > [ ] +1
> > > > [ ] +0
> > > > [ ] -1
> > > > 
> > > > 
> > > > 
> > > > -
> > > > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
> > > > For additional commands, e-mail: dev-h...@maven.apache.org
> > 
> > -
> > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
> > For additional commands, e-mail: dev-h...@maven.apache.org
> > 
> > --
> 
> Sent from my phone





-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org



Re: relativePath for parent poms in our plugins

2019-12-21 Thread Hervé BOUTEMY
disagree

We have the repo configuration which brings a location for every Git 
repository:
https://maven.apache.org/scm.html
or https://github.com/apache/maven-sources/

The relative paths are calculated against that.
And I recently even added aggregator poms to build absolutely everything in 
one unique build

Regards,

Hervé

Le jeudi 19 décembre 2019, 12:13:56 CET Mark Struberg a écrit :
> Hi folks!
> 
> Looking at massembler right now I stumbled across a parentPom section
> 
> 
>   maven-plugins
>   org.apache.maven.plugins
>   33
>   ../../pom/maven/maven-plugins/pom.xml
> 
> 
> This was perfectly fine when we had all in SVN under one big project.
> But nowadays - having all in GIT - I'd we should remove the relativePath,
> isn't?
> 
> LieGrue,
> strub
> 
> 
> -
> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
> For additional commands, e-mail: dev-h...@maven.apache.org





-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org



Re: [VOTE] Release Apache Maven Source Plugin version 3.2.1

2019-12-21 Thread Stephen Connolly
On Tue 17 Dec 2019 at 08:14, Hervé BOUTEMY  wrote:

> I forgot to mention:
> notice that thanks to maven-release-plugin 3.0.0-M1, the
> project.build.outputTimestamp property was automatically updated 2 times
> during the release:
> - [1] during the release preparation phase
> - [2] when preparing next development iteration
>
> We have now the expected developer experience: everything is automatic
> (after init = manually defining an initial property value) and the
> timestamp is as meaningful as possible


Can I -as a developer- have
https://github.com/apache/maven-source-plugin/blob/e8eaa79e273c5d2b2e02eb1b8a964b2160081e0e/pom.xml#L84
as an empty property on `master` and have it only populated with a
timestamp for the release tag?

>
>
> Regards,
>
> Hervé
>
> [1]
> https://github.com/apache/maven-source-plugin/commit/a59a2e481f7d8e46f2abbd339d2d27e9b2964eba
>
> [2]
> https://github.com/apache/maven-source-plugin/commit/e8eaa79e273c5d2b2e02eb1b8a964b2160081e0e
>
> Le lundi 16 décembre 2019, 19:55:47 CET Hervé BOUTEMY a écrit :
> > for those interested, I add the "Reproducible Builds (free) Bounty" :)
> >
> > instructions:
> > - use JDK 8 on an Unix (and please share if you find a trick to build on
> > Windows, geting the same result) - please install locally
> > maven-buildinfo-plugin
> > https://github.com/apache/maven-studies/tree/maven-buildinfo-plugin -
> build
> > with "mvn -Papache-release,run-its -Dgpg.skip verify buildinfo:save" -
> > check the content of target/buildinfo against reference in attachment If
> > you don't want to install maven-buildinfo-plugin, you can check the
> output
> > checksums by hand, there are only 3 files to check in such a simple
> > mono-module project: maven-source-plugin-3.2.1.jar,
> > maven-source-plugin-3.2.1-source-release.zip and
> > maven-source-plugin-3.2.1-sources.jar
> >
> > Regards,
> >
> > Hervé
> >
> > Le lundi 16 décembre 2019, 19:37:00 CET Hervé BOUTEMY a écrit :
> > > Hi,
> > >
> > > We solved 2 issues:
> > >
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317924;
> > > ve rsion=12346480=Text
> > >
> > > Staging repo:
> > > https://repository.apache.org/content/repositories/maven-1545/
> > >
> https://repository.apache.org/content/repositories/maven-1545/org/apache/m
> > > av
> > >
> en/plugins/maven-source-plugin/3.2.1/maven-source-plugin-3.2.1-source-rel
> > > eas e.zip
> > >
> > > Source release checksum(s):
> > > maven-source-plugin-3.2.1-source-release.zip sha512:
> > >
> 4d7252839cc74dae8100a47adadbe6fc2c8f4d57e930fa695e4e6c75a8571b1246a63aa25d
> > > e
> > > 0cf2d73601e599faea2a31be43b1fe442e36d463702d885ccf8b7
> > >
> > > Staging site:
> > > https://maven.apache.org/plugins-archives/maven-source-plugin-LATEST/
> > >
> > > Guide to testing staged releases:
> > >
> https://maven.apache.org/guides/development/guide-testing-releases.html
> > >
> > > Vote open for at least 72 hours.
> > >
> > > [ ] +1
> > > [ ] +0
> > > [ ] -1
> > >
> > >
> > >
> > > -
> > > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
> > > For additional commands, e-mail: dev-h...@maven.apache.org
>
>
>
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
> For additional commands, e-mail: dev-h...@maven.apache.org
>
> --
Sent from my phone