Re: BuildPluginManager NPE

2020-01-20 Thread Francois Papon
Hi,

I found a workaround by adding the parameter in the configuration:

${session}

However, I don't understand why the default values of the external
plugin are not used:

@Parameter(defaultValue = "${session}", readonly = true)
 protected MavenSession mavenSession;

regards,

François
fpa...@apache.org

Le 20/01/2020 à 20:34, Francois Papon a écrit :
> Hi,
>
> I'm using the BuildPluginManager in my custom maven-plugin to execute an
> external maven plugin but I have a NPE  in the executeMojo because the
> maven session in the external maven plugin is null.
>
> Here an example of the code I'm using:
>
>             PluginDescriptor toolPluginDescriptor =
> pluginManager.loadPlugin(toolPlugin,
>     mavenProject.getRemotePluginRepositories(),
>     mavenSession.getRepositorySession());
>     MojoDescriptor toolMojoDescriptor =
> toolPluginDescriptor.getMojo("assembly");
>     MojoExecution execution = new
> MojoExecution(toolMojoDescriptor, configuration);
>     pluginManager.executeMojo(mavenSession, execution);
> //mavenSession is not null
>
> Any ideas?
>
> Thanks!
>
> regards,
>

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org



BuildPluginManager NPE

2020-01-20 Thread Francois Papon
Hi,

I'm using the BuildPluginManager in my custom maven-plugin to execute an
external maven plugin but I have a NPE  in the executeMojo because the
maven session in the external maven plugin is null.

Here an example of the code I'm using:

            PluginDescriptor toolPluginDescriptor =
pluginManager.loadPlugin(toolPlugin,
    mavenProject.getRemotePluginRepositories(),
    mavenSession.getRepositorySession());
    MojoDescriptor toolMojoDescriptor =
toolPluginDescriptor.getMojo("assembly");
    MojoExecution execution = new
MojoExecution(toolMojoDescriptor, configuration);
    pluginManager.executeMojo(mavenSession, execution);
//mavenSession is not null

Any ideas?

Thanks!

regards,

-- 
François fpa...@apache.org



Re: [VOTE] Release Apache Maven Remote Resources Plugin version 1.7.0

2020-01-20 Thread Karl Heinz Marbaise

Hi,

+1 from me.

Kind regards
Karl Heinz Marbaise
On 18.01.20 22:05, Hervé BOUTEMY wrote:

Hi,

We solved 2 issues:
https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317825&version=12331232&styleName=Text

Staging repo:
https://repository.apache.org/content/repositories/maven-1546/
https://repository.apache.org/content/repositories/maven-1546/org/apache/maven/plugins/maven-remote-resources-plugin/1.7.0/maven-remote-resources-plugin-1.7.0-source-release.zip

Source release checksum(s):
maven-remote-resources-plugin-1.7.0-source-release.zip sha512: 
84adbcae661ad59f5c27c06f546ffb2a9d717eb5451194b522160d53d6877d0d2dce155352305cba43a67cf6579f3dfbf88694cd84b72960507308c4382038b6

Staging site:
https://maven.apache.org/plugins-archives/maven-remote-resources-plugin-LATEST/

Guide to testing staged releases:
https://maven.apache.org/guides/development/guide-testing-releases.html

Vote open for at least 72 hours.

[ ] +1
[ ] +0
[ ] -1



-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org



Re: [VOTE] Release Apache Maven Remote Resources Plugin version 1.7.0

2020-01-20 Thread Hervé BOUTEMY
here is my +1

I need more votes, please

Regards,

Hervé

Le samedi 18 janvier 2020, 22:05:29 CET Hervé BOUTEMY a écrit :
> Hi,
> 
> We solved 2 issues:
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317825&ve
> rsion=12331232&styleName=Text
> 
> Staging repo:
> https://repository.apache.org/content/repositories/maven-1546/
> https://repository.apache.org/content/repositories/maven-1546/org/apache/mav
> en/plugins/maven-remote-resources-plugin/1.7.0/maven-remote-resources-plugin
> -1.7.0-source-release.zip
> 
> Source release checksum(s):
> maven-remote-resources-plugin-1.7.0-source-release.zip sha512:
> 84adbcae661ad59f5c27c06f546ffb2a9d717eb5451194b522160d53d6877d0d2dce1553523
> 05cba43a67cf6579f3dfbf88694cd84b72960507308c4382038b6
> 
> Staging site:
> https://maven.apache.org/plugins-archives/maven-remote-resources-plugin-LATE
> ST/
> 
> Guide to testing staged releases:
> https://maven.apache.org/guides/development/guide-testing-releases.html
> 
> Vote open for at least 72 hours.
> 
> [ ] +1
> [ ] +0
> [ ] -1
> 
> 
> 
> -
> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
> For additional commands, e-mail: dev-h...@maven.apache.org





-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org



Re: archiving obsolete Git repository

2020-01-20 Thread Robert Scholte
I've already let INFRA close https://github.com/apache/maven-pom
See https://issues.apache.org/jira/browse/INFRA-19704


Robert
On 19-1-2020 20:57:01, Hervé BOUTEMY  wrote:
As discussed recently, we have multiple obsolete Git repositories from old
projects or read-only svn2git, that are confusing for users: we should archive
them, to get the same result as https://github.com/apache/maven-ant-plugin

Here is the list of such repositories:
- https://github.com/apache/maven-plugins
- https://github.com/apache/maven-shared
- https://github.com/apache/maven-doxia-tools
- https://github.com/apache/maven-pom
- https://github.com/apache/maven-artifact
- https://github.com/apache/maven-mercury
- https://github.com/apache/maven-app-engine
- https://github.com/apache/maven-repository-tools
- https://github.com/apache/maven-resources
- https://github.com/apache/maven-sandbox
- https://github.com/apache/maven-doxia-ide

Any objection to archive any of them? Or any additional repository?

Regards,

Hervé



-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org



Re: [MCHECKSTYLE] release for upstream checkstyle

2020-01-20 Thread Enrico Olivelli
Master is now in great shape.
There is a PR to update to 8.23, but as Benjamin says I would not commit
that change now

https://github.com/apache/maven-checkstyle-plugin/pull/24

If now one objects I will send the VOTE email tomorrow or within this week
current git sha is f0b96ab98437149486771df879a23e5740090f0c

Thank you again Ben for helping with this

Enrico

Il giorno mer 15 gen 2020 alle ore 13:02 Benjamin Marwell <
bmarw...@gmail.com> ha scritto:

> I would like to suggest to stay at 8.19 just for now.
> Updating beyond 8.23 is a breaking change, although it this plugin
> understands itself as a wrapper only.
>
>
> I suggest discussion about upgrading checkstyle should be in the
> corresponding ticket:
> https://issues.apache.org/jira/projects/MCHECKSTYLE/issues/MCHECKSTYLE-384
>
> Am Mi., 15. Jan. 2020 um 10:05 Uhr schrieb Eric Lilja <
> mindcoo...@gmail.com>:
> >
> > Which version of Checkstyle will be used for the release? 8.28?
> >
> > - Eric L
> >
> > On Wed, Jan 15, 2020 at 9:43 AM Enrico Olivelli 
> wrote:
> >
> > > This is red
> > >
> > >
> https://builds.apache.org/job/maven-box/job/maven-checkstyle-plugin/job/master/
> > >
> > > We need it blue :-)
> > >
> > > Enrico
> > >
> > > Il giorno mer 15 gen 2020 alle ore 07:46 Enrico Olivelli <
> > > eolive...@gmail.com> ha scritto:
> > >
> > > > Okay
> > > >
> > > > If No one objects I will prepare for a release.
> > > >
> > > > Currently ASF CI is not very healthy, as soon as I am confident I
> will
> > > run
> > > > the procedure
> > > >
> > > >
> > > > Enrico
> > > >
> > > >
> > > >
> > > > Il dom 12 gen 2020, 08:35 Enrico Olivelli  ha
> > > > scritto:
> > > >
> > > >> Ben
> > > >> It is a good idea.
> > > >>
> > > >> Any volunteer?
> > > >>
> > > >> Enrico
> > > >>
> > > >> Il ven 10 gen 2020, 18:46 Benjamin Marwell  ha
> > > >> scritto:
> > > >>
> > > >>> Hi everyone,
> > > >>>
> > > >>> since the classloader issue is resolved in the master branch, I'd
> like
> > > >>> to suggest a release before merging the violation class PR.
> > > >>>
> > > >>> The sooner the better (for the checkstyle team anyway).
> > > >>>
> > > >>> Thanks,
> > > >>> Ben
> > > >>>
> > > >>>
> -
> > > >>> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
> > > >>> For additional commands, e-mail: dev-h...@maven.apache.org
> > > >>>
> > > >>>
> > >
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
> For additional commands, e-mail: dev-h...@maven.apache.org
>
>