Re: Javadoc Plugin release
Hi The stack trace is truncated in your email. Can you paste the logs to a gist so I can try looking at it. There are some old flaky tests relying on having an internet connection. But I don't want to fix this now.. Actually I need a release for the jetty project which is a bit stucked to release jetty 10 as jetty 10 cannot build an aggregated javadoc ATM because of some bugs here. On Mon, 9 Mar 2020 at 22:02, Elliotte Rusty Harold wrote: > I see two test failures locally: > > [ERROR] Failures: > [ERROR] JavadocJarTest.testContinueIfFailOnErrorIsFalse:170 > [ERROR] JavadocReportTest.testNewline:880 Doesn't handle correctly > newline for string parameters. See options and packages files. > [ERROR] Errors: > [ERROR] > FixJavadocMojoTest.testFix:123->executeMojoAndTest:576->invokeCompileGoal:629 > » NullPointer > [ERROR] JavadocJarTest.testDefaultConfig:77 » MojoExecution > MavenReportException: Erro... > [ERROR] > JavadocJarTest.testIncludeMavenDescriptorWhenExplicitlyConfigured:178 > » MojoExecution > [ERROR] JavadocJarTest.testInvalidDestdir:152 » MojoExecution > MavenReportException: Er... > [ERROR] JavadocReportTest.testCustomConfiguration:396 » > MojoExecution An error has occ... > [ERROR] JavadocReportTest.testDefaultConfiguration:243 » > MojoExecution An error has oc... > [ERROR] JavadocReportTest.testDocfiles:369 » MojoExecution An error > has occurred in Ja... > [ERROR] JavadocReportTest.testDoclets:490 » MojoExecution An error > has occurred in Jav... > [ERROR] JavadocReportTest.testOptionsUmlautEncoding:566 » > MojoExecution An error has o... > [ERROR] JavadocReportTest.testQuotedPath:532 » MojoExecution An > error has occurred in ... > [ERROR] JavadocReportTest.testStylesheetfile:1251 » MojoExecution An > error has occurre... > [ERROR] JavadocReportTest.testSubpackages:320 » MojoExecution An > error has occurred in... > [ERROR] JavadocReportTest.testToFindJavadoc:735 » MojoExecution An > error has occurred ... > [INFO] > [ERROR] Tests run: 67, Failures: 2, Errors: 13, Skipped: 0 > > > On Mon, Mar 9, 2020 at 2:26 AM Olivier Lamy wrote: > > > > Hi > > I'd like to make a javadoc plugin release. > > 2 issues left ATM but I can move them to next version. > > > > Cheers > > -- > > Olivier > > > > -- > Elliotte Rusty Harold > elh...@ibiblio.org > > - > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > For additional commands, e-mail: dev-h...@maven.apache.org > > -- Olivier Lamy http://twitter.com/olamy | http://linkedin.com/in/olamy
Re: Javadoc Plugin release
I tested using maven 3.2.5 and jdk 1.7.0_80 and could not reproduce the issue. On Mon, 9 Mar 2020 at 17:21, Robert Scholte wrote: > https://builds.apache.org/job/maven-box/job/maven-javadoc-plugin/ [ > https://builds.apache.org/job/maven-box/job/maven-javadoc-plugin/] master > is broken. > > It looks like a false positive, JDK7 + Linux is tested with other Maven > versions and these succeed. > If it is happening on the same node, try removing it from the Jenkins > file. > > Robert > On 9-3-2020 07:26:34, Olivier Lamy wrote: > Hi > I'd like to make a javadoc plugin release. > 2 issues left ATM but I can move them to next version. > > Cheers > -- > Olivier > -- Olivier Lamy http://twitter.com/olamy | http://linkedin.com/in/olamy
Re: Maven exec plugin
Better ask the MojoHaus Dev list, see https://www.mojohaus.org/mail-lists.html (even though most Maven committers have commit rights for Mojohaus as well) Robert On 9-3-2020 16:31:21, Elliotte Rusty Harold wrote: Anyone available to show some love to https://github.com/mojohaus/exec-maven-plugin/? The issues and PRs are piling up and I don't see any activity in the repo since August. -- Elliotte Rusty Harold elh...@ibiblio.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Maven exec plugin
Anyone available to show some love to https://github.com/mojohaus/exec-maven-plugin/? The issues and PRs are piling up and I don't see any activity in the repo since August. -- Elliotte Rusty Harold elh...@ibiblio.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: Javadoc Plugin release
I see two test failures locally: [ERROR] Failures: [ERROR] JavadocJarTest.testContinueIfFailOnErrorIsFalse:170 [ERROR] JavadocReportTest.testNewline:880 Doesn't handle correctly newline for string parameters. See options and packages files. [ERROR] Errors: [ERROR] FixJavadocMojoTest.testFix:123->executeMojoAndTest:576->invokeCompileGoal:629 » NullPointer [ERROR] JavadocJarTest.testDefaultConfig:77 » MojoExecution MavenReportException: Erro... [ERROR] JavadocJarTest.testIncludeMavenDescriptorWhenExplicitlyConfigured:178 » MojoExecution [ERROR] JavadocJarTest.testInvalidDestdir:152 » MojoExecution MavenReportException: Er... [ERROR] JavadocReportTest.testCustomConfiguration:396 » MojoExecution An error has occ... [ERROR] JavadocReportTest.testDefaultConfiguration:243 » MojoExecution An error has oc... [ERROR] JavadocReportTest.testDocfiles:369 » MojoExecution An error has occurred in Ja... [ERROR] JavadocReportTest.testDoclets:490 » MojoExecution An error has occurred in Jav... [ERROR] JavadocReportTest.testOptionsUmlautEncoding:566 » MojoExecution An error has o... [ERROR] JavadocReportTest.testQuotedPath:532 » MojoExecution An error has occurred in ... [ERROR] JavadocReportTest.testStylesheetfile:1251 » MojoExecution An error has occurre... [ERROR] JavadocReportTest.testSubpackages:320 » MojoExecution An error has occurred in... [ERROR] JavadocReportTest.testToFindJavadoc:735 » MojoExecution An error has occurred ... [INFO] [ERROR] Tests run: 67, Failures: 2, Errors: 13, Skipped: 0 On Mon, Mar 9, 2020 at 2:26 AM Olivier Lamy wrote: > > Hi > I'd like to make a javadoc plugin release. > 2 issues left ATM but I can move them to next version. > > Cheers > -- > Olivier -- Elliotte Rusty Harold elh...@ibiblio.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: Javadoc Plugin release
There are five open PRs in the repo. It would be nice to review and respond to them. One, I think, can be closed based on the discussion. One is not ready (needs a test). I need to look at the other three. On Mon, Mar 9, 2020 at 2:26 AM Olivier Lamy wrote: > > Hi > I'd like to make a javadoc plugin release. > 2 issues left ATM but I can move them to next version. > > Cheers > -- > Olivier -- Elliotte Rusty Harold elh...@ibiblio.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: Javadoc Plugin release
Dependencies in this project look quite out of date. We should probably update the parent POM, doxia, possibly the http client, and several other things first. This shouldn't take long once the CI is fixed. On Mon, Mar 9, 2020 at 2:26 AM Olivier Lamy wrote: > > Hi > I'd like to make a javadoc plugin release. > 2 issues left ATM but I can move them to next version. > > Cheers > -- > Olivier -- Elliotte Rusty Harold elh...@ibiblio.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: [DISCUSS] checking reproducible builds
unpack and get (without transitive dependencies) are candidates to me.
Having extra goals makes the plugin more interesting.
Robert
On 8-3-2020 23:25:11, Hervé BOUTEMY wrote:
clearly, save goal is not a good choice: buildinfo would be better
I know buildinfo is not a usual term, but it's widely used in Reproducible
Builds [1] & [2], then it would be nice us Maven not to reinvent a wheel that
has already been invented
on separating checking, I really don't see how this improves experience
I love this idea of maven-artifact-plugin, but I don't see which goals od
maven-dependency-plugin could go in:
https://maven.apache.org/plugins/maven-dependency-plugin/
Regards,
Hervé
[1] https://reproducible-builds.org/docs/jvm/
[2] https://wiki.debian.org/ReproducibleBuilds/BuildinfoFiles
Le dimanche 8 mars 2020, 21:04:56 CET Robert Scholte a écrit :
> I'm thinking of maven-artifact-plugin, having goals related to artifacts.
> That implies that the save goal should be renamed.
> A couple of goals of the maven-dependency-plugin are actually more
> artifact-related are might be worth moving.
>
> Robert
>
> On 8-3-2020 13:44:07, Michael Osipov wrote:
>
> Am 2020-03-08 um 12:48 schrieb Hervé BOUTEMY:
> > Le dimanche 8 mars 2020, 00:31:07 CET Michael Osipov a écrit :
> >> Am 2020-03-07 um 19:04 schrieb Hervé BOUTEMY:
> >>> Le samedi 7 mars 2020, 17:39:20 CET Michael Osipov a écrit :
> This is expected because I am on 1.8.0_242. I don't have Java 7
> installed anymore on the server.
> >>>
> >>> for the discussion I wanted us to have, just being able to test and see
> >>> how we detect issues, this is perfect, isn't it?
> >>
> >> This is really nice. Here is the diffoscope output:
> > you're discovering the wonders of diffoscope :)
> >
> >>> --- maven-site-plugin-3.9.0.jar
> >>> +++ reference/maven-site-plugin-3.9.0.jar
> >>> ├── zipinfo {}
> >>> │ @@ -1,8 +1,8 @@
> >
> > [...]
> >
> >>> META-INF/MANIFEST.MF
> >>> │ @@ -1,10 +1,10 @@
> >>> │ Manifest-Version: 1.0
> >>> │ +Implementation-Vendor: The Apache Software Foundation^M
> >>> │ Implementation-Title: Apache Maven Site Plugin
> >>> │ Implementation-Version: 3.9.0
> >>> │ +Build-Jdk-Spec: 1.7^M
> >>> │ Specification-Vendor: The Apache Software Foundation
> >>> │ -Specification-Title: Apache Maven Site Plugin^M
> >>> │ -Build-Jdk-Spec: 1.8^M
> >>> │ Created-By: Maven Jar Plugin 3.2.0
> >>> │ +Specification-Title: Apache Maven Site Plugin^M
> >>> │ Specification-Version: 3.9
> >>> │ -Implementation-Vendor: The Apache Software Foundation^M
> >>
> >> I wonder where the CRs code from...this could be the default
> >> serialization format on every platform.
> >
> > FYI I don't have such CRs in output on my Linux box
>
> This cannot be. See
> https://github.com/AdoptOpenJDK/openjdk-jdk11u/blob/master/src/java.base/sha
> re/classes/java/util/jar/Manifest.java and search for \r\n. Old Sun code
> uses *always* CRLF. Plase recheck on your side and run a hexdump on the
> Manifest file.
>
> >>> how did you find the experience? any improvement proposal?
> >>> and any idea on where to put this goal in the future?
> >>
> >> There is room for improvement when I quickly read the code. I will write
> >> separately on this.
> >
> > sure, code can be improved: don't hesitate
> > but I was not asking yet for code improvement (I'm confident, it will
> > happen) but *experience* improvement
> >
> >> I'd leave as a plugin for now.
> >
> > you mean a separate plugin? same "buildinfo" name as current? "save" goal
> > name?
>
> OK, let's talk about experience:
>
> * buildinfo may be changed to broader name, e.g.,
> maven-reproducibility-plugin. Explanain follows
> * 'save' does too much. It should save only and not compare. Save should
> either run at initialize or at build-resources phase, imho
> * Add a 'compare' goal, not phase bound. It performs the actual comparsion.
>
> Strictly speaking if the plugin is called buildinfo it should handle the
> buildinfo files only.
>
> >> At least in 3.7.x.
> >
> > 3.7.x as Maven 3.7.x?
> > does that mean that you think it should be one day integrated into Maven
> > core? what's the rationale?
>
> Not really, but if this happens, not before 4.x. I don't have any
> rationale or entry point for this yet.
>
> Michael
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
> For additional commands, e-mail: dev-h...@maven.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org
Re: Javadoc Plugin release
https://builds.apache.org/job/maven-box/job/maven-javadoc-plugin/ [https://builds.apache.org/job/maven-box/job/maven-javadoc-plugin/] master is broken. It looks like a false positive, JDK7 + Linux is tested with other Maven versions and these succeed. If it is happening on the same node, try removing it from the Jenkins file. Robert On 9-3-2020 07:26:34, Olivier Lamy wrote: Hi I'd like to make a javadoc plugin release. 2 issues left ATM but I can move them to next version. Cheers -- Olivier
Re: Javadoc Plugin release
+1, they can be fixed later IMHO Le lun. 9 mars 2020 à 07:26, Olivier Lamy a écrit : > Hi > I'd like to make a javadoc plugin release. > 2 issues left ATM but I can move them to next version. > > Cheers > -- > Olivier >
Javadoc Plugin release
Hi I'd like to make a javadoc plugin release. 2 issues left ATM but I can move them to next version. Cheers -- Olivier
Re: [DISCUSS] checking reproducible builds
Hmm, thinking out loud but cant a reproducible build check just build the
project twice staging locally first artifacts and comparing second pass
outputs to the staged ones?
Le dim. 8 mars 2020 à 23:25, Hervé BOUTEMY a écrit :
> clearly, save goal is not a good choice: buildinfo would be better
>
> I know buildinfo is not a usual term, but it's widely used in Reproducible
> Builds [1] & [2], then it would be nice us Maven not to reinvent a wheel
> that
> has already been invented
>
> on separating checking, I really don't see how this improves experience
>
> I love this idea of maven-artifact-plugin, but I don't see which goals od
> maven-dependency-plugin could go in:
> https://maven.apache.org/plugins/maven-dependency-plugin/
>
> Regards,
>
> Hervé
>
> [1] https://reproducible-builds.org/docs/jvm/
>
> [2] https://wiki.debian.org/ReproducibleBuilds/BuildinfoFiles
>
> Le dimanche 8 mars 2020, 21:04:56 CET Robert Scholte a écrit :
> > I'm thinking of maven-artifact-plugin, having goals related to artifacts.
> > That implies that the save goal should be renamed.
> > A couple of goals of the maven-dependency-plugin are actually more
> > artifact-related are might be worth moving.
> >
> > Robert
> >
> > On 8-3-2020 13:44:07, Michael Osipov wrote:
> >
> > Am 2020-03-08 um 12:48 schrieb Hervé BOUTEMY:
> > > Le dimanche 8 mars 2020, 00:31:07 CET Michael Osipov a écrit :
> > >> Am 2020-03-07 um 19:04 schrieb Hervé BOUTEMY:
> > >>> Le samedi 7 mars 2020, 17:39:20 CET Michael Osipov a écrit :
> > This is expected because I am on 1.8.0_242. I don't have Java 7
> > installed anymore on the server.
> > >>>
> > >>> for the discussion I wanted us to have, just being able to test and
> see
> > >>> how we detect issues, this is perfect, isn't it?
> > >>
> > >> This is really nice. Here is the diffoscope output:
> > > you're discovering the wonders of diffoscope :)
> > >
> > >>> --- maven-site-plugin-3.9.0.jar
> > >>> +++ reference/maven-site-plugin-3.9.0.jar
> > >>> ├── zipinfo {}
> > >>> │ @@ -1,8 +1,8 @@
> > >
> > > [...]
> > >
> > >>> META-INF/MANIFEST.MF
> > >>> │ @@ -1,10 +1,10 @@
> > >>> │ Manifest-Version: 1.0
> > >>> │ +Implementation-Vendor: The Apache Software Foundation^M
> > >>> │ Implementation-Title: Apache Maven Site Plugin
> > >>> │ Implementation-Version: 3.9.0
> > >>> │ +Build-Jdk-Spec: 1.7^M
> > >>> │ Specification-Vendor: The Apache Software Foundation
> > >>> │ -Specification-Title: Apache Maven Site Plugin^M
> > >>> │ -Build-Jdk-Spec: 1.8^M
> > >>> │ Created-By: Maven Jar Plugin 3.2.0
> > >>> │ +Specification-Title: Apache Maven Site Plugin^M
> > >>> │ Specification-Version: 3.9
> > >>> │ -Implementation-Vendor: The Apache Software Foundation^M
> > >>
> > >> I wonder where the CRs code from...this could be the default
> > >> serialization format on every platform.
> > >
> > > FYI I don't have such CRs in output on my Linux box
> >
> > This cannot be. See
> >
> https://github.com/AdoptOpenJDK/openjdk-jdk11u/blob/master/src/java.base/sha
> > re/classes/java/util/jar/Manifest.java and search for \r\n. Old Sun code
> > uses *always* CRLF. Plase recheck on your side and run a hexdump on the
> > Manifest file.
> >
> > >>> how did you find the experience? any improvement proposal?
> > >>> and any idea on where to put this goal in the future?
> > >>
> > >> There is room for improvement when I quickly read the code. I will
> write
> > >> separately on this.
> > >
> > > sure, code can be improved: don't hesitate
> > > but I was not asking yet for code improvement (I'm confident, it will
> > > happen) but *experience* improvement
> > >
> > >> I'd leave as a plugin for now.
> > >
> > > you mean a separate plugin? same "buildinfo" name as current? "save"
> goal
> > > name?
> >
> > OK, let's talk about experience:
> >
> > * buildinfo may be changed to broader name, e.g.,
> > maven-reproducibility-plugin. Explanain follows
> > * 'save' does too much. It should save only and not compare. Save should
> > either run at initialize or at build-resources phase, imho
> > * Add a 'compare' goal, not phase bound. It performs the actual
> comparsion.
> >
> > Strictly speaking if the plugin is called buildinfo it should handle the
> > buildinfo files only.
> >
> > >> At least in 3.7.x.
> > >
> > > 3.7.x as Maven 3.7.x?
> > > does that mean that you think it should be one day integrated into
> Maven
> > > core? what's the rationale?
> >
> > Not really, but if this happens, not before 4.x. I don't have any
> > rationale or entry point for this yet.
> >
> > Michael
> >
> >
> > -
> > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
> > For additional commands, e-mail: dev-h...@maven.apache.org
>
>
>
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
> For additional commands, e-mail: dev-h...@maven.apache.org
>
>
Re: [VOTE] Release Apache Maven Dependency Plugin version 3.1.2
+1 (non binding) Le lun. 9 mars 2020 à 02:16, Olivier Lamy a écrit : > +1 > > > On Sat, 7 Mar 2020 at 21:56, Karl Heinz Marbaise > wrote: > > > We solved 23 issues: > > > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317227=12343772 > > > > There are still a couple of issues left in JIRA: > > > > > https://issues.apache.org/jira/issues/?jql=project%20%3D%20MDEP%20AND%20resolution%20%3D%20Unresolved%20ORDER%20BY%20key%20DESC%2C%20priority%20DESC%2C%20updated%20DESC > > > > Staging repo: > > https://repository.apache.org/content/repositories/maven-1555 > > > > > > > https://repository.apache.org/content/repositories/maven-1555/org/apache/maven/plugins/maven-dependency-plugin/3.1.2/maven-dependency-plugin-3.1.2-source-release.zip > > > > Source release checksum(s): > > [NAME-OF]-source-release.zip sha512: > > > > > e06c1696842682e599c2b7e6a24c58ac0c01ae0d5bf57fcc7269a7fd11092143c598fa82f908ee181d905cb949f44515e14b7b899e5df1aa184d68d2d308f83f > > > > Staging site: > > > https://maven.apache.org/plugins-archives/maven-dependency-plugin-LATEST/ > > > > Guide to testing staged releases: > > https://maven.apache.org/guides/development/guide-testing-releases.html > > > > Vote open for at least 72 hours. > > > > [ ] +1 > > [ ] +0 > > [ ] -1 > > > > Kind regards > > Karl Heinz Marbaise > > > > - > > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > > For additional commands, e-mail: dev-h...@maven.apache.org > > > > > > -- > Olivier Lamy > http://twitter.com/olamy | http://linkedin.com/in/olamy >
