Re: [VOTE] Release Maven Resolver version 1.6.1
+1 this time, I could reproduce the build, done with JDK 8 on Windows Regards, Hervé Le vendredi 2 octobre 2020, 20:32:20 CEST Michael Osipov a écrit : > Hi, > > We solved 25 issues: > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12320628 > rsion=12348853 > > There are still a couple of issues left in JIRA: > https://issues.apache.org/jira/projects/MRESOLVER/issues?filter=allopenissue > s > > Staging repo: > https://repository.apache.org/content/repositories/maven-1607/ > https://repository.apache.org/content/repositories/maven-1607/org/apache/mav > en/resolver/maven-resolver/1.6.1/maven-resolver-1.6.1-source-release.zip > > Source release checksum(s): > maven-resolver-1.6.1-source-release.zip > ab45c772e9af4061977feb4fb48e3ae9ddd8cbebe41ada40f2a762504e96fd4c0fd4a939ab70 > 7667d9888caf92ab9fa354abe0624031c7049b7a2cb133421ddd > > Staging site: > https://maven.apache.org/resolver-archives/resolver-LATEST/ > > Guide to testing staged releases: > https://maven.apache.org/guides/development/guide-testing-releases.html > > Note: This Resolver offers salvation from a 13.5 years old feature > request: MNG-2802 > Yes, you can have now concurrent-safe access to your local Maven > repository synchronized with Redis. > > Vote open for 72 hours. > > [ ] +1 > [ ] +0 > [ ] -1 > > - > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > For additional commands, e-mail: dev-h...@maven.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] [maven-site] asfgit closed pull request #206: docs: remove bad link
asfgit closed pull request #206: URL: https://github.com/apache/maven-site/pull/206 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] [maven-site] elharo opened a new pull request #206: docs: remove bad link
elharo opened a new pull request #206: URL: https://github.com/apache/maven-site/pull/206 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: Hacktoberfest
Sadly, I fully agree with Robert :-( Am 2020-10-04 um 16:11 schrieb Robert Scholte: As you know, the truth right now it is impossible to keep up. The amount of mails and PRs waiting for responses exceeds our capacity. So it is a matter of prioritizing, and yes, that could mean that PRs will stay unanswered. IF we would also join hacktober, we must change those priorities for a month and focus on that, maybe even using the time to respond the open PRs. thanks, Robert On 4-10-2020 13:36:52, Markus KARG wrote: Robert, in fact I think it would be an even better signal to new contributors is at least 5 committers would agree to pick up PRs for a whole year. -Markus -Ursprüngliche Nachricht- Von: Robert Scholte [mailto:rfscho...@apache.org] Gesendet: Sonntag, 4. Oktober 2020 10:55 An: Maarten Mulders; dev@maven.apache.org Betreff: Re: Hacktoberfest I think the hacktober is a good initiative. Just be aware that we need to respond to these PRs ASAP, otherwise it might work against us. We already have a huge amount of PRs that still need to be reviewed, so it is not like we don't have enough PRs. I think we need at least 5 committers that explicitly say the will pick up these PR with the highest priority for 1 month. Otherwise I'd say no. Robert On 3-10-2020 20:41:04, Maarten Mulders wrote: Hi all, Today, I came across this update [1] from DigitalOcean, one of the companies behind Hacktoberfest. TL;DR: to prevent "spam pull requests", only accepted/merged/approved pull requests against GitHub repositories labelled "hacktoberfest" qualify for the free t-shirt or planting a tree. This is other than previous years, where _every_ pull request would qualify, even if the repository owner did not explicitly participate in Hacktoberfest. I would argue it makes sense to opt-in Maven repositories for Hacktoberfest. If it could encourage people to start contributing to Maven, I think that would be useful. It might also bring Maven to the attention of people who are looking for (Java) projects to contribute to. Any thoughts? Thanks, Maarten [1] https://hacktoberfest.digitalocean.com/hacktoberfest-update - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: [VOTE] Release Maven Resolver version 1.6.1
Build is back to normal. Even the previous failure does not affect any downstream users. Do you still want to cast -1? Am 2020-10-04 um 12:53 schrieb Elliotte Rusty Harold: Maven-resolver has been failing at head for several days: https://ci-builds.apache.org/job/Maven/job/maven-box/job/maven-resolver/job/master/26/ Not sure if the offending PR is included in the release candidate but either way I'd prefer not to release in an unstable state in case an emergency fix on the release is needed so -1 from me. On Sun, Oct 4, 2020 at 4:48 AM Mark Derricutt wrote: +1 Non-binding. Seems to be working fine on my custom artefact resolving plugin/library. On 3 October 2020 at 7:32:20 AM, Osipov Michael (micha...@apache.org) wrote: Hi, We solved 25 issues: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12320628=12348853 There are still a couple of issues left in JIRA: https://issues.apache.org/jira/projects/MRESOLVER/issues?filter=allopenissues Staging repo: https://repository.apache.org/content/repositories/maven-1607/ https://repository.apache.org/content/repositories/maven-1607/org/apache/maven/resolver/maven-resolver/1.6.1/maven-resolver-1.6.1-source-release.zip Source release checksum(s): maven-resolver-1.6.1-source-release.zip ab45c772e9af4061977feb4fb48e3ae9ddd8cbebe41ada40f2a762504e96fd4c0fd4a939ab707667d9888caf92ab9fa354abe0624031c7049b7a2cb133421ddd Staging site: https://maven.apache.org/resolver-archives/resolver-LATEST/ Guide to testing staged releases: https://maven.apache.org/guides/development/guide-testing-releases.html Note: This Resolver offers salvation from a 13.5 years old feature request: MNG-2802 Yes, you can have now concurrent-safe access to your local Maven repository synchronized with Redis. Vote open for 72 hours. [ ] +1 [ ] +0 [ ] -1 - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: [VOTE] Release Maven Resolver version 1.6.1
Am 2020-10-02 um 20:32 schrieb Michael Osipov: Hi, We solved 25 issues: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12320628=12348853 There are still a couple of issues left in JIRA: https://issues.apache.org/jira/projects/MRESOLVER/issues?filter=allopenissues Staging repo: https://repository.apache.org/content/repositories/maven-1607/ https://repository.apache.org/content/repositories/maven-1607/org/apache/maven/resolver/maven-resolver/1.6.1/maven-resolver-1.6.1-source-release.zip Source release checksum(s): maven-resolver-1.6.1-source-release.zip ab45c772e9af4061977feb4fb48e3ae9ddd8cbebe41ada40f2a762504e96fd4c0fd4a939ab707667d9888caf92ab9fa354abe0624031c7049b7a2cb133421ddd Staging site: https://maven.apache.org/resolver-archives/resolver-LATEST/ Guide to testing staged releases: https://maven.apache.org/guides/development/guide-testing-releases.html Note: This Resolver offers salvation from a 13.5 years old feature request: MNG-2802 Yes, you can have now concurrent-safe access to your local Maven repository synchronized with Redis. Vote open for 72 hours. +1 - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: Plugin ITs with toolchain on ci-builds.a.o
Thanks for the mentioning the trick. I experimented a bit and it seems, "invoker.toolchain.jdk.version" is indeed working as expected. It was probably a temporary hickup on the jenkins build nodes. However, toolchains.xml is only available on linux nodes, not on Windows nodes. I've create a INFRA ticket for that [1]. In order to have my new integration test working for both linux and windows, I'm using now a custom selector script [2]. This script copies the user's (jenkin's) toolchains.xml file into the integration test, if available. Under Windows, it creates a new toolchains.xml using a fixed path to the jdk (F:\jenkins\tools\java\latest11). While looking at other plugins, I found two integration tests in m-compiler-p which were not being executed due to referencing a non-existing toolchain. I've fixed and enabled these tests (for linux only). Regards, Andreas [1]: https://issues.apache.org/jira/browse/INFRA-20938 [2]: https://github.com/apache/maven-pmd-plugin/blob/mpmd-304/src/it/MPMD-304-toolchain-support/selector.groovy Am 03.10.20 um 11:20 schrieb Robert Scholte: > that's actually a question for builds@a.o > IIRC the trick done by other plugins is to write an integration test with a > toolchains.xm, filtering it with the Java Runtime path. > Best it to search for ITs by one of the toolchain-aware plugins[1] > > thanks, > Robert > > [1] https://maven.apache.org/guides/mini/guide-using-toolchains.html > On 2-10-2020 20:40:23, Andreas Dangel wrote: > Hi all, > > I'm trying to create a IT that uses toolchain. I've configured it in the > test's pom [1] and in invoker.properties [2]. Locally, the IT executed, > but on ci-builds.a.o the test "MPMD-304-toolchain-support" is skipped > "due to Toolchain" [3]. I was assuming, that the toolchains configured > by puppet [4] are available... > > Any idea what I'm missing? This is about implementing MPMD-304 [5]. > > Thanks, > > Andreas > > [1] > https://github.com/apache/maven-pmd-plugin/pull/31/files#diff-1c38d38a7b5627065f01e2758630a0b2R83-R88 > [2] > https://github.com/apache/maven-pmd-plugin/pull/31/files#diff-fc4ff6f6b9b97eeed9bf34122d18b660R20-R24 > [3] > https://ci-builds.apache.org/blue/organizations/jenkins/Maven%2Fmaven-box%2Fmaven-pmd-plugin/detail/mpmd-304/2/pipeline/118#step-141-log-417 > [4] > https://github.com/apache/infrastructure-p6/blob/production/modules/build_nodes/files/toolchains.xml#L64 > [5] https://issues.apache.org/jira/browse/MPMD-304 > > > > > - > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > For additional commands, e-mail: dev-h...@maven.apache.org > > - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] [maven-site] elharo commented on a change in pull request #205: [MNG-6994] clarify repository order
elharo commented on a change in pull request #205: URL: https://github.com/apache/maven-site/pull/205#discussion_r499269010 ## File path: content/apt/guides/introduction/introduction-to-profiles.apt ## @@ -403,6 +403,56 @@ mvn groupId:artifactId:goal -P !profile-1,!profile-2 One of the goals in Maven 2 is to consolidate all the information needed to run a build into a single file, or file hierarchy which is the POM. +* Profile Order + +All profile elements in a POM from active profiles overwrite the global elements with the same name of the POM or extend those in case of collections. Review comment: I think you can delete "of the POM" ## File path: content/apt/guides/introduction/introduction-to-profiles.apt ## @@ -403,6 +403,56 @@ mvn groupId:artifactId:goal -P !profile-1,!profile-2 One of the goals in Maven 2 is to consolidate all the information needed to run a build into a single file, or file hierarchy which is the POM. +* Profile Order + +All profile elements in a POM from active profiles overwrite the global elements with the same name of the POM or extend those in case of collections. +In case multiple profiles are active in the same POM or external file, the ones which are defined <> take precedence over the ones defined <> (independent of their profile id and activation order). Review comment: I'm not sure you need "independent of their profile id and activation order" but if you do, you can drop the parentheses. ## File path: content/apt/guides/introduction/introduction-to-profiles.apt ## @@ -403,6 +403,56 @@ mvn groupId:artifactId:goal -P !profile-1,!profile-2 One of the goals in Maven 2 is to consolidate all the information needed to run a build into a single file, or file hierarchy which is the POM. +* Profile Order + +All profile elements in a POM from active profiles overwrite the global elements with the same name of the POM or extend those in case of collections. +In case multiple profiles are active in the same POM or external file, the ones which are defined <> take precedence over the ones defined <> (independent of their profile id and activation order). Review comment: In case --> If ## File path: content/apt/guides/introduction/introduction-to-profiles.apt ## @@ -403,6 +403,56 @@ mvn groupId:artifactId:goal -P !profile-1,!profile-2 One of the goals in Maven 2 is to consolidate all the information needed to Review comment: up to you, but otherwise I might be inspired to send a PR to fix this that conflicts with this one. :-) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] [maven-site] kwin commented on a change in pull request #205: [MNG-6994] clarify repository order
kwin commented on a change in pull request #205: URL: https://github.com/apache/maven-site/pull/205#discussion_r499264802 ## File path: content/apt/guides/introduction/introduction-to-profiles.apt ## @@ -403,6 +403,56 @@ mvn groupId:artifactId:goal -P !profile-1,!profile-2 One of the goals in Maven 2 is to consolidate all the information needed to Review comment: This is a section I didn't touch at all. Do you really want me to do changes on unrelated and unchanged sections? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: AW: Hacktoberfest
My experience is that the better contributions come from people who need to get work done, which is usually best exemplified through bug fix PRs. If I were to manage incoming PRs for a hackathon event, I would not want to do so without a solid set of Jiras for new features and bugs, otherwise there is zero focus, and what comes in is going to be random. I have Digital Ocean Hacktoberfest T-shirt and I love it but that should not be the sole motivator IMO. I really see a grooming of Jiras as a key to success and a prequestite to opening up a project to a hackathon. Unless of course, you are happy to wade through spammy PRs. Gary On Sun, Oct 4, 2020, 11:43 Markus KARG wrote: > You are right that, but this is a tricky situation: > > * We need more committers to accept more PRs. > * We need to accept more PRs to encourage contributors to contribute more > often. > * Contributions need to contribute accepted PRs more often to become > committer. > > So the sole possible solutions are: > > * Contributors become committers without frequently accepted PRs (rather > bad idea) > * Committers accept PRs more frequenlty (the sole left over solution) > > Maybe I missed something, but I do not see any other solution the get at > speed. > > -Markus > > > -Ursprüngliche Nachricht- > Von: Robert Scholte [mailto:rfscho...@apache.org] > Gesendet: Sonntag, 4. Oktober 2020 16:11 > An: dev@maven.apache.org > Betreff: Re: AW: Hacktoberfest > > As you know, the truth right now it is impossible to keep up. The amount > of mails and PRs waiting for responses exceeds our capacity. > So it is a matter of prioritizing, and yes, that could mean that PRs will > stay unanswered. > IF we would also join hacktober, we must change those priorities for a > month and focus on that, maybe even using the time to respond the open PRs. > > thanks, > Robert > > On 4-10-2020 13:36:52, Markus KARG wrote: > Robert, > > in fact I think it would be an even better signal to new contributors is > at least 5 committers would agree to pick up PRs for a whole year. > > -Markus > > > -Ursprüngliche Nachricht- > Von: Robert Scholte [mailto:rfscho...@apache.org] > Gesendet: Sonntag, 4. Oktober 2020 10:55 > An: Maarten Mulders; dev@maven.apache.org > Betreff: Re: Hacktoberfest > > I think the hacktober is a good initiative. > Just be aware that we need to respond to these PRs ASAP, otherwise it > might work against us. > We already have a huge amount of PRs that still need to be reviewed, so it > is not like we don't have enough PRs. > > I think we need at least 5 committers that explicitly say the will pick up > these PR with the highest priority for 1 month. > Otherwise I'd say no. > > Robert > > > On 3-10-2020 20:41:04, Maarten Mulders wrote: > Hi all, > > Today, I came across this update [1] from DigitalOcean, one of the > companies behind Hacktoberfest. TL;DR: to prevent "spam pull requests", > only accepted/merged/approved pull requests against GitHub repositories > labelled "hacktoberfest" qualify for the free t-shirt or planting a > tree. This is other than previous years, where _every_ pull request > would qualify, even if the repository owner did not explicitly > participate in Hacktoberfest. > > I would argue it makes sense to opt-in Maven repositories for > Hacktoberfest. If it could encourage people to start contributing to > Maven, I think that would be useful. It might also bring Maven to the > attention of people who are looking for (Java) projects to contribute to. > > Any thoughts? > > Thanks, > > Maarten > > > > [1] https://hacktoberfest.digitalocean.com/hacktoberfest-update > > - > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > For additional commands, e-mail: dev-h...@maven.apache.org > > > > - > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > For additional commands, e-mail: dev-h...@maven.apache.org > > > > - > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > For additional commands, e-mail: dev-h...@maven.apache.org > >
AW: AW: Hacktoberfest
You are right that, but this is a tricky situation: * We need more committers to accept more PRs. * We need to accept more PRs to encourage contributors to contribute more often. * Contributions need to contribute accepted PRs more often to become committer. So the sole possible solutions are: * Contributors become committers without frequently accepted PRs (rather bad idea) * Committers accept PRs more frequenlty (the sole left over solution) Maybe I missed something, but I do not see any other solution the get at speed. -Markus -Ursprüngliche Nachricht- Von: Robert Scholte [mailto:rfscho...@apache.org] Gesendet: Sonntag, 4. Oktober 2020 16:11 An: dev@maven.apache.org Betreff: Re: AW: Hacktoberfest As you know, the truth right now it is impossible to keep up. The amount of mails and PRs waiting for responses exceeds our capacity. So it is a matter of prioritizing, and yes, that could mean that PRs will stay unanswered. IF we would also join hacktober, we must change those priorities for a month and focus on that, maybe even using the time to respond the open PRs. thanks, Robert On 4-10-2020 13:36:52, Markus KARG wrote: Robert, in fact I think it would be an even better signal to new contributors is at least 5 committers would agree to pick up PRs for a whole year. -Markus -Ursprüngliche Nachricht- Von: Robert Scholte [mailto:rfscho...@apache.org] Gesendet: Sonntag, 4. Oktober 2020 10:55 An: Maarten Mulders; dev@maven.apache.org Betreff: Re: Hacktoberfest I think the hacktober is a good initiative. Just be aware that we need to respond to these PRs ASAP, otherwise it might work against us. We already have a huge amount of PRs that still need to be reviewed, so it is not like we don't have enough PRs. I think we need at least 5 committers that explicitly say the will pick up these PR with the highest priority for 1 month. Otherwise I'd say no. Robert On 3-10-2020 20:41:04, Maarten Mulders wrote: Hi all, Today, I came across this update [1] from DigitalOcean, one of the companies behind Hacktoberfest. TL;DR: to prevent "spam pull requests", only accepted/merged/approved pull requests against GitHub repositories labelled "hacktoberfest" qualify for the free t-shirt or planting a tree. This is other than previous years, where _every_ pull request would qualify, even if the repository owner did not explicitly participate in Hacktoberfest. I would argue it makes sense to opt-in Maven repositories for Hacktoberfest. If it could encourage people to start contributing to Maven, I think that would be useful. It might also bring Maven to the attention of people who are looking for (Java) projects to contribute to. Any thoughts? Thanks, Maarten [1] https://hacktoberfest.digitalocean.com/hacktoberfest-update - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] [maven-site] elharo commented on a change in pull request #205: [MNG-6994] clarify repository order
elharo commented on a change in pull request #205: URL: https://github.com/apache/maven-site/pull/205#discussion_r499259831 ## File path: content/apt/guides/introduction/introduction-to-profiles.apt ## @@ -403,6 +403,56 @@ mvn groupId:artifactId:goal -P !profile-1,!profile-2 One of the goals in Maven 2 is to consolidate all the information needed to Review comment: in Maven 2 --> of Maven This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] [maven-site] kwin commented on a change in pull request #205: [MNG-6994] clarify repository order
kwin commented on a change in pull request #205:
URL: https://github.com/apache/maven-site/pull/205#discussion_r499259005
##
File path: content/apt/guides/mini/guide-multiple-repositories.apt
##
@@ -102,3 +104,15 @@ mvn -Pmyprofile ...
activate multiple profiles simultaneously.
<>: The settings descriptor documentation can be found on the
{{{../../maven-settings/settings.html}Maven Local Settings Model Website}}.
+
+ ** Repository Order
+
+Remote repository URLs are queried in the following order for artifacts until
one returns a valid result:
+
+[[1]] Global <<>>
+[[1]] User <<>>
+[[1]] Local POM
+[[1]] Parent POMs, recursively
+[[1]] Super POM
+
+For each of these locations the repositories within the profiles are queried
first in the order outlined at
{{{../introduction/introduction-to-profiles.html}Introduction to build
profiles}}.
Review comment:
done
##
File path: content/apt/guides/mini/guide-multiple-repositories.apt
##
@@ -55,8 +55,10 @@ Setting up Multiple Repositories
<> You will also get the standard set of repositories as defined in
the
{{{../introduction/introduction-to-the-pom.html#Super_POM}Super POM}}.
+
+
The other way you can specify the use of multiple repositories by creating a
profile in
- your <<<$\{user.home\}/.m2/settings.xml>>> file like the following:
+ your <<<$\{user.home\}/.m2/settings.xml>>> or
<<<$\{maven.home\}/conf/settings.xml>>> file like the following:
Review comment:
done
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] [maven-site] kwin commented on a change in pull request #205: [MNG-6994] clarify repository order
kwin commented on a change in pull request #205: URL: https://github.com/apache/maven-site/pull/205#discussion_r499258979 ## File path: content/apt/guides/mini/guide-multiple-repositories.apt ## @@ -29,7 +29,7 @@ Setting up Multiple Repositories There are two different ways that you can specify the use of multiple repositories. The first - way is to specify in a POM which repositories you want to use: + way is to specify in a POM which repositories you want to use (both inside and outside of build profiles): Review comment: done This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] [maven-site] kwin commented on a change in pull request #205: [MNG-6994] clarify repository order
kwin commented on a change in pull request #205: URL: https://github.com/apache/maven-site/pull/205#discussion_r499258960 ## File path: content/apt/guides/introduction/introduction-to-profiles.apt ## @@ -403,6 +403,56 @@ mvn groupId:artifactId:goal -P !profile-1,!profile-2 One of the goals in Maven 2 is to consolidate all the information needed to run a build into a single file, or file hierarchy which is the POM. +* Profile Order + +All profile elements in a POM from active profiles overwrite/enrich the global elements with the same name of the POM (i.e. take precedence). Review comment: done This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: AW: Hacktoberfest
Which is why I am doing the same sadly over at Apache Commons and forging ahead with regular work. I considered proposing one repo but that would only open the floodgates... Gary On Sun, Oct 4, 2020, 10:11 Robert Scholte wrote: > As you know, the truth right now it is impossible to keep up. The amount > of mails and PRs waiting for responses exceeds our capacity. > So it is a matter of prioritizing, and yes, that could mean that PRs will > stay unanswered. > IF we would also join hacktober, we must change those priorities for a > month and focus on that, maybe even using the time to respond the open PRs. > > thanks, > Robert > > On 4-10-2020 13:36:52, Markus KARG wrote: > Robert, > > in fact I think it would be an even better signal to new contributors is > at least 5 committers would agree to pick up PRs for a whole year. > > -Markus > > > -Ursprüngliche Nachricht- > Von: Robert Scholte [mailto:rfscho...@apache.org] > Gesendet: Sonntag, 4. Oktober 2020 10:55 > An: Maarten Mulders; dev@maven.apache.org > Betreff: Re: Hacktoberfest > > I think the hacktober is a good initiative. > Just be aware that we need to respond to these PRs ASAP, otherwise it > might work against us. > We already have a huge amount of PRs that still need to be reviewed, so it > is not like we don't have enough PRs. > > I think we need at least 5 committers that explicitly say the will pick up > these PR with the highest priority for 1 month. > Otherwise I'd say no. > > Robert > > > On 3-10-2020 20:41:04, Maarten Mulders wrote: > Hi all, > > Today, I came across this update [1] from DigitalOcean, one of the > companies behind Hacktoberfest. TL;DR: to prevent "spam pull requests", > only accepted/merged/approved pull requests against GitHub repositories > labelled "hacktoberfest" qualify for the free t-shirt or planting a > tree. This is other than previous years, where _every_ pull request > would qualify, even if the repository owner did not explicitly > participate in Hacktoberfest. > > I would argue it makes sense to opt-in Maven repositories for > Hacktoberfest. If it could encourage people to start contributing to > Maven, I think that would be useful. It might also bring Maven to the > attention of people who are looking for (Java) projects to contribute to. > > Any thoughts? > > Thanks, > > Maarten > > > > [1] https://hacktoberfest.digitalocean.com/hacktoberfest-update > > - > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > For additional commands, e-mail: dev-h...@maven.apache.org > > > > - > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > For additional commands, e-mail: dev-h...@maven.apache.org > >
Re: AW: Hacktoberfest
As you know, the truth right now it is impossible to keep up. The amount of mails and PRs waiting for responses exceeds our capacity. So it is a matter of prioritizing, and yes, that could mean that PRs will stay unanswered. IF we would also join hacktober, we must change those priorities for a month and focus on that, maybe even using the time to respond the open PRs. thanks, Robert On 4-10-2020 13:36:52, Markus KARG wrote: Robert, in fact I think it would be an even better signal to new contributors is at least 5 committers would agree to pick up PRs for a whole year. -Markus -Ursprüngliche Nachricht- Von: Robert Scholte [mailto:rfscho...@apache.org] Gesendet: Sonntag, 4. Oktober 2020 10:55 An: Maarten Mulders; dev@maven.apache.org Betreff: Re: Hacktoberfest I think the hacktober is a good initiative. Just be aware that we need to respond to these PRs ASAP, otherwise it might work against us. We already have a huge amount of PRs that still need to be reviewed, so it is not like we don't have enough PRs. I think we need at least 5 committers that explicitly say the will pick up these PR with the highest priority for 1 month. Otherwise I'd say no. Robert On 3-10-2020 20:41:04, Maarten Mulders wrote: Hi all, Today, I came across this update [1] from DigitalOcean, one of the companies behind Hacktoberfest. TL;DR: to prevent "spam pull requests", only accepted/merged/approved pull requests against GitHub repositories labelled "hacktoberfest" qualify for the free t-shirt or planting a tree. This is other than previous years, where _every_ pull request would qualify, even if the repository owner did not explicitly participate in Hacktoberfest. I would argue it makes sense to opt-in Maven repositories for Hacktoberfest. If it could encourage people to start contributing to Maven, I think that would be useful. It might also bring Maven to the attention of people who are looking for (Java) projects to contribute to. Any thoughts? Thanks, Maarten [1] https://hacktoberfest.digitalocean.com/hacktoberfest-update - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: Maven Sign Plugin
First working version is ready: https://github.com/apache/maven-studies/pull/2 I'm waiting for your opinion pt., 2 paź 2020 o 17:05 Slawomir Jaranowski napisał(a): > Targeting to maven 3.7.0-SNAPSHOT makes easier access to Transformer api. > So one issue is need to resolve: > https://issues.apache.org/jira/browse/MNG-6992 > > Of course it is clear that all "uploaded" files must be signed. > Question is - if we should use transformer api only for POM or for all? > > pt., 2 paź 2020 o 15:57 Robert Scholte napisał(a): > >> All "uploaded" files must be signed, see for instance >> https://repo1.maven.org/maven2/org/apache/maven/maven-core/3.6.3/ >> And don't care about older Maven versions, for now just set the >> prerequisite for Maven to 3.7.0-SNAPSHOT in the pom. >> >> On 2-10-2020 14:21:02, Slawomir Jaranowski >> wrote: >> But on the other side, plugins must sign other artifacts associated with a >> given project. >> >> So in this way we have two different processes - one for pom with >> transformation and ather for rest artifacts. >> >> Maybe all project artifacts should go through the transformation process >> then we can have one way for all. >> >> Anyway, first we should resolve how to access Transformers from the >> plugin. >> And how (if we want) get comparability for old maven versions. >> >> >> pt., 2 paź 2020 o 10:46 Robert Scholte napisał(a): >> >> > In the end a signer is just another file transformer, so we need to >> > achieve something like this: >> > local pom >> build/consumer pom (distribute) >> sign (distribute) >> > The plugin must be able to register a SignFileTransformer, which should >> > only be called during deploy. For the latter I can imagine we need to >> > extend the API. >> > >> > thanks, >> > Robert >> > On 28-9-2020 00:35:45, Slawomir Jaranowski wrote: >> > In order to remove reflection and possibility to call: >> > >> > FileTransformerManager fileTransformerManager = >> > repositorySystemSession.getFileTransformerManager(); >> > >> > I must add: >> > >> > org.eclipse.aether.transform >> > >> > in: >> > >> > >> https://github.com/apache/maven/blob/0e3c7a433fc4f700cc2ae6d2c11ae39ec93cbadb/maven-core/src/main/resources/META-INF/maven/extension.xml#L58 >> > >> > Without it I have: >> > java.lang.ClassNotFoundException: >> > org.eclipse.aether.transform.FileTransformerManager >> > >> > this change will be possible in the latest maven version, call above >> method >> > on older maven version will cause ClassNotFoundException >> > >> > adding direct dependency to maven-resolver-api (even in newer version) >> in >> > plugin not help, >> > I suppose that classloader for plugin is prepare in special way >> according >> > to META-INF/maven/extension.xml >> > >> > I don't know why reflection works ... >> > >> > >> > >> > niedz., 27 wrz 2020 o 20:30 Robert Scholte >> > napisał(a): >> > >> > > For now I would focus on making it work for Maven 3.7.0 and above. >> > > That would remove the need for reflection right? >> > > >> > > If there are multiple transfomers, in the end their result should all >> be >> > > signed. >> > > The reason behind this is that in the future we could upload multiple >> > > files based on the same pom. >> > > We should always upload a model 4.0.0 compatible version, but we might >> > > also transform the local pom to a more efficient file preferred by >> Maven >> > 5. >> > > >> > > thanks, >> > > Robert >> > > >> > > >> > > >> > > On 27-9-2020 13:06:45, Slawomir Jaranowski wrote: >> > > Ok. >> > > I did some research and spike. >> > > >> > > We need access to *FileTransformerManager*, it look like this is >> method, >> > > which we want: >> > > >> > > * >> org.eclipse.aether.RepositorySystemSession#getFileTransformerManager* >> > > We can use it from maven 3.6 (without overwriting the version of >> > > maven-resolver-api) ... so the plugin has a minimum maven requirement >> for >> > > this version. But even in 3.6 and 3.7-SNAPSHOT i have exception during >> > > execution: >> > > >> > > [ERROR] Failed to execute goal >> > > org.apache.maven.plugins:maven-sign-plugin:1.0-SNAPSHOT:sign >> > > (with-method-call) on project test1: Execution with-method-call of >> goal >> > > org.apache.maven.plugins:maven-sign-plugin:1.0-SNAPSHOT:sign failed: A >> > > required class was missing while executing >> > > org.apache.maven.plugins:maven-sign-plugin:1.0-SNAPSHOT:sign: >> > > org/eclipse/aether/transform/FileTransformerManager >> > > >> > > So next I try by reflection ... (now looks not good) ... but I have >> > > expected result >> > > >> > > So when we must use reflection maybe this magic should be done in >> > separate >> > > utils like >> > > *maven-resolver, maven-artifact-transfer *(where we have magic with >> > > reflections) >> > > When we prepare a method/class for transparent transformation in an >> > > external library we can simply use it in the gpg plugin and problems >> for >> > > the new version of maven will be solved. >> > > Gpg plugin already use
Re: Hacktoberfest
Same for me - I think having (new) contributions is important, so I will reserve some time for that in this month. From the contributor point of view, a PR counts if: Submitted in a repo with the hacktoberfest topic AND during the month of October AND ( The PR is merged OR The PR is labelled as hacktoberfest-accepted by a maintainer OR The PR has been approved ) So from our point of view, we don't need to have the contributions *merged* . I think that if we see enough potential in a contributions but there's minor points left to improve, we could already label it 'hacktoberfest-accepted'. Then there's a risk that they don't finish it off, but since it would be only minor points to improve, we could even do that ourselves. Thanks, Maarten On October 4, 2020 at 13:17, Elliotte Rusty Harold wrote: I'll look at some, but I can't promise highest priority. On Sun, Oct 4, 2020 at 4:55 AM Robert Scholte wrote: I think the hacktober is a good initiative. Just be aware that we need to respond to these PRs ASAP, otherwise it might work against us. We already have a huge amount of PRs that still need to be reviewed, so it is not like we don't have enough PRs. I think we need at least 5 committers that explicitly say the will pick up these PR with the highest priority for 1 month. Otherwise I'd say no. Robert On 3-10-2020 20:41:04, Maarten Mulders wrote: Hi all, Today, I came across this update [1] from DigitalOcean, one of the companies behind Hacktoberfest. TL;DR: to prevent "spam pull requests", only accepted/merged/approved pull requests against GitHub repositories labelled "hacktoberfest" qualify for the free t-shirt or planting a tree. This is other than previous years, where _every_ pull request would qualify, even if the repository owner did not explicitly participate in Hacktoberfest. I would argue it makes sense to opt-in Maven repositories for Hacktoberfest. If it could encourage people to start contributing to Maven, I think that would be useful. It might also bring Maven to the attention of people who are looking for (Java) projects to contribute to. Any thoughts? Thanks, Maarten [1] https://hacktoberfest.digitalocean.com/hacktoberfest-update - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
AW: Hacktoberfest
Robert, in fact I think it would be an even better signal to new contributors is at least 5 committers would agree to pick up PRs for a whole year. -Markus -Ursprüngliche Nachricht- Von: Robert Scholte [mailto:rfscho...@apache.org] Gesendet: Sonntag, 4. Oktober 2020 10:55 An: Maarten Mulders; dev@maven.apache.org Betreff: Re: Hacktoberfest I think the hacktober is a good initiative. Just be aware that we need to respond to these PRs ASAP, otherwise it might work against us. We already have a huge amount of PRs that still need to be reviewed, so it is not like we don't have enough PRs. I think we need at least 5 committers that explicitly say the will pick up these PR with the highest priority for 1 month. Otherwise I'd say no. Robert On 3-10-2020 20:41:04, Maarten Mulders wrote: Hi all, Today, I came across this update [1] from DigitalOcean, one of the companies behind Hacktoberfest. TL;DR: to prevent "spam pull requests", only accepted/merged/approved pull requests against GitHub repositories labelled "hacktoberfest" qualify for the free t-shirt or planting a tree. This is other than previous years, where _every_ pull request would qualify, even if the repository owner did not explicitly participate in Hacktoberfest. I would argue it makes sense to opt-in Maven repositories for Hacktoberfest. If it could encourage people to start contributing to Maven, I think that would be useful. It might also bring Maven to the attention of people who are looking for (Java) projects to contribute to. Any thoughts? Thanks, Maarten [1] https://hacktoberfest.digitalocean.com/hacktoberfest-update - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: Hacktoberfest
I'll look at some, but I can't promise highest priority. On Sun, Oct 4, 2020 at 4:55 AM Robert Scholte wrote: > > I think the hacktober is a good initiative. > Just be aware that we need to respond to these PRs ASAP, otherwise it might > work against us. > We already have a huge amount of PRs that still need to be reviewed, so it is > not like we don't have enough PRs. > > I think we need at least 5 committers that explicitly say the will pick up > these PR with the highest priority for 1 month. > Otherwise I'd say no. > > Robert > > > On 3-10-2020 20:41:04, Maarten Mulders wrote: > Hi all, > > Today, I came across this update [1] from DigitalOcean, one of the > companies behind Hacktoberfest. TL;DR: to prevent "spam pull requests", > only accepted/merged/approved pull requests against GitHub repositories > labelled "hacktoberfest" qualify for the free t-shirt or planting a > tree. This is other than previous years, where _every_ pull request > would qualify, even if the repository owner did not explicitly > participate in Hacktoberfest. > > I would argue it makes sense to opt-in Maven repositories for > Hacktoberfest. If it could encourage people to start contributing to > Maven, I think that would be useful. It might also bring Maven to the > attention of people who are looking for (Java) projects to contribute to. > > Any thoughts? > > Thanks, > > Maarten > > > > [1] https://hacktoberfest.digitalocean.com/hacktoberfest-update > > - > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > For additional commands, e-mail: dev-h...@maven.apache.org > -- Elliotte Rusty Harold elh...@ibiblio.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] [maven-site] elharo commented on a change in pull request #205: MNG-6994 clarify repository order
elharo commented on a change in pull request #205:
URL: https://github.com/apache/maven-site/pull/205#discussion_r499234532
##
File path: content/apt/guides/introduction/introduction-to-profiles.apt
##
@@ -403,6 +403,56 @@ mvn groupId:artifactId:goal -P !profile-1,!profile-2
One of the goals in Maven 2 is to consolidate all the information needed to
run a build into a single file, or file hierarchy which is the POM.
+* Profile Order
+
+All profile elements in a POM from active profiles overwrite/enrich the global
elements with the same name of the POM (i.e. take precedence).
Review comment:
overwrite or enrich? Which is it? Pick one or explain why both and under
what circumstances.
##
File path: content/apt/guides/introduction/introduction-to-profiles.apt
##
@@ -403,6 +403,56 @@ mvn groupId:artifactId:goal -P !profile-1,!profile-2
One of the goals in Maven 2 is to consolidate all the information needed to
run a build into a single file, or file hierarchy which is the POM.
+* Profile Order
+
+All profile elements in a POM from active profiles overwrite/enrich the global
elements with the same name of the POM (i.e. take precedence).
Review comment:
rewrite without parentheses or Latin (i.e.)
##
File path: content/apt/guides/mini/guide-multiple-repositories.apt
##
@@ -29,7 +29,7 @@
Setting up Multiple Repositories
There are two different ways that you can specify the use of multiple
repositories. The first
- way is to specify in a POM which repositories you want to use:
+ way is to specify in a POM which repositories you want to use (both inside
and outside of build profiles):
Review comment:
avoid parentheses
##
File path: content/apt/guides/mini/guide-multiple-repositories.apt
##
@@ -102,3 +104,15 @@ mvn -Pmyprofile ...
activate multiple profiles simultaneously.
<>: The settings descriptor documentation can be found on the
{{{../../maven-settings/settings.html}Maven Local Settings Model Website}}.
+
+ ** Repository Order
+
+Remote repository URLs are queried in the following order for artifacts until
one returns a valid result:
+
+[[1]] Global <<>>
+[[1]] User <<>>
+[[1]] Local POM
+[[1]] Parent POMs, recursively
+[[1]] Super POM
+
+For each of these locations the repositories within the profiles are queried
first in the order outlined at
{{{../introduction/introduction-to-profiles.html}Introduction to build
profiles}}.
Review comment:
comma after locations
##
File path: content/apt/guides/introduction/introduction-to-profiles.apt
##
@@ -403,6 +403,56 @@ mvn groupId:artifactId:goal -P !profile-1,!profile-2
One of the goals in Maven 2 is to consolidate all the information needed to
run a build into a single file, or file hierarchy which is the POM.
+* Profile Order
+
+All profile elements in a POM from active profiles overwrite/enrich the global
elements with the same name of the POM (i.e. take precedence).
+In case multiple profiles are active in the same POM or external file the ones
which are being defined <> take precedence over the ones being defined
<> (independent of their profile id and activation order).
+
+Example:
+
++---+
+
+ ...
+
+
+ global-repo
+ ...
+
+
+ ...
+
+
+ profile-1
+
+true
+
+
+
+ profile-1-repo
+ ...
+
+
+
+
+ profile-2
+
+true
+
+
+
+ profile-2-repo
+ ...
+
+
+
+...
+
+ ...
+
++---+
+
+This leads to the following repository list (only ids listed):
<<>>.
Review comment:
This leads to the repository list: <<>>.
##
File path: content/apt/guides/mini/guide-multiple-repositories.apt
##
@@ -55,8 +55,10 @@ Setting up Multiple Repositories
<> You will also get the standard set of repositories as defined in
the
{{{../introduction/introduction-to-the-pom.html#Super_POM}Super POM}}.
+
+
The other way you can specify the use of multiple repositories by creating a
profile in
Review comment:
delete "the use of"
by --> is by
##
File path: content/apt/guides/introduction/introduction-to-profiles.apt
##
@@ -403,6 +403,56 @@ mvn groupId:artifactId:goal -P !profile-1,!profile-2
One of the goals in Maven 2 is to consolidate all the information needed to
run a build into a single file, or file hierarchy which is the POM.
+* Profile Order
+
+All profile elements in a POM from active profiles overwrite/enrich the global
elements with the same name of the POM (i.e. take precedence).
+In case multiple profiles are active in the same POM or external file the ones
which are being defined <> take precedence over the ones being defined
<> (independent of their profile id and activation order).
Review comment:
comma after file
delete being (twice)
##
File
Re: [VOTE] Release Maven Resolver version 1.6.1
The failure is in the release candidate. It appears to be a result of https://issues.apache.org/jira/browse/MRESOLVER-136 which requires Java 8 to build and thus also fails on JDK 7 (though the build also fails on JDK 11, perhaps for other reasons.) My initial thought is that we should roll this PR back. A claim is made that the binary is JDK7 compatible though the build is not. I'm not sure how to test that in Jenkins. Perhaps we can disable the JDK7 build in this repo, but that seems dangerous. I prefer a rollback. On Sun, Oct 4, 2020 at 6:53 AM Elliotte Rusty Harold wrote: > > Maven-resolver has been failing at head for several days: > > https://ci-builds.apache.org/job/Maven/job/maven-box/job/maven-resolver/job/master/26/ > > Not sure if the offending PR is included in the release candidate but > either way I'd prefer not to release in an unstable state in case an > emergency fix on the release is needed so -1 from me. > > On Sun, Oct 4, 2020 at 4:48 AM Mark Derricutt wrote: > > > > +1 Non-binding. Seems to be working fine on my custom artefact resolving > > plugin/library. > > > > On 3 October 2020 at 7:32:20 AM, Osipov Michael (micha...@apache.org) wrote: > > > > Hi, > > > > We solved 25 issues: > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12320628=12348853 > > > > There are still a couple of issues left in JIRA: > > https://issues.apache.org/jira/projects/MRESOLVER/issues?filter=allopenissues > > > > Staging repo: > > https://repository.apache.org/content/repositories/maven-1607/ > > https://repository.apache.org/content/repositories/maven-1607/org/apache/maven/resolver/maven-resolver/1.6.1/maven-resolver-1.6.1-source-release.zip > > > > Source release checksum(s): > > maven-resolver-1.6.1-source-release.zip > > ab45c772e9af4061977feb4fb48e3ae9ddd8cbebe41ada40f2a762504e96fd4c0fd4a939ab707667d9888caf92ab9fa354abe0624031c7049b7a2cb133421ddd > > > > > > Staging site: > > https://maven.apache.org/resolver-archives/resolver-LATEST/ > > > > Guide to testing staged releases: > > https://maven.apache.org/guides/development/guide-testing-releases.html > > > > Note: This Resolver offers salvation from a 13.5 years old feature > > request: MNG-2802 > > Yes, you can have now concurrent-safe access to your local Maven > > repository synchronized with Redis. > > > > Vote open for 72 hours. > > > > [ ] +1 > > [ ] +0 > > [ ] -1 > > > > - > > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > > For additional commands, e-mail: dev-h...@maven.apache.org > > > > -- > Elliotte Rusty Harold > elh...@ibiblio.org -- Elliotte Rusty Harold elh...@ibiblio.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: [VOTE] Release Maven Resolver version 1.6.1
Maven-resolver has been failing at head for several days: https://ci-builds.apache.org/job/Maven/job/maven-box/job/maven-resolver/job/master/26/ Not sure if the offending PR is included in the release candidate but either way I'd prefer not to release in an unstable state in case an emergency fix on the release is needed so -1 from me. On Sun, Oct 4, 2020 at 4:48 AM Mark Derricutt wrote: > > +1 Non-binding. Seems to be working fine on my custom artefact resolving > plugin/library. > > On 3 October 2020 at 7:32:20 AM, Osipov Michael (micha...@apache.org) wrote: > > Hi, > > We solved 25 issues: > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12320628=12348853 > > There are still a couple of issues left in JIRA: > https://issues.apache.org/jira/projects/MRESOLVER/issues?filter=allopenissues > > Staging repo: > https://repository.apache.org/content/repositories/maven-1607/ > https://repository.apache.org/content/repositories/maven-1607/org/apache/maven/resolver/maven-resolver/1.6.1/maven-resolver-1.6.1-source-release.zip > > Source release checksum(s): > maven-resolver-1.6.1-source-release.zip > ab45c772e9af4061977feb4fb48e3ae9ddd8cbebe41ada40f2a762504e96fd4c0fd4a939ab707667d9888caf92ab9fa354abe0624031c7049b7a2cb133421ddd > > > Staging site: > https://maven.apache.org/resolver-archives/resolver-LATEST/ > > Guide to testing staged releases: > https://maven.apache.org/guides/development/guide-testing-releases.html > > Note: This Resolver offers salvation from a 13.5 years old feature > request: MNG-2802 > Yes, you can have now concurrent-safe access to your local Maven > repository synchronized with Redis. > > Vote open for 72 hours. > > [ ] +1 > [ ] +0 > [ ] -1 > > - > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > For additional commands, e-mail: dev-h...@maven.apache.org -- Elliotte Rusty Harold elh...@ibiblio.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] [maven-site] kwin commented on a change in pull request #205: MNG-6994 clarify repository order
kwin commented on a change in pull request #205: URL: https://github.com/apache/maven-site/pull/205#discussion_r499223023 ## File path: content/apt/guides/mini/guide-multiple-repositories.apt ## @@ -52,11 +52,15 @@ Setting up Multiple Repositories ++ +You can give repositories in a POM also in profiles. Review comment: Fixed! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: Hacktoberfest
I think the hacktober is a good initiative. Just be aware that we need to respond to these PRs ASAP, otherwise it might work against us. We already have a huge amount of PRs that still need to be reviewed, so it is not like we don't have enough PRs. I think we need at least 5 committers that explicitly say the will pick up these PR with the highest priority for 1 month. Otherwise I'd say no. Robert On 3-10-2020 20:41:04, Maarten Mulders wrote: Hi all, Today, I came across this update [1] from DigitalOcean, one of the companies behind Hacktoberfest. TL;DR: to prevent "spam pull requests", only accepted/merged/approved pull requests against GitHub repositories labelled "hacktoberfest" qualify for the free t-shirt or planting a tree. This is other than previous years, where _every_ pull request would qualify, even if the repository owner did not explicitly participate in Hacktoberfest. I would argue it makes sense to opt-in Maven repositories for Hacktoberfest. If it could encourage people to start contributing to Maven, I think that would be useful. It might also bring Maven to the attention of people who are looking for (Java) projects to contribute to. Any thoughts? Thanks, Maarten [1] https://hacktoberfest.digitalocean.com/hacktoberfest-update - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: [VOTE] Release Maven Resolver version 1.6.1
+1 Non-binding. Seems to be working fine on my custom artefact resolving plugin/library. On 3 October 2020 at 7:32:20 AM, Osipov Michael (micha...@apache.org) wrote: Hi, We solved 25 issues: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12320628=12348853 There are still a couple of issues left in JIRA: https://issues.apache.org/jira/projects/MRESOLVER/issues?filter=allopenissues Staging repo: https://repository.apache.org/content/repositories/maven-1607/ https://repository.apache.org/content/repositories/maven-1607/org/apache/maven/resolver/maven-resolver/1.6.1/maven-resolver-1.6.1-source-release.zip Source release checksum(s): maven-resolver-1.6.1-source-release.zip ab45c772e9af4061977feb4fb48e3ae9ddd8cbebe41ada40f2a762504e96fd4c0fd4a939ab707667d9888caf92ab9fa354abe0624031c7049b7a2cb133421ddd Staging site: https://maven.apache.org/resolver-archives/resolver-LATEST/ Guide to testing staged releases: https://maven.apache.org/guides/development/guide-testing-releases.html Note: This Resolver offers salvation from a 13.5 years old feature request: MNG-2802 Yes, you can have now concurrent-safe access to your local Maven repository synchronized with Redis. Vote open for 72 hours. [ ] +1 [ ] +0 [ ] -1 - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: Classloader hierarchy with extensions
I remember working with Stephen on this. I think the related issues were MNG-6209, MNG-6275 Stephen wrote a small integration test to show which extensions were visible to who and in which order. It showed there are some edge cases that didn't work as expected. However, I can't find that project anymore. I hope Stephen still has a link. thanks, Robert [1] https://issues.apache.org/jira/browse/MNG-6209 [2] https://issues.apache.org/jira/browse/MNG-6275 On 4-10-2020 01:49:10, Michael Osipov wrote: Folks, hopefully someone of you is able to make me understand the following: Maven 3 class loading [1] says that extensions are available to plugins. E.g., Wagon FTP should be available to Maven Deploy Plugin oder Wagon Maven Plugin. While working on MNG-6965 I came across this MNG-4381 which makes [1] with Wagon FTP possible. Going through I get to MNG-2749 and MNG-3281. The very spot making this happen is: https://github.com/apache/maven/blob/9567da2bc889a94f5c3b692b4afb310ddbacd6e5/maven-core/src/main/java/org/apache/maven/project/DefaultProjectBuildingHelper.java#L213-L221 I am really confused right now. One ticket says (MNG-4381) that Maven 2.x did not provide extensions to be visible to plugins yet MNG-2749 says the opposite. Moreover, MNG-3281 says that this is to be restored. Looking at the provided snippet, this works as long as the extensions is a single artifact w/o a dependency tree which is actually a hack for backwards-compat to Maven 2.x. So please tell me, since Wagon FTP is more than one artifact, how can this be available to plugins? Michael [1] https://cwiki.apache.org/confluence/display/MAVEN/Maven+3.x+Class+Loading - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
